• last updated 1 hour ago
Constraints: committers
Constraints: files
Constraints: dates
Correct some PL/pgSQL errors uncovered by PG 8.3 when trying to install

this in order to test some 3rd-party OpenACS software that uses it.

No upgrade script for two reasons:

1. It's contrib/obsolete-packages

2. The old PL/pgSQL pseudo-code should still run fine in the PG 8.3 environment,

it's only compiling the source that chokes.

merge of 4.6.3b1 to HEAD

    • -10
    • +11
  1. … 180 more files in changeset.
I've changed "timestamp" to "timestamptz" and have begun fixing some

code that used to be legal but as of PG 7.3 is not. You can no longer

subtract an integer from a timestamp but must cast to date, "timestamp"

disappeared (must use "interval" now), "datetime" disappeared ("timestamptz"),

and suchwhat.

Not done but closer than it was before ...

    • -10
    • +10
  1. … 51 more files in changeset.
file upgrade-4.6-4.6.1.sql was initially added on branch oacs-4-6.

    • -0
    • +0
A bunch of things

1. AOLserver 4.0's nsxml appears to expose a gcc bug which causes the

backwards-compatible "getattr" command to fail. I dug around nsxml

and it does appear to be a gcc bug. I changed to the proper nsxml v2


2. In the course of exploring #1 above, I realized that the calls to

dom:: Tcl XML package commands were still being executed despite

being commented out. Typical Tcl misunderstanding on someone's part.

Net effect: we were parsing all APM .info files twice, once in Tcl

and once in ns_xml! Yuk!

3. Fixed a minor notifications bug - you couldn't delete a notification

request if any unsent notifications were pending, causing the homework

package to bomb if you deleted an uploaded homework file and the prof

hadn't yet received their notification.

4. Fixed an obscure corner case in my permissions denormalization code.

  1. … 15 more files in changeset.
merge bartt PG 7.3 fixes from HEAD

  1. … 54 more files in changeset.
Patches to make OpenACS PG 7.3 compatible.

  1. … 54 more files in changeset.
1) cleaned up workflows .info file

2) fixed error message in acs-workflow

3) fixed code to reassign tasks to users

4) send return_url to task-action.adp

5) fixed bug in ticket-tracker's clarify_fire callback

6) added return_url to ticket tracker's emails

  1. … 7 more files in changeset.

1. Added session-update.tcl, a small utility which somewhat safely allows

you to put up a link that changes a session_property, for instance to

change the number of items displayed or that sort of thing. The caller

must sign their values and URL, which are verified by the callee via

ad_page_contract. If the referrer doesn't match the signed expected

referrer, you get bounced. I think this is reasonably secure (though

permissions should always be rigorously checked on all pages, of course)

2. acs_events had an html_p flag in the datamodel but no way to set it.

Fixed. It should really be a mime-type but since it's not using the

CR, and since I'm extremely busy with other stuff, I didn't fix it.

3. While doing #1 above I learned that signing and verifying arrays didn't

quite work. Fixed.

4. Found and fixed a small problem with my earlier work on the currency widget.

  1. … 13 more files in changeset.

Added a new function that returns the task_id for a particular case/taskkey.

The only way to get this (needed to fire a message transition) was for one's

client code to poke into the datamodel directly with a select.

  1. … 2 more files in changeset.

1. Changed a couple of ns_schedule_proc calls to ad_schedule_proc.

2. Moved job scheduling for workflow from the db to tcl, because PG doesn't

support in-db job scheduling.

  1. … 9 more files in changeset.
initial revision of acs-workflow-4.3

initial revision of acs-workflow-4.3

initial revision of acs-workflow-4.3

initial revision of acs-workflow-4.3

    • -0
    • +697
  1. … 234 more files in changeset.
initial revision of acs-workflow-4.3

    • -119
    • +213
    • -215
    • +365
    • -0
    • +697
    • -0
    • +37
    • -0
    • +2
    • -0
    • +2056
    • -0
    • +0
  1. … 137 more files in changeset.

Had to declare v_request_id ...

fixed typo

moved notification call into callback routine

  1. … 2 more files in changeset.
reset party_from to -1

  1. … 1 more file in changeset.
fixed display of CR file content in oracle

  1. … 8 more files in changeset.
removed another vestige of acs-notification

removed requirement on acs-notifications

  1. … 7 more files in changeset.
converted notification calls to acs_mail_nt calls

  1. … 8 more files in changeset.

1. Added a check that PG was initdb's with the collation order for

characters that we expect.

2. Jon added a "sql/common" directory for the insert statements which

load data for acs-references, so I added a new datamodel type "common"

to the APM.

3. Created a new db API routine that returns true if a given db_type is

compatible with the current RDBMS.

4. Added a workaround for a PL/pgSQL "execute" bug in acs-workflow (other

cases had been fixed previously by others but this one was missed)

5. Diddled a couple of .info files using the APM.

  1. … 10 more files in changeset.
more workflow cleanup

  1. … 17 more files in changeset.
more debugging of workflow

  1. … 3 more files in changeset.
fixed up wf after initial testing

  1. … 14 more files in changeset.

Removed more of the "default '' not null" kludge.

  1. … 18 more files in changeset.
added comments for default parameters

  1. … 9 more files in changeset.