Activity OpenACS/

7:10 pm

hectorr

Implement the 'dotlrn_applet::remove_applet_from_dotlrn' proc, called from different remove_applet procs, but never implemented

- -0
- +17
/openacs-4/packages/dotlrn/tcl/applets-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/applets-procs.tcl
- -0
- +19
/openacs-4/packages/dotlrn/tcl/applets-procs.xql
- History
- Source
- Diff
/openacs-4/packages/.../tcl/applets-procs.xql

5:40 pm

antoniop

Replace xowf proctoring implementation with that coming from proctoring-support

TODO: nicer detection of whether proctoring-support package is actually installed

- -7
- +9
/openacs-4/packages/xowf/lib/inclass-exam.wf
- History
- Source
- Diff
/openacs-4/packages/.../lib/inclass-exam.wf
- -239
- +0
/openacs-4/packages/xowf/lib/proctored-page.adp
- History
- Source
- Diff
/openacs-4/packages/.../proctored-page.adp
- -208
- +0
/openacs-4/packages/xowf/lib/proctored-page.tcl
- History
- Source
- Diff
/openacs-4/packages/.../proctored-page.tcl
- -67
- +0
/openacs-4/packages/xowf/lib/proctoring-upload.tcl
- History
- Source
- Diff
/openacs-4/packages/.../proctoring-upload.tcl
- -3
- +0
/openacs-4/packages/xowf/www/resources/proctoring/gif.js
- History
- Source
- Diff
/openacs-4/packages/.../proctoring/gif.js
- -1
- +0
/openacs-4/packages/xowf/www/resources/proctoring/gif.js.map
- History
- Source
- Diff
/openacs-4/packages/.../proctoring/gif.js.map
- -3
- +0
/openacs-4/packages/xowf/www/resources/proctoring/gif.worker.js
- History
- Source
- Diff
/openacs-4/packages/.../gif.worker.js
- -1
- +0
/openacs-4/packages/xowf/www/resources/proctoring/gif.worker.js.map
- History
- Source
- Diff
/openacs-4/packages/.../gif.worker.js.map
- -754
- +0
/openacs-4/packages/xowf/www/resources/proctoring/proctoring.js
- History
- Source
- Diff
/openacs-4/packages/.../proctoring.js

4:35 pm

gustafn

prefer SQL max() function over sort and limit 1

- -2
- +1
/openacs-4/packages/rss-support/tcl/rss-utilities-procs.xql
- History
- Source
- Diff
/openacs-4/.../rss-utilities-procs.xql
- -3
- +4
/openacs-4/packages/xowiki/tcl/package-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/package-procs.tcl

2:42 pm

antoniop

Make apm callbacks private and move them together with the others

- -0
- +70
/openacs-4/packages/acs-subsite/tcl/apm-callback-procs.tcl
- History
- Source
- Diff
/openacs-4/.../apm-callback-procs.tcl
- -73
- +1
/openacs-4/packages/acs-subsite/tcl/subsite-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/subsite-procs.tcl

2:41 pm

antoniop

Maintain also the has_child cache when mounting a package

- -1
- +3
/openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../site-nodes-procs.tcl

1:56 pm

antoniop

Fix typo

- -2
- +2
/openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../site-nodes-procs.tcl

9:46 am

antoniop

Make installation procs private

- -8
- +8
/openacs-4/packages/news/tcl/news-apm-callback-procs.tcl
- History
- Source
- Diff
/openacs-4/.../news-apm-callback-procs.tcl

6:45 pm

antoniop

When a new group is created, flush all the group::get_id caches with the same name so that the new group has a chance to be retrieved

Note that it is wrong to assume a group_name will be unique, although this is normally not far from the truth in our everyday practice

- -1
- +7
/openacs-4/packages/acs-subsite/tcl/group-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/group-procs.tcl

6:42 pm

this also exposes a potential problem with group::get_id when a group is created, deleted, and then a new one is created with the same name (e.g. executing the test multiple times). As the memoize cache is not maintained, the returned group_id will be incorrect.

- -1
- +18
/openacs-4/packages/acs-subsite/tcl/test/acs-subsite-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../acs-subsite-procs.tcl

5:25 pm

antoniop

Increase proc coverage

- -1
- +3
/openacs-4/packages/acs-subsite/tcl/test/acs-subsite-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../acs-subsite-procs.tcl

4:51 pm

antoniop

Reinstate lost queries for content::item::content_is_null

- -0
- +15
/openacs-4/packages/acs-content-repository/tcl/content-item-procs-oracle.xql
- History
- Source
- Diff
/openacs-4/.../content-item-procs-oracle.xql
- -0
- +15
/openacs-4/packages/acs-content-repository/tcl/content-item-procs-postgresql.xql
- History
- Source
- Diff
/openacs-4/.../content-item-procs-postgresql.xql

4:51 pm

antoniop

More
MAIN:antoniop:20200828145134
deleted 1 file
MAIN

file content-item-procs-oracle.xql was initially added on branch oacs-5-10.

- -0
- +0
/openacs-4/packages/acs-content-repository/tcl/content-item-procs-oracle.xql
- History
- Source
/openacs-4/.../content-item-procs-oracle.xql

4:51 pm

antoniop

More
MAIN:antoniop:20200828145134:1
deleted 1 file
MAIN

file content-item-procs-postgresql.xql was initially added on branch oacs-5-10.

- -0
- +0
/openacs-4/packages/acs-content-repository/tcl/content-item-procs-postgresql.xql
- History
- Source
/openacs-4/.../content-item-procs-postgresql.xql

3:33 pm

antoniop

Move examination statement acceptance as last step of the proctoring wizard, localize the accept button, bind ajax logging of acceptance to the actual clicking of the accept button

- -2
- +2
/openacs-4/packages/proctoring-support/proctoring-support.info
- History
- Source
- Diff
/openacs-4/.../proctoring-support.info
- -0
- +1
/openacs-4/packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml
- History
- Source
- Diff
/openacs-4/.../proctoring-support.de_DE.ISO-8859-1.xml
- -0
- +1
/openacs-4/packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml
- History
- Source
- Diff
/openacs-4/.../proctoring-support.en_US.ISO-8859-1.xml
- -5
- +6
/openacs-4/packages/proctoring-support/lib/proctored-page.adp
- History
- Source
- Diff
/openacs-4/packages/.../proctored-page.adp
- -9
- +18
/openacs-4/packages/proctoring-support/www/resources/proctored-page.js
- History
- Source
- Diff
/openacs-4/packages/.../proctored-page.js

2:23 pm

antoniop

Improve test

- -8
- +13
/openacs-4/packages/acs-lang/tcl/test/acs-lang-localization-procs.tcl
- History
- Source
- Diff
/openacs-4/.../acs-lang-localization-procs.tcl

2:17 pm

antoniop

New test for lang::util::convert_to_i18n pinpointing some expected behaviors of this proc

- -0
- +67
/openacs-4/packages/acs-lang/tcl/test/acs-lang-localization-procs.tcl
- History
- Source
- Diff
/openacs-4/.../acs-lang-localization-procs.tcl

7:29 pm

gustafn

Upgrade CKEditor to 4.14.1

- -4
- +4
/openacs-4/packages/richtext-ckeditor4/richtext-ckeditor4.info
- History
- Source
- Diff
/openacs-4/.../richtext-ckeditor4.info
- -4
- +4
/openacs-4/packages/richtext-ckeditor4/tcl/richtext-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../richtext-procs.tcl

6:07 pm

antoniop

Improve doc and minor refactoring to reduce the diff with possible upcoming change

- -10
- +42
/openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/xowiki-procs.tcl

5:48 pm

antoniop

Fix typo

- -2
- +2
/openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl
- History
- Source
- Diff
/openacs-4/.../lang-message-procs.tcl

4:56 pm

gustafn

cache method "has_children" to avoid frequent (but cheap) DB calls

- -16
- +30
/openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../site-nodes-procs.tcl

4:55 pm

gustafn

improve handling of errors, which are triggerd by the error template

- -2
- +10
/openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
- History
- Source
- Diff
/openacs-4/.../request-processor-procs.tcl

2:53 pm

antoniop

acs-lang reform:

when calling lang::util::convert_to_i18n, do not always register a en_US translation, which will be otherwise always overridden. Instead, let lang::message::register make sure that a en_US message exists and create it only when needed as a fallback. Before, lang::message::register would return an error when e.g. a new message keys was registered for de_DE and no en_US was there. Now the en_US will be just created on the fly.

This does not break current automated tests