• last updated 34 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Do not handle 400 responses in any special way: cases found in practice were always the result of a client-side timeout

Hide timing information from the user

Streamline proctoring upload:

- do not hardcode a timeout, requests will either complete or eventually fail

- use a single event handler at the end of the request to decide if and how to reschedule the upload. This prevents the possibility that the same error event triggers multiple uploads via different handlers

- improve documentation

improve error messages for autosave-handler

added type per question to exam overview

provide a nicer exam-overview

    • -26
    • +81
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
intensify argument checking

    • -1
    • +1
    /openacs-4/packages/xowiki/lib/view.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/www/index.vuh
make function "get_current_folder" more robust in case invalid data is fed in

new web-callback method "www-update-references"

This method can be called on the package-level to

referesh all page references (from wiki-links) for

an instance.

    • -3
    • +39
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
Added support for "-orderby" to includeletes "toc" and "book"

Previously, these includelets could be only used when a page_order was given.

In some cases, the base functionality came in handy for other cases, such

as e.g. a glossary.

provide nicer icon for revisions button

provide more detailed test-item descriptions for exam/question overviews

improve message keys

added exam-overview

    • -62
    • +19
    /openacs-4/packages/xowf/lib/inclass-exam.wf
    • -2
    • +149
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowf/www/index.vuh
make grading checke configurable via URL, make calculations more robust

CVS: ----------------------------------------------------------------------

    • -6
    • +13
    /openacs-4/packages/xowf/lib/inclass-exam.wf
added policy for supporting view of revisons, used more detailed message key values for supporting rounding by points or revisions

    • -43
    • +112
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
added button for form-usages for displaying revisions

Improve further: flush the object only when the state changes

    • -3
    • +6
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
Improve fix:

in FormPage www-edit, just after the save_data operation we render the FormPage to refresh the references. We should flush the form object cache here, as otherwise any formfield spec will come from the form in the previous state

    • -5
    • +7
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
Reinstate oacs-dav as a dependency... there is api usage that is not so easy to replace at the moment

Remove non-functional "double click protection" in order to remove a potential attack vector

added page contract filter "printable" to avoid potential DB errors on certain binary values

    • -3
    • +3
    /openacs-4/packages/search/search.info
    • -4
    • +6
    /openacs-4/packages/search/www/search.tcl
added page contract filter "printable" to avoid passing of binary values to certain pages

    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
avoid site-map lookups from the DB when the connections is already closed. This avoids hard DB-errors when the URL contains invalid characters

fixed bug introduced 8 months ago

Fix test category, add tested api

Make sure that the form object is flushed whenever state might have changed

If code executed after the state change accesses the form object again, this could be that from a previous state and e.g. hold the wrong form definition. This happens in practice downstream, where the submitting of activities also involves accessing the form definition to e.g. compute the grade based on the questions. Downstream we also cache the formfield specs, so if a spec is dependent on the state, might be wrong in also for future requests.

    • -0
    • +5
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
improve robustness when called without connection

Fix typo, write a basic test for the involved api

provide a friendly error message

    • -7
    • +12
    /openacs-4/packages/xowiki/tcl/package-procs.tcl