Activity OpenACS/

12:10 pm

lars

More
MAIN:lars:20040218111030
changed 3 files
MAIN

Fix for bug where tree_sortkey would start from zero for each parent that wasn't a cr_item (since parent_id's foreign key constraint is on acs_objects, not cr_items). Now all non-cr_item-parent-ids are treated as one big pool of 'null' parent_id's, allowing you to create as many logical roots as you darn well please. I would appreciate review from the OCT on this patch (and am going to solicit one by email).

- -2
- +2
/openacs-4/packages/acs-content-repository/acs-content-repository.info
- History
- Source
- Diff
/openacs-4/.../acs-content-repository.info
- -25
- +42
/openacs-4/packages/acs-content-repository/sql/postgresql/content-create.sql
- History
- Source
- Diff
/openacs-4/packages/.../content-create.sql
- -0
- +129
/openacs-4/packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.0.0-5.1.0d1.sql
- History
- Source
- Diff
/openacs-4/.../upgrade-5.0.0-5.1.0d1.sql

10:55 am

lars

More
MAIN:lars:20040218095551
changed 1 file
MAIN

Wrapping if's in curly braces

- -9
- +7
/openacs-4/packages/acs-content-repository/tcl/filter-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/filter-procs.tcl

8:36 pm

rocaelh

More
MAIN:rocaelh:20040217193649
changed 2 files
MAIN

checking for validity of term dates

- -1
- +5
/openacs-4/packages/dotlrn/www/admin/term-edit.tcl
- History
- Source
- Diff
/openacs-4/packages/.../admin/term-edit.tcl
- -1
- +5
/openacs-4/packages/dotlrn/www/admin/term-new.tcl
- History
- Source
- Diff
/openacs-4/packages/.../admin/term-new.tcl

4:36 pm

lars

More
MAIN:lars:20040217153627
changed 1 file
MAIN

Fix for bug introduced by Don's 1.45 on_validation_error patch: Now we would enter the on/after_submit-new/edit_data blocks, even if the form was refreshing.

- -89
- +90
/openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl
- History
- Source
- Diff
/openacs-4/.../form-processing-procs.tcl

4:32 pm

donb

More
MAIN:donb:20040217153250
changed 7 files
MAIN

PG 7.3 doesn't support 'current_timestamp' as a literal any more (it still

is defined as a variable, of course). Also define_function_args assumes

NULL as the default value if none is specified, 'null' <> NULL ...

- -2
- +2
/openacs-4/packages/acs-content-repository/sql/postgresql/content-extlink.sql
- History
- Source
- Diff
/openacs-4/packages/.../content-extlink.sql
- -2
- +2
/openacs-4/packages/acs-content-repository/sql/postgresql/content-folder.sql
- History
- Source
- Diff
/openacs-4/packages/.../content-folder.sql
- -2
- +2
/openacs-4/packages/acs-content-repository/sql/postgresql/content-item.sql
- History
- Source
- Diff
/openacs-4/packages/.../content-item.sql
- -1
- +1
/openacs-4/packages/acs-content-repository/sql/postgresql/content-keyword.sql
- History
- Source
- Diff
/openacs-4/packages/.../content-keyword.sql
- -2
- +2
/openacs-4/packages/acs-content-repository/sql/postgresql/content-symlink.sql
- History
- Source
- Diff
/openacs-4/packages/.../content-symlink.sql
- -2
- +2
/openacs-4/packages/acs-content-repository/sql/postgresql/content-template.sql
- History
- Source
- Diff
/openacs-4/packages/.../content-template.sql
- -14
- +25
/openacs-4/packages/acs-content-repository/sql/postgresql/content-type.sql
- History
- Source
- Diff
/openacs-4/packages/.../content-type.sql

4:21 pm

lars

More
MAIN:lars:20040217152151
changed 1 file
MAIN

Should've been more thorough. Turns out every single test case was registered with backslash-space on the first line, causing an error

- -22
- +8
/openacs-4/packages/acs-authentication/tcl/test/sync-test-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../sync-test-procs.tcl

4:10 pm

lars

More
MAIN:lars:20040217151022
changed 1 file
MAIN

Fixed bug with default values for creating folders; default values in define_function_args are literal strings, not expressions, so security_inherit_p;null is treated as the literal string 'null', and so is creation_date;current_timestamp treated as the literal string 'current_timestamp', which is not a valid timestamp format. There are probably other similar bugs introduced, we just fixed the ones that were blocking us. Emailing OCT about this.