• last updated 29 mins ago
Constraints: committers
Constraints: files
Constraints: dates
file test-item.css was initially added on branch oacs-5-10.

    • -0
    • +0
- new abstract form-field class: ShuffleField

* provide means for shuffling options and answers

* three shuffle modes:

- no-shuffling (parameter shuffle false)

- shuffling on every call

- shuffling for a seed (depending on an ID, always the same shuffling)

- new form-field class text_fields, based on ShuffleField

similar to checkbox, but with text fields

and autocorrection via "correct_when"

- support for richtext in checkbox labels

- factored out set_feedback (was previously inline in xowf)

- bump version number to 5.10.0d41

    • -2
    • +2
    • -14
    • +231
reduce verbosity

    • -5
    • +6
sort available-formfields by displayed class-name, not via fully qualified class-name

access components via instance variable

    • -5
    • +5
improve spelling

factor out loop invariants

thighten parameter checking to valid classes

    • -3
    • +3
Provide default value for "return_url" and use "export_vars" for url-construction; whitespace changes

improve spelling

    • -1
    • +1
    • -1
    • +1
added error message for new validator

    • -2
    • +2
added validator for "correct_when" form field types

prefer variable names over method calls

new includelet for documentation purposes: available-formfields

Fix typo in message key

- Fix a tricky Tcl_Obj sharing bug triggered by the usage of C-level

IndexObjs based on volatile tables. Consider the following example:

proc foo {x} {

return [bar -value x ...]


The Tcl_Obj "x" is shared as name of argument and as a value of the

non-positional parameter "-value". When bar (e.g. C-implemented)

uses Tcl_GetIndexFromObj*() to lookup "x" in a table of options,

which is volatile, the involved Tcl_Obj will be converted to an


On a call with wrong number of arguments( e.g."foo 1 2 3"), Tcl

will try to give a nice error message, saying that "foo x" can be

called only with one argument. When printing argument "x", it sees

that "x" is an indexObj, and for these kinds of objects, "x" might

be an abbreviated version of a full name. Since the table behind

the indexObj is in the case above volatile, a crash might happen.

The committed fix above is just a temporary measure. NaviServer should

try to avoid such Tcl_Obj conversions in these cases. It is also

questionable, whether the attempt to interpret a argument name as

an abbreviated.

deactivate html hacking (replace textarea by "p") since rendering is

broken due to bootstrap's "form-control" class

    • -2
    • +2
strip white space

Make page for managing the parameter "PrivateEmailLevelP" subsite aware.

allow empty correct_when specifications

Whitespace cleanup

Use already existing message-key.

ensure that every formfield is disabled in the disabled_fc list (e.g. mc-interaction)

Export message keys to normalize sorting anx xml quoting (will prevent huge diffs with new message keys)

Fixed typo in message-key. Bump acs-lang version to reload message keys.

reduce verbosity

use new form-field type "correct_when"

provide new form-field "correct_when" for conveniant user interaction

the form-field type is currently just a text field with a tailored

help text, but can be extended in the future via pull-downs etc.

    • -2
    • +2
use ad_return_complaint for invalid query parameter parsing (at least in connection threads)

fix workflow such these work as well with shared workflow definitons

    • -26
    • +26
    • -38
    • +44