Index: openacs-4/packages/xotcl-request-monitor/www/last100.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-request-monitor/www/last100.tcl,v diff -u -N -r1.7.2.5 -r1.7.2.6 --- openacs-4/packages/xotcl-request-monitor/www/last100.tcl 29 Jan 2017 18:15:15 -0000 1.7.2.5 +++ openacs-4/packages/xotcl-request-monitor/www/last100.tcl 29 Jul 2017 10:35:37 -0000 1.7.2.6 @@ -13,6 +13,8 @@ set title "Last 100 Requests" set context [list $title] +set admin_p [acs_user::site_wide_admin_p] + set stat [list] foreach {key value} [throttle last100] {lappend stat $value} @@ -43,13 +45,30 @@ } else { set user_string $requestor } + + # + # Provide the urls only to admins as links. + # + # First of all, it is questionable, whether this page should be + # public. However, when this page is public, and a spider + # (re)submits a previously broken link, and visits then the last100 + # page, it thinks that the site has still the broken page. This + # might happen e.g. with Google bot, leading to worse than necessary + # error rating. + # + if {$admin_p} { + set href "[ad_url]$url" + } else { + set href "" + } t1 add -time [clock format $timestamp -format "%H:%M:%S"] \ -user $user_string \ -user.href [export_vars -base last-requests {{request_key $requestor}}] \ -ms $ms \ -url $url \ - -url.href "[ad_url]$url" + -url.href $href } + set t1 [t1 asHTML] set last_url [ad_return_url]