Index: openacs-4/packages/acs-admin/www/auth/login-attempts.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/auth/login-attempts.tcl,v diff -u -N -r1.2 -r1.2.2.1 --- openacs-4/packages/acs-admin/www/auth/login-attempts.tcl 29 Jun 2018 17:27:18 -0000 1.2 +++ openacs-4/packages/acs-admin/www/auth/login-attempts.tcl 20 Nov 2019 13:24:52 -0000 1.2.2.1 @@ -21,7 +21,7 @@ ::template::multirow create login_attempts attempt_key attempts locked_until flush_url foreach { attempt_key seconds attempts } [::auth::login_attempts::get_all] { - ::template::multirow append login_attempts $attempt_key $attempts [clock_to_ansi $seconds] [export_vars -base "login-attempts-reset" {attempt_key}] + ::template::multirow append login_attempts $attempt_key $attempts [lc_clock_to_ansi $seconds] [export_vars -base "login-attempts-reset" {attempt_key}] } Index: openacs-4/packages/acs-lang/tcl/localization-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-lang/tcl/localization-procs.tcl,v diff -u -N -r1.29.2.5 -r1.29.2.6 --- openacs-4/packages/acs-lang/tcl/localization-procs.tcl 10 Aug 2019 15:10:51 -0000 1.29.2.5 +++ openacs-4/packages/acs-lang/tcl/localization-procs.tcl 20 Nov 2019 13:24:52 -0000 1.29.2.6 @@ -198,15 +198,31 @@ return [lc_sepfmt $out $grouping $sep] } -ad_proc -public clock_to_ansi { +ad_proc -deprecated clock_to_ansi { seconds } { Convert a time in the Tcl internal clock seconds format to ANSI format, usable by lc_time_fmt. + DEPRECATED: this proc does not comply with naming convention + enforced by acs-tcl.naming__proc_naming automated test + @author Lars Pind (lars@pinds.com) @return ANSI (YYYY-MM-DD HH24:MI:SS) formatted date. @see lc_time_fmt + @see lc_clock_to_ansi } { + return [lc_clock_to_ansi $seconds] +} + +ad_proc -public lc_clock_to_ansi { + seconds +} { + Convert a time in the Tcl internal clock seconds format to ANSI format, usable by lc_time_fmt. + + @author Lars Pind (lars@pinds.com) + @return ANSI (YYYY-MM-DD HH24:MI:SS) formatted date. + @see lc_time_fmt +} { return [clock format $seconds -format "%Y-%m-%d %H:%M:%S"] } Index: openacs-4/packages/categories/lib/contributions.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/categories/lib/contributions.tcl,v diff -u -N -r1.5 -r1.5.2.1 --- openacs-4/packages/categories/lib/contributions.tcl 7 Aug 2017 23:48:05 -0000 1.5 +++ openacs-4/packages/categories/lib/contributions.tcl 20 Nov 2019 13:24:52 -0000 1.5.2.1 @@ -104,7 +104,7 @@ } } -set now [clock_to_ansi [clock seconds]] +set now [lc_clock_to_ansi [clock seconds]] set restrict {} Index: openacs-4/packages/xotcl-request-monitor/www/whos-online-today.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-request-monitor/www/whos-online-today.tcl,v diff -u -N -r1.9 -r1.9.2.1 --- openacs-4/packages/xotcl-request-monitor/www/whos-online-today.tcl 29 Jun 2018 17:27:19 -0000 1.9 +++ openacs-4/packages/xotcl-request-monitor/www/whos-online-today.tcl 20 Nov 2019 13:24:52 -0000 1.9.2.1 @@ -42,7 +42,7 @@ if {!$all} {set elements [concat $ip $auth]} {set elements $auth} set summary "We noticed in [expr {[llength $ip]+[llength $auth]}] users in total, containing [llength $auth] authenticated users" -set now_ansi [clock_to_ansi [clock seconds]] +set now_ansi [lc_clock_to_ansi [clock seconds]] foreach element $elements { lassign $element user_id timestamp @@ -60,7 +60,7 @@ $user_url \ $timestamp \ [util::age_pretty \ - -timestamp_ansi [clock_to_ansi $timestamp] \ + -timestamp_ansi [lc_clock_to_ansi $timestamp] \ -sysdate_ansi $now_ansi \ -mode_3_fmt "%d %b %Y, at %X"] \ ] Index: openacs-4/packages/xowiki/tcl/includelet-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/includelet-procs.tcl,v diff -u -N -r1.239.2.31 -r1.239.2.32 --- openacs-4/packages/xowiki/tcl/includelet-procs.tcl 19 Nov 2019 12:46:23 -0000 1.239.2.31 +++ openacs-4/packages/xowiki/tcl/includelet-procs.tcl 20 Nov 2019 13:24:52 -0000 1.239.2.32 @@ -2093,7 +2093,7 @@ regexp {^([^.]+)[.]} $time _ time set pretty_time [util::age_pretty -timestamp_ansi $time \ - -sysdate_ansi [clock_to_ansi [clock seconds]] \ + -sysdate_ansi [lc_clock_to_ansi [clock seconds]] \ -mode_3_fmt "%d %b %Y, at %X"] set name [::xo::get_user_name $user_id] Index: openacs-4/packages/xowiki/tcl/weblog-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/weblog-procs.tcl,v diff -u -N -r1.75.2.14 -r1.75.2.15 --- openacs-4/packages/xowiki/tcl/weblog-procs.tcl 5 Oct 2019 13:20:19 -0000 1.75.2.14 +++ openacs-4/packages/xowiki/tcl/weblog-procs.tcl 20 Nov 2019 13:24:52 -0000 1.75.2.15 @@ -233,7 +233,7 @@ set time [::xo::db::tcl_date $publish_date tz] set pretty_date [util::age_pretty -timestamp_ansi $time \ - -sysdate_ansi [clock_to_ansi [clock seconds]] \ + -sysdate_ansi [lc_clock_to_ansi [clock seconds]] \ -mode_3_fmt "%d %b %Y, at %X"] if {${:summary}} {