Index: openacs-4/packages/acs-tcl/tcl/test/doc-check-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/test/doc-check-procs.tcl,v diff -u -N -r1.20.2.1 -r1.20.2.2 --- openacs-4/packages/acs-tcl/tcl/test/doc-check-procs.tcl 27 Mar 2019 13:52:28 -0000 1.20.2.1 +++ openacs-4/packages/acs-tcl/tcl/test/doc-check-procs.tcl 29 Mar 2019 15:12:32 -0000 1.20.2.2 @@ -32,53 +32,9 @@ aa_log "Found $good good of $count checked" } -aa_register_case -cats {smoke production_safe} web_callable_methods_naming { - checks naming conventions of web callable methods - - @author Gustaf Neumann -} { - set count 0 - - foreach cl [::xowiki::Page info subclass -closure] { - foreach m [$cl info instprocs] { - if {[string match "www-*" $m]} { - incr count - regexp {www[-](.*)$} $m . suffix - set wrong [regexp {[^a-z0-9-]} $suffix] - aa_false "web callable method '$cl instproc $m' does not follow naming guidelines (just lower case, digit and dash)" $wrong - - } - } - } - aa_log "Checked $count web callable methods" -} - aa_register_case \ -cats {smoke production_safe} \ -error_level warning \ - web_callable_methods_doc { - Checks if documentation exists for web callable methods - - @author Gustaf Neumann -} { - set count 0 - foreach cl [::xowiki::Page info subclass -closure] { - foreach m [$cl info instprocs] { - if {[string match "www-*" $m]} { - incr count - set exists [nsv_exists api_proc_doc "$cl instproc $m"] - aa_true "documentation for web callable method '$cl instproc $m'" $exists - } - } - } - aa_log "Checked $count web callable methods" -} - - - -aa_register_case \ - -cats {smoke production_safe} \ - -error_level warning \ documentation__check_proc_testcase { Checks if testcases exist for public procs. Index: openacs-4/packages/xowiki/tcl/test/test-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/test/test-procs.tcl,v diff -u -N -r1.15 -r1.15.2.1 --- openacs-4/packages/xowiki/tcl/test/test-procs.tcl 29 Jan 2019 11:49:52 -0000 1.15 +++ openacs-4/packages/xowiki/tcl/test/test-procs.tcl 29 Mar 2019 15:12:32 -0000 1.15.2.1 @@ -401,6 +401,47 @@ } +aa_register_case -cats {smoke production_safe} web_callable_methods_naming { + checks naming conventions of web callable methods + + @author Gustaf Neumann +} { + set count 0 + + foreach cl [::xowiki::Page info subclass -closure] { + foreach m [$cl info instprocs] { + if {[string match "www-*" $m]} { + incr count + regexp {www[-](.*)$} $m . suffix + set wrong [regexp {[^a-z0-9-]} $suffix] + aa_false "web callable method '$cl instproc $m' does not follow naming guidelines (just lower case, digit and dash)" $wrong + } + } + } + aa_log "Checked $count web callable methods" +} + +aa_register_case \ + -cats {smoke production_safe} \ + -error_level warning \ + web_callable_methods_doc { + Checks if documentation exists for web callable methods + + @author Gustaf Neumann +} { + set count 0 + foreach cl [::xowiki::Page info subclass -closure] { + foreach m [$cl info instprocs] { + if {[string match "www-*" $m]} { + incr count + set exists [nsv_exists api_proc_doc "$cl instproc $m"] + aa_true "documentation for web callable method '$cl instproc $m'" $exists + } + } + } + aa_log "Checked $count web callable methods" +} + # # Local variables: # mode: tcl