Index: openacs-4/packages/assessment/tcl/as-assessment-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/tcl/as-assessment-procs.tcl,v diff -u -N -r1.38 -r1.39 --- openacs-4/packages/assessment/tcl/as-assessment-procs.tcl 7 Aug 2017 23:48:03 -0000 1.38 +++ openacs-4/packages/assessment/tcl/as-assessment-procs.tcl 15 Jun 2018 22:47:45 -0000 1.39 @@ -40,7 +40,7 @@ New assessment to the database } { - if { (![info exists package_id] || $package_id eq "") } { set package_id [ad_conn package_id] } + if { $package_id eq "" } { set package_id [ad_conn package_id] } set folder_id [as::assessment::folder_id -package_id $package_id] if { $creator_id eq "" } { set creator_id [ad_conn user_id]} Index: openacs-4/packages/assessment/tcl/as-item-display-tb-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/tcl/as-item-display-tb-procs.tcl,v diff -u -N -r1.13 -r1.14 --- openacs-4/packages/assessment/tcl/as-item-display-tb-procs.tcl 7 Aug 2017 23:48:03 -0000 1.13 +++ openacs-4/packages/assessment/tcl/as-item-display-tb-procs.tcl 15 Jun 2018 22:47:45 -0000 1.14 @@ -17,7 +17,7 @@ New Item Display TextBox Type to the database } { - if { (![info exists package_id] || $package_id eq "") } { + if { $package_id eq "" } { set package_id [ad_conn package_id] } set folder_id [as::assessment::folder_id -package_id $package_id] Index: openacs-4/packages/assessment/tcl/as-item-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/tcl/as-item-procs.tcl,v diff -u -N -r1.23 -r1.24 --- openacs-4/packages/assessment/tcl/as-item-procs.tcl 7 Aug 2017 23:48:03 -0000 1.23 +++ openacs-4/packages/assessment/tcl/as-item-procs.tcl 15 Jun 2018 22:47:45 -0000 1.24 @@ -27,7 +27,7 @@ New item to the database } { - if { (![info exists package_id] || $package_id eq "") } { + if { $package_id eq "" } { set package_id [ad_conn package_id] } set folder_id [as::assessment::folder_id -package_id $package_id] @@ -166,7 +166,7 @@ Copies an item in the database } { # Update as_item in the CR (and as_items table) getting the revision_id (as_item_id) - if { (![info exists package_id] || $package_id eq "") } { + if { $package_id eq "" } { set package_id [ad_conn package_id] } set folder_id [as::assessment::folder_id -package_id $package_id] Index: openacs-4/packages/assessment/tcl/as-item-type-sa-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/tcl/as-item-type-sa-procs.tcl,v diff -u -N -r1.18 -r1.19 --- openacs-4/packages/assessment/tcl/as-item-type-sa-procs.tcl 7 Aug 2017 23:48:03 -0000 1.18 +++ openacs-4/packages/assessment/tcl/as-item-type-sa-procs.tcl 15 Jun 2018 22:47:45 -0000 1.19 @@ -17,7 +17,7 @@ New Short Answer Answers item to the data database } { - if { (![info exists package_id] || $package_id eq "") } { + if { $package_id eq "" } { set package_id [ad_conn package_id] } set folder_id [as::assessment::folder_id -package_id $package_id] Index: openacs-4/packages/bug-tracker/tcl/bug-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/tcl/bug-procs.tcl,v diff -u -N -r1.42 -r1.43 --- openacs-4/packages/bug-tracker/tcl/bug-procs.tcl 9 May 2018 15:33:29 -0000 1.42 +++ openacs-4/packages/bug-tracker/tcl/bug-procs.tcl 15 Jun 2018 22:47:45 -0000 1.43 @@ -100,7 +100,7 @@ @return bug_id The same bug_id passed in, just for convenience. } { - if { (![info exists user_agent] || $user_agent eq "") && [ad_conn isconnected] } { + if { $user_agent eq "" && [ad_conn isconnected] } { set user_agent [ns_set get [ns_conn headers] "User-Agent"] } @@ -219,7 +219,7 @@ } { upvar $array row - if { (![info exists user_id] || $user_id eq "") } { + if { $user_id eq "" } { set user_id [ad_conn user_id] } Index: openacs-4/packages/chat/www/search-2.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/chat/www/search-2.tcl,v diff -u -N -r1.7 -r1.8 --- openacs-4/packages/chat/www/search-2.tcl 20 Jun 2016 08:37:04 -0000 1.7 +++ openacs-4/packages/chat/www/search-2.tcl 15 Jun 2018 22:47:45 -0000 1.8 @@ -35,14 +35,12 @@ } } else { # from one of the user pages - if { (![info exists email] || $email eq "") && \ - (![info exists last_name] || $last_name eq "") } { + if { $email eq "" && $last_name eq "" } { incr exception_count append exception_text "
  • You must specify either an email address or last name to search for.\n" } - if { [info exists email] && [info exists last_name] && \ - $email ne "" && $last_name ne "" } { + if { $email ne "" && $last_name ne "" } { incr exception_count append exception_text "
  • You can only specify either email or last name, not both.\n" }