Index: openacs-4/packages/acs-admin/tcl/apm-admin-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/tcl/apm-admin-procs.tcl,v diff -u -N -r1.25 -r1.26 --- openacs-4/packages/acs-admin/tcl/apm-admin-procs.tcl 25 Apr 2018 19:23:25 -0000 1.25 +++ openacs-4/packages/acs-admin/tcl/apm-admin-procs.tcl 9 May 2018 15:33:28 -0000 1.26 @@ -277,8 +277,8 @@ } } - array set channel_tag {} - array set channel_bugfix_version {} + array set channel_tag [list] + array set channel_bugfix_version [list] for { } { $i < [llength $lines] } { incr i } { # Tag lines have the form tag: cvs-version @@ -338,7 +338,7 @@ # Store the list of packages we've seen for this channel, so we don't include the same package twice # Seems odd, but we have to do this given the forked packages sitting in /contrib - set packages {} + set packages [list] # Checkout from the tag given by channel_tag($channel) if { $debug_p } { Index: openacs-4/packages/acs-admin/www/monitor.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/monitor.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/acs-admin/www/monitor.tcl 26 Apr 2018 08:56:37 -0000 1.5 +++ openacs-4/packages/acs-admin/www/monitor.tcl 9 May 2018 15:33:28 -0000 1.6 @@ -12,14 +12,14 @@ #gets the information in a different way. set threads [ns_info threads] -set connections {} +set connections [list] foreach thread $threads { if { [lindex $thread 5] eq "ns:connthread" && [llength [lindex $thread 6]] > 0 } { lappend connections [lindex $thread 6] } } -array set ip_p {} +array set ip_p [list] multirow create connections num ip state method url seconds bytes Index: openacs-4/packages/acs-admin/www/apm/build-repository.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/apm/Attic/build-repository.tcl,v diff -u -N -r1.22 -r1.23 --- openacs-4/packages/acs-admin/www/apm/build-repository.tcl 8 May 2018 20:46:28 -0000 1.22 +++ openacs-4/packages/acs-admin/www/apm/build-repository.tcl 9 May 2018 15:33:28 -0000 1.23 @@ -60,8 +60,8 @@ } } -array set channel_tag {} -array set channel_bugfix_version {} +array set channel_tag [list] +array set channel_bugfix_version [list] for { } { $i < [llength $lines] } { incr i } { # Tag lines have the form tag: cvs-version @@ -114,7 +114,7 @@ # Store the list of packages we've seen for this channel, so we don't include the same package twice # Seems odd, but we have to do this given the forked packages sitting in /contrib - set packages {} + set packages [list] # Checkout from the tag given by channel_tag($channel) if { $debug_p } { Index: openacs-4/packages/acs-admin/www/apm/packages-install.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/apm/packages-install.tcl,v diff -u -N -r1.27 -r1.28 --- openacs-4/packages/acs-admin/www/apm/packages-install.tcl 25 Apr 2018 19:23:25 -0000 1.27 +++ openacs-4/packages/acs-admin/www/apm/packages-install.tcl 9 May 2018 15:33:28 -0000 1.28 @@ -135,9 +135,9 @@ ad_set_client_property -clob t apm spec_files $spec_files - set errors {} - set pkg_info_list {} - set pkg_key_list {} + set errors [list] + set pkg_info_list [list] + set pkg_key_list [list] apm_log APMDebug "APM: Specification files available: $spec_files" foreach spec_file $spec_files { ### Parse the package. Index: openacs-4/packages/acs-admin/www/apm/version-callbacks.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/apm/version-callbacks.tcl,v diff -u -N -r1.10 -r1.11 --- openacs-4/packages/acs-admin/www/apm/version-callbacks.tcl 25 Apr 2018 19:23:25 -0000 1.10 +++ openacs-4/packages/acs-admin/www/apm/version-callbacks.tcl 9 May 2018 15:33:28 -0000 1.11 @@ -23,7 +23,7 @@ if { [llength $unused_callback_types] > 0 } { set actions [list "\#acs-admin.Add_callback\#" [export_vars -base "version-callback-add-edit" { version_id }]] } else { - set actions {} + set actions [list] } Index: openacs-4/packages/acs-admin/www/apm/version-reload.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/apm/version-reload.tcl,v diff -u -N -r1.14 -r1.15 --- openacs-4/packages/acs-admin/www/apm/version-reload.tcl 25 Apr 2018 19:23:25 -0000 1.14 +++ openacs-4/packages/acs-admin/www/apm/version-reload.tcl 9 May 2018 15:33:28 -0000 1.15 @@ -31,7 +31,7 @@ # Source all of the marked files using the current interpreter, accumulating # errors into apm_package_load_errors - array set errors {} + array set errors [list] ad_try { apm_load_any_changed_libraries errors } on error {errorMsg} { @@ -43,7 +43,7 @@ if {[info exists errors($package_key)]} { array set package_errors $errors($package_key) } else { - array set package_errors {} + array set package_errors [list] } foreach file $files { Index: openacs-4/packages/acs-admin/www/apm/version-view.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/apm/version-view.tcl,v diff -u -N -r1.26 -r1.27 --- openacs-4/packages/acs-admin/www/apm/version-view.tcl 26 Apr 2018 08:56:37 -0000 1.26 +++ openacs-4/packages/acs-admin/www/apm/version-view.tcl 9 May 2018 15:33:28 -0000 1.27 @@ -58,7 +58,7 @@ # Later we'll output any items in "prompts" as entries in a bullet list at the # top of the page (these are things that the administrator probably needs to # address ASAP). -set prompts {} +set prompts [list] if { ![info exists installed_version_id] } { if { !$downloaded_p } { @@ -115,7 +115,7 @@ # Obtain a list of owners, properly hyperlinked. -set owners {} +set owners [list] db_foreach apm_all_owners { select owner_uri, owner_name from apm_package_owners where version_id = :version_id } { Index: openacs-4/packages/acs-admin/www/auth/authority-parameters.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/auth/authority-parameters.tcl,v diff -u -N -r1.7 -r1.8 --- openacs-4/packages/acs-admin/www/auth/authority-parameters.tcl 25 Apr 2018 19:23:25 -0000 1.7 +++ openacs-4/packages/acs-admin/www/auth/authority-parameters.tcl 9 May 2018 15:33:28 -0000 1.8 @@ -15,11 +15,11 @@ # Get the implementation id and implementation pretty name -array set parameters {} -array set parameter_values {} +array set parameters [list] +array set parameter_values [list] # Each element is a list of impl_ids which have this parameter -array set param_impls {} +array set param_impls [list] foreach element_name [auth::authority::get_sc_impl_columns] { set name_column $element_name @@ -47,7 +47,7 @@ # Set focus on first param name set first_param_name [lindex [array names parameters] 0] - set form_widgets {} + set form_widgets [list] foreach parameter_name [array names parameters] { lappend form_widgets [list ${parameter_name}:text,optional [list label $parameter_name] [list help_text $parameters($parameter_name)] {html {size 80}}] } Index: openacs-4/packages/acs-admin/www/install/install.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/install/install.tcl,v diff -u -N -r1.11 -r1.12 --- openacs-4/packages/acs-admin/www/install/install.tcl 25 Apr 2018 19:23:25 -0000 1.11 +++ openacs-4/packages/acs-admin/www/install/install.tcl 9 May 2018 15:33:28 -0000 1.12 @@ -55,7 +55,7 @@ apm_get_installed_versions -array installed_versions set upgrades_p 0 -array set package {} +array set package [list] if {$channel eq ""} { set channel $current_channel Index: openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl,v diff -u -N -r1.43 -r1.44 --- openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl 1 May 2018 09:06:57 -0000 1.43 +++ openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl 9 May 2018 15:33:28 -0000 1.44 @@ -188,7 +188,7 @@ return $out } - array set params {} + array set params [list] if { [info exists doc_elements(param)] } { foreach param $doc_elements(param) { @@ -215,7 +215,7 @@ # append out "
Query Parameters:
\n" # foreach arg_name $doc_elements(as_arg_names) { # append out "$arg_name" - # set notes {} + # set notes [list] # if { [info exists as_default_value($arg_name)] } { # lappend notes "defaults to \"$as_default_value($arg_name)\"" # } @@ -310,7 +310,7 @@
" - array set property_doc {} + array set property_doc [list] if { [info exists doc_elements(property)] } { foreach property $doc_elements(property) { if { [regexp {^([^ \t]+)[ \t](.+)$} $property "" name value] } { @@ -715,7 +715,7 @@ Returns the functions in the system that contain string in their name and have been defined using ad_proc. } { - set matches {} + set matches [list] foreach function [nsv_array names api_proc_doc] { if {[string match -nocase "*$string*" $function]} { array set doc_elements [nsv_get api_proc_doc $function] @@ -733,7 +733,7 @@ have been defined using ad_proc. The description includes the documentation string, if any. } { - set matches {} + set matches [list] foreach function [nsv_array names api_proc_doc] { if {[string match -nocase $proc $function]} { array set doc_elements [nsv_get api_proc_doc $function] @@ -1487,7 +1487,7 @@ } { - set linkList {} + set linkList [list] set filename $::acs::rootdir/$path set path_dirname [file dirname $path] set file_dirname [file dirname $filename] Index: openacs-4/packages/acs-api-browser/www/content-page-view.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-api-browser/www/content-page-view.tcl,v diff -u -N -r1.13 -r1.14 --- openacs-4/packages/acs-api-browser/www/content-page-view.tcl 26 Apr 2018 08:56:37 -0000 1.13 +++ openacs-4/packages/acs-api-browser/www/content-page-view.tcl 9 May 2018 15:33:28 -0000 1.14 @@ -19,7 +19,7 @@ script_documentation:onevalue } -set context {} +set context [list] set url_vars [export_vars {path version_id}] set return_url [export_vars -base [ad_conn url] {path version_id}] set default_source_p [ad_get_client_property -default 0 acs-api-browser api_doc_source_p] Index: openacs-4/packages/acs-api-browser/www/display-sql.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-api-browser/www/display-sql.tcl,v diff -u -N -r1.10 -r1.11 --- openacs-4/packages/acs-api-browser/www/display-sql.tcl 26 Apr 2018 08:56:37 -0000 1.10 +++ openacs-4/packages/acs-api-browser/www/display-sql.tcl 9 May 2018 15:33:28 -0000 1.11 @@ -28,7 +28,7 @@ sql:onevalue } -set context {} +set context [list] if {$version_id ne ""} { db_0or1row package_info_from_package_id { select pretty_name, package_key, version_name Index: openacs-4/packages/acs-api-browser/www/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-api-browser/www/index.tcl,v diff -u -N -r1.9 -r1.10 --- openacs-4/packages/acs-api-browser/www/index.tcl 26 Apr 2018 08:56:37 -0000 1.9 +++ openacs-4/packages/acs-api-browser/www/index.tcl 9 May 2018 15:33:28 -0000 1.10 @@ -20,7 +20,7 @@ } set title "API Browser" -set context {} +set context [list] if { [info exists about_package_key] } { Index: openacs-4/packages/acs-api-browser/www/package-view.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-api-browser/www/package-view.tcl,v diff -u -N -r1.15 -r1.16 --- openacs-4/packages/acs-api-browser/www/package-view.tcl 25 Apr 2018 19:23:25 -0000 1.15 +++ openacs-4/packages/acs-api-browser/www/package-view.tcl 9 May 2018 15:33:28 -0000 1.16 @@ -67,7 +67,7 @@ switch $kind { procs_files { - array set procs {} + array set procs [list] multirow create procs_files path full_path first_sentence view @@ -92,7 +92,7 @@ } } procs { - array set procs {} + array set procs [list] foreach path [apm_get_package_files -package_key $package_key -file_types tcl_procs] { if { [nsv_exists api_proc_doc_scripts "packages/$package_key/$path"] } { @@ -128,7 +128,7 @@ } content { multirow create content_pages indentation full_path content_type name type first_sentence - set last_components {} + set last_components [list] foreach path [apm_get_package_files -package_key $package_key -file_types content_page] { set components [split $path "/"] if { [info exists doc_elements] } { Index: openacs-4/packages/acs-api-browser/www/proc-browse.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-api-browser/www/proc-browse.tcl,v diff -u -N -r1.8 -r1.9 --- openacs-4/packages/acs-api-browser/www/proc-browse.tcl 26 Apr 2018 08:56:37 -0000 1.8 +++ openacs-4/packages/acs-api-browser/www/proc-browse.tcl 9 May 2018 15:33:28 -0000 1.9 @@ -34,7 +34,7 @@ set context [list "Browse Procedures"] set dimensional_slider [ad_dimensional $dimensional] -set matches {} +set matches [list] foreach proc [nsv_array names api_proc_doc] { array set doc_elements [nsv_get api_proc_doc $proc] Index: openacs-4/packages/acs-api-browser/www/proc-search.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-api-browser/www/proc-search.tcl,v diff -u -N -r1.19 -r1.20 --- openacs-4/packages/acs-api-browser/www/proc-search.tcl 26 Apr 2018 08:56:37 -0000 1.19 +++ openacs-4/packages/acs-api-browser/www/proc-search.tcl 9 May 2018 15:33:28 -0000 1.20 @@ -61,9 +61,9 @@ } set counter 0 -set matches {} -set deprecated_matches {} -set private_matches {} +set matches [list] +set deprecated_matches [list] +set private_matches [list] # place a [list proc_name score positionals] into matches for every proc foreach proc [nsv_array names api_proc_doc] { Index: openacs-4/packages/acs-api-browser/www/proc-view.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-api-browser/www/proc-view.tcl,v diff -u -N -r1.13 -r1.14 --- openacs-4/packages/acs-api-browser/www/proc-view.tcl 26 Apr 2018 08:56:37 -0000 1.13 +++ openacs-4/packages/acs-api-browser/www/proc-view.tcl 9 May 2018 15:33:28 -0000 1.14 @@ -18,7 +18,7 @@ set title $proc -set context {} +set context [list] if { $version_id ne "" } { db_0or1row package_info_from_package_id { select pretty_name, package_key, version_name Index: openacs-4/packages/acs-api-browser/www/procs-file-view.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-api-browser/www/procs-file-view.tcl,v diff -u -N -r1.11 -r1.12 --- openacs-4/packages/acs-api-browser/www/procs-file-view.tcl 26 Apr 2018 08:56:37 -0000 1.11 +++ openacs-4/packages/acs-api-browser/www/procs-file-view.tcl 9 May 2018 15:33:28 -0000 1.12 @@ -67,7 +67,7 @@ } } -set context {} +set context [list] if { [info exists version_id] } { db_0or1row package_info_from_package_id { select pretty_name, package_key, version_name Index: openacs-4/packages/acs-api-browser/www/type-view.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-api-browser/www/type-view.tcl,v diff -u -N -r1.6 -r1.7 --- openacs-4/packages/acs-api-browser/www/type-view.tcl 26 Apr 2018 08:56:37 -0000 1.6 +++ openacs-4/packages/acs-api-browser/www/type-view.tcl 9 May 2018 15:33:28 -0000 1.7 @@ -27,7 +27,7 @@ set public_p [::apidoc::set_public $version_id] -set context {} +set context [list] if { [info exists version_id] } { db_1row package_info_from_version_id { Index: openacs-4/packages/acs-authentication/lib/local-search.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-authentication/lib/local-search.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/acs-authentication/lib/local-search.tcl 8 May 2018 22:37:18 -0000 1.5 +++ openacs-4/packages/acs-authentication/lib/local-search.tcl 9 May 2018 15:33:28 -0000 1.6 @@ -18,7 +18,7 @@ set orderby "" } set search_text [string tolower $search_text] -set search_terms {} +set search_terms [list] foreach term [split $search_text] { lappend search_terms $term } @@ -47,7 +47,7 @@ or lower(email) like '%' || :search_text || '%' " { -set status {} +set status [list] if {[info exists object_id]} { set group_member_p [permission::permission_p -object_id $object_id -party_id $user_id -privilege $privilege] set status "" Index: openacs-4/packages/acs-authentication/tcl/authentication-procs-aolserver.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-authentication/tcl/authentication-procs-aolserver.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/acs-authentication/tcl/authentication-procs-aolserver.tcl 25 Apr 2018 19:23:25 -0000 1.2 +++ openacs-4/packages/acs-authentication/tcl/authentication-procs-aolserver.tcl 9 May 2018 15:33:28 -0000 1.3 @@ -100,7 +100,7 @@ @return list {key number_of_attempts timeout} } { - set result {} + set result [list] set current_time [ns_time] set max_age [parameter::get_from_package_key \ -parameter "MaxConsecutiveFailedLoginAttemptsLockoutTime" \ Index: openacs-4/packages/acs-authentication/tcl/authentication-procs-naviserver.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-authentication/tcl/authentication-procs-naviserver.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/acs-authentication/tcl/authentication-procs-naviserver.tcl 25 Apr 2018 19:23:25 -0000 1.2 +++ openacs-4/packages/acs-authentication/tcl/authentication-procs-naviserver.tcl 9 May 2018 15:33:28 -0000 1.3 @@ -63,7 +63,7 @@ @return list {key number_of_attempts timeout ... } } { - set result {} + set result [list] set keys [ns_cache_keys ns:memoize] set contents [lindex [ns_cache_stats -contents -- ns:memoize] 0] Index: openacs-4/packages/acs-authentication/tcl/driver-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-authentication/tcl/driver-procs.tcl,v diff -u -N -r1.12 -r1.13 --- openacs-4/packages/acs-authentication/tcl/driver-procs.tcl 25 Apr 2018 19:23:25 -0000 1.12 +++ openacs-4/packages/acs-authentication/tcl/driver-procs.tcl 9 May 2018 15:33:28 -0000 1.13 @@ -52,7 +52,7 @@ @author Simon Carstensen (simon@collaboraid.biz) @creation-date 2003-08-27 } { - array set param {} + array set param [list] db_foreach select_values { select key, value @@ -64,7 +64,7 @@ } # We need to ensure that the driver gets all the parameters it is asking for, and nothing but the ones it is asking for - set params {} + set params [list] foreach { name desc } [get_parameters -impl_id $impl_id] { if { [info exists param($name)] } { lappend params $name $param($name) Index: openacs-4/packages/acs-authentication/tcl/local-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-authentication/tcl/local-procs.tcl,v diff -u -N -r1.43 -r1.44 --- openacs-4/packages/acs-authentication/tcl/local-procs.tcl 25 Apr 2018 19:23:25 -0000 1.43 +++ openacs-4/packages/acs-authentication/tcl/local-procs.tcl 9 May 2018 15:33:28 -0000 1.44 @@ -143,7 +143,7 @@ Implements the Authenticate operation of the auth_authentication service contract for the local account implementation. } { - array set auth_info {} + array set auth_info [list] if {$authority_id eq ""} { set authority_id [auth::authority::local] @@ -630,7 +630,7 @@ service contract for the local account implementation. } { - set results {} + set results [list] db_foreach user_search {} { lappend results $user_id } Index: openacs-4/packages/acs-authentication/tcl/sync-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-authentication/tcl/sync-procs.tcl,v diff -u -N -r1.41 -r1.42 --- openacs-4/packages/acs-authentication/tcl/sync-procs.tcl 25 Apr 2018 19:23:25 -0000 1.41 +++ openacs-4/packages/acs-authentication/tcl/sync-procs.tcl 9 May 2018 15:33:28 -0000 1.42 @@ -547,7 +547,7 @@ # TODO: using a different error-code could make the code saver, by # just ingnoring such cases. # - set elms {} + set elms [list] ad_try { set elms [auth::sync::GetElements -authority_id $authority_id] } on error {errorMsg dict} { Index: openacs-4/packages/acs-authentication/tcl/test/acs-authentication-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-authentication/tcl/test/acs-authentication-procs.tcl,v diff -u -N -r1.47 -r1.48 --- openacs-4/packages/acs-authentication/tcl/test/acs-authentication-procs.tcl 25 Apr 2018 19:23:25 -0000 1.47 +++ openacs-4/packages/acs-authentication/tcl/test/acs-authentication-procs.tcl 9 May 2018 15:33:28 -0000 1.48 @@ -629,7 +629,7 @@ aa_true "List of parameters is not empty" [expr {[llength $parameters] != 0}] - array set values {} + array set values [list] # Set the values foreach parameter $parameters { Index: openacs-4/packages/acs-automated-testing/www/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-automated-testing/www/index.tcl,v diff -u -N -r1.8 -r1.9 --- openacs-4/packages/acs-automated-testing/www/index.tcl 26 Apr 2018 08:56:37 -0000 1.8 +++ openacs-4/packages/acs-automated-testing/www/index.tcl 9 May 2018 15:33:28 -0000 1.9 @@ -10,7 +10,7 @@ } set page_title "Test Servers Control Page" -set context {} +set context [list] multirow create servers path admin_login_url local_url remote_url name description install_date error_total_count parse_errors set xml_report_dir [aa_test::xml_report_dir] Index: openacs-4/packages/acs-bootstrap-installer/installer/www/blank-master.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-bootstrap-installer/installer/www/blank-master.tcl,v diff -u -N -r1.7 -r1.8 --- openacs-4/packages/acs-bootstrap-installer/installer/www/blank-master.tcl 25 Apr 2018 19:23:25 -0000 1.7 +++ openacs-4/packages/acs-bootstrap-installer/installer/www/blank-master.tcl 9 May 2018 15:33:28 -0000 1.8 @@ -117,7 +117,7 @@ if { [llength $css] == 2 && [llength $first] == 1 && [string index $first 0] ne "-"} { template::head::add_css -href $first -media [lindex $css 1] } elseif {[llength $first] == 2} { - set params {} + set params [list] foreach param $css { lappend params -[lindex $param 0] [lindex $param 1] } Index: openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl,v diff -u -N -r1.54 -r1.55 --- openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl 8 May 2018 22:37:18 -0000 1.54 +++ openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl 9 May 2018 15:33:28 -0000 1.55 @@ -1,10 +1,10 @@ # For documentation, see the ad_library call at the bottom of this script. -nsv_array set api_proc_doc {} -nsv_array set api_proc_doc_scripts {} -nsv_array set api_library_doc {} -nsv_array set proc_doc {} -nsv_array set proc_source_file {} +nsv_array set api_proc_doc [list] +nsv_array set api_proc_doc_scripts [list] +nsv_array set api_library_doc [list] +nsv_array set proc_doc [list] +nsv_array set proc_source_file [list] # @@ -95,7 +95,7 @@ set lines [split $doc_string "\n\r"] - array set elements {} + array set elements [list] set current_element main set buffer "" @@ -304,7 +304,7 @@ if { $n_args_remaining == 3 } { # No doc string provided. #ns_log notice "missing doc string for ad_proc $proc_name ([info script])" - array set doc_elements {} + array set doc_elements [list] set doc_elements(main) "" } else { # Doc string was provided. @@ -326,12 +326,12 @@ # ##### - set switches {} - set positionals {} + set switches [list] + set positionals [list] set seen_positional_with_default_p 0 set n_positionals_with_defaults 0 - array set default_values {} - array set flags {} + array set default_values [list] + array set flags [list] set varargs_p 0 set switch_code "" @@ -341,7 +341,7 @@ set first_arg [lindex $arg_list 0] if { [llength $first_arg] == 0 || [llength $first_arg] > 2 } { ns_log Warning "Convert old (deprecated) style proc: $proc_name" - set new_arg_list {} + set new_arg_list [list] foreach { switch default_value } $first_arg { lappend new_arg_list [list $switch $default_value] } @@ -369,7 +369,7 @@ set default_p 0 } - set arg_flags {} + set arg_flags [list] set arg_split [split $arg ":"] if { [llength $arg_split] == 2 } { set arg [lindex $arg_split 0] @@ -781,7 +781,7 @@ if { $varargs_p } { upvar args args - set args {} + set args [list] } set counter 0 Index: openacs-4/packages/acs-bootstrap-installer/tcl/10-utilities-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-bootstrap-installer/tcl/10-utilities-procs.tcl,v diff -u -N -r1.11 -r1.12 --- openacs-4/packages/acs-bootstrap-installer/tcl/10-utilities-procs.tcl 25 Apr 2018 19:23:25 -0000 1.11 +++ openacs-4/packages/acs-bootstrap-installer/tcl/10-utilities-procs.tcl 9 May 2018 15:33:28 -0000 1.12 @@ -26,11 +26,11 @@ } { # Use the examined_files array to track files that we've examined. - array set examined_files {} + array set examined_files [list] # A list of files that we will return (in the order in which we # examined them). - set files {} + set files [list] # A list of files that we still need to examine. set files_to_examine [list $path] Index: openacs-4/packages/acs-bootstrap-installer/tcl/30-apm-load-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-bootstrap-installer/tcl/30-apm-load-procs.tcl,v diff -u -N -r1.45 -r1.46 --- openacs-4/packages/acs-bootstrap-installer/tcl/30-apm-load-procs.tcl 25 Apr 2018 19:23:25 -0000 1.45 +++ openacs-4/packages/acs-bootstrap-installer/tcl/30-apm-load-procs.tcl 9 May 2018 15:33:28 -0000 1.46 @@ -196,7 +196,7 @@ # We don't assume db_type proc is defined yet set system_db_type [nsv_get ad_database_type .] - set matching_files {} + set matching_files [list] foreach file $files { set rel_path [string range $file [string length $package_path]+1 end] set file_type [apm_guess_file_type $package_key $rel_path] @@ -368,7 +368,7 @@ if {$errorVarName ne ""} { upvar $errorVarName errors } else { - array set errors {} + array set errors [list] } if { ![file exists $__file] } { @@ -423,7 +423,7 @@ @param init Load initialization files @param procs Load the proc library files } { - set file_types {} + set file_types [list] if { $procs_p } { lappend file_types tcl_procs } Index: openacs-4/packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl,v diff -u -N -r1.46 -r1.47 --- openacs-4/packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl 8 May 2018 22:37:18 -0000 1.46 +++ openacs-4/packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl 9 May 2018 15:33:28 -0000 1.47 @@ -224,7 +224,7 @@ if {$errorVarName ne ""} { upvar $errorVarName errors } else { - array set errors {} + array set errors [list] } if { [catch {db_qd_internal_load_cache $file_path} errMsg] } { set backTrace $::errorInfo Index: openacs-4/packages/acs-core-docs/tcl/acs-core-docs-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-core-docs/tcl/acs-core-docs-procs.tcl,v diff -u -N -r1.8 -r1.9 --- openacs-4/packages/acs-core-docs/tcl/acs-core-docs-procs.tcl 30 Apr 2018 15:34:17 -0000 1.8 +++ openacs-4/packages/acs-core-docs/tcl/acs-core-docs-procs.tcl 9 May 2018 15:33:28 -0000 1.9 @@ -12,7 +12,7 @@ @author Jeff Davis (davis@xarg.net) } { - set uninstalled {} + set uninstalled [list] # Determine which spec files are not installed foreach spec_file [apm_scan_packages "$::acs::rootdir/packages"] { if { ! [catch {array set version [apm_read_package_info_file $spec_file]} errMsg] } { @@ -26,7 +26,7 @@ } # sort the list and return in array set form - set out {} + set out [list] foreach pkg [lsort -dictionary -index 1 $uninstalled] { lappend out {*}$pkg } Index: openacs-4/packages/acs-core-docs/www/tutorial-admin-pages.adp =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-core-docs/www/tutorial-admin-pages.adp,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/acs-core-docs/www/tutorial-admin-pages.adp 26 Apr 2018 08:56:37 -0000 1.5 +++ openacs-4/packages/acs-core-docs/www/tutorial-admin-pages.adp 9 May 2018 15:33:28 -0000 1.6 @@ -49,7 +49,7 @@ -object_id $package_id \ -privilege admin] -set context {} +set context [list] set title "Administration" Index: openacs-4/packages/acs-core-docs/www/tutorial-admin-pages.html =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-core-docs/www/tutorial-admin-pages.html,v diff -u -N -r1.17 -r1.18 --- openacs-4/packages/acs-core-docs/www/tutorial-admin-pages.html 26 Apr 2018 08:56:37 -0000 1.17 +++ openacs-4/packages/acs-core-docs/www/tutorial-admin-pages.html 9 May 2018 15:33:28 -0000 1.18 @@ -49,7 +49,7 @@ -object_id $package_id \ -privilege admin] -set context {} +set context [list] set title "Administration" Index: openacs-4/packages/acs-core-docs/www/tutorial-pages.adp =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-core-docs/www/tutorial-pages.adp,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/acs-core-docs/www/tutorial-pages.adp 26 Apr 2018 08:56:37 -0000 1.5 +++ openacs-4/packages/acs-core-docs/www/tutorial-pages.adp 9 May 2018 15:33:28 -0000 1.6 @@ -49,7 +49,7 @@ } set page_title [ad_conn instance_name] -set context {} +set context [list] # Local variables: # mode: tcl # tcl-indent-level: 4 Index: openacs-4/packages/acs-core-docs/www/tutorial-pages.html =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-core-docs/www/tutorial-pages.html,v diff -u -N -r1.48 -r1.49 --- openacs-4/packages/acs-core-docs/www/tutorial-pages.html 26 Apr 2018 08:56:37 -0000 1.48 +++ openacs-4/packages/acs-core-docs/www/tutorial-pages.html 9 May 2018 15:33:28 -0000 1.49 @@ -45,7 +45,7 @@ } set page_title [ad_conn instance_name] -set context {} +set context [list] # Local variables: # mode: tcl # tcl-indent-level: 4 Index: openacs-4/packages/acs-core-docs/www/files/tutorial/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-core-docs/www/files/tutorial/index.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/acs-core-docs/www/files/tutorial/index.tcl 26 Apr 2018 08:56:37 -0000 1.4 +++ openacs-4/packages/acs-core-docs/www/files/tutorial/index.tcl 9 May 2018 15:33:28 -0000 1.5 @@ -6,7 +6,7 @@ } set page_title [ad_conn instance_name] -set context {} +set context [list] # Local variables: # mode: tcl # tcl-indent-level: 4 Index: openacs-4/packages/acs-core-docs/www/xml/developers-guide/tutorial-advanced.xml =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-core-docs/www/xml/developers-guide/tutorial-advanced.xml,v diff -u -N -r1.56 -r1.57 --- openacs-4/packages/acs-core-docs/www/xml/developers-guide/tutorial-advanced.xml 26 Apr 2018 08:56:37 -0000 1.56 +++ openacs-4/packages/acs-core-docs/www/xml/developers-guide/tutorial-advanced.xml 9 May 2018 15:33:28 -0000 1.57 @@ -419,7 +419,7 @@ -object_id $package_id \ -privilege admin] -set context {} +set context [list] set title "Administration" Index: openacs-4/packages/acs-developer-support/tcl/acs-developer-support-init.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-developer-support/tcl/acs-developer-support-init.tcl,v diff -u -N -r1.11 -r1.12 --- openacs-4/packages/acs-developer-support/tcl/acs-developer-support-init.tcl 25 Apr 2018 19:23:25 -0000 1.11 +++ openacs-4/packages/acs-developer-support/tcl/acs-developer-support-init.tcl 9 May 2018 15:33:28 -0000 1.12 @@ -8,12 +8,12 @@ if { ![nsv_exists ds_properties enabled_p] } { ad_register_filter -critical t -priority 999999 trace * /* ds_trace_filter ad_schedule_proc [parameter::get -package_id [ds_instance_id] -parameter DataSweepInterval -default 900] ds_sweep_data - nsv_array set ds_request {} + nsv_array set ds_request [list] nsv_set ds_properties enabled_p [parameter::get -package_id [ds_instance_id] -parameter EnabledOnStartupP -default 0] # Take the IP list (space or comma separated) and turn it into a Tcl list. - set IPs {} + set IPs [list] foreach ip [lsort -unique [split [parameter::get -package_id [ds_instance_id] -parameter EnabledIPs -default *] { ,}]] { if {$ip eq "*"} { # a star means anything will match so just use the * instead Index: openacs-4/packages/acs-developer-support/tcl/acs-developer-support-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-developer-support/tcl/acs-developer-support-procs.tcl,v diff -u -N -r1.58 -r1.59 --- openacs-4/packages/acs-developer-support/tcl/acs-developer-support-procs.tcl 25 Apr 2018 19:23:25 -0000 1.58 +++ openacs-4/packages/acs-developer-support/tcl/acs-developer-support-procs.tcl 9 May 2018 15:33:28 -0000 1.59 @@ -342,7 +342,7 @@ set _errno [catch { if { [info exists bind] && [llength $bind] != 0 } { if { [llength $bind] == 1 } { - set bind_vars {} + set bind_vars [list] set len [ns_set size $bind] for {set i 0} {$i < $len} {incr i} { lappend bind_vars [ns_set key $bind $i] \ @@ -638,7 +638,7 @@ ad_proc -public ds_get_comments {} { Get comments for the current request } { - set comments {} + set comments [list] if { [nsv_exists ds_request $::ad_conn(request).comment] } { set comments [nsv_get ds_request $::ad_conn(request).comment] } Index: openacs-4/packages/acs-lang/tcl/lang-catalog-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-lang/tcl/lang-catalog-procs.tcl,v diff -u -N -r1.57 -r1.58 --- openacs-4/packages/acs-lang/tcl/lang-catalog-procs.tcl 25 Apr 2018 19:23:25 -0000 1.57 +++ openacs-4/packages/acs-lang/tcl/lang-catalog-procs.tcl 9 May 2018 15:33:28 -0000 1.58 @@ -207,7 +207,7 @@ @author Peter Marklund } { - set catalog_paths {} + set catalog_paths [list] set catalog_dir [lang::catalog::package_catalog_dir $package_key] foreach file_path [glob -nocomplain "$catalog_dir/*"] { @@ -232,7 +232,7 @@ @author Peter Marklund } { - set message_list {} + set message_list [list] foreach message_tuple [all_messages_for_package_and_locale $package_key $locale] { lassign $message_tuple message_key message description @@ -256,7 +256,7 @@ @author Peter Marklund } { - set message_list {} + set message_list [list] db_foreach last_sync_messages {} { if { ![template::util::is_true $deleted_p] } { lappend message_list $message_key $message @@ -405,8 +405,8 @@ } # Get messages and descriptions for the locale - set messages_list {} - set descriptions_list {} + set messages_list [list] + set descriptions_list [list] foreach message_tuple [all_messages_for_package_and_locale $package_key $locale] { lassign $message_tuple message_key message description lappend messages_list $message_key $message @@ -717,7 +717,7 @@ set message_count(added) 0 set message_count(updated) 0 set message_count(deleted) 0 - set message_count(errors) {} + set message_count(errors) [list] # Form arrays for all three sets of messages array set file_messages $file_messages_list @@ -729,15 +729,15 @@ -locale $locale] foreach arrname { base_messages file_messages db_messages } { - set dummy {} + set dummy [list] foreach elm [lsort [array names $arrname]] { lappend dummy "$elm=[set ${arrname}($elm)]" } ns_log Debug "lang::catalog::import_messages - $arrname: $dummy" } # Remember each time we've processed a key, so we don't process it twice - array set message_key_processed_p {} + array set message_key_processed_p [list] # Loop over the union of import and db keys. foreach message_key [lsort [concat [array names db_messages] [array names file_messages] [array names base_messages]]] { @@ -991,7 +991,7 @@ set message_count(added) 0 set message_count(updated) 0 set message_count(deleted) 0 - set message_count(errors) {} + set message_count(errors) [list] if { $package_key ne "" } { set package_key_list $package_key @@ -1074,7 +1074,7 @@ set locales_list [concat $en_us_locale_list $other_locales_list] # Get all catalog files for enabled locales - set catalog_files {} + set catalog_files [list] foreach locale $locales_list { # If we are only processing certain locales and this is not one of them - continue Index: openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl,v diff -u -N -r1.59 -r1.60 --- openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl 25 Apr 2018 19:23:25 -0000 1.59 +++ openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl 9 May 2018 15:33:28 -0000 1.60 @@ -178,7 +178,7 @@ lang::message::check $locale $package_key $message_key $message # Build up an array of columns to set - array set cols {} + array set cols [list] if { $update_sync_p } { set cols(sync_time) [db_map sync_time] } else { @@ -212,7 +212,7 @@ set cols(deleted_p) :deleted_p # For use in update query - set set_clauses {} + set set_clauses [list] foreach col [array names cols] { lappend set_clauses "$col = $cols($col)" } @@ -253,8 +253,8 @@ set cols(creation_user) :creation_user } - set col_clauses {} - set val_clauses {} + set col_clauses [list] + set val_clauses [list] foreach col [array names cols] { lappend col_clauses $col lappend val_clauses $cols($col) @@ -505,7 +505,7 @@ } } - set set_clauses {} + set set_clauses [list] foreach name [array names edit_array] { lappend set_clauses "$name = :$name" set $name $edit_array($name) @@ -542,7 +542,7 @@ @author Peter Marklund } { # Build any package and locale where clauses - set where_clauses {} + set where_clauses [list] foreach col {package_key locale} { if { [set $col] ne "" } { lappend where_clauses "$col = :${col}" @@ -596,7 +596,7 @@ @author Peter Marklund (peter@collaboraid.biz) @creation-date 12 November 2002 } { - set variables_list {} + set variables_list [list] set remaining_message $message while { [regexp [embedded_vars_regexp] $remaining_message \ match before_percent percent_match remaining_message] } { Index: openacs-4/packages/acs-lang/tcl/lang-util-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-lang/tcl/lang-util-procs.tcl,v diff -u -N -r1.53 -r1.54 --- openacs-4/packages/acs-lang/tcl/lang-util-procs.tcl 8 May 2018 22:37:18 -0000 1.53 +++ openacs-4/packages/acs-lang/tcl/lang-util-procs.tcl 9 May 2018 15:33:28 -0000 1.54 @@ -110,7 +110,7 @@ set multilingual_string_offset "0" set offset_string $multilingual_string - set indices_list {} + set indices_list [list] while { [regexp -indices $regexp_pattern $offset_string full_match_idx key_match_idx] } { @@ -527,8 +527,8 @@ set state text set out {} - set report {} - set garbage {} + set report [list] + set garbage [list] set n 0 @@ -807,7 +807,7 @@ } { localize the elements of a list_of_lists } { - set list_output {} + set list_output [list] foreach item $list { set item_output [list] foreach part $item { Index: openacs-4/packages/acs-lang/tcl/locale-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-lang/tcl/locale-procs.tcl,v diff -u -N -r1.43 -r1.44 --- openacs-4/packages/acs-lang/tcl/locale-procs.tcl 25 Apr 2018 19:23:25 -0000 1.43 +++ openacs-4/packages/acs-lang/tcl/locale-procs.tcl 9 May 2018 15:33:28 -0000 1.44 @@ -631,7 +631,7 @@ # Split by comma, and get rid of any ;q=0.5 parts # acclang is something like 'da,en-us;q=0.8,es-ni;q=0.5,de;q=0.3' - set acclangv {} + set acclangv [list] foreach elm [split $acclang ","] { # Get rid of trailing ;q=0.5 part and trim spaces set elm [string trimleft [lindex [split $elm ";"] 0] " "] Index: openacs-4/packages/acs-lang/www/admin/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-lang/www/admin/index.tcl,v diff -u -N -r1.14 -r1.15 --- openacs-4/packages/acs-lang/www/admin/index.tcl 26 Apr 2018 08:56:37 -0000 1.14 +++ openacs-4/packages/acs-lang/www/admin/index.tcl 9 May 2018 15:33:28 -0000 1.15 @@ -15,7 +15,7 @@ set system_locale_label [lang::util::get_label $system_locale] set page_title [_ acs-lang.Administration_of_Localization] -set context {} +set context [list] set site_wide_admin_p [acs_user::site_wide_admin_p] Index: openacs-4/packages/acs-lang/www/admin/test/translator-mode.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-lang/www/admin/test/translator-mode.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/acs-lang/www/admin/test/translator-mode.tcl 26 Apr 2018 08:56:37 -0000 1.3 +++ openacs-4/packages/acs-lang/www/admin/test/translator-mode.tcl 9 May 2018 15:33:28 -0000 1.4 @@ -4,7 +4,7 @@ set tcl_message [_ acs-lang.French] -set options {} +set options [list] foreach elm { English French German Spanish } { lappend options [list [_ acs-lang.$elm] $elm] Index: openacs-4/packages/acs-mail-lite/tcl/incoming-mail-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-mail-lite/tcl/Attic/incoming-mail-procs.tcl,v diff -u -N -r1.16 -r1.17 --- openacs-4/packages/acs-mail-lite/tcl/incoming-mail-procs.tcl 26 Apr 2018 08:56:37 -0000 1.16 +++ openacs-4/packages/acs-mail-lite/tcl/incoming-mail-procs.tcl 9 May 2018 15:33:28 -0000 1.17 @@ -206,7 +206,7 @@ #get all available headers set keys [mime::getheader $mime -names] - set headers {} + set headers [list] # create both the headers array and all headers directly for the email array foreach header $keys { @@ -225,7 +225,7 @@ } # travers the tree and extract parts into a flat list - set all_parts {} + set all_parts [list] foreach part $parts { if {[mime::getproperty $part content] eq "multipart/alternative"} { foreach child_part [mime::getproperty $part parts] { @@ -236,8 +236,8 @@ } } - set bodies {} - set files {} + set bodies [list] + set files [list] #now extract all parts (bodies/files) and fill the email array foreach part $all_parts { Index: openacs-4/packages/acs-mail-lite/www/doc/incoming-email-legacy-notes.adp =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-mail-lite/www/doc/incoming-email-legacy-notes.adp,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/acs-mail-lite/www/doc/incoming-email-legacy-notes.adp 26 Apr 2018 08:56:37 -0000 1.3 +++ openacs-4/packages/acs-mail-lite/www/doc/incoming-email-legacy-notes.adp 9 May 2018 15:33:28 -0000 1.4 @@ -106,7 +106,7 @@ #get all available headers set keys [mime::getheader $mime -names] - set headers {} + set headers [list] # create both the headers array and all headers directly for the email array foreach header $keys { @@ -149,8 +149,8 @@

-    set bodies {}
-    set files {}
+    set bodies [list]
+    set files [list]
     
     #now extract all parts (bodies/files) and fill the email array
     foreach part $all_parts {
Index: openacs-4/packages/acs-outdated/tcl/acs-tcl-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-outdated/tcl/acs-tcl-procs.tcl,v
diff -u -N -r1.3 -r1.4
--- openacs-4/packages/acs-outdated/tcl/acs-tcl-procs.tcl	25 Apr 2018 19:47:46 -0000	1.3
+++ openacs-4/packages/acs-outdated/tcl/acs-tcl-procs.tcl	9 May 2018 15:33:28 -0000	1.4
@@ -2,7 +2,7 @@
     Applies proc_name to each item of the list, appending the result of 
     each call to a new list that is the return value.
 } {
-    set lmap {}
+    set lmap [list]
     foreach item $list {
         lappend lmap [safe_eval $proc_name $item]
     }
Index: openacs-4/packages/acs-service-contract/tcl/acs-service-contract-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-service-contract/tcl/acs-service-contract-procs.tcl,v
diff -u -N -r1.29 -r1.30
--- openacs-4/packages/acs-service-contract/tcl/acs-service-contract-procs.tcl	9 May 2018 10:11:45 -0000	1.29
+++ openacs-4/packages/acs-service-contract/tcl/acs-service-contract-procs.tcl	9 May 2018 15:33:28 -0000	1.30
@@ -145,7 +145,7 @@
     @return 0 on failure, 1 on success.
     @author Neophytos Demetriou
 } {
-    set arguments {}
+    set arguments [list]
     set docblock {}
 
     set proc_name [acs_sc_generate_name $contract $impl $operation]
@@ -228,7 +228,7 @@
 	    set full_statement [join $full_statement]
 	}
 	PLPGSQL {
-	    set args_list {}
+	    set args_list [list]
 	    for {set __i 0} {$__i < [llength $arguments]} {incr __i} {
 		lappend args_list "\$[lindex $arguments $__i]"
 	    }
Index: openacs-4/packages/acs-service-contract/tcl/contract-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-service-contract/tcl/contract-procs.tcl,v
diff -u -N -r1.10 -r1.11
--- openacs-4/packages/acs-service-contract/tcl/contract-procs.tcl	25 Apr 2018 19:23:26 -0000	1.10
+++ openacs-4/packages/acs-service-contract/tcl/contract-procs.tcl	9 May 2018 15:33:28 -0000	1.11
@@ -157,8 +157,8 @@
 
         if { !$no_cascade_p } {
             
-            set operations {}
-            set msg_types {}
+            set operations [list]
+            set msg_types [list]
             
             db_foreach select_operations {} {
                 # Put them on list of message types and operations to delete
Index: openacs-4/packages/acs-service-contract/www/index.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-service-contract/www/index.tcl,v
diff -u -N -r1.10 -r1.11
--- openacs-4/packages/acs-service-contract/www/index.tcl	26 Apr 2018 08:56:37 -0000	1.10
+++ openacs-4/packages/acs-service-contract/www/index.tcl	9 May 2018 15:33:28 -0000	1.11
@@ -1,4 +1,4 @@
-set context {}
+set context [list]
 
 db_multirow defined_contracts defined_contracts {
     select contract_id,
Index: openacs-4/packages/acs-subsite/lib/applications.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/lib/applications.tcl,v
diff -u -N -r1.8 -r1.9
--- openacs-4/packages/acs-subsite/lib/applications.tcl	26 Apr 2018 08:56:37 -0000	1.8
+++ openacs-4/packages/acs-subsite/lib/applications.tcl	9 May 2018 15:33:28 -0000	1.9
@@ -1,6 +1,6 @@
 set admin_p [permission::permission_p -object_id [ad_conn subsite_id] -privilege admin -party_id [ad_conn untrusted_user_id]]
 
-set actions {}
+set actions [list]
 if { $admin_p } {
     lappend actions \
         [_ acs-subsite.Add_new_app] \
Index: openacs-4/packages/acs-subsite/lib/services.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/lib/services.tcl,v
diff -u -N -r1.7 -r1.8
--- openacs-4/packages/acs-subsite/lib/services.tcl	26 Apr 2018 08:56:37 -0000	1.7
+++ openacs-4/packages/acs-subsite/lib/services.tcl	9 May 2018 15:33:28 -0000	1.8
@@ -11,7 +11,7 @@
         }
     }
 
-set services {}
+set services [list]
 
 foreach url [site_node::get_children -package_type apm_service -node_id [subsite::get_element -element node_id]] {
     array unset node 
Index: openacs-4/packages/acs-subsite/tcl/attribute-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/tcl/attribute-procs.tcl,v
diff -u -N -r1.16 -r1.17
--- openacs-4/packages/acs-subsite/tcl/attribute-procs.tcl	25 Apr 2018 19:23:26 -0000	1.16
+++ openacs-4/packages/acs-subsite/tcl/attribute-procs.tcl	9 May 2018 15:33:28 -0000	1.17
@@ -117,7 +117,7 @@
     # friendly and is thus used as the column name
     set attribute_name [plsql_utility::generate_oracle_name $pretty_name]
     
-#      set attr_list {}
+#      set attr_list [list]
 #      lappend attr_list [list "object_type" '$object_type']
 #      lappend attr_list [list "attribute_name" '$attribute_name']
 #      lappend attr_list [list "min_n_values" '$min_n_values']
@@ -130,7 +130,7 @@
     # A note (by ben, OpenACS)
     # the queries are empty because they are pulled out later in db_exec_plsql
     
-    set plsql {}
+    set plsql [list]
     lappend plsql_drop [list db_exec_plsql "drop_attribute" "FOO"]
     lappend plsql [list db_exec_plsql "create_attribute" "FOO"]
 
@@ -419,7 +419,7 @@
 } { 
     upvar $array_name attr_props
     upvar $enum_array_name enum_values
-    set attr_list {}
+    set attr_list [list]
 
     set storage_clause ""
 
Index: openacs-4/packages/acs-subsite/tcl/group-type-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/tcl/group-type-procs.tcl,v
diff -u -N -r1.8 -r1.9
--- openacs-4/packages/acs-subsite/tcl/group-type-procs.tcl	26 Apr 2018 08:56:37 -0000	1.8
+++ openacs-4/packages/acs-subsite/tcl/group-type-procs.tcl	9 May 2018 15:33:28 -0000	1.9
@@ -106,8 +106,8 @@
 	# Store the plsql in a list so that we can choose, at the end,
 	# to either execute it or return it as a debug message
 
-	set plsql {}
-	set plsql_drop {}
+	set plsql [list]
+	set plsql_drop [list]
 
 	if { [db_table_exists $table_name] } {
 	    # What to do? Options:
Index: openacs-4/packages/acs-subsite/tcl/package-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/tcl/package-procs.tcl,v
diff -u -N -r1.35 -r1.36
--- openacs-4/packages/acs-subsite/tcl/package-procs.tcl	9 May 2018 08:17:15 -0000	1.35
+++ openacs-4/packages/acs-subsite/tcl/package-procs.tcl	9 May 2018 15:33:28 -0000	1.36
@@ -86,7 +86,7 @@
     # pl/sql code. Note that the helper procs also return nicely
     # formatted pl/sql code
 
-    set attr_list {}
+    set attr_list [list]
 
     # Start with the primary key for this object type. Continuing with
     # convention that id_column can be null (will default to new
@@ -498,7 +498,7 @@
         }
     }
 
-    set pk_formatted {}
+    set pk_formatted [list]
     for { set i 0 } { $i < [llength $primary_keys] - 1 } { incr i } {
         lappend pk_formatted "[lindex $primary_keys $i] = [lindex $primary_keys $i+1]"
     }
@@ -763,7 +763,7 @@
     # parameters we've already added in the array param_array (all keys are
     # in upper case)
 
-    set pieces {}
+    set pieces [list]
 
     foreach pair $var_list {
         lassign $pair __key __value
@@ -884,7 +884,7 @@
     # parameters we've already added in the array param_array (all keys are
     # in upper case)
 
-    set pieces {}
+    set pieces [list]
 
     foreach pair $var_list {
         lassign $pair __key __value
Index: openacs-4/packages/acs-subsite/tcl/plpgsql-utility-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/tcl/plpgsql-utility-procs.tcl,v
diff -u -N -r1.8 -r1.9
--- openacs-4/packages/acs-subsite/tcl/plpgsql-utility-procs.tcl	26 Apr 2018 08:56:37 -0000	1.8
+++ openacs-4/packages/acs-subsite/tcl/plpgsql-utility-procs.tcl	9 May 2018 15:33:28 -0000	1.9
@@ -22,7 +22,7 @@
 	@creation-date 11/2000
 
     } {
-	set the_list {}
+	set the_list [list]
 	foreach row $attr_list {
 	    lappend the_list [list [lindex $row 1] [lindex $row 3]]
 	}
@@ -56,7 +56,7 @@
 	}
 
 	# For each real arg, append default or supplied arg value
-	set pieces {}
+	set pieces [list]
 	foreach row $real_args {
 	    lassign $row arg_name arg_default
 
@@ -97,7 +97,7 @@
 	@creation-date 11/2000
 
     } {
-	set pieces {}
+	set pieces [list]
 	set arg_num 0
 	foreach triple $attr_list {
 	    incr arg_num
@@ -118,7 +118,7 @@
 	@creation-date 07/2001
 
     } {
-	set pieces {}
+	set pieces [list]
 	foreach triple $attr_list {
 	    set table [string toupper [string trim [lindex $triple 0]]]
 	    set attr [string toupper [string trim [lindex $triple 1]]]
@@ -146,7 +146,7 @@
 	@creation-date 07/2001
 
     } {
-	set pieces {}
+	set pieces [list]
 	foreach triple $attr_list {
 	    set attr  [string trim [lindex $triple 1]]
 	    set dft   [string trim [lindex $triple 2]]
Index: openacs-4/packages/acs-subsite/tcl/plsql-utility-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/tcl/plsql-utility-procs.tcl,v
diff -u -N -r1.6 -r1.7
--- openacs-4/packages/acs-subsite/tcl/plsql-utility-procs.tcl	26 Apr 2018 08:56:37 -0000	1.6
+++ openacs-4/packages/acs-subsite/tcl/plsql-utility-procs.tcl	9 May 2018 15:33:28 -0000	1.7
@@ -219,7 +219,7 @@
 	@creation-date 11/2000
 
     } {
-	set pieces {}
+	set pieces [list]
 	foreach triple $attr_list {
 	    set table [string toupper [string trim [lindex $triple 0]]]
 	    set attr [string toupper [string trim [lindex $triple 1]]]
@@ -246,7 +246,7 @@
 	@creation-date 11/2000
 
     } {
-	set the_list {}
+	set the_list [list]
 	foreach row $attr_list {
 	    lappend the_list [list [lindex $row 1] [lindex $row 3]]
 	}
@@ -264,7 +264,7 @@
 	@creation-date 11/2000
 
     } {
-	set pieces {}
+	set pieces [list]
 	foreach row $pairs {
 	    set attr [string trim [lindex $row 0]]
 	    set attr_value [string trim [lindex $row 1]]
@@ -292,7 +292,7 @@
 
     } {
 	set ignore [string toupper $ignore]
-	set this_columns {}
+	set this_columns [list]
 	set table_name [string toupper [string trim $table_name]]
 	foreach triple $attr_list {
 	    set table [string toupper [string trim [lindex $triple 0]]]
Index: openacs-4/packages/acs-subsite/tcl/rel-types-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/tcl/rel-types-procs.tcl,v
diff -u -N -r1.15 -r1.16
--- openacs-4/packages/acs-subsite/tcl/rel-types-procs.tcl	26 Apr 2018 08:56:37 -0000	1.15
+++ openacs-4/packages/acs-subsite/tcl/rel-types-procs.tcl	9 May 2018 15:33:28 -0000	1.16
@@ -131,7 +131,7 @@
 	set pk_constraint_name [plsql_utility::generate_constraint_name $table_name rel_id "pk"]
 	set fk_constraint_name [plsql_utility::generate_constraint_name $table_name rel_id "fk"]
 
-	set plsql {}
+	set plsql [list]
 
 	# Create the actual acs object type
 
Index: openacs-4/packages/acs-subsite/tcl/subsite-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/tcl/subsite-procs.tcl,v
diff -u -N -r1.54 -r1.55
--- openacs-4/packages/acs-subsite/tcl/subsite-procs.tcl	30 Apr 2018 08:51:11 -0000	1.54
+++ openacs-4/packages/acs-subsite/tcl/subsite-procs.tcl	9 May 2018 15:33:28 -0000	1.55
@@ -399,7 +399,7 @@
 } {
     @return the object type hierarchy for the given object type from ancestor_type to object_type
 } {
-    set path_list {}
+    set path_list [list]
 
     set type_list [db_list select_object_type_path {}]
 
@@ -624,14 +624,14 @@
     Defines the page flow structure.
 } {
     # This is where the page flow structure is defined
-    set subsections {}
+    set subsections [list]
     lappend subsections home {
         label "Home"
         url ""
     }
 
 
-    set pageflow {}
+    set pageflow [list]
 
     if {$url eq ""} {
         set subsite_url [subsite::get_element -element url]
@@ -1286,7 +1286,7 @@
     @see subsite::util::packages
 } {
     # need to strip nodes which have no mounted package...
-    set packages {}
+    set packages [list]
     foreach package [site_node::get_children -all -node_id $node_id -element package_id] {
         if {$package ne ""} {
             lappend packages $package
Index: openacs-4/packages/acs-subsite/www/index.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/www/index.tcl,v
diff -u -N -r1.23 -r1.24
--- openacs-4/packages/acs-subsite/www/index.tcl	26 Apr 2018 08:56:37 -0000	1.23
+++ openacs-4/packages/acs-subsite/www/index.tcl	9 May 2018 15:33:28 -0000	1.24
@@ -40,7 +40,7 @@
     ad_script_abort
 }
 
-set context {}
+set context [list]
 set package_id [ad_conn package_id]
 set admin_p [permission::permission_p -object_id $package_id -party_id [ad_conn untrusted_user_id] -privilege admin]
 
Index: openacs-4/packages/acs-subsite/www/admin/group-types/delete-2.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/www/admin/group-types/delete-2.tcl,v
diff -u -N -r1.10 -r1.11
--- openacs-4/packages/acs-subsite/www/admin/group-types/delete-2.tcl	26 Apr 2018 08:56:37 -0000	1.10
+++ openacs-4/packages/acs-subsite/www/admin/group-types/delete-2.tcl	9 May 2018 15:33:28 -0000	1.11
@@ -31,7 +31,7 @@
     ad_script_abort
 }
 
-set plsql {}
+set plsql [list]
 
 if { ![db_0or1row select_type_info {
     select t.table_name, t.package_name
Index: openacs-4/packages/acs-subsite/www/admin/site-map/index.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/www/admin/site-map/index.tcl,v
diff -u -N -r1.32 -r1.33
--- openacs-4/packages/acs-subsite/www/admin/site-map/index.tcl	25 Apr 2018 19:23:26 -0000	1.32
+++ openacs-4/packages/acs-subsite/www/admin/site-map/index.tcl	9 May 2018 15:33:28 -0000	1.33
@@ -260,7 +260,7 @@
     set expand_mode 0
     if {!$root_p && $n_children > 0} {
         set expand_mode 1
-        set urlvars {}
+        set urlvars [list]
         foreach n $expand {
             if {$n == $node_id} {
                 set expand_mode 2
Index: openacs-4/packages/acs-subsite/www/admin/site-map/site-map.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/www/admin/site-map/site-map.tcl,v
diff -u -N -r1.14 -r1.15
--- openacs-4/packages/acs-subsite/www/admin/site-map/site-map.tcl	26 Apr 2018 08:56:37 -0000	1.14
+++ openacs-4/packages/acs-subsite/www/admin/site-map/site-map.tcl	9 May 2018 15:33:28 -0000	1.15
@@ -169,7 +169,7 @@
     }
 
 multirow create nodes node_id expand_mode expand_url tree_indent name name_url instance instance_url type action_type action_form_part add_folder_url new_app_url unmount_url mount_url rename_url delete_url parameters_url permissions_url extra_form_part view_p
-set open_nodes {}
+set open_nodes [list]
 
 db_foreach nodes_select {} {
     set add_folder_url ""
@@ -231,7 +231,7 @@
     set expand_mode 0
     if {!$root_p && $n_children > 0} {
 	set expand_mode 1
-	set urlvars {}
+	set urlvars [list]
 	foreach n $expand {
 	    if {$n == $node_id} {
 		set expand_mode 2
Index: openacs-4/packages/acs-subsite/www/permissions/grant.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/www/permissions/grant.tcl,v
diff -u -N -r1.20 -r1.21
--- openacs-4/packages/acs-subsite/www/permissions/grant.tcl	26 Apr 2018 08:56:37 -0000	1.20
+++ openacs-4/packages/acs-subsite/www/permissions/grant.tcl	9 May 2018 15:33:28 -0000	1.21
@@ -34,7 +34,7 @@
 # Initialize the $hierarchy datastructure which is a list of
 # lists. The inner lists consist of two elements: 1. level,
 # 2. privilege
-set hierarchy {}
+set hierarchy [list]
 foreach privilege $existing_privs {
     lappend hierarchy [list 0 $privilege]
 }
@@ -127,7 +127,7 @@
     -optional
 
 if { ![info exists privileges] } {
-    set privileges {}
+    set privileges [list]
 }
 
 # limit the size of the select widget to a number that should fit on a
Index: openacs-4/packages/acs-subsite/www/permissions/one.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/www/permissions/one.tcl,v
diff -u -N -r1.19 -r1.20
--- openacs-4/packages/acs-subsite/www/permissions/one.tcl	26 Apr 2018 08:56:37 -0000	1.19
+++ openacs-4/packages/acs-subsite/www/permissions/one.tcl	9 May 2018 15:33:28 -0000	1.20
@@ -34,7 +34,7 @@
 
 db_multirow acl acl {} {}
 
-set controls {}
+set controls [list]
 set controlsUrl [export_vars -base grant {application_url object_id}]
 lappend controls "[ns_quotehtml [_ acs-subsite.Grant_Permission]]"
 
Index: openacs-4/packages/acs-subsite/www/permissions/perm-include.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/www/permissions/perm-include.tcl,v
diff -u -N -r1.16 -r1.17
--- openacs-4/packages/acs-subsite/www/permissions/perm-include.tcl	26 Apr 2018 08:56:37 -0000	1.16
+++ openacs-4/packages/acs-subsite/www/permissions/perm-include.tcl	9 May 2018 15:33:28 -0000	1.17
@@ -21,7 +21,7 @@
 
 db_1row object_info {}
 
-set elements {}
+set elements [list]
 lappend elements grantee_name { 
     label "[_ acs-subsite.Name]"
     link_url_col name_url
Index: openacs-4/packages/acs-subsite/www/shared/whos-online.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/www/shared/whos-online.tcl,v
diff -u -N -r1.13 -r1.14
--- openacs-4/packages/acs-subsite/www/shared/whos-online.tcl	26 Apr 2018 08:56:37 -0000	1.13
+++ openacs-4/packages/acs-subsite/www/shared/whos-online.tcl	9 May 2018 15:33:28 -0000	1.14
@@ -29,7 +29,7 @@
         }
     }
 
-set users {}
+set users [list]
 
 foreach user_id [whos_online::user_ids] {
     acs_user::get -user_id $user_id -array user
Index: openacs-4/packages/acs-subsite/www/site-map/index.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/www/site-map/index.tcl,v
diff -u -N -r1.11 -r1.12
--- openacs-4/packages/acs-subsite/www/site-map/index.tcl	26 Apr 2018 08:56:37 -0000	1.11
+++ openacs-4/packages/acs-subsite/www/site-map/index.tcl	9 May 2018 15:33:28 -0000	1.12
@@ -128,7 +128,7 @@
     }
 
 multirow create nodes node_id expand_mode expand_url tree_indent name name_url instance instance_url type action_type action_form_part add_folder_url new_app_url unmount_url mount_url rename_url delete_url parameters_url permissions_url extra_form_part view_p
-set open_nodes {}
+set open_nodes [list]
 
 db_foreach nodes_select {} {
     set add_folder_url ""
@@ -191,7 +191,7 @@
     set expand_mode 0
     if {!$root_p && $n_children > 0} {
 	set expand_mode 1
-	set urlvars {}
+	set urlvars [list]
 	foreach n $expand {
 	    if {$n == $node_id} {
 		set expand_mode 2
Index: openacs-4/packages/acs-tcl/lib/page-error.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/lib/page-error.tcl,v
diff -u -N -r1.14 -r1.15
--- openacs-4/packages/acs-tcl/lib/page-error.tcl	25 Apr 2018 19:23:26 -0000	1.14
+++ openacs-4/packages/acs-tcl/lib/page-error.tcl	9 May 2018 15:33:28 -0000	1.15
@@ -110,7 +110,7 @@
 	# add commentaries.  If the bug is closed or fixed we have to
 	# reopen the bug.
         #
-        array set row {}
+        array set row [list]
 	set bug_id $exist_bug
 	
 	if {$bug_number eq ""} {
@@ -256,7 +256,7 @@
 	{entry_id:integer(hidden),optional}
     } -on_submit {
 
-	array set row {}
+	array set row [list]
 	
 	set description [element get_value bug_edit description]
 	set error_desc_html "
Index: openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl,v
diff -u -N -r1.99 -r1.100
--- openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl	8 May 2018 22:37:18 -0000	1.99
+++ openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl	9 May 2018 15:33:28 -0000	1.100
@@ -504,7 +504,7 @@
 
     # Initialize bookkeeping variables.
     if { ![info exists db_state(handles)] } {
-        set db_state(handles) {}
+        set db_state(handles) [list]
     }
     if { ![info exists db_state(n_handles_used)] } {
         set db_state(n_handles_used) 0
@@ -805,7 +805,7 @@
         upvar bind bind
         if { [info exists bind] && [llength $bind] != 0 } {
             if { [llength $bind] == 1 } {
-                set bind_vars {}
+                set bind_vars [list]
                 set len [ns_set size $bind]
                 for {set i 0} {$i < $len} {incr i} {
                     lappend bind_vars [ns_set key $bind $i] \
@@ -862,7 +862,7 @@
 
     @see db_bind_var_subsitution
 } {
-    set quote_indices {}
+    set quote_indices [list]
 
     # Returns a list on the format
     # Example - for sql={'a'a'a'} returns
@@ -1197,7 +1197,7 @@
         return [ns_cache eval $cache_pool $cache_key {
             db_with_handle -dbn $dbn db {
                 set selection [db_exec select $db $full_statement_name $sql]
-                set result {}
+                set result [list]
                 while { [db_getrow $db $selection] } {
                     lappend result [ns_set value $selection 0]
                 }
@@ -1208,7 +1208,7 @@
 
     db_with_handle -dbn $dbn db {
         set selection [db_exec select $db $full_statement_name $sql]
-        set result {}
+        set result [list]
         while { [db_getrow $db $selection] } {
             lappend result [ns_set value $selection 0]
         }
@@ -1251,9 +1251,9 @@
         return [ns_cache eval $cache_pool $cache_key {
             db_with_handle -dbn $dbn db {
                 set selection [db_exec select $db $full_statement_name $sql]
-                set result {}
+                set result [list]
                 while { [db_getrow $db $selection] } {
-                    set this_result {}
+                    set this_result [list]
                     for { set i 0 } { $i < [ns_set size $selection] } { incr i } {
                         lappend this_result  [ns_set value $selection $i]
                     }
@@ -1266,9 +1266,9 @@
 
     db_with_handle -dbn $dbn db {
         set selection [db_exec select $db $full_statement_name $sql]
-        set result {}
+        set result [list]
         while { [db_getrow $db $selection] } {
-            set this_result {}
+            set this_result [list]
             for { set i 0 } { $i < [ns_set size $selection] } { incr i } {
                 lappend this_result  [ns_set value $selection $i]
             }
@@ -1304,7 +1304,7 @@
     set full_statement_name [db_qd_get_fullname $statement_name]
 
     db_with_handle -dbn $dbn db {
-        set result {}
+        set result [list]
         set selection [db_exec select $db $full_statement_name $sql]
 
         while {[db_getrow $db $selection]} {
@@ -1779,7 +1779,7 @@
         set value [ns_cache eval $cache_pool $cache_key {
             db_multirow_helper
 
-            set values {}
+            set values [list]
 
             for { set count 1 } { $count <= $counter } { incr count } {
                 upvar $level_up "$var_name:[expr {$count}]" array_val
@@ -1826,7 +1826,7 @@
 
     
     # Initialize the lines variable to hold a list of order line summaries
-    set lines {}
+    set lines [list]
 
     # Start building the multirow. We add the dynamic column 'lines_pretty', which will
     # contain the pretty summary of the order lines.
@@ -1846,7 +1846,7 @@
             set lines_pretty [join $lines ", "]
 
             # Reset the lines list, so we start from a fresh with the next row
-            set lines {}
+            set lines [list]
         } else {
             # There are yet more order lines to come for this order,
             # continue until we've collected all the order lines
@@ -1909,7 +1909,7 @@
     # Remember which one (if any) is provided:
 
     set lob_argc 0
-    set lob_argv {}
+    set lob_argv [list]
     set command "dml"
     if { [info exists clobs] } {
         set command "clob_dml"
@@ -1940,7 +1940,7 @@
         db_with_handle -dbn $dbn db {
             if { $lob_argc == 1 } {
                 # Bind :1, :2, ..., :n as LOBs (where n = [llength $lob_argv])
-                set bind_vars {}
+                set bind_vars [list]
                 for { set i 1 } { $i <= [llength $lob_argv] } { incr i } {
                     lappend bind_vars $i
                 }
@@ -2064,7 +2064,7 @@
                 set selection [db_exec 0or1row $db $full_statement_name $sql]
             }
 
-            set values {}
+            set values [list]
 
             if { $selection ne "" } {
                 for {set i 0} { $i < [ns_set size $selection] } {incr i} {
@@ -2862,7 +2862,7 @@
         }
     }
 
-    set tables {}
+    set tables [list]
     if { [info exists pattern] } {
         db_foreach -dbn $dbn table_names_with_pattern \
             $sql_table_names_with_pattern {
@@ -2925,7 +2925,7 @@
 
     @change-log yon@arsdigita.com 20000711 changed to return lower case column names
 } {
-    set columns {}
+    set columns [list]
 
     # Works for both Oracle and PostgreSQL:
     db_foreach -dbn $dbn table_column_names {
@@ -2947,7 +2947,7 @@
 
     @author Lars Pind (lars@pinds.com)
 } {
-    set columns {}
+    set columns [list]
 
     # Works for both Oracle and PostgreSQL:
     set n_rows [db_string -dbn $dbn column_exists {
@@ -3338,7 +3338,7 @@
         upvar bind bind
         if { [info exists bind] && [llength $bind] != 0 } {
             if { [llength $bind] == 1 } {
-                set bind_vars {}
+                set bind_vars [list]
                 set len [ns_set size $bind]
                 for {set i 0} {$i < $len} {incr i} {
                     lappend bind_vars [ns_set key $bind $i] \
Index: openacs-4/packages/acs-tcl/tcl/admin-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/admin-procs.tcl,v
diff -u -N -r1.26 -r1.27
--- openacs-4/packages/acs-tcl/tcl/admin-procs.tcl	25 Apr 2018 19:23:26 -0000	1.26
+++ openacs-4/packages/acs-tcl/tcl/admin-procs.tcl	9 May 2018 15:33:28 -0000	1.27
@@ -55,7 +55,7 @@
     Takes an ns_set of key/value pairs and produces a human-readable
     description of the class of users specified.
 } {
-    set clauses {}
+    set clauses [list]
     set pretty_description ""
 
     # turn all the parameters in the ns_set into Tcl vars
@@ -193,7 +193,7 @@
     in the user_state finite state machine. If the nohtml switch
     is set, then a list of lists will be returned (url label).
 } {
-    set user_finite_states {}
+    set user_finite_states [list]
     switch -- $member_state {
         "approved" {
             lappend user_finite_states \
Index: openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl,v
diff -u -N -r1.119 -r1.120
--- openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl	30 Apr 2018 15:34:17 -0000	1.119
+++ openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl	9 May 2018 15:33:28 -0000	1.120
@@ -30,7 +30,7 @@
     ### Scan for all unregistered .info files.
 
     ns_log Notice "apm_scan_packages: Scanning for new unregistered packages..."
-    set new_spec_files {}
+    set new_spec_files [list]
     # Loop through all directories in the /packages directory, searching each for a
     # .info file.
     foreach dir [lsort [glob -nocomplain "$path/*"]] {
@@ -257,10 +257,10 @@
     ##              by packages in the install set.
     ## extra_package_keys - package keys of extra packages to install to satisfy all requirements.
 
-    set extra_package_keys {}
+    set extra_package_keys [list]
 
     set updated_p 1
-    set install_in {}
+    set install_in [list]
     foreach spec_file $spec_files {
         if { [catch {
             array set package [apm_read_package_info_file $spec_file]
@@ -301,8 +301,8 @@
 
         # Inner loop tries to add another package from the install_pend list
         while { $updated_p && [info exists install_pend] && $install_pend ne ""} {
-            set install_in_provides {}
-            set new_install_pend {}
+            set install_in_provides [list]
+            set new_install_pend [list]
             set updated_p 0
             # Generate the list of dependencies currently provided by the install set.
             foreach pkg_info $install_in {
@@ -455,26 +455,26 @@
 
     # 'pending_packages' is an array keyed by package_key with a value of 1 for each package pending installation
     # When dependencies have been met, the entry will be unset
-    array set pending_packages {}
+    array set pending_packages [list]
     foreach package_key $package_keys {
         set pending_packages($package_key) 1
     }
 
     # 'installed_packages' is an array keyed by package_key with a value of 1 for each package
     # whose dependencies have been met and is ready to be installed
-    array set installed_packages {}
+    array set installed_packages [list]
 
     # 'provided' will keep track of what we've provided with the currently installed packages
     # combined with the packages which we're already able to install
     apm_get_installed_provides -array provided
 
     # 'required' will keep track of unsatisfied dependencies
     # keyed by (service-uri) and will contain the largest version number required
-    array set required {}
+    array set required [list]
 
     # 'required_by' will keep track of unsatisfied dependencies
     # keyed by (service-uri) and will contain the largest version number required
-    array set required_by {}
+    array set required_by [list]
 
     # Just to get us started
     set updated_p 1
@@ -621,7 +621,7 @@
     } else {
         set result(status) failed
 
-        array set failed {}
+        array set failed [list]
 
         # There were problems, now be helpful
 
@@ -710,7 +710,7 @@
         return
     }
 
-    set pkg_info_list {}
+    set pkg_info_list [list]
     foreach spec_file [glob -nocomplain "$::acs::rootdir/packages/*/*.info"] {
         # Get package info, and find out if this is a package we should install
         if { [catch {
@@ -1417,7 +1417,7 @@
     Prepare the owners data structure for installation.
 
 } {
-    set owners {}
+    set owners [list]
     for {set i 0} {$i < [llength $owner_names] } {incr i} {
         if { [lindex $owner_names $i] ne "" } {
             lappend owners [list [lindex $owner_names $i] [lindex $owner_uris $i]]
@@ -1714,9 +1714,9 @@
     } else {
         lappend types_to_retrieve "data_model_upgrade"
     }
-    set data_model_list {}
-    set upgrade_file_list {}
-    set ctl_file_list {}
+    set data_model_list [list]
+    set upgrade_file_list [list]
+    set ctl_file_list [list]
     set file_list [apm_get_package_files -include_data_model_files \
                        -file_types $types_to_retrieve \
                        -package_path $package_path \
@@ -1762,7 +1762,7 @@
     @param file_list A list of files and file types of form [list [list "foo.sql" "data_model_upgrade"] ...]
 } {
 
-    set query_file_list {}
+    set query_file_list [list]
 
     foreach file $file_list {
         lassign $file path file_type file_db_type
@@ -1967,7 +1967,7 @@
         error "The length of spec should be dividable by 3"
     }
 
-    array set chunks {}
+    array set chunks [list]
     foreach { elm_from elm_to elm_chunk } $spec {
 
         # Check that
@@ -2074,7 +2074,7 @@
             }
 
             # Build a list of packages to install additionally
-            set version(install) {}
+            set version(install) [list]
             foreach node [xml_node_get_children_by_name $package_node install] {
                 set install [apm_attribute_value $node package]
                 lappend version(install) $install
@@ -2248,7 +2248,7 @@
     # If it is nested we will typically need id's from the parent
     if {!$nested_p} {
         array unset ids
-        array set ids {}
+        array set ids [list]
 
         # set default ids for the main site and core packages
         set ids(ACS_KERNEL) [apm_package_id_from_key acs-kernel]
Index: openacs-4/packages/acs-tcl/tcl/apm-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/apm-procs.tcl,v
diff -u -N -r1.103 -r1.104
--- openacs-4/packages/acs-tcl/tcl/apm-procs.tcl	25 Apr 2018 19:23:26 -0000	1.103
+++ openacs-4/packages/acs-tcl/tcl/apm-procs.tcl	9 May 2018 15:33:29 -0000	1.104
@@ -282,22 +282,22 @@
 } {
 
     array unset ::apm_visited_package_keys
-    set ::apm_package_url_resolution {}
+    set ::apm_package_url_resolution [list]
     apm_package_list_url_resolution $package_key
     nsv_set apm_package_url_resolution $package_key $::apm_package_url_resolution
 
     array unset ::apm_visited_package_keys
-    set ::apm_package_inherit_order {}
+    set ::apm_package_inherit_order [list]
     apm_one_package_inherit_order $package_key
     nsv_set apm_package_inherit_order $package_key $::apm_package_inherit_order
 
     array unset ::apm_visited_package_keys
-    set ::apm_package_load_libraries_order {}
+    set ::apm_package_load_libraries_order [list]
     apm_one_package_load_libraries_dependencies $package_key
     nsv_set apm_package_load_libraries_order $package_key $::apm_package_load_libraries_order
 
     array unset ::apm_visited_package_keys
-    set ::apm_package_descendents {}
+    set ::apm_package_descendents [list]
     apm_one_package_descendents $package_key
     nsv_set apm_package_descendents $package_key $::apm_package_descendents
 
@@ -371,7 +371,7 @@
 
     @author Peter Marklund
 } {
-    set changed_files {}
+    set changed_files [list]
     foreach relative_path $file_list {
         set full_path "$::acs::rootdir/$relative_path"
 
@@ -418,7 +418,7 @@
     ns_log notice "apm_mark_version_for_reload try to get package_key from $version_id"
     set package_key [apm_package_key_from_version_id $version_id]
     ns_log notice "apm_mark_version_for_reload $package_key $version_id"
-    set changed_files {}
+    set changed_files [list]
 
     set file_types [list tcl_procs query_file]
     if { [apm_load_tests_p] } {
@@ -509,7 +509,7 @@
                     to in *all* active interpreters).
 
 } {
-    set file_types {}
+    set file_types [list]
     if { $procs_p } {
         lappend file_types tcl_procs
     }
@@ -528,7 +528,7 @@
     }
 
     # Scan the package directory for files to source.    
-    set files {}    
+    set files [list]    
     foreach package $packages {
 
         set paths [apm_get_package_files -package_key $package -file_types $file_types]
@@ -583,7 +583,7 @@
         set packages [apm_enabled_packages]
     }
 
-    set packages_to_load {}
+    set packages_to_load [list]
     foreach package_key $packages {
         foreach package_to_load [::apm_package_load_libraries_order $package_key] {
             if {$package_to_load ni $packages_to_load} {
@@ -648,7 +648,7 @@
     }
 
     # Scan the package directory for files to source.    
-    set files {}    
+    set files [list]    
     foreach package $packages {
 
         set files [ad_find_all_files $::acs::rootdir/packages/$package]
@@ -697,7 +697,7 @@
     Returns a list of subdirectories of path (including path itself)
 
 } {
-    set dirs {}
+    set dirs [list]
     lappend dirs $path
     foreach subdir [glob -nocomplain -type d [file join $path *]] {
         lappend dirs {*}[apm_subdirs $subdir]
@@ -745,7 +745,7 @@
     if {$errorVarName ne ""} {
         upvar $errorVarName errors
     } else {
-        array set errors {}
+        array set errors [list]
     }
 
     # Determine the current reload level in this interpreter by calling
@@ -758,7 +758,7 @@
 
     # Check watched files, adding them to files_to_reload if they have
     # changed.
-    set files_to_reload {}
+    set files_to_reload [list]
     foreach file [nsv_array names apm_reload_watch] {
         set path "$::acs::rootdir/$file"
         ns_log Debug "APM: File being watched: $path"
@@ -783,7 +783,7 @@
 
     # Keep track of which files we've reloaded in this loop so we never
     # reload the same one twice.
-    array set reloaded_files {}
+    array set reloaded_files [list]
     while { $reload_level < [nsv_get apm_properties reload_level] } {
         incr reload_level
         set changed_reload_level_p 1
@@ -862,7 +862,7 @@
     @see db_known_database_types
     @see apm_package_supports_rdbms_p
 } {
-    set supported_databases_list {}
+    set supported_databases_list [list]
     foreach db_type_info [db_known_database_types] {
         set db_type [lindex $db_type_info 0]
         if { [apm_package_supports_rdbms_p -package_key $package_key] } {
@@ -1236,7 +1236,7 @@
 } {
     
     if {$mounted_p} {
-        set package_ids {}
+        set package_ids [list]
         db_foreach apm_package_ids_from_key {
             select package_id from apm_packages where package_key = :package_key
         } {
@@ -1497,7 +1497,7 @@
 
     set supported_types [apm_supported_callback_types]
 
-    set unused_types {}
+    set unused_types [list]
     foreach supported_type $supported_types {
         if {$supported_type ni $used_callback_types} {
             lappend unused_types $supported_type
Index: openacs-4/packages/acs-tcl/tcl/application-data-link-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/application-data-link-procs.tcl,v
diff -u -N -r1.16 -r1.17
--- openacs-4/packages/acs-tcl/tcl/application-data-link-procs.tcl	25 Apr 2018 19:23:26 -0000	1.16
+++ openacs-4/packages/acs-tcl/tcl/application-data-link-procs.tcl	9 May 2018 15:33:29 -0000	1.17
@@ -294,7 +294,7 @@
     @creation-date 2006-08-31
 
 } {
-    set refs {}
+    set refs [list]
     set http_url [string trimright [ad_url] /]/
     set https_url [string map {http https} $http_url]
     set re "(?:\")(?:$http_url|$https_url|/)(?:o|image|file)/(\\d{1,8})"
@@ -334,7 +334,7 @@
     if {![llength $link_object_ids]} {
 	set link_object_ids [application_data_link::scan_for_links -text $text]
     }
-    set delete_ids {}
+    set delete_ids [list]
     foreach old_link $old_links {
 	if {$old_link ni $link_object_ids} {
 	    lappend delete_ids $old_link
Index: openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl,v
diff -u -N -r1.69 -r1.70
--- openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl	25 Apr 2018 19:23:26 -0000	1.69
+++ openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl	9 May 2018 15:33:29 -0000	1.70
@@ -470,7 +470,7 @@
 
     @author Lars Pind (lars@collaboraid.biz)
 } {
-    set cols {}
+    set cols [list]
     foreach var { authority_id username screen_name password_question password_answer email_verified_p } {
         if { [info exists $var] } {
             lappend cols "$var = :$var"
@@ -559,7 +559,7 @@
 
     @author Lars Pind (lars@collaboraid.biz)
 } {
-    set cols {}
+    set cols [list]
     foreach var { email url } {
         if { [info exists $var] } {
             lappend cols "$var = :$var"
Index: openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/defs-procs.tcl,v
diff -u -N -r1.72 -r1.73
--- openacs-4/packages/acs-tcl/tcl/defs-procs.tcl	25 Apr 2018 19:23:26 -0000	1.72
+++ openacs-4/packages/acs-tcl/tcl/defs-procs.tcl	9 May 2018 15:33:29 -0000	1.73
@@ -358,7 +358,7 @@
     @author Unknown
     @author Roberto Mello
 } {
-    set lines {}
+    set lines [list]
     if { $line2 eq "" } {
 	lappend lines $line1
     } elseif { $line1 eq "" } {
Index: openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl,v
diff -u -N -r1.17 -r1.18
--- openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl	30 Apr 2018 09:14:23 -0000	1.17
+++ openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl	9 May 2018 15:33:29 -0000	1.18
@@ -228,7 +228,7 @@
     #
     ####################
 
-    array set export {}
+    array set export [list]
 
     set override_p 0
     foreach argument { include override } {
@@ -283,13 +283,13 @@
     ####################
     
     if { !$form_p } {
-        set export_list {}
+        set export_list [list]
         foreach varname [array names export] {
             lappend export_list "[ns_urlencode $varname]=[ns_urlencode $export($varname)]"
         }
         return [join $export_list &]
     } else {
-        set export_list {}
+        set export_list [list]
         foreach varname [array names export] {
             lappend export_list ""
@@ -815,7 +815,7 @@
 $page_title
 
 "
-    array set attrs {}
+    array set attrs [list]
     set attrs(bgcolor) [parameter::get -package_id [ad_acs_kernel_id] -parameter bgcolor -default "white"]
     set attrs(text)    [parameter::get -package_id [ad_acs_kernel_id] -parameter textcolor -default "black"]
 
@@ -1773,8 +1773,8 @@
     
     # build the map of currently selected columns 
     set full_column [split $sort_spec ","]
-    set sel_columns {}
-    set direction {}
+    set sel_columns [list]
+    set direction [list]
     foreach col $full_column {
         regexp {([^*,]+)([*])?} $col match coln dirn
         if {$dirn eq "*"} {
@@ -2153,7 +2153,7 @@
 ad_proc -deprecated set_intersection { u v } {
     

Returns the intersection of sets $u and $v.

} { - set result {} + set result [list] foreach ue $u { if { [set_member? $v $ue] } { @@ -2171,7 +2171,7 @@ to that intersection, and also returns that intersection.

} { upvar $u-name u - set result {} + set result [list] foreach ue $u { if { [set_member? $v $ue] } { @@ -2187,7 +2187,7 @@

Returns the difference of sets $u and $v. (i.e. The set of all members of u that aren't also members of $v.)

} { - set result {} + set result [list] foreach ue $u { if { ![set_member? $v $ue] } { @@ -2205,7 +2205,7 @@ to that difference, and also returns that difference.

} { upvar $u-name u - set result {} + set result [list] foreach ue $u { if { ![set_member? $v $ue] } { @@ -2663,7 +2663,7 @@ } - set variables {} + set variables [list] switch -- $mode { array { set variables $formvars Index: openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl,v diff -u -N -r1.74 -r1.75 --- openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl 25 Apr 2018 19:23:26 -0000 1.74 +++ openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl 9 May 2018 15:33:29 -0000 1.75 @@ -582,7 +582,7 @@ global af_element_names if { !$extend_p } { - set af_element_names($form_name) {} + set af_element_names($form_name) [list] } global af_parts @@ -630,8 +630,8 @@ # Track element names and their parameters locally as we'll generate those in this form # or extend block on the fly - set element_names {} - array set af_element_parameters {} + set element_names [list] + array set af_element_parameters [list] if { [info exists form] } { @@ -654,11 +654,11 @@ lappend af_element_names($form_name) $element_name set af_extra_args($element_name) [lrange $element 1 end] set pre_flag_list [split [string tolower $flags] ,] - set af_flag_list(${form_name}__$element_name) {} + set af_flag_list(${form_name}__$element_name) [list] # find parameterized flags. We only allow one parameter. foreach flag $pre_flag_list { - set af_element_parameters($element_name:$flag) {} + set af_element_parameters($element_name:$flag) [list] set left_paren [string first "(" $flag] if { $left_paren != -1 } { if { [string index $flag end] ne ")" } { @@ -683,7 +683,7 @@ global af_validate_elements if { !$extend_p } { - set af_validate_elements($form_name) {} + set af_validate_elements($form_name) [list] } if { [info exists validate] } { @@ -1214,7 +1214,7 @@ # Pass the form variables to the confirm template, applying the to_html filter if present - set args {} + set args [list] foreach element_name $af_element_names($form_name) { if { [llength $element_name] == 1 } { if { [info exists af_to_html(${form_name}__$element_name)] } { Index: openacs-4/packages/acs-tcl/tcl/html-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/html-procs.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/acs-tcl/tcl/html-procs.tcl 25 Apr 2018 19:23:26 -0000 1.4 +++ openacs-4/packages/acs-tcl/tcl/html-procs.tcl 9 May 2018 15:33:29 -0000 1.5 @@ -38,19 +38,19 @@ dom parse -html -keepEmpties $html doc set root [$doc documentElement] - set forms {} + set forms [list] # Get every form... foreach f [$root selectNodes {//form}] { set form [list "attributes" [util::get_node_attributes -node $f]] - set fields {} + set fields [list] # ...every input tag foreach input [$f selectNodes {//input}] { lappend fields [list tag "input" attributes [util::get_node_attributes -node $input]] } # ...every select tag with its options foreach select [$f selectNodes {//select}] { set field [list tag "select" attributes [util::get_node_attributes -node $select]] - set options {} + set options [list] foreach option [$f selectNodes {option}] { lappend options [list attributes [$option attributes] value [$option nodeValue]] } @@ -148,7 +148,7 @@ } # Now vars must be translated in export_vars form - set vars {} + set vars [list] foreach {name value} [array get v] { # Multiple values must be specified # with the :multiple modifier Index: openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl,v diff -u -N -r1.13 -r1.14 --- openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl 25 Apr 2018 19:23:26 -0000 1.13 +++ openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl 9 May 2018 15:33:29 -0000 1.14 @@ -42,7 +42,7 @@ if {$headers eq ""} { set headers [ns_set create headers] } - set cookies {} + set cookies [list] foreach {name value} $resp_headers { # get only set-cookie headers, ignoring case set name [string tolower $name] @@ -258,8 +258,8 @@ } { Obtains implemented apis for http communication } { - set http {} - set https {} + set http [list] + set https [list] if {[util::which curl] ne ""} { lappend http "curl" lappend https "curl" @@ -1009,7 +1009,7 @@ # set this_proc ::util::http::request - set urlvars {} + set urlvars [list] # ...retrieve redirect location variables... set locvars [lindex [split $location ?] 1] Index: openacs-4/packages/acs-tcl/tcl/install-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/install-procs.tcl,v diff -u -N -r1.33 -r1.34 --- openacs-4/packages/acs-tcl/tcl/install-procs.tcl 25 Apr 2018 19:23:26 -0000 1.33 +++ openacs-4/packages/acs-tcl/tcl/install-procs.tcl 9 May 2018 15:33:29 -0000 1.34 @@ -110,7 +110,7 @@ set context_id [apm_attribute_value -default "" $node context-id] set security_inherit_p [apm_attribute_value -default "t" $node security-inherit-p] - set out {} + set out [list] # Remove double slashes regsub -all {//} $mount_point "/" mount_point @@ -194,7 +194,7 @@ set package_key [apm_attribute_value -default "" $node package-key] set mount_point [apm_attribute_value -default "" $node mount-point] - set out {} + set out [list] # Remove double slashes regsub -all {//} $mount_point "/" mount_point Index: openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl,v diff -u -N -r1.39 -r1.40 --- openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl 25 Apr 2018 19:23:26 -0000 1.39 +++ openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl 9 May 2018 15:33:29 -0000 1.40 @@ -60,7 +60,7 @@ @author Peter Marklund } { - set context {} + set context [list] while { $node_id ne "" } { array set node [site_node::get -node_id $node_id] @@ -234,7 +234,7 @@ } { set count 0 - set return_list {} + set return_list [list] foreach value $values { if { $default eq $value } { @@ -274,7 +274,7 @@ # directories that should not receive links to move up one level proc ad_no_uplevel_patterns {} { - set regexp_patterns {} + set regexp_patterns [list] lappend regexp_patterns "*/pvt/home.tcl" # Tcl files in the root directory lappend regexp_patterns "^/\[^/\]*\.tcl\$" Index: openacs-4/packages/acs-tcl/tcl/request-processor-init.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/request-processor-init.tcl,v diff -u -N -r1.20 -r1.21 --- openacs-4/packages/acs-tcl/tcl/request-processor-init.tcl 25 Apr 2018 19:23:26 -0000 1.20 +++ openacs-4/packages/acs-tcl/tcl/request-processor-init.tcl 9 May 2018 15:33:29 -0000 1.21 @@ -116,7 +116,7 @@ if {[nsv_exists rp_filters .]} { set filters [nsv_get rp_filters .] } else { - set filters {} + set filters [list] } # This lsort is what makes the priority stuff work. It guarantees # that filters are registered in order of priority. AOLServer will @@ -159,7 +159,7 @@ if {[nsv_exists rp_registered_procs .]} { set procs [nsv_get rp_registered_procs .] } else { - set procs {} + set procs [list] } set proc_index 0 Index: openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl,v diff -u -N -r1.135 -r1.136 --- openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl 25 Apr 2018 19:23:26 -0000 1.135 +++ openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl 9 May 2018 15:33:29 -0000 1.136 @@ -863,7 +863,7 @@ ds_add conn error $message - set params {} + set params [list] #Serve the stacktrace set params [list [list stacktrace $message] \ @@ -913,7 +913,7 @@ } set components [split $path "/"] - set prefixes {} + set prefixes [list] for {set i [expr {[llength $components] -1}]} {$i > 0} {incr i -1} { lappend prefixes "[join [lrange $components 0 $i] /]/" lappend prefixes [join [lrange $components 0 $i] /] @@ -1675,9 +1675,9 @@ if { [apm_first_time_loading_p] } { # Initialize nsv_sets - nsv_array set rp_filters {} - nsv_array set rp_registered_procs {} - nsv_array set rp_extension_handlers {} + nsv_array set rp_filters [list] + nsv_array set rp_registered_procs [list] + nsv_array set rp_extension_handlers [list] # The following stuff is in a -procs.tcl file rather than a # -init.tcl file since we want it done really early in the startup Index: openacs-4/packages/acs-tcl/tcl/security-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/security-procs.tcl,v diff -u -N -r1.92 -r1.93 --- openacs-4/packages/acs-tcl/tcl/security-procs.tcl 2 May 2018 07:19:26 -0000 1.92 +++ openacs-4/packages/acs-tcl/tcl/security-procs.tcl 9 May 2018 15:33:29 -0000 1.93 @@ -1326,7 +1326,7 @@ # we assume sample size of 10%. set num_tokens [expr {$num_tokens * 10}] set counter 0 - set list_of_tokens {} + set list_of_tokens [list] # the best thing to use here would be an array_dml, except # that an array_dml makes it hard to use sysdate and sequences. @@ -1941,7 +1941,7 @@ @return insecure location and secure location followed possibly by alternate location(s) as a list. } { - set locations {} + set locations [list] set portless_locations {} # # Get Information from configured servers Index: openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl,v diff -u -N -r1.106 -r1.107 --- openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl 25 Apr 2018 19:23:26 -0000 1.106 +++ openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl 9 May 2018 15:33:29 -0000 1.107 @@ -448,7 +448,7 @@ set query_name select_site_node } - set cur_obj_ids {} + set cur_obj_ids [list] db_foreach $query_name {} { if {$parent_id eq ""} { # url of root node @@ -625,9 +625,9 @@ Return a list of site node info associated with the given object_id. The nodes will be ordered descendingly by url (children before their parents). } { - set node_id_list {} + set node_id_list [list] - set url_list {} + set url_list [list] foreach url [get_url_from_object_id -object_id $object_id] { lappend node_id_list [get -url $url] } @@ -726,7 +726,7 @@ } { @return the ancestors of this node } { - set result {} + set result [list] set array_result_p [string equal $element ""] while {$node_id ne "" } { @@ -803,7 +803,7 @@ set node_url [site_node::get_url -node_id $node_id] if { !$all_p } { - set child_urls {} + set child_urls [list] set s [string length "$node_url"] # find all child_urls who have only one path element below node_id # by clipping the node url and last character and seeing if there @@ -819,7 +819,7 @@ if { [llength $filters] > 0 } { - set return_val {} + set return_val [list] foreach child_url $child_urls { array unset site_node if {![catch {array set site_node [nsv_get site_nodes $child_url]}]} { @@ -847,7 +847,7 @@ } } } elseif { $element ne "" } { - set return_val {} + set return_val [list] foreach child_url $child_urls { array unset site_node if {![catch {array set site_node [nsv_get site_nodes $child_url]}]} { @@ -1357,7 +1357,7 @@ } if { [llength $filters] > 0 } { - set return_val {} + set return_val [list] foreach child_url $child_urls { array unset site_node if {![catch {array set site_node [:get -url $child_url]}]} { @@ -1379,7 +1379,7 @@ } } } elseif { $element ne "" } { - set return_val {} + set return_val [list] foreach child_url $child_urls { array unset site_node if {![catch {array set site_node [:get -url $child_url]}]} { Index: openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl,v diff -u -N -r1.50 -r1.51 --- openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl 25 Apr 2018 19:23:26 -0000 1.50 +++ openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl 9 May 2018 15:33:29 -0000 1.51 @@ -63,8 +63,8 @@ @author Lars Pind (lars@pinds.com) @creation-date 24 July 2000 } { - set ::ad_page_contract_complaints {} - set ::ad_page_contract_errorkeys {} + set ::ad_page_contract_complaints [list] + set ::ad_page_contract_errorkeys [list] set ::ad_page_contract_context $context } @@ -136,7 +136,7 @@ @author Lars Pind (lars@pinds.com) @creation-date 25 July 2000 } { - array set ::ad_page_contract_error_string {} + array set ::ad_page_contract_error_string [list] foreach { errorkeys text } $errorstrings { foreach errorkey $errorkeys { @@ -541,7 +541,7 @@ if { [llength $args] == 0 } { - set query {} + set query [list] } else { set valid_args { validate errors return_errors properties } ;# add type later @@ -553,7 +553,7 @@ } else { # otherwise, accept a -query argument lappend valid_args query - set query {} + set query [list] } ad_arg_parser $valid_args $args @@ -599,16 +599,16 @@ # array apc_flags($name): contains a list of the flags that apply # - set apc_formals {} - array set apc_formal {} - array set apc_default_value {} + set apc_formals [list] + array set apc_formal [list] + array set apc_default_value [list] - array set apc_internal_filter {} - array set apc_filters {} - array set apc_post_filters {} - array set apc_filter_parameters {} + array set apc_internal_filter [list] + array set apc_filters [list] + array set apc_post_filters [list] + array set apc_filter_parameters [list] - array set apc_flags {} + array set apc_flags [list] foreach element $query { set element_len [llength $element] @@ -631,7 +631,7 @@ } set pre_flag_list [split [string tolower $flags] ,] - set flag_list {} + set flag_list [list] # find parameterized flags foreach flag $pre_flag_list { @@ -664,7 +664,7 @@ # Sort the flag list according to priority # - set flag_list_for_sorting {} + set flag_list_for_sorting [list] foreach flag $flag_list { lappend flag_list_for_sorting [list [ad_page_contract_filter_priority $flag] $flag] } @@ -676,9 +676,9 @@ # apc_flags($name) is for documentation only. # - set apc_flags($name) {} - set apc_filters($name) {} - set apc_post_filters($name) {} + set apc_flags($name) [list] + set apc_filters($name) [list] + set apc_post_filters($name) [list] foreach flag_entry $flag_list_sorted { set flag [lindex $flag_entry 1] @@ -769,10 +769,10 @@ # for the validation block. Once the block has executed, this entry # self destructs, i.e. unset apc_validation_blocks($name) - array set apc_validation_blocks {} + array set apc_validation_blocks [list] if { ![info exists validate] } { - set validate {} + set validate [list] } set validate_len [llength $validate] @@ -812,7 +812,7 @@ } incr i } else { - set requires {} + set requires [list] } set code [lindex $validate $i] set apc_validation_blocks($name) [list $requires $code] @@ -846,7 +846,7 @@ # This is the array in which we store the signature variables as we come across them # Whenever we see a variable named foo:sig, we record it here as apc_signatures(foo). - array set apc_signatures {} + array set apc_signatures [list] for { set form_counter_i 0 } { $form_counter_i < $form_size } { incr form_counter_i } { Index: openacs-4/packages/acs-tcl/tcl/util-diff-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/util-diff-procs.tcl,v diff -u -N -r1.6 -r1.7 --- openacs-4/packages/acs-tcl/tcl/util-diff-procs.tcl 25 Apr 2018 19:23:26 -0000 1.6 +++ openacs-4/packages/acs-tcl/tcl/util-diff-procs.tcl 9 May 2018 15:33:29 -0000 1.7 @@ -115,7 +115,7 @@ package require struct::list set frag $old - set old_list {} + set old_list [list] while {$frag ne ""} { if {![regexp "(\[^<]*)(<(/?)(\[^ \r\n\t>]+)(\[^>]*)>)?(.*)" $frag match pretag fulltag close tag tagbody frag]} { # we should never get here, the regexp should match anything @@ -126,7 +126,7 @@ } if {$pretag ne ""} { set pretag [string map {\n " "} $pretag] - set pretag2 {} + set pretag2 [list] foreach element [split $pretag " "] { if {[string trim $element] ne ""} { lappend pretag2 [string trim $element] @@ -142,7 +142,7 @@ } set frag $new - set new_list {} + set new_list [list] while {$frag ne ""} { if {![regexp "(\[^<]*)(<(/?)(\[^ \r\n\t>]+)(\[^>]*)>)?(.*)" $frag match pretag fulltag close tag tagbody frag]} { # we should never get here, the regexp should match anything @@ -152,7 +152,7 @@ } if {$pretag ne ""} { set pretag [string map {\n " "} $pretag] - set pretag2 {} + set pretag2 [list] foreach element [split $pretag " "] { if {[string trim $element] ne ""} { lappend pretag2 [string trim $element] Index: openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl,v diff -u -N -r1.155 -r1.156 --- openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl 25 Apr 2018 19:23:26 -0000 1.155 +++ openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl 9 May 2018 15:33:29 -0000 1.156 @@ -70,7 +70,7 @@ # To avoid having the full path of the file included in the archive, # we must first cd to the source directory. zip doesn't have an option # to do this without building a little script... - set zip_cmd {} + set zip_cmd [list] lappend zip_cmd "cd $in_path" lappend zip_cmd "${zip} -r \"${destination}\" \"${filename}\"" set zip_cmd [join $zip_cmd " && "] @@ -681,7 +681,7 @@ # 'noprocessing_vars' is yet another container of variables, # only this one doesn't have the values subst'ed # and we don't try to find :multiple and :array flags in the namespec - set noprocessing_vars {} + set noprocessing_vars [list] if { $entire_form_p } { set the_form [ns_getform] @@ -705,13 +705,13 @@ # 2. if they're in vars, but not in exclude or override, use those # There'll always be an entry here if the variable is to be exported - array set exp_precedence_type {} + array set exp_precedence_type [list] # This contains entries of the form exp_flag(name:flag) e.g., exp_flag(foo:multiple) - array set exp_flag {} + array set exp_flag [list] # This contains the value if provided, otherwise we'll pull it out of the caller's environment - array set exp_value {} + array set exp_value [list] foreach precedence_type { override exclude vars noprocessing_vars } { foreach var_spec [set $precedence_type] { @@ -767,7 +767,7 @@ if { [array exists upvar_variable] } { if { $no_empty_p } { # If the no_empty_p flag is set, remove empty string values first - set exp_value($name) {} + set exp_value($name) [list] foreach { key value } [array get upvar_variable] { if { $value ne "" } { lappend exp_value($name) $key $value @@ -788,7 +788,7 @@ # no_empty_p flag set, remove empty strings if { [info exists exp_flag($name:multiple)] } { # This is a list, remove empty entries - set exp_value($name) {} + set exp_value($name) [list] foreach elm $upvar_variable { if { $elm ne "" } { lappend exp_value($name) $elm @@ -871,7 +871,7 @@ set export_string {} if { $url_p } { - set export_list {} + set export_list [list] for { set i 0 } { $i < $export_size } { incr i } { lappend export_list [ad_urlencode_query [ns_set key $export_set $i]]=[ad_urlencode_query [ns_set value $export_set $i]] } @@ -985,7 +985,7 @@ set setid [ns_getform] } - set return_list {} + set return_list [list] if { $setid ne "" } { set set_size [ns_set size $setid] set set_counter_i 0 @@ -1022,7 +1022,7 @@ @see export_vars } { - set params {} + set params [list] set the_form [ns_getform] if { $the_form ne "" } { for {set i 0} {$i<[ns_set size $the_form]} {incr i} { @@ -1422,7 +1422,7 @@ nsv_set ad_procs . $procs ns_mutex unlock [nsv_get ad_procs mutex] - set my_args {} + set my_args [list] if { $thread == "t" } { lappend my_args "-thread" } @@ -2219,7 +2219,7 @@ return [list] } - set sorted_list1 {} + set sorted_list1 [list] foreach elm [lsort $list1] { if { [llength $sorted_list1] == 0 || [lindex $sorted_list1 end] ne $elm } { lappend sorted_list1 $elm @@ -2230,7 +2230,7 @@ set len1 [llength $sorted_list1] set len2 [llength $sorted_list2] - set missing_elms {} + set missing_elms [list] # Loop over list1 and list2 in sort order, comparing the elements @@ -2326,7 +2326,7 @@ @author Lars Pind (lars@pinds.com) } { - set keys {} + set keys [list] set size [ns_set size $set_id] for { set i 0 } { $i < $size } { incr i } { set key [ns_set key $set_id $i] @@ -2671,7 +2671,7 @@ @return An array of equivalent keys and values as the ns_set specified. } { - set result {} + set result [list] for {set i 0} {$i < [ns_set size $set]} {incr i} { lappend result [ns_set key $set $i] @@ -2733,7 +2733,7 @@ @author Ola Hansson (ola@polyxena.net) @creation-date September 27, 2002 } { - set result {} + set result [list] foreach ns_set $list_of_ns_sets { lappend result [util_ns_set_to_list -set $ns_set] @@ -3344,7 +3344,7 @@ Returns a random permutation of the list. } { set len [llength $list] - set result {} + set result [list] while { [llength $list] > 0 } { set index [randomRange [expr {[llength $list] - 1}]] lappend result [lindex $list $index] @@ -3594,11 +3594,11 @@ @return list of lists (filename and full_path) of all files found. } { # Use the examined_files array to track files that we've examined. - array set examined_files {} + array set examined_files [list] # A list of files that we will return (in the order in which we # examined them). - set files {} + set files [list] # A list of files that we still need to examine. set files_to_examine [list $path] @@ -3608,7 +3608,7 @@ # add contained files to $new_files_to_examine (which will become # $files_to_examine in the next iteration). while { [incr max_depth -1] > -2 && [llength $files_to_examine] != 0 } { - set new_files_to_examine {} + set new_files_to_examine [list] foreach file $files_to_examine { # Only examine the file if we haven't already. (This is just a safeguard # in case, e.g., Tcl decides to play funny games with symbolic links so Index: openacs-4/packages/acs-tcl/tcl/whos-online-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/whos-online-procs.tcl,v diff -u -N -r1.6 -r1.7 --- openacs-4/packages/acs-tcl/tcl/whos-online-procs.tcl 25 Apr 2018 19:23:26 -0000 1.6 +++ openacs-4/packages/acs-tcl/tcl/whos-online-procs.tcl 9 May 2018 15:33:29 -0000 1.7 @@ -32,7 +32,7 @@ @author Bjoern Kiesbye } { array set last_hit [nsv_array get last_hit] - set onliners_out {} + set onliners_out [list] set interval 1 set oldtime [expr {[ns_time] - [interval]}] @@ -135,7 +135,7 @@ @author Bjoern Kiesbye } { array set last_hit [nsv_array get last_hit] - set onliners {} + set onliners [list] set oldtime [expr {[ns_time] - [interval]}] for { set search [array startsearch last_hit] } { [array anymore last_hit $search] } {} { Index: openacs-4/packages/acs-tcl/tcl/test/file-test-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/test/file-test-procs.tcl,v diff -u -N -r1.12 -r1.13 --- openacs-4/packages/acs-tcl/tcl/test/file-test-procs.tcl 25 Apr 2018 19:23:26 -0000 1.12 +++ openacs-4/packages/acs-tcl/tcl/test/file-test-procs.tcl 9 May 2018 15:33:29 -0000 1.13 @@ -138,7 +138,7 @@ # build list of files for each db type, sort, check strict ordering. foreach db_type {postgresql oracle} { - set upgrades {} + set upgrades [list] foreach file $files { # DRB: Ignore old upgrade scripts that aren't in the proper place. We # still have old ACS 3 -> ACS 4 upgrade scripts lying around, and Index: openacs-4/packages/acs-templating/tcl/date-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/date-procs.tcl,v diff -u -N -r1.56 -r1.57 --- openacs-4/packages/acs-templating/tcl/date-procs.tcl 25 Apr 2018 19:23:26 -0000 1.56 +++ openacs-4/packages/acs-templating/tcl/date-procs.tcl 9 May 2018 15:33:29 -0000 1.57 @@ -143,7 +143,7 @@ } { set now [clock format [clock seconds] -format "%Y %m %d"] - set today {} + set today [list] foreach v $now { # trim leading zeros to avoid octal problem @@ -157,7 +157,7 @@ Create a new Date object for the current date and time } { set now [clock format [clock seconds] -format "%Y %m %d %H %M %S"] - set today {} + set today [list] foreach v $now { lappend today [util::trim_leading_zeros $v] @@ -340,7 +340,7 @@ # Return a date in format "YYYY MM DD HH24 MI SS" # For use with karl's non-working form builder API set clipped_date [lrange $date 0 5] - set ret {} + set ret [list] set pad "0000" foreach fragment $clipped_date { lappend ret "[string range $pad [string length $fragment] end]$fragment" @@ -351,7 +351,7 @@ linear_date_no_time { # Return a date in format "YYYY MM DD" set clipped_date [lrange $date 0 2] - set ret {} + set ret [list] set pad "0000" foreach fragment $clipped_date { lappend ret "[string range $pad [string length $fragment] end]$fragment" @@ -367,7 +367,7 @@ # not a terribly efficient thing to do. set clipped_date [lrange $date 0 2] - set date_list {} + set date_list [list] set pad "0000" foreach fragment $clipped_date { lappend date_list "[string range $pad [string length $fragment] end]$fragment" @@ -489,7 +489,7 @@ } clock { set old_date [clock format $value -format "%Y %m %d %H %M %S"] - set new_date {} + set new_date [list] foreach field $old_date { lappend new_date [util::trim_leading_zeros $field] } @@ -498,7 +498,7 @@ } sql_date { set old_format [lindex $date 6] - set new_date {} + set new_date [list] foreach fragment $value { lappend new_date [util::trim_leading_zeros $fragment] } @@ -568,7 +568,7 @@ @author Walter McGinnis (wtem@olywa.net) @creation-date 2002-01-06 } { - set now {} + set now [list] foreach v [clock format [clock seconds] -format "%Y %m %d %H %M %S"] { lappend now [util::trim_leading_zeros $v] } @@ -603,7 +603,7 @@ @author Walter McGinnis (wtem@olywa.net) @creation-date 2002-01-06 } { - set now {} + set now [list] foreach v [clock format [clock seconds] -format "%Y %m %d %H %M %S"] { lappend now [util::trim_leading_zeros $v] } @@ -727,7 +727,7 @@ unpack $date - set error_msg {} + set error_msg [list] foreach {field exp} { year "YYYY|YY" month "MM|MON|MONTH" day "DD" hours "HH24|HH12" minutes "MI" seconds "SS" } { @@ -1036,7 +1036,7 @@ # of tokens set format_string $element(format) - set tokens {} + set tokens [list] if {[info exists attributes(id)]} { set id_attr_name $attributes(id) Index: openacs-4/packages/acs-templating/tcl/doc-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/doc-procs.tcl,v diff -u -N -r1.10 -r1.11 --- openacs-4/packages/acs-templating/tcl/doc-procs.tcl 25 Apr 2018 19:23:26 -0000 1.10 +++ openacs-4/packages/acs-templating/tcl/doc-procs.tcl 9 May 2018 15:33:29 -0000 1.11 @@ -38,7 +38,7 @@ # regular expression for match directive comments set direxp {^\#[\s]*@([a-zA-Z0-9\-_]+)[\s]+(.*)$} - set directives {} + set directives [list] foreach line $lines { Index: openacs-4/packages/acs-templating/tcl/doc-tcl-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/doc-tcl-procs.tcl,v diff -u -N -r1.16 -r1.17 --- openacs-4/packages/acs-templating/tcl/doc-tcl-procs.tcl 8 May 2018 21:16:21 -0000 1.16 +++ openacs-4/packages/acs-templating/tcl/doc-tcl-procs.tcl 9 May 2018 15:33:29 -0000 1.17 @@ -90,7 +90,7 @@ @see doc::util::text_divider } { - set indices_list {} + set indices_list [list] set last_index -1 while { [regexp -indices $marker $text marker_idx] } { @@ -119,7 +119,7 @@ upvar $text_ref text set indices_list [doc::util::find_marker_indices $text $marker] - set result_list {} + set result_list [list] # first check for no markers present if { $indices_list eq "end" } { @@ -289,9 +289,9 @@ # if we wanted to include the source text for the procedure as well: # set proc_info [list [list proc_name $proc_name] [list source $source_text]] - set proc_param {} - set proc_option {} - set proc_see {} + set proc_param [list] + set proc_option [list] + set proc_see [list] set directives [lsort -index 0 [template::parse_directives $comment_text]] @@ -566,9 +566,9 @@ # with respect to namespaces in the same order as the list result upvar namespace_list namespace_list - set namespace_list {} + set namespace_list [list] - set result {} + set result [list] foreach dir $dir_list { Index: openacs-4/packages/acs-templating/tcl/element-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/element-procs.tcl,v diff -u -N -r1.35 -r1.36 --- openacs-4/packages/acs-templating/tcl/element-procs.tcl 25 Apr 2018 19:23:26 -0000 1.35 +++ openacs-4/packages/acs-templating/tcl/element-procs.tcl 9 May 2018 15:33:29 -0000 1.36 @@ -431,7 +431,7 @@ # if the element is optional and the value is an empty string, then ignore if { $is_optional && [lindex $values 0] eq "" } { - set values {} + set values [list] # also clobber the value(s) for a submit widget if {$element(widget) eq "submit"} { @@ -487,10 +487,10 @@ } else { - set element(validate) {} + set element(validate) [list] } - set v_errors {} + set v_errors [list] foreach value $values { @@ -605,7 +605,7 @@ set values [ns_querygetall $element(id)] # QUIRK: ns_querygetall returns a single-element list {{}} for no values - if { [string equal $values {{}}] } { set values {} } + if { [string equal $values {{}}] } { set values [list] } } else { set values [template::data::transform::$datatype element] @@ -758,7 +758,7 @@ # breaks eg ad_form. # if { [string equal opts(value) {}] } { - set opts(values) {} + set opts(values) [list] } else { set opts(values) [list $opts(value)] } Index: openacs-4/packages/acs-templating/tcl/form-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/form-procs.tcl,v diff -u -N -r1.50 -r1.51 --- openacs-4/packages/acs-templating/tcl/form-procs.tcl 1 May 2018 09:34:09 -0000 1.50 +++ openacs-4/packages/acs-templating/tcl/form-procs.tcl 9 May 2018 15:33:29 -0000 1.51 @@ -141,7 +141,7 @@ template::util::get_opts $args - set elements {} + set elements [list] # check whether this form is being submitted upvar #$level $id:submission submission @@ -785,7 +785,7 @@ set elements $properties(element_names) if { $no_api_p } { - set elements_no_api {} + set elements_no_api [list] foreach element $elements { if { ![regexp {^__} $element] } { lappend elements_no_api $element @@ -830,7 +830,7 @@ get_reference set exp [join $args "|"] - set values {} + set values [list] foreach element_name $properties(element_names) { if { [regexp $exp $element_name match] } { Index: openacs-4/packages/acs-templating/tcl/list-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/list-procs.tcl,v diff -u -N -r1.82 -r1.83 --- openacs-4/packages/acs-templating/tcl/list-procs.tcl 8 May 2018 11:21:49 -0000 1.82 +++ openacs-4/packages/acs-templating/tcl/list-procs.tcl 9 May 2018 15:33:29 -0000 1.83 @@ -755,7 +755,7 @@ if { [llength $list_properties(from_clauses)] == 0 } { return {} } - set trimmed_from_clauses {} + set trimmed_from_clauses [list] set result {} @@ -916,9 +916,9 @@ set __groupby $list_properties(groupby) # Output header row - set __cols {} - set __csv_cols {} - set __csv_labels {} + set __cols [list] + set __csv_cols [list] + set __csv_labels [list] foreach __element_name $list_properties(elements) { template::list::element::get_reference -list_name $name -element_name $__element_name @@ -948,7 +948,7 @@ } if {$__groupby eq "" || $group_lastnum_p} { - set __cols {} + set __cols [list] foreach __element_name $__csv_cols { if {![string match "*___*_group" $__element_name]} { @@ -998,7 +998,7 @@ if { [llength $ids] == 0 } { return NULL } - set quoted_ids {} + set quoted_ids [list] foreach one_id $ids { lappend quoted_ids "'[DoubleApos $one_id]'" } @@ -1098,7 +1098,7 @@ template::list::orderby::get_reference -list_name $name -orderby_name $list_properties(orderby_selected_name) - set result {} + set result [list] if {$list_properties(orderby_selected_direction) eq "desc"} { lappend result "-decreasing" } @@ -1422,7 +1422,7 @@ # However, for now, it's just commented out with an if 0 ... block. if 0 { set num_pages 11 - set pages {} + set pages [list] for { set i [expr {$current_page - $num_pages}] } { $i < $current_page + $num_pages } { incr i } { if { $i > 0 && $i <= $paginator(page_count) } { lappend pages $i @@ -1591,7 +1591,7 @@ get_reference -name $name if {[info exists filter_names]} { - set filter_refs {} + set filter_refs [list] foreach filter_name $filter_names { lappend filter_refs ${name}:filter:${filter_name}:properties } @@ -2124,7 +2124,7 @@ # Create the orderby filter, if specified if { $element_properties(orderby) ne "" || $element_properties(orderby_asc) ne "" || $element_properties(orderby_desc) ne "" } { - set orderby_spec {} + set orderby_spec [list] foreach elm { orderby orderby_asc orderby_desc default_direction label } { if { $element_properties($elm) ne "" } { lappend orderby_spec $elm $element_properties($elm) @@ -3211,15 +3211,15 @@ # Get an upvar'd reference to list_properties get_reference -name $name - set filter_names_options_tmp {} - set filter_names_options {} - set filter_hidden_filters {} - set filter_key_filters {} + set filter_names_options_tmp [list] + set filter_names_options [list] + set filter_hidden_filters [list] + set filter_key_filters [list] set filter_exclude_from_key [list orderby groupby format page __list_view] if {[llength $filter_exclude_from_key_extra]} { lappend filter_exclude_from_key {*}$filter_exclude_from_key_extra } - set filter_hidden_filters_url_vars {} + set filter_hidden_filters_url_vars [list] # loop through all the filters in this list foreach filter_ref $list_properties(filter_refs) { upvar #$level $filter_ref filter_properties @@ -3290,7 +3290,7 @@ # the filter from the client property if its # specified in clear_one set __old_client_property_filters [ad_get_client_property acs-templating $__list_filter_form_client_property_key] - set __client_property_filters {} + set __client_property_filters [list] foreach {__ref __value} $__old_client_property_filters { if {[set ${__ref}(name)] ne $clear_one} { @@ -3361,7 +3361,7 @@ } if {![template::element::exists $filters_form_name $filter_properties(name)]} { # extract options - set options {} + set options [list] foreach \ elm $filter_properties(values) \ @@ -3424,7 +3424,7 @@ # still has to process the values to generate a valid # where clause template::list::get_reference -name $name - set templist {} + set templist [list] foreach {f_ref f_value} $__client_property_filters { upvar \#[template::adp_level] $f_ref filter_properties set filter_properties(value) [set $filter_properties(name)] Index: openacs-4/packages/acs-templating/tcl/paginator-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/paginator-procs.tcl,v diff -u -N -r1.30 -r1.31 --- openacs-4/packages/acs-templating/tcl/paginator-procs.tcl 30 Apr 2018 12:45:00 -0000 1.30 +++ openacs-4/packages/acs-templating/tcl/paginator-procs.tcl 9 May 2018 15:33:29 -0000 1.31 @@ -187,7 +187,7 @@ # perform the query in the calling scope so bind variables have effect upvar 2 __paginator_ids ids - set ids {} + set ids [list] set full_statement_name [uplevel 2 "db_qd_get_fullname $statement_name"] @@ -255,7 +255,7 @@ set i 0 set page_size $properties(pagesize) - set context_ids {} + set context_ids [list] set row_ids "" foreach row $ids { @@ -458,7 +458,7 @@ if { $end > $page_count } { set end $page_count } - set pages {} + set pages [list] for { set i $start } { $i <= $end } { incr i } { lappend pages $i @@ -499,7 +499,7 @@ if { $end > $page_count } { set end $page_count) } - set pages {} + set pages [list] for { set i $start } { $i <= $end } { incr i $group_size } { lappend pages $i @@ -745,7 +745,7 @@ # DEDS: quote the ids so that we are not # necessarily limited to integer keys - set quoted_ids {} + set quoted_ids [list] foreach one_id $ids { lappend quoted_ids "'[DoubleApos $one_id]'" } Index: openacs-4/packages/acs-templating/tcl/query-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/query-procs.tcl,v diff -u -N -r1.44 -r1.45 --- openacs-4/packages/acs-templating/tcl/query-procs.tcl 8 May 2018 18:02:44 -0000 1.44 +++ openacs-4/packages/acs-templating/tcl/query-procs.tcl 9 May 2018 15:33:29 -0000 1.45 @@ -341,7 +341,7 @@ } # build the values on which to group - set group_values {} + set group_values [list] foreach group $groups { lappend group_values [ns_set get $row $group] } @@ -671,7 +671,7 @@ pop { upvar $multirow_level_up $name:rowcount rowcount $name:columns columns - set r_list {} + set r_list [list] if {$rowcount > 0} { upvar $multirow_level_up $name:$rowcount row for { set i 0 } { $i < [llength $columns] } { incr i } { @@ -918,7 +918,7 @@ set sort_cols [lrange $args $i end] - set sort_list {} + set sort_list [list] for { set i 1 } { $i <= $rowcount } { incr i } { upvar $multirow_level_up $name:$i row @@ -1002,7 +1002,7 @@ } get_query { - set keyvalues {} + set keyvalues [list] for { set i 0 } { $i < [ns_set size $params] } { incr i } { set key [ns_set key $params $i] set value [ns_set value $params $i] Index: openacs-4/packages/acs-templating/tcl/spellcheck-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/spellcheck-procs.tcl,v diff -u -N -r1.25 -r1.26 --- openacs-4/packages/acs-templating/tcl/spellcheck-procs.tcl 25 Apr 2018 19:23:26 -0000 1.25 +++ openacs-4/packages/acs-templating/tcl/spellcheck-procs.tcl 9 May 2018 15:33:29 -0000 1.26 @@ -142,7 +142,7 @@ } { set sorted_list [lsort -dictionary $the_list] - set new_list {} + set new_list [list] set old_element "XXinitial_conditionXX" foreach list_element $sorted_list { @@ -277,7 +277,7 @@ upvar $error_num_ref error_num set error_num 0 - set errors {} + set errors [list] set processed_text "" Index: openacs-4/packages/acs-templating/tcl/util-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/util-procs.tcl,v diff -u -N -r1.37 -r1.38 --- openacs-4/packages/acs-templating/tcl/util-procs.tcl 25 Apr 2018 19:23:26 -0000 1.37 +++ openacs-4/packages/acs-templating/tcl/util-procs.tcl 9 May 2018 15:33:29 -0000 1.38 @@ -73,7 +73,7 @@ upvar $array_ref arr - set ret {} + set ret [list] foreach {key value} [array get arr] { lappend ret "-$key" $value } @@ -165,7 +165,7 @@ upvar $listref inlist if { ! [info exists inlist] } { - set inlist {} + set inlist [list] } # inlist represents the top level of the data structure into which @@ -181,7 +181,7 @@ if { [info exists values($next)] } { set next_list $values($next) } else { - set next_list {} + set next_list [list] } # the number of additional arguments after next determines how many @@ -228,7 +228,7 @@ @return A list in the form { key value key value key value ... } } { - set result {} + set result [list] for { set i 0 } { $i < [ns_set size $set] } { incr i } { @@ -364,7 +364,7 @@ upvar $level $name:rowcount rowcount - set rows {} + set rows [list] for { set i 1 } { $i <= $rowcount } { incr i } { @@ -594,7 +594,7 @@ Return a list of numbers, {1 2 3 ... n} } { - set ret {} + set ret [list] for {set i $start_at} { $i <= $last_number } {incr i} { lappend ret $i } Index: openacs-4/packages/acs-templating/tcl/widget-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/widget-procs.tcl,v diff -u -N -r1.61 -r1.62 --- openacs-4/packages/acs-templating/tcl/widget-procs.tcl 1 May 2018 08:23:06 -0000 1.61 +++ openacs-4/packages/acs-templating/tcl/widget-procs.tcl 9 May 2018 15:33:29 -0000 1.62 @@ -173,7 +173,7 @@ } else { # we need to return a select list - set options {} + set options [list] if { [llength $persons] > 0 } { set options $persons @@ -672,7 +672,7 @@ set output {} if { $mode ne "edit" } { - set selected_list {} + set selected_list [list] foreach option $options_list { lassign $option label value Index: openacs-4/packages/acs-templating/tcl/wizard-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/wizard-procs.tcl,v diff -u -N -r1.16 -r1.17 --- openacs-4/packages/acs-templating/tcl/wizard-procs.tcl 25 Apr 2018 19:23:26 -0000 1.16 +++ openacs-4/packages/acs-templating/tcl/wizard-procs.tcl 9 May 2018 15:33:29 -0000 1.17 @@ -93,7 +93,7 @@ template::util::get_opts $args - set steps {} + set steps [list] set rowcount 0 if { [info exists opts(name)] } { set wizard_name $opts(name) @@ -416,7 +416,7 @@ get_reference upvar 2 wizard_submit_buttons buttons - set buttons {} + set buttons [list] set param_level [template::adp_level] upvar #$param_level wizard:params params @@ -611,7 +611,7 @@ append url "&wizard_visitedstep${one_wizard}=[ns_queryget wizard_visitedstep${one_wizard}]" } - set multiple_listed {} + set multiple_listed [list] # check for passthrough parameters Index: openacs-4/packages/acs-templating/www/doc/demo/list3/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/www/doc/demo/list3/index.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/acs-templating/www/doc/demo/list3/index.tcl 26 Apr 2018 08:56:37 -0000 1.4 +++ openacs-4/packages/acs-templating/www/doc/demo/list3/index.tcl 9 May 2018 15:33:29 -0000 1.5 @@ -16,7 +16,7 @@ set package_id [ad_conn package_id] set user_id [ad_conn user_id] -set context {} +set context [list] set create_p [permission::permission_p -object_id $package_id -privilege create] template::list::create -name notes \ Index: openacs-4/packages/acs-templating/www/doc/demo/list4/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/www/doc/demo/list4/index.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/acs-templating/www/doc/demo/list4/index.tcl 26 Apr 2018 08:56:37 -0000 1.4 +++ openacs-4/packages/acs-templating/www/doc/demo/list4/index.tcl 9 May 2018 15:33:29 -0000 1.5 @@ -22,7 +22,7 @@ set package_id [ad_conn package_id] set user_id [ad_conn user_id] -set context {} +set context [list] set create_p [permission::permission_p -object_id $package_id -privilege create] # Here, we are adding a link for every row. The title of the note Index: openacs-4/packages/acs-templating/www/doc/demo/list5/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/www/doc/demo/list5/index.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/acs-templating/www/doc/demo/list5/index.tcl 26 Apr 2018 08:56:37 -0000 1.4 +++ openacs-4/packages/acs-templating/www/doc/demo/list5/index.tcl 9 May 2018 15:33:29 -0000 1.5 @@ -16,7 +16,7 @@ set package_id [ad_conn package_id] set user_id [ad_conn user_id] -set context {} +set context [list] set create_p [permission::permission_p -object_id $package_id -privilege create] # New here, is the use of -key to signify which column is the key field, Index: openacs-4/packages/acs-templating/www/doc/demo/list6/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/www/doc/demo/list6/index.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/acs-templating/www/doc/demo/list6/index.tcl 26 Apr 2018 08:56:37 -0000 1.4 +++ openacs-4/packages/acs-templating/www/doc/demo/list6/index.tcl 9 May 2018 15:33:29 -0000 1.5 @@ -16,10 +16,10 @@ set package_id [ad_conn package_id] set user_id [ad_conn user_id] -set context {} +set context [list] set create_p [permission::permission_p -object_id $package_id -privilege create] -set actions {} +set actions [list] if { $create_p } { lappend actions "Create Note" add-edit "Create Note" Index: openacs-4/packages/acs-templating/www/doc/demo/list7/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/www/doc/demo/list7/index.tcl,v diff -u -N -r1.6 -r1.7 --- openacs-4/packages/acs-templating/www/doc/demo/list7/index.tcl 26 Apr 2018 08:56:37 -0000 1.6 +++ openacs-4/packages/acs-templating/www/doc/demo/list7/index.tcl 9 May 2018 15:33:29 -0000 1.7 @@ -32,10 +32,10 @@ set package_id [ad_conn package_id] set user_id [ad_conn user_id] -set context {} +set context [list] set create_p [permission::permission_p -object_id $package_id -privilege create] -set actions {} +set actions [list] if { $create_p } { lappend actions "Create Note" add-edit "Create Note" Index: openacs-4/packages/acs-templating/www/doc/demo/list8/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/www/doc/demo/list8/index.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/acs-templating/www/doc/demo/list8/index.tcl 26 Apr 2018 08:56:37 -0000 1.5 +++ openacs-4/packages/acs-templating/www/doc/demo/list8/index.tcl 9 May 2018 15:33:29 -0000 1.6 @@ -24,10 +24,10 @@ set package_id [ad_conn package_id] set user_id [ad_conn user_id] -set context {} +set context [list] set create_p [permission::permission_p -object_id $package_id -privilege create] -set actions {} +set actions [list] if { $create_p } { lappend actions "Create Note" add-edit "Create Note" Index: openacs-4/packages/acs-templating/www/doc/demo/list9/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/www/doc/demo/list9/index.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/acs-templating/www/doc/demo/list9/index.tcl 26 Apr 2018 08:56:37 -0000 1.4 +++ openacs-4/packages/acs-templating/www/doc/demo/list9/index.tcl 9 May 2018 15:33:29 -0000 1.5 @@ -18,10 +18,10 @@ set package_id [ad_conn package_id] set user_id [ad_conn user_id] -set context {} +set context [list] set create_p [permission::permission_p -object_id $package_id -privilege create] -set actions {} +set actions [list] if { $create_p } { lappend actions "Create Note" add-edit "Create Note" Index: openacs-4/packages/address-book/www/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/address-book/www/index.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/address-book/www/index.tcl 26 Apr 2018 08:56:37 -0000 1.5 +++ openacs-4/packages/address-book/www/index.tcl 9 May 2018 15:33:29 -0000 1.6 @@ -27,7 +27,7 @@ set instance_name [db_exec_plsql package_name {begin :1 := acs_object.name(:instance_id); end;}] -set context {} +set context [list] set create_p [ad_permission_p $instance_id create] Index: openacs-4/packages/adserver/www/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/adserver/www/index.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/adserver/www/index.tcl 26 Apr 2018 08:56:37 -0000 1.3 +++ openacs-4/packages/adserver/www/index.tcl 9 May 2018 15:33:29 -0000 1.4 @@ -27,7 +27,7 @@ " set package_id [ad_conn package_id] -set ads {} +set ads [list] set count 0 db_foreach adserver_sample_groups { select group_key, pretty_name, adv_count, rotation_method Index: openacs-4/packages/ajax-filestorage-ui/lib/ajaxfs-include.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ajax-filestorage-ui/lib/ajaxfs-include.tcl,v diff -u -N -r1.13 -r1.14 --- openacs-4/packages/ajax-filestorage-ui/lib/ajaxfs-include.tcl 25 Apr 2018 19:47:46 -0000 1.13 +++ openacs-4/packages/ajax-filestorage-ui/lib/ajaxfs-include.tcl 9 May 2018 15:33:29 -0000 1.14 @@ -70,7 +70,7 @@ if { [exists_and_not_null package_id] } { - set options {} + set options [list] # get the root folder set rootfolder_id [fs_get_root_folder -package_id $package_id] Index: openacs-4/packages/ajax-photoalbum-ui/lib/ajaxpa-include.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ajax-photoalbum-ui/lib/ajaxpa-include.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/ajax-photoalbum-ui/lib/ajaxpa-include.tcl 25 Apr 2018 19:47:46 -0000 1.2 +++ openacs-4/packages/ajax-photoalbum-ui/lib/ajaxpa-include.tcl 9 May 2018 15:33:29 -0000 1.3 @@ -16,7 +16,7 @@ if { [exists_and_not_null package_id] } { set user_id [ad_conn user_id] - set options {} + set options [list] set rootfolder_id [pa_get_root_folder $package_id] set instance_name [db_string "get_folder_name" "select name as instance_name from fs_folders where folder_id = :rootfolder_id"] Index: openacs-4/packages/ajax-photoalbum-ui/www/doc/photo-album-ajaxpa.diff =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ajax-photoalbum-ui/www/doc/photo-album-ajaxpa.diff,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/ajax-photoalbum-ui/www/doc/photo-album-ajaxpa.diff 25 Apr 2018 19:47:46 -0000 1.2 +++ openacs-4/packages/ajax-photoalbum-ui/www/doc/photo-album-ajaxpa.diff 9 May 2018 15:33:29 -0000 1.3 @@ -65,7 +65,7 @@ } { return the image information from a given file } { - set info {} + set info [list] + if { ![exists_and_not_null package_id] } { set package_id [ad_conn package_id] } if { [catch {set size [file size $file]} errMsg] } { return -code error $errMsg Index: openacs-4/packages/ajaxhelper/tcl/ajax-dojo-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ajaxhelper/tcl/ajax-dojo-procs.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/ajaxhelper/tcl/ajax-dojo-procs.tcl 26 Apr 2018 08:56:37 -0000 1.5 +++ openacs-4/packages/ajaxhelper/tcl/ajax-dojo-procs.tcl 9 May 2018 15:33:29 -0000 1.6 @@ -191,7 +191,7 @@ @creation-date 2006-11-05 } { - set objargs {} + set objargs [list] foreach args $argslist { lappend objargs [join $args ":"] } Index: openacs-4/packages/ajaxhelper/tcl/ajax-listbuilder-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ajaxhelper/tcl/ajax-listbuilder-procs.tcl,v diff -u -N -r1.6 -r1.7 --- openacs-4/packages/ajaxhelper/tcl/ajax-listbuilder-procs.tcl 25 Apr 2018 19:47:46 -0000 1.6 +++ openacs-4/packages/ajaxhelper/tcl/ajax-listbuilder-procs.tcl 9 May 2018 15:33:29 -0000 1.7 @@ -33,13 +33,13 @@ if {[info exists _hide_column]} { set hide_column $_hide_column } else { - set hide_column {} + set hide_column [list] } upvar move _move if {[info exists _move]} { set move $_move } else { - set move {} + set move [list] } upvar groupby _groupby set previous_index 0 @@ -49,7 +49,7 @@ template::list::get_reference -name $list_name upvar #[template::adp_level] ${list_name}:filter:groupby:properties groupby_ref - set groupbys {} + set groupbys [list] foreach elm $groupby_ref(values) { set value [lindex $elm 1] lappend groupbys [lindex $value 0 1] @@ -73,16 +73,16 @@ set first_not_checkbox 1 } - set sortmenuitems {} + set sortmenuitems [list] lappend sortmenuitems [list [list "text" "A-Z"] [list "url" "[filter_url -list_name $list_name -filter_name orderby -filter_value ${element},asc -return_url $return_url]"]] lappend sortmenuitems [list [list "text" "Z-A"] [list "url" "[filter_url -list_name $list_name -filter_name orderby -filter_value ${element},desc -return_url $return_url]"]] - set groupmenuitems {} + set groupmenuitems [list] lappend groupmenuitems [list [list "text" "By Exact Value"] [list "url" "[filter_url -list_name $list_name -filter_name groupby -filter_value $element -return_url $return_url]"] ] # lappend groupmenuitems [list [list "text" "By First Letter"] [list "url" "javascript:void(0)"] ] - set movemenuitems {} + set movemenuitems [list] set this_move $move if {[set this_move_index [lsearch $move $element]] > -1} { set this_move [lreplace $move $this_move_index [expr {$this_move_index + 1}]] @@ -97,7 +97,7 @@ lappend movemenuitems [list [list "text" "First"] [list "url" "[filter_url -list_name $list_name -filter_name move -filter_value [concat $this_move [list $element $first_not_checkbox]] -return_url $return_url]"]] } - set menulist {} + set menulist [list] if {[lsearch $list_properties(orderby_refs) "*${element_properties(name)}*"] > -1} { lappend menulist [list [list "text" "Sort"] [list "submenu" [list [list "id" "sort-$element_properties(name)"] [list "itemdata" $sortmenuitems] ] ] ] } @@ -180,9 +180,9 @@ if {[info exists _add_column]} { set add_column $_add_column } else { - set add_column {} + set add_column [list] } - set addcolumnlist {} + set addcolumnlist [list] template::list::get_reference -name $list_name lappend list_properties(actions) [_ acs-templating.Add_Column] "javascript:void(0)" [_ acs-templating.Add_Column] @@ -252,7 +252,7 @@ foreach view $view_names { set view_name [lindex $view 0] set value [lindex $view 1] - set viewmenuitems {} + set viewmenuitems [list] lappend viewlist [list [list "text" $view_name] [list "url" "[filter_url -list_name $list_name -filter_name __list_view -filter_value $value -return_url [ad_conn url]]" ]] } @@ -455,7 +455,7 @@ } if {[info exists hide]} { - set reset_filters {} + set reset_filters [list] if {[info exists orderby] && [lsearch $hide [lindex [split $orderby ,] 0]] > -1} { unset orderby lappend reset_filters orderby Index: openacs-4/packages/ajaxhelper/tcl/ajax-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ajaxhelper/tcl/ajax-procs.tcl,v diff -u -N -r1.18 -r1.19 --- openacs-4/packages/ajaxhelper/tcl/ajax-procs.tcl 25 Apr 2018 19:47:46 -0000 1.18 +++ openacs-4/packages/ajaxhelper/tcl/ajax-procs.tcl 9 May 2018 15:33:29 -0000 1.19 @@ -240,16 +240,16 @@ Converts a properly structured list of lists into JSON format. The list of lists may look something like - set data {} + set data [list] lappend data [list [list "x" "1"] [list "y" "10"] ] lappend data [list [list "x" "5"] [list "y" "20"] ] each line represents a row composed of lists. Each list in the row holds a pair that will be joined by ":". } { - set rows {} + set rows [list] foreach row $lists_of_pairs { - set pairs {} + set pairs [list] foreach pair $row { lappend pairs [join $pair ":"] } Index: openacs-4/packages/ajaxhelper/tcl/ajax-yahoo-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ajaxhelper/tcl/ajax-yahoo-procs.tcl,v diff -u -N -r1.14 -r1.15 --- openacs-4/packages/ajaxhelper/tcl/ajax-yahoo-procs.tcl 25 Apr 2018 19:47:46 -0000 1.14 +++ openacs-4/packages/ajaxhelper/tcl/ajax-yahoo-procs.tcl 9 May 2018 15:33:29 -0000 1.15 @@ -367,7 +367,7 @@ This is an example of a node list. - set nodes {} + set nodes [list] lappend nodes [list "fld1" "Folder 1" "tree" "" "" "" ""] lappend nodes [list "fld2" "Folder 2" "tree" "javascript:alert('this is a tree node')" "" "" ""] @@ -531,17 +531,17 @@ Converts a properly structured list of menu items into JSON format. The list of lists may look something like - set submenu {} + set submenu [list] lappend submenu [list [list "text" "Submenu1"] [list "url" "http://www.google.com"] ] lappend submenu [list [list "text" "Submenu2"] [list "url" "http://www.yahoo.com"] ] each line represents a row composed of lists. Each list in the row holds a pair that will be joined by ":". } { - set rows {} + set rows [list] foreach row $lists_of_pairs { - set pairs {} + set pairs [list] foreach pair $row { if { [lindex $pair 0] eq "submenu" } { set submenulist [lindex $pair 1] @@ -695,17 +695,17 @@ if { [llength [lindex $suggestlist 0]] > 1} { # yes , let's create the array for the innerlist and put each array into one big array - set outerlist {} + set outerlist [list] foreach onelist $suggestlist { - set escaped_list {} + set escaped_list [list] foreach elm $onelist { lappend escaped_list [string map {' \\'} $elm] } lappend outerlist "\[ '[join $escaped_list "','"]' \]" } set script "var ${varname}Arr = \[ [join $outerlist ","] \];" - set markup {} + set markup [list] for { set x 0} { $x < [llength [lindex $suggestlist 0]] } { incr x} { lappend markup "oResultItem\[${x}\]" } Index: openacs-4/packages/ajaxhelper/tcl/json-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ajaxhelper/tcl/json-procs.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/ajaxhelper/tcl/json-procs.tcl 25 Apr 2018 19:47:46 -0000 1.4 +++ openacs-4/packages/ajaxhelper/tcl/json-procs.tcl 9 May 2018 15:33:29 -0000 1.5 @@ -67,7 +67,7 @@ # we are dealing with an Object getc set state OBJECT - set dictVal {} + set dictVal [list] } VALUE { # this object element's value is an Object Index: openacs-4/packages/ajaxhelper/www/doc/head-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ajaxhelper/www/doc/head-procs.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/ajaxhelper/www/doc/head-procs.tcl 25 Apr 2018 19:47:46 -0000 1.5 +++ openacs-4/packages/ajaxhelper/www/doc/head-procs.tcl 9 May 2018 15:33:29 -0000 1.6 @@ -20,28 +20,28 @@ } { variable ::template::head::scripts array unset scripts - array set scripts {} + array set scripts [list] variable ::template::head::links array unset links - array set links {} + array set links [list] variable ::template::head::metas array unset metas - array set metas {} + array set metas [list] variable ::template::body_handlers array unset body_handlers - array set body_handlers {} + array set body_handlers [list] variable ::template::body_scripts array unset body_scripts - set body_scripts {} + set body_scripts [list] variable ::template::headers - set headers {} + set headers [list] variable ::template::footers - set footers {} + set footers [list] } ad_proc -public template::head::add_script { Index: openacs-4/packages/ajaxhelper/www/tests/test_dojochartengine.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ajaxhelper/www/tests/test_dojochartengine.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/ajaxhelper/www/tests/test_dojochartengine.tcl 26 Apr 2018 08:56:37 -0000 1.3 +++ openacs-4/packages/ajaxhelper/www/tests/test_dojochartengine.tcl 9 May 2018 15:33:29 -0000 1.4 @@ -1,6 +1,6 @@ # create the list that holds our data -set data {} +set data [list] lappend data [list [list "x" "1"] [list "y" "10"] ] lappend data [list [list "x" "5"] [list "y" "20"] ] @@ -25,7 +25,7 @@ return $type } $objname proc bindings_from_list {lists_of_pairs} { - set pairs {} + set pairs [list] foreach pair $lists_of_pairs { lappend pairs [join $pair ":"] } @@ -58,7 +58,7 @@ return $varname } $objname proc range_from_list {rangelist} { - set pairs {} + set pairs [list] foreach pair $rangelist { lappend pairs [join $pair ":"] } @@ -100,7 +100,7 @@ return $varname } $objname proc range_from_list {rangelist} { - set pairs {} + set pairs [list] foreach pair $rangelist { lappend pairs [join $pair ":"] } @@ -135,7 +135,7 @@ $objname set axis_obj_list [list "axis1" "axis2"] $objname proc createscript { } { my instvar varname series_obj_list axis_obj_list - set axislist {} + set axislist [list] foreach axis $axis_obj_list { lappend axislist [$axis getvarname] } Index: openacs-4/packages/ajaxhelper/www/tests/test_yahoomenu-js.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ajaxhelper/www/tests/test_yahoomenu-js.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/ajaxhelper/www/tests/test_yahoomenu-js.tcl 25 Apr 2018 19:47:46 -0000 1.4 +++ openacs-4/packages/ajaxhelper/www/tests/test_yahoomenu-js.tcl 9 May 2018 15:33:29 -0000 1.5 @@ -2,7 +2,7 @@ # Menu 1 -# set menulist1 {} +# set menulist1 [list] # lappend menulist1 [list [list "text" "Google"] [list "url" "http://www.google.com"] ] # lappend menulist1 [list [list "text" "Yahoo"] [list "url" "http://www.yahoo.com"] ] @@ -19,11 +19,11 @@ # Menu 2 -# set submenuitems {} +# set submenuitems [list] # lappend submenuitems [list [list "text" "Home Page"] [list "url" "http://www.solutiongrove.com"] ] # lappend submenuitems [list [list "text" "Blog"] [list "url" "http://www.solutiongrove.com/blogger/"] ] # set submenulist1 [list [list "id" "sgrovelinks"] [list "itemdata" $submenuitems] ] -# set menulist2 {} +# set menulist2 [list] # lappend menulist2 [list [list "text" "OpenACS"] [list "url" "http://www.openacs.org"] ] # lappend menulist2 [list [list "text" "Solution Grove"] [list "submenu" $submenulist1] ] Index: openacs-4/packages/ajaxhelper/www/tests/test_yahootreeview.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ajaxhelper/www/tests/test_yahootreeview.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/ajaxhelper/www/tests/test_yahootreeview.tcl 26 Apr 2018 08:56:37 -0000 1.4 +++ openacs-4/packages/ajaxhelper/www/tests/test_yahootreeview.tcl 9 May 2018 15:33:29 -0000 1.5 @@ -1,5 +1,5 @@ # create the nodes for our tree -set nodes {} +set nodes [list] # 1st level lappend nodes [list "fld1" "Folder 1" "tree" "" "" "" ""] Index: openacs-4/packages/ams/tcl/address-widget-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ams/tcl/address-widget-procs.tcl,v diff -u -N -r1.20 -r1.21 --- openacs-4/packages/ams/tcl/address-widget-procs.tcl 25 Apr 2018 19:47:46 -0000 1.20 +++ openacs-4/packages/ams/tcl/address-widget-procs.tcl 9 May 2018 15:33:29 -0000 1.21 @@ -156,7 +156,7 @@ Returns the country list. } { set country_code_list [db_list get_country_codes {}] - set return_country_list {} + set return_country_list [list] set reserved_country_codes [parameter::get_from_package_key -parameter "DefaultISOCountryCode" -package_key "ams" -default ""] foreach country $country_code_list { @@ -165,7 +165,7 @@ } } set return_country_list [ams::util::sort_list_of_lists -list $return_country_list] - set country_code {} + set country_code [list] if { [exists_and_not_null reserved_country_codes] } { foreach country $reserved_country_codes { set country [string toupper $country] @@ -215,7 +215,7 @@ set additional_text [template::util::address::get_property additional_text $address_list] set postal_type [template::util::address::get_property postal_type $address_list] - set message {} + set message [list] # this is used to make sure there are no invalid characters in the address set address_temp "$delivery_address $municipality $region $postal_code $country_code $additional_text $postal_type" if { [::string match "\{" $address_temp] || [::string match "\}" $address_temp] } { @@ -371,7 +371,7 @@ } if { $country_code == "US" || $country_code == "CA" } { # make the city pretty - set municipality_temp {} + set municipality_temp [list] foreach word $municipality { # I am sure there are more then "Mc" words when they come up add them here if { [regexp {^MC([a-zA-Z]+?)} [string toupper $word]] } { Index: openacs-4/packages/ams/tcl/ams-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ams/tcl/ams-procs.tcl,v diff -u -N -r1.56 -r1.57 --- openacs-4/packages/ams/tcl/ams-procs.tcl 26 Apr 2018 08:56:37 -0000 1.56 +++ openacs-4/packages/ams/tcl/ams-procs.tcl 9 May 2018 15:33:29 -0000 1.57 @@ -202,9 +202,9 @@ } { localize the elements of a list_of_lists } { - set list_output {} + set list_output [list] foreach item $list { - set item_output {} + set item_output [list] foreach part $item { lappend item_output [lang::util::localize $part] } @@ -219,7 +219,7 @@ } { sort a list_of_lists } { -# set sort_output {} +# set sort_output [list] # foreach item $list { # set sort_key [string toupper [lindex $item $position]] # we need to replace spaces because it prevents @@ -229,7 +229,7 @@ # lappend sort_output [list $sort_key $item] # } # set sort_output [lsort $sort_output] -# set list_output {} +# set list_output [list] # foreach item $sort_output { # lappend list_output [lindex $item 1] # } @@ -461,7 +461,7 @@ @param list_names A list of list_names to get the list_ids from. Either this or list_name must be provided. @param key The key element to use in the form. } { - set list_ids {} + set list_ids [list] if { [empty_string_p $list_names] && [empty_string_p $list_name] } { ad_return_complaint 1 "[_ ams.you_must_provide_list_name]" ad_script_abort @@ -499,11 +499,11 @@ # Control list to know which attributes are already in the # elements list so we don't en up with duplicates - set control_list {} + set control_list [list] # If we do not have a list_id then don't bother to try and get any attributes... if {[string eq "" $list_ids]} { - set all_attributes {} + set all_attributes [list] } else { set all_attributes [db_list_of_lists select_elements " "] } @@ -664,7 +664,7 @@ set list_names $list_name } - set list_ids {} + set list_ids [list] foreach l_name $list_names { set list_id [ams::list::get_list_id -package_key $package_key -object_type $object_type -list_name $l_name] if {![empty_string_p $list_id]} { @@ -677,12 +677,12 @@ set list_ids [template::util::tcl_to_sql_list $list_ids] if { [exists_and_not_null list_ids] } { - set values {} + set values [list] set heading "" # Control list to know which attributes are already in the # elements list so we don't en up with duplicates - set control_list {} + set control_list [list] set all_attributes [db_list_of_lists select_values {}] @@ -696,7 +696,7 @@ set widget [lindex $attribute 4] set value [lindex $attribute 5] - set val {} + set val [list] if { [regexp "\{text/.*\}" $value value_format] } { lappend val [lindex $value_format 0] lappend val [list [string range $value [expr [string length $value_format] + 1] [string length $value]]] Index: openacs-4/packages/ams/tcl/ams-widget-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ams/tcl/ams-widget-procs.tcl,v diff -u -N -r1.39 -r1.40 --- openacs-4/packages/ams/tcl/ams-widget-procs.tcl 25 Apr 2018 19:47:46 -0000 1.39 +++ openacs-4/packages/ams/tcl/ams-widget-procs.tcl 9 May 2018 15:33:29 -0000 1.40 @@ -67,7 +67,7 @@ value_text - value_html { if { [exists_and_not_null value] } { if { [::ams::widget_has_options_p -widget $widget] } { - set output {} + set output [list] foreach option [::ams::widget_options -attribute_id $attribute_id -locale $locale] { if { [lsearch $value [lindex $option 1]] >= 0 } { lappend output [lindex $option 0] @@ -106,7 +106,7 @@ } { Return all widget procs. Each list element is a list of the first then pretty_name then the widget } { - set return_list {} + set return_list [list] db_foreach get_options {} { set pretty_name "[lang::util::localize $pretty_name $locale]" lappend return_list [list $pretty_name $option_id] @@ -126,7 +126,7 @@ } { Return all widget procs. Each list element is a list of the first then pretty_name then the widget } { - set widgets {} + set widgets [list] set all_procs [::info procs "::ams::widget::*"] foreach widget $all_procs { if { [string is false [regsub {__arg_parser} $widget {} widget]] } { @@ -141,7 +141,7 @@ } { Initialize all widgets. Deprecated widgets that no longer exist in the tcl api. } { - set proc_widgets {} + set proc_widgets [list] foreach widget [ams::widget_list] { lappend proc_widgets [lindex $widget 1] } @@ -422,7 +422,7 @@ switch $request { ad_form_widget { set help_text [attribute::help_text -attribute_id $attribute_id] - set element {} + set element [list] if { [string is true $optional_p] } { return "${attribute_name}:mobile_number(mobile_number),optional {help_text \"$help_text\"} {[list label ${pretty_name}]} {[list html ${html_options}]}" } else { @@ -513,7 +513,7 @@ switch $request { ad_form_widget { set help_text [attribute::help_text -attribute_id $attribute_id] - set element {} + set element [list] if { [string is true $optional_p] } { lappend element ${attribute_name}:text(text),optional } else { @@ -606,7 +606,7 @@ switch $request { ad_form_widget { set help_text [attribute::help_text -attribute_id $attribute_id] - set element {} + set element [list] if { [string is true $optional_p] } { lappend element ${attribute_name}:text(text),optional } else { Index: openacs-4/packages/ams/www/attribute-add-2.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ams/www/attribute-add-2.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/ams/www/attribute-add-2.tcl 25 Apr 2018 19:47:46 -0000 1.5 +++ openacs-4/packages/ams/www/attribute-add-2.tcl 9 May 2018 15:33:29 -0000 1.6 @@ -91,7 +91,7 @@ } -on_submit { set i 1 - set options {} + set options [list] while { $i <= "9" } { set option_value [string trim [set option${i}]] ns_log notice $option_value Index: openacs-4/packages/ams/www/attribute-add.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ams/www/attribute-add.tcl,v diff -u -N -r1.11 -r1.12 --- openacs-4/packages/ams/www/attribute-add.tcl 25 Apr 2018 19:47:46 -0000 1.11 +++ openacs-4/packages/ams/www/attribute-add.tcl 9 May 2018 15:33:29 -0000 1.12 @@ -41,7 +41,7 @@ set default_number_of_options 5 set option_fields_count $default_number_of_options set i 1 - set elements {} + set elements [list] lappend elements [list option_fields_count:integer(hidden) [list value $option_fields_count]] # lappend elements [list options_on_last_screen:integer(hidden),optional] while { $i <= $option_fields_count } { Index: openacs-4/packages/assessment/tcl/as-checks-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/tcl/as-checks-procs.tcl,v diff -u -N -r1.30 -r1.31 --- openacs-4/packages/assessment/tcl/as-checks-procs.tcl 25 Apr 2018 19:47:46 -0000 1.30 +++ openacs-4/packages/assessment/tcl/as-checks-procs.tcl 9 May 2018 15:33:29 -0000 1.31 @@ -274,7 +274,7 @@ } set admin [db_list_of_lists get_assessment_admin {}] - set to {} + set to [list] foreach notify_user $admin { lappend to $notify_user } @@ -348,7 +348,7 @@ db_dml update_actions_log {} set admin [db_list_of_lists get_assessment_admin {}] - set to {} + set to [list] foreach notify_user $admin { lappend to $notify_user } Index: openacs-4/packages/assessment/tcl/as-list-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/tcl/as-list-procs.tcl,v diff -u -N -r1.10 -r1.11 --- openacs-4/packages/assessment/tcl/as-list-procs.tcl 25 Apr 2018 21:16:43 -0000 1.10 +++ openacs-4/packages/assessment/tcl/as-list-procs.tcl 9 May 2018 15:33:29 -0000 1.11 @@ -24,10 +24,10 @@ @error } { # Process search items - set paramlist {} + set paramlist [list] if { [set form [rp_getform]] ne "" } { array set formarr [util_ns_set_to_list -set $form] - set paramlist {} + set paramlist [list] foreach param [array names formarr] { if { [regexp -nocase {^as_item_id_(\d+)$} $param match one_item_id] } { @@ -50,10 +50,10 @@ @error } { # Process search items - set as_item_ids {} + set as_item_ids [list] if { [set form [rp_getform]] ne "" } { array set formarr [util_ns_set_to_list -set $form] - set paramlist {} + set paramlist [list] foreach param [array names formarr] { if { [regexp -nocase {^as_item_id_(\d+)$} $param match one_item_id] } { @@ -102,15 +102,15 @@ @param assessment_ids List of IDs of the assessments to get the items from } { - set elements {} + set elements [list] set multirow __as_list_$list_name as::list::get_items_multirow \ -assessment_ids $assessment_ids \ -multirow $multirow # don't query the same item more than one - array set visited_items {} + array set visited_items [list] template::multirow foreach $multirow { if {![info exists visited_items($item_id)] && $as_item_id == $latest_revision} { set visited_items($item_id) $item_id @@ -182,7 +182,7 @@ #get all the items - set filters {} + set filters [list] # we just want the questions that are in all the assessments we received set multirow __as_list_$list_name @@ -191,7 +191,7 @@ -multirow $multirow # don't query the same item more than one - array set visited_items {} + array set visited_items [list] template::multirow foreach $multirow { if {![info exists visited_items($item_id)]} { set visited_items($item_id) $item_id @@ -269,7 +269,7 @@ } else { set multiple_assessment_where "" } - array set visited_sections {} + array set visited_sections [list] foreach section [db_list_of_lists sections {}] { lassign $section option_section_title option_section_id if {![info exists visited_sections($option_section_id)]} { @@ -292,7 +292,7 @@ #get all the items - set groupbys {} + set groupbys [list] # we just want the questions that are in all the assessments we received set multirow __as_list_$list_name @@ -301,7 +301,7 @@ -multirow $multirow # don't query the same item more than one - array set visited_items {} + array set visited_items [list] template::multirow foreach $multirow { if {![info exists visited_items($item_id)]} { set visited_items($item_id) $item_id @@ -328,7 +328,7 @@ #get all the items - set orderbys {} + set orderbys [list] # we just want the questions that are in all the assessments we received set multirow __as_list_$list_name @@ -337,7 +337,7 @@ -multirow $multirow # don't query the same item more than one - array set visited_items {} + array set visited_items [list] template::multirow foreach $multirow { if {![info exists visited_items($item_id)]} { set visited_items($item_id) $item_id Index: openacs-4/packages/assessment/www/asm-admin/action-params.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/www/asm-admin/action-params.tcl,v diff -u -N -r1.12 -r1.13 --- openacs-4/packages/assessment/www/asm-admin/action-params.tcl 25 Apr 2018 19:47:46 -0000 1.12 +++ openacs-4/packages/assessment/www/asm-admin/action-params.tcl 9 May 2018 15:33:29 -0000 1.13 @@ -68,7 +68,7 @@ } db_foreach get_params {} { - set choices {} + set choices [list] if { $type eq "n" } { if { $action_perform eq "aa" || $action_perform eq "m" || $action_perform eq "or" || $action_perform eq "sa"} { set choices [db_list_of_lists choices {}] Index: openacs-4/packages/assessment/www/asm-admin/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/www/asm-admin/index.tcl,v diff -u -N -r1.15 -r1.16 --- openacs-4/packages/assessment/www/asm-admin/index.tcl 26 Apr 2018 08:56:37 -0000 1.15 +++ openacs-4/packages/assessment/www/asm-admin/index.tcl 9 May 2018 15:33:29 -0000 1.16 @@ -28,7 +28,7 @@ {zipfile:file {label "[_ assessment.Import_QTI_ZIP_File]"}} } -set actions {} +set actions [list] set advanced_options_p [parameter::get -parameter ShowAdvancedOptions -default 1] if { $advanced_options_p } { lappend actions [_ assessment.New_Survey] {assessment-form?type=survey} [_ assessment.New_Survey] \ Index: openacs-4/packages/assessment/www/asm-admin/item-stats.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/www/asm-admin/item-stats.tcl,v diff -u -N -r1.9 -r1.10 --- openacs-4/packages/assessment/www/asm-admin/item-stats.tcl 25 Apr 2018 19:47:46 -0000 1.9 +++ openacs-4/packages/assessment/www/asm-admin/item-stats.tcl 9 May 2018 15:33:29 -0000 1.10 @@ -33,7 +33,7 @@ if {[info exists session_id_list]} { set session_ids $session_id_list - set session_id_list {} + set session_id_list [list] foreach elm [split $session_id_list] { if {$elm ne ""} { lappend session_id_list $elm @@ -95,8 +95,8 @@ set total_correct 0 set total_choices 0 - set choices {} - set visited_session_ids {} + set choices [list] + set visited_session_ids [list] set item_choices_limit_session "" if { ([info exists limit_to_section_clause] && $limit_to_section_clause ne "") } { set item_choices_limit_session "and d.session_id in $limit_to_section_clause" } @@ -210,7 +210,7 @@ "float" { set stats "\n" - set number_answers {} + set number_answers [list] set total_responses 0 db_foreach get_number_answers { select count(*) as n_responses, numeric_answer Index: openacs-4/packages/assessment/www/asm-admin/sessions.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/www/asm-admin/sessions.tcl,v diff -u -N -r1.9 -r1.10 --- openacs-4/packages/assessment/www/asm-admin/sessions.tcl 26 Apr 2018 08:56:37 -0000 1.9 +++ openacs-4/packages/assessment/www/asm-admin/sessions.tcl 9 May 2018 15:33:29 -0000 1.10 @@ -34,7 +34,7 @@ } set base_url [ad_return_url] -set actions {} +set actions [list] if { [info exists subject_id] } { set actions [list "[_ assessment.All_Users]" ? "[_ assessment.All_Users]"] Index: openacs-4/packages/assessment-portlet/www/assessment-portlet.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment-portlet/www/assessment-portlet.tcl,v diff -u -N -r1.20 -r1.21 --- openacs-4/packages/assessment-portlet/www/assessment-portlet.tcl 26 Apr 2018 08:56:37 -0000 1.20 +++ openacs-4/packages/assessment-portlet/www/assessment-portlet.tcl 9 May 2018 15:33:29 -0000 1.21 @@ -18,7 +18,7 @@ set list_of_package_ids $config(package_id) set one_instance_p [ad_decode [llength $list_of_package_ids] 1 1 0] -set elements {} +set elements [list] if {!$one_instance_p} { set elements [list community_name \ [list \ @@ -104,7 +104,7 @@ } -set elements {} +set elements [list] if {!$one_instance_p} { set elements [list community_name \ [list \ Index: openacs-4/packages/auth-ldap/lib/search.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/auth-ldap/lib/search.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/auth-ldap/lib/search.tcl 26 Apr 2018 08:56:37 -0000 1.2 +++ openacs-4/packages/auth-ldap/lib/search.tcl 9 May 2018 15:33:29 -0000 1.3 @@ -19,7 +19,7 @@ set auth_search_parameters [auth::driver::get_parameter_values -authority_id $authority_id -impl_id $auth_search_impl_id] array set auth_search_parameters_arr $auth_search_parameters -set search_attribs {} +set search_attribs [list] # foreach attribute_mapping [split $auth_search_parameters_arr(InfoAttributeMap) ";"] { # set attr [lindex [split $attribute_mapping "="] 1] # set pretty_name [lindex [split $attribute_mapping "="] 0] @@ -40,7 +40,7 @@ } } -set search_terms {} +set search_terms [list] foreach attr [concat search_text $search_attribs] { if {[info exists $attr] && [set $attr] ne ""} { lappend search_terms $attr [set $attr] @@ -83,7 +83,7 @@ # does the user have a local account? set local_account_p 0 set user_id "" - set status {} + set status [list] db_0or1row user_exists_p "select user_id from cc_users where upper(username) = upper(:user) and upper(email) = upper(:email)" if {$user_id eq ""} { set group_member_p 0 Index: openacs-4/packages/auth-ldap/tcl/auth-ldap-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/auth-ldap/tcl/auth-ldap-procs.tcl,v diff -u -N -r1.16 -r1.17 --- openacs-4/packages/auth-ldap/tcl/auth-ldap-procs.tcl 26 Apr 2018 08:56:37 -0000 1.16 +++ openacs-4/packages/auth-ldap/tcl/auth-ldap-procs.tcl 9 May 2018 15:33:29 -0000 1.17 @@ -523,7 +523,7 @@ } append dn ",$params(BaseDN)" - set attributes {} + set attributes [list] foreach elm [split $params(Attributes) ";"] { set elmv [split $elm "="] set attribute [string trim [lindex $elmv 0]] @@ -603,7 +603,7 @@ } # Set up mapping data structure - array set map {} + array set map [list] foreach elm [split $params(InfoAttributeMap) ";"] { set elmv [split $elm "="] set oacs_elm [string trim [lindex $elmv 0]] @@ -613,7 +613,7 @@ } # Map LDAP attributes to OpenACS elements - array set user {} + array set user [list] foreach { attribute value } [lindex $search_result 0] { if { [info exists map($attribute)] } { foreach oacs_elm $map($attribute) { @@ -704,7 +704,7 @@ if { [llength $matches] < 1 } { return [list] } else { - set usernames {} + set usernames [list] foreach user $matches { lappend usernames [lindex $user 3] } Index: openacs-4/packages/b-responsive-theme/www/blank-master.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/b-responsive-theme/www/blank-master.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/b-responsive-theme/www/blank-master.tcl 25 Apr 2018 19:47:46 -0000 1.3 +++ openacs-4/packages/b-responsive-theme/www/blank-master.tcl 9 May 2018 15:33:29 -0000 1.4 @@ -100,7 +100,7 @@ if { [llength $css] == 2 && [llength [lindex $css 0]] == 1 } { template::head::add_css -href [lindex $css 0] -media [lindex $css 1] } else { - set params {} + set params [list] foreach param $css { lappend params -[lindex $param 0] [lindex $param 1] } @@ -172,7 +172,7 @@ # we are using TinyMCE template::head::add_javascript -src "/resources/acs-templating/tinymce/jscripts/tiny_mce/tiny_mce_src.js" -order tinymce0 # get the textareas where we apply tinymce - set tinymce_elements {} + set tinymce_elements [list] foreach htmlarea_id [lsort -unique $::acs_blank_master__htmlareas] { lappend tinymce_elements $htmlarea_id } Index: openacs-4/packages/bug-tracker/tcl/bug-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/tcl/bug-procs.tcl,v diff -u -N -r1.41 -r1.42 --- openacs-4/packages/bug-tracker/tcl/bug-procs.tcl 30 Apr 2018 09:40:53 -0000 1.41 +++ openacs-4/packages/bug-tracker/tcl/bug-procs.tcl 9 May 2018 15:33:29 -0000 1.42 @@ -262,7 +262,7 @@ } { upvar $array row - array set assignments {} + array set assignments [list] set role_prefix "role_" foreach name [array names row "${role_prefix}*"] { @@ -710,7 +710,7 @@ } # Build up the details list - set details_list {} + set details_list [list] foreach field $fields { lappend details_list $label($field) $value($field) } @@ -824,7 +824,7 @@ } } - set category_defaults {} + set category_defaults [list] foreach { parent_id parent_heading } [bug_tracker::category_types] { @@ -1048,7 +1048,7 @@ fixed_in_version_name } - set category_defaults {} + set category_defaults [list] foreach { parent_id parent_heading } [bug_tracker::category_types] { lappend category_defaults $parent_id {} @@ -1115,7 +1115,7 @@ bug_tracker::bug::get_list -ulevel 2 bug_tracker::bug::get_multirow - set filter_bug_numbers {} + set filter_bug_numbers [list] template::multirow foreach bugs { lappend filter_bug_numbers $bug_number } Index: openacs-4/packages/bug-tracker/tcl/bug-tracker-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/tcl/bug-tracker-procs.tcl,v diff -u -N -r1.57 -r1.58 --- openacs-4/packages/bug-tracker/tcl/bug-tracker-procs.tcl 30 Apr 2018 12:45:00 -0000 1.57 +++ openacs-4/packages/bug-tracker/tcl/bug-tracker-procs.tcl 9 May 2018 15:33:29 -0000 1.58 @@ -331,7 +331,7 @@ set workflow_id [bug_tracker::bug::get_instance_workflow_id -package_id $package_id] set state_ids [workflow::fsm::get_states -workflow_id $workflow_id] - set option_list {} + set option_list [list] foreach state_id $state_ids { workflow::state::fsm::get -state_id $state_id -array state lappend option_list [list "$state(pretty_name)" $state(short_name)] @@ -469,8 +469,8 @@ @return Returns the category types for this instance as an array-list of { parent_id1 heading1 parent_id2 heading2 ... } } { - array set heading {} - set parent_ids {} + array set heading [list] + set parent_ids [list] set last_parent_id {} foreach elm [get_keywords -package_id $package_id] { @@ -483,7 +483,7 @@ } } - set result {} + set result [list] foreach parent_id $parent_ids { lappend result $parent_id $heading($parent_id) } @@ -532,7 +532,7 @@ @param parent_id The category type's keyword_id @return options-list for a select widget for the given category type } { - set options {} + set options [list] foreach elm [get_keywords -package_id $package_id] { lassign $elm elm_child_id elm_child_heading elm_parent_id @@ -1146,7 +1146,7 @@ Return a list of lists with the bug number in the first element and the bug summary in the second. } { - set bug_list {} + set bug_list [list] set package_id [ad_conn package_id] if { $only_open_p } { @@ -1176,7 +1176,7 @@ {-write_or_submitter_p:required} } { set bug_list [get_mapped_bugs -patch_number $patch_number] - set bug_link_list {} + set bug_link_list [list] if { [llength $bug_list] == 0} { return "" @@ -1210,7 +1210,7 @@ {-bug_id:required} {-show_patch_status open} } { - set patch_list {} + set patch_list [list] switch -- $show_patch_status { open { @@ -1451,7 +1451,7 @@ ad_proc bug_tracker::get_related_files_links { {-bug_id:required} } { - set related_files_list {} + set related_files_list [list] set user_id [ad_conn user_id] set admin_p [permission::permission_p \ -party_id $user_id \ @@ -1502,7 +1502,7 @@ ad_proc bug_tracker::get_related_files_links { {-bug_id:required} } { - set related_files_list {} + set related_files_list [list] set user_id [ad_conn user_id] set admin_p [permission::permission_p \ -party_id $user_id \ Index: openacs-4/packages/bug-tracker/tcl/bug-tracker-scheduled-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/tcl/bug-tracker-scheduled-procs.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/bug-tracker/tcl/bug-tracker-scheduled-procs.tcl 25 Apr 2018 19:47:46 -0000 1.5 +++ openacs-4/packages/bug-tracker/tcl/bug-tracker-scheduled-procs.tcl 9 May 2018 15:33:29 -0000 1.6 @@ -32,7 +32,7 @@ workflow::action::get -action_id $enabled_action(action_id) -array available_action if {$available_action(short_name) eq "resolve"} { set action_id $enabled_action(action_id) - array set row {} + array set row [list] foreach field [workflow::action::get_element -action_id $action_id -element edit_fields] { set row($field) "" } @@ -52,7 +52,7 @@ workflow::action::get -action_id $enabled_action(action_id) -array available_action if {$available_action(short_name) eq "close"} { set action_id $enabled_action(action_id) - array set row {} + array set row [list] foreach field [workflow::action::get_element -action_id $action_id -element edit_fields] { set row($field) "" } Index: openacs-4/packages/bug-tracker/www/bug.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/www/bug.tcl,v diff -u -N -r1.56 -r1.57 --- openacs-4/packages/bug-tracker/www/bug.tcl 26 Apr 2018 08:56:37 -0000 1.56 +++ openacs-4/packages/bug-tracker/www/bug.tcl 9 May 2018 15:33:29 -0000 1.57 @@ -98,7 +98,7 @@ ns_log Notice "actions: enabled_action_id: '${enabled_action_id}'" # Buttons -set actions {} +set actions [list] if { $enabled_action_id eq "" } { #ns_log Notice "actions: case_id: $case_id" @@ -232,7 +232,7 @@ } # TODO: Export filters -set filters {} +set filters [list] foreach name [bug_tracker::get_export_variables] { if { [info exists $name] } { lappend filters [list "${name}:text(hidden),optional" [list value [set $name]]] @@ -258,7 +258,7 @@ # on_submit block ad_form -extend -name bug -on_submit { - array set row {} + array set row [list] if { $enabled_action_id ne "" } { foreach field [workflow::action::get_element -action_id $action_id -element edit_fields] { Index: openacs-4/packages/bug-tracker/www/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/www/index.tcl,v diff -u -N -r1.23 -r1.24 --- openacs-4/packages/bug-tracker/www/index.tcl 26 Apr 2018 08:56:37 -0000 1.23 +++ openacs-4/packages/bug-tracker/www/index.tcl 9 May 2018 15:33:29 -0000 1.24 @@ -7,7 +7,7 @@ } [bug_tracker::get_page_variables] set page_title [ad_conn instance_name] -set context {} +set context [list] set admin_p [permission::permission_p -object_id [ad_conn package_id] -privilege admin] set user_id [ad_conn user_id] bug_tracker::get_pretty_names -array pretty_names Index: openacs-4/packages/bug-tracker/www/related-file-add.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/www/related-file-add.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/bug-tracker/www/related-file-add.tcl 25 Apr 2018 19:47:46 -0000 1.5 +++ openacs-4/packages/bug-tracker/www/related-file-add.tcl 9 May 2018 15:33:29 -0000 1.6 @@ -82,7 +82,7 @@ workflow::action::get -action_id $enabled_action(action_id) -array available_action if {$available_action(short_name) eq "comment"} { set action_id $enabled_action(action_id) - array set row {} + array set row [list] foreach field [workflow::action::get_element -action_id $action_id -element edit_fields] { set row($field) "" } Index: openacs-4/packages/bug-tracker/www/related-file-delete.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/www/related-file-delete.tcl,v diff -u -N -r1.6 -r1.7 --- openacs-4/packages/bug-tracker/www/related-file-delete.tcl 25 Apr 2018 19:47:46 -0000 1.6 +++ openacs-4/packages/bug-tracker/www/related-file-delete.tcl 9 May 2018 15:33:29 -0000 1.7 @@ -66,7 +66,7 @@ workflow::action::get -action_id $enabled_action(action_id) -array available_action if {$available_action(short_name) eq "comment"} { set action_id $enabled_action(action_id) - array set row {} + array set row [list] foreach field [workflow::action::get_element -action_id $action_id -element edit_fields] { set row($field) "" } Index: openacs-4/packages/bug-tracker/www/related-file-update.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/www/related-file-update.tcl,v diff -u -N -r1.6 -r1.7 --- openacs-4/packages/bug-tracker/www/related-file-update.tcl 25 Apr 2018 19:47:46 -0000 1.6 +++ openacs-4/packages/bug-tracker/www/related-file-update.tcl 9 May 2018 15:33:29 -0000 1.7 @@ -87,7 +87,7 @@ workflow::action::get -action_id $enabled_action(action_id) -array available_action if {$available_action(short_name) eq "comment"} { set action_id $enabled_action(action_id) - array set row {} + array set row [list] foreach field [workflow::action::get_element -action_id $action_id -element edit_fields] { set row($field) "" } Index: openacs-4/packages/bug-tracker/www/admin/category-defaults.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/www/admin/category-defaults.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/bug-tracker/www/admin/category-defaults.tcl 26 Apr 2018 08:56:37 -0000 1.4 +++ openacs-4/packages/bug-tracker/www/admin/category-defaults.tcl 9 May 2018 15:33:29 -0000 1.5 @@ -8,7 +8,7 @@ array set default_configs [bug_tracker::get_default_configurations] -set options {} +set options [list] foreach name [lsort -ascii [array names default_configs]] { lappend options [list $name $name] Index: openacs-4/packages/bug-tracker/www/admin/initial-setup.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/www/admin/initial-setup.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/bug-tracker/www/admin/initial-setup.tcl 26 Apr 2018 08:56:37 -0000 1.4 +++ openacs-4/packages/bug-tracker/www/admin/initial-setup.tcl 9 May 2018 15:33:29 -0000 1.5 @@ -8,7 +8,7 @@ array set default_configs [bug_tracker::get_default_configurations] -set options {} +set options [list] foreach name [lsort -ascii [array names default_configs]] { lappend options [list $name $name] Index: openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl,v diff -u -N -r1.17 -r1.18 --- openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl 25 Apr 2018 19:47:46 -0000 1.17 +++ openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl 9 May 2018 15:33:29 -0000 1.18 @@ -194,7 +194,7 @@ # for strings of the format {column_name} in the subject # and message and replace them with the value of that # column as returned by the query - set pairs {} + set pairs [list] for {set i 0} {$i < [ns_set size $recipient]} {incr i} { lappend pairs [list \{[ns_set key $recipient $i]\} [ns_set value $recipient $i]] } Index: openacs-4/packages/calendar/tcl/cal-item-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/calendar/tcl/cal-item-procs.tcl,v diff -u -N -r1.32 -r1.33 --- openacs-4/packages/calendar/tcl/cal-item-procs.tcl 30 Apr 2018 13:54:38 -0000 1.32 +++ openacs-4/packages/calendar/tcl/cal-item-procs.tcl 9 May 2018 15:33:29 -0000 1.33 @@ -271,7 +271,7 @@ db_exec_plsql update_interval {} # Update the item_type_id and calendar_id - set colspecs {} + set colspecs [list] lappend colspecs "item_type_id = :item_type_id" if { $calendar_id ne "" } { lappend colspecs "on_which_calendar = :calendar_id" @@ -355,7 +355,7 @@ -cal_item_id $event_id \ -array orig_event - set colspecs {} + set colspecs [list] foreach col {name description} { if {$orig_event($col) ne [set $col]} { lappend colspecs "$col = :$col" @@ -364,7 +364,7 @@ if {[llength $colspecs]} { db_dml recurrence_events_update {} } - set colspecs {} + set colspecs [list] lappend colspecs {item_type_id = :item_type_id} if { $calendar_id ne "" } { lappend colspecs {on_which_calendar = :calendar_id} Index: openacs-4/packages/calendar/www/admin/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/calendar/www/admin/index.tcl,v diff -u -N -r1.10 -r1.11 --- openacs-4/packages/calendar/www/admin/index.tcl 26 Apr 2018 08:56:37 -0000 1.10 +++ openacs-4/packages/calendar/www/admin/index.tcl 9 May 2018 15:33:29 -0000 1.11 @@ -13,7 +13,7 @@ set package_id [ad_conn package_id] set page_title [_ calendar.lt_Calendar_Administrati] -set context {} +set context [list] db_multirow calendars select_calendars { select c.calendar_name, Index: openacs-4/packages/cards-portlet/www/cards-portlet.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/cards-portlet/www/cards-portlet.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/cards-portlet/www/cards-portlet.tcl 26 Apr 2018 08:56:37 -0000 1.2 +++ openacs-4/packages/cards-portlet/www/cards-portlet.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -31,7 +31,7 @@ set user_id [ad_conn user_id] set sep_package_ids [join $list_of_package_ids ", "] if {[llength $list_of_package_ids] == 1} { set single_p "t"} else {set single_p "f"} -set context {} +set context [list] set shaded_p $config(shaded_p) set cards_url "[ad_conn package_url]/cards/cards" set community_id [dotlrn_community::get_community_id] Index: openacs-4/packages/categories/tcl/categories-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/categories/tcl/categories-procs.tcl,v diff -u -N -r1.32 -r1.33 --- openacs-4/packages/categories/tcl/categories-procs.tcl 25 Apr 2018 19:47:46 -0000 1.32 +++ openacs-4/packages/categories/tcl/categories-procs.tcl 9 May 2018 15:33:30 -0000 1.33 @@ -379,7 +379,7 @@ @return list of names corresponding to the list of category_id's supplied. @author Timo Hentschel (timo@timohentschel.de) } { - set result {} + set result [list] foreach category_id $category_ids { lappend result [category::get_name $category_id $locale] } Index: openacs-4/packages/categories/tcl/category-trees-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/categories/tcl/category-trees-procs.tcl,v diff -u -N -r1.28 -r1.29 --- openacs-4/packages/categories/tcl/category-trees-procs.tcl 25 Apr 2018 19:47:46 -0000 1.28 +++ openacs-4/packages/categories/tcl/category-trees-procs.tcl 9 May 2018 15:33:30 -0000 1.29 @@ -32,7 +32,7 @@ returns the main categories of a given tree } { set locale [ad_conn locale] - set result {} + set result [list] set categories [db_list get_categories ""] foreach category_id $categories { lappend result $category_id @@ -223,7 +223,7 @@ assign_single_p require_category_p @author Timo Hentschel (timo@timohentschel.de) } { - set result {} + set result [list] db_foreach get_mapped_trees "" { lappend result [list $tree_id [get_name $tree_id $locale] $subtree_category_id $assign_single_p $require_category_p $widget] @@ -238,7 +238,7 @@ @return Tcl list of tree_ids @author Peter Kreuzinger (peter.kreuzinger@wu-wien.ac.at) } { - set result {} + set result [list] db_foreach get_trees "" { lappend result $tree_id @@ -272,7 +272,7 @@ assign_single_p require_category_p widget @author Jade Rubick (jader@bread.com) } { - set result {} + set result [list] db_foreach get_mapped_trees_from_object_list "" { lappend result [list $tree_id [get_name $tree_id $locale] $subtree_category_id $assign_single_p $require_category_p $widget] @@ -347,16 +347,16 @@ catch {nsv_unset category_trees} set tree_id_old 0 set cur_level 1 - set stack {} + set stack [list] set invalid_p "" - set tree {} + set tree [list] db_foreach reset_cache "" { if {$tree_id != $tree_id_old && $tree_id_old != 0} { nsv_set category_trees $tree_id_old $tree set cur_level 1 - set stack {} + set stack [list] set invalid_p "" - set tree {} + set tree [list] } set tree_id_old $tree_id lappend tree [list $category_id [ad_decode "$invalid_p$deprecated_p" "" f t] $cur_level] @@ -386,9 +386,9 @@ @author Timo Hentschel (timo@timohentschel.de) } { set cur_level 1 - set stack {} + set stack [list] set invalid_p "" - set tree {} + set tree [list] db_foreach flush_cache "" { lappend tree [list $category_id [ad_decode "$invalid_p$deprecated_p" "" f t] $cur_level] if { $right_ind - $left_ind > 1} { @@ -574,7 +574,7 @@ && [llength $category_counts] > 1} { array set counts $category_counts } else { - array set counts {} + array set counts [list] } # If we should append, then don't create the datasource if it already exists @@ -611,12 +611,12 @@ # given level set size [template::multirow size $datasource] - set rollup {} + set rollup [list] for {set i $size} {$i > 0} {incr i -1} { set level [template::multirow get $datasource $i level] set count [template::multirow get $datasource $i count] set j 1 - set nrollup {} + set nrollup [list] foreach r $rollup { if {$j < $level} { lappend nrollup [expr {$r + $count}] Index: openacs-4/packages/categories/tcl/widget-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/categories/tcl/widget-procs.tcl,v diff -u -N -r1.27 -r1.28 --- openacs-4/packages/categories/tcl/widget-procs.tcl 1 May 2018 09:06:57 -0000 1.27 +++ openacs-4/packages/categories/tcl/widget-procs.tcl 9 May 2018 15:33:30 -0000 1.28 @@ -104,7 +104,7 @@ set mapped_categories [ns_querygetall $element(id)] # QUIRK: ns_querygetall returns a single-element list {{}} for no values if { [string equal $mapped_categories {{}}] } { - set mapped_categories {} + set mapped_categories [list] } } set output {} @@ -135,7 +135,7 @@ foreach mapped_tree $mapped_trees { lassign $mapped_tree tree_id tree_name subtree_id assign_single_p require_category_p widget set tree_name [ns_quotehtml [lang::util::localize $tree_name]] - set one_tree {} + set one_tree [list] if { $require_category_p == "t" } { set required_mark "*" @@ -196,7 +196,7 @@ # author: Timo Hentschel (timo@timohentschel.de) upvar 2 $message_ref message $value_ref values - set invalid_values {} + set invalid_values [list] foreach value $values { if {![regexp {^[+-]?\d+$} $value]} { @@ -225,7 +225,7 @@ # QUIRK: ns_querygetall returns a single-element list {{}} for no values if { [string equal $values {{}}] } { - set values {} + set values [list] } # to mark submission of form for rendering element in case of invalid data @@ -262,7 +262,7 @@ } if { $tree_id eq "" } { - set trees {} + set trees [list] foreach tree [category_tree::get_mapped_trees $package_id] { lassign $tree tree_id tree_name subtree_id assign_single_p require_category_p if {$require_category_p == "t" || ![info exists element(optional)]} { @@ -273,11 +273,11 @@ if {$require_category_p == "t"} { set trees [list [list $tree_id $subtree_id]] } else { - set trees {} + set trees [list] } } - set trees_without_category {} + set trees_without_category [list] foreach tree $trees { lassign $tree tree_id subtree_id # get categories of every tree requiring a categorization Index: openacs-4/packages/categories/www/cadmin/tree-order-update.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/categories/www/cadmin/tree-order-update.tcl,v diff -u -N -r1.11 -r1.12 --- openacs-4/packages/categories/www/cadmin/tree-order-update.tcl 8 May 2018 16:21:26 -0000 1.11 +++ openacs-4/packages/categories/www/cadmin/tree-order-update.tcl 9 May 2018 15:33:30 -0000 1.12 @@ -34,8 +34,8 @@ set last_ind [expr {($count / 5) + 1}] set count 1 - set stack {} - set done_list {} + set stack [list] + set done_list [list] # put toplevel categories on stack if {[info exists child(-1)]} { set stack [lsort -integer -index 0 $child(-1)] Index: openacs-4/packages/categories/www/cadmin/tree-view.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/categories/www/cadmin/tree-view.tcl,v diff -u -N -r1.21 -r1.22 --- openacs-4/packages/categories/www/cadmin/tree-view.tcl 26 Apr 2018 08:56:37 -0000 1.21 +++ openacs-4/packages/categories/www/cadmin/tree-view.tcl 9 May 2018 15:33:30 -0000 1.22 @@ -75,7 +75,7 @@ } } -set elements {} +set elements [list] if { $can_write_p } { lappend elements edit { @@ -130,8 +130,8 @@ } } -set actions {} -set bulk_actions {} +set actions [list] +set bulk_actions [list] if { $can_write_p } { set bulk_actions { "#categories.Delete#" "category-delete" "#categories.Delete_category_link_title#" Index: openacs-4/packages/chat/tcl/chat-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/chat/tcl/chat-procs.tcl,v diff -u -N -r1.17 -r1.18 --- openacs-4/packages/chat/tcl/chat-procs.tcl 30 Apr 2018 12:45:00 -0000 1.17 +++ openacs-4/packages/chat/tcl/chat-procs.tcl 9 May 2018 15:33:30 -0000 1.18 @@ -631,7 +631,7 @@ # do we have to create a transcript for the room if { $room_info(auto_transcript_p) == "t" } { # build a list of all messages - set contents {} + set contents [list] foreach message [db_list_of_lists get_archives_messages {}] { lassign $message msg creation_user creation_date set user_name [expr {$creation_user > 0 ? [chat_user_name $creation_user] : "system"}] Index: openacs-4/packages/chat/www/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/chat/www/index.tcl,v diff -u -N -r1.15 -r1.16 --- openacs-4/packages/chat/www/index.tcl 26 Apr 2018 08:56:37 -0000 1.15 +++ openacs-4/packages/chat/www/index.tcl 9 May 2018 15:33:30 -0000 1.16 @@ -16,7 +16,7 @@ set package_id [ad_conn package_id] set user_id [ad_conn user_id] -set actions {} +set actions [list] set room_create_p [permission::permission_p -object_id $package_id -privilege chat_room_create] set default_client [parameter::get -parameter "DefaultClient" -default "ajax"] set warning "" Index: openacs-4/packages/chat-includelet/lib/chat-includelet.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/chat-includelet/lib/chat-includelet.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/chat-includelet/lib/chat-includelet.tcl 26 Apr 2018 08:56:37 -0000 1.2 +++ openacs-4/packages/chat-includelet/lib/chat-includelet.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -1,6 +1,6 @@ set chat_url "[ad_conn package_url]/chat/" -set context {} +set context [list] set user_id [ad_conn user_id] set room_create_p [ad_permission_p $user_id chat_room_create] set default_mode [ad_parameter DefaultClient chat "ajax"] Index: openacs-4/packages/clickthrough/www/admin/report.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/clickthrough/www/admin/report.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/clickthrough/www/admin/report.tcl 26 Apr 2018 08:56:38 -0000 1.3 +++ openacs-4/packages/clickthrough/www/admin/report.tcl 9 May 2018 15:33:30 -0000 1.4 @@ -18,6 +18,6 @@ set package_name [clickthrough_parent_package_instance_name] -set context {} +set context [list] ad_return_template Index: openacs-4/packages/cms/tcl/browser-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/cms/tcl/browser-procs.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/cms/tcl/browser-procs.tcl 25 Apr 2018 19:47:46 -0000 1.5 +++ openacs-4/packages/cms/tcl/browser-procs.tcl 9 May 2018 15:33:30 -0000 1.6 @@ -24,7 +24,7 @@ } { - set state {} + set state [list] foreach mount_point [buildMountPoints $user_id] { lappend state [stateNodeCreate [folderAccess mount_point $mount_point] [list]] } @@ -44,7 +44,7 @@ } { - set new_children {} + set new_children [list] upvar $stateRef state foreach child $children { @@ -89,7 +89,7 @@ collapse { # Collapse: empty the children list ns_log debug "updateTreeStateChildren: COLLAPSING: [folderPath $user_id $mount_point $target_id]" - set child_children {} + set child_children [list] } expand { @@ -172,7 +172,7 @@ } # Merge the new children, preserving the sorted order - set child_children {} + set child_children [list] foreach new_child $folder_children { set old_child_id [stateNodeAccess id $new_child] # If the old child exists, use it instead of the new one @@ -222,7 +222,7 @@ # Reference the state upvar $stateRef state - set folderList {} + set folderList [list] foreach node $state { @@ -366,7 +366,7 @@ the folders in the process } { - set child_ids {} + set child_ids [list] foreach subfolder $subfolder_list { if { ![template::util::is_nil user_id] } { cacheOneFolder $user_id $subfolder 1 Index: openacs-4/packages/cms/tcl/clipboard-ui-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/cms/tcl/clipboard-ui-procs.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/cms/tcl/clipboard-ui-procs.tcl 25 Apr 2018 19:47:46 -0000 1.4 +++ openacs-4/packages/cms/tcl/clipboard-ui-procs.tcl 9 May 2018 15:33:30 -0000 1.5 @@ -24,7 +24,7 @@ set elements $opts(elements) unset opts(elements) } else { - set elements {} + set elements [list] } set v_args [template::util::list_opts] @@ -72,7 +72,7 @@ # Set defaults set row(html) "" set row(hidden) "" - set row(elements) {} + set row(elements) [list] # Create the checkbox set element_code [list check -datatype text -widget checkbox \ @@ -214,7 +214,7 @@ return } - set header {} + set header [list] foreach element_name $row(elements) { upvar "${form_name}:${element_name}_${row_index}" element if { ![string equal $element(widget) hidden] } { Index: openacs-4/packages/cms/tcl/form-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/cms/tcl/form-procs.tcl,v diff -u -N -r1.31 -r1.32 --- openacs-4/packages/cms/tcl/form-procs.tcl 25 Apr 2018 19:47:46 -0000 1.31 +++ openacs-4/packages/cms/tcl/form-procs.tcl 9 May 2018 15:33:30 -0000 1.32 @@ -57,8 +57,8 @@ upvar content_type content_type upvar opts opts - set code_params {} - set html_params {} + set code_params [list] + set html_params [list] # Process the results of the query. for { set i $start_row } { $i <= $rowcount } { incr i } { @@ -207,8 +207,8 @@ set last_attribute_name "" set new_section_p 1 - set code_params {} - set html_params {} + set code_params [list] + set html_params [list] # Perform a gigantic query to retrieve all metadata query_form_metadata @@ -250,8 +250,8 @@ ns_log debug "content::get_revision_form: type_label: $last_type" eval $form_element - set code_params {} - set html_params {} + set code_params [list] + set html_params [list] } @@ -396,8 +396,8 @@ if { $i != 1 } { content::process_revision_form_dml } - set columns {} - set values {} + set columns [list] + set values [list] } # fetch the value of the attribute from the form @@ -493,8 +493,8 @@ if { $i != 1 } { content::process_insert_statement } - set columns {} - set values {} + set columns [list] + set values [list] } # fetch the value of the attribute from the form @@ -552,7 +552,7 @@ Assemble a passthrough list out of variables } { - set result {} + set result [list] foreach varname $args { upvar $varname var lappend result [list $varname $var] @@ -783,9 +783,9 @@ # initialize the column and value list set columns [list item_id revision_id creation_user creation_ip] set values [list :item_id :revision_id null null] - set default_columns {} - set default_values {} - set missing_columns {} + set default_columns [list] + set default_values [list] + set missing_columns [list] # query for attribute names and datatypes foreach attribute [get_attributes $content_type attribute_name datatype default_value ancestor] { @@ -1344,7 +1344,7 @@ set attribute_data [eval get_type_attribute_params [array names type_lookup]] - set attribute_names {} + set attribute_names [list] array set attributes_by_type $attribute_data foreach row $attribute_list { @@ -1754,8 +1754,8 @@ # Assemble the list of columns to query, handling dates # correctly - set columns {} - set attr_types {} + set columns [list] + set attr_types [list] foreach attr $attributes { if { [template::element exists $form_name "$prefix$attr"] } { set datatype [template::element get_property $form_name "$prefix$attr" datatype] Index: openacs-4/packages/cms/tcl/module-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/cms/tcl/module-procs.tcl,v diff -u -N -r1.11 -r1.12 --- openacs-4/packages/cms/tcl/module-procs.tcl 25 Apr 2018 19:47:46 -0000 1.11 +++ openacs-4/packages/cms/tcl/module-procs.tcl 9 May 2018 15:33:30 -0000 1.12 @@ -192,7 +192,7 @@ } { - set children {} + set children [list] if { [string equal $id {}] } { set id [getRootFolderID [ad_conn package_id]] @@ -222,7 +222,7 @@ } { - set children {} + set children [list] if { [string equal $id {}] } { set where_clause "k.parent_id is null" @@ -307,7 +307,7 @@ return [list] } - set children {} + set children [list] set module_name [namespace tail [namespace current]] Index: openacs-4/packages/cms/www/doc/dev-guide.html =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/cms/www/doc/dev-guide.html,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/cms/www/doc/dev-guide.html 25 Apr 2018 19:47:46 -0000 1.2 +++ openacs-4/packages/cms/www/doc/dev-guide.html 9 May 2018 15:33:30 -0000 1.3 @@ -1903,7 +1903,7 @@ 1 2 3 4 % set factor 3 3 - % set b {} + % set b [list] % list_map $a {lappend b [expr $list_item * $factor]} % set b 3 6 9 12 Index: openacs-4/packages/cms/www/doc/xml/uplevels-namespaces.xml =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/cms/www/doc/xml/uplevels-namespaces.xml,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/cms/www/doc/xml/uplevels-namespaces.xml 25 Apr 2018 19:47:46 -0000 1.2 +++ openacs-4/packages/cms/www/doc/xml/uplevels-namespaces.xml 9 May 2018 15:33:30 -0000 1.3 @@ -964,7 +964,7 @@ 1 2 3 4 % set factor 3 3 -% set b {} +% set b [list] % list_map $a {lappend b [expr $list_item * $factor]} % set b 3 6 9 12 Index: openacs-4/packages/cms/www/modules/items/publish-status.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/cms/www/modules/items/publish-status.tcl,v diff -u -N -r1.10 -r1.11 --- openacs-4/packages/cms/www/modules/items/publish-status.tcl 26 Apr 2018 08:56:38 -0000 1.10 +++ openacs-4/packages/cms/www/modules/items/publish-status.tcl 9 May 2018 15:33:30 -0000 1.11 @@ -20,7 +20,7 @@ # Build a sentence describing the publishing status -set actions {} +set actions [list] switch $info(publish_status) { Index: openacs-4/packages/cms/www/modules/sitemap/delete-items.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/cms/www/modules/sitemap/delete-items.tcl,v diff -u -N -r1.9 -r1.10 --- openacs-4/packages/cms/www/modules/sitemap/delete-items.tcl 25 Apr 2018 19:47:46 -0000 1.9 +++ openacs-4/packages/cms/www/modules/sitemap/delete-items.tcl 9 May 2018 15:33:30 -0000 1.10 @@ -69,7 +69,7 @@ db_transaction { - set parents {} + set parents [list] foreach del_item_id $deleted_items { set is_symlink [element get_values delete "is_symlink_$del_item_id"] set is_folder [element get_values delete "is_folder_$del_item_id"] Index: openacs-4/packages/cms/www/modules/users/user-search.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/cms/www/modules/users/user-search.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/cms/www/modules/users/user-search.tcl 25 Apr 2018 19:47:46 -0000 1.5 +++ openacs-4/packages/cms/www/modules/users/user-search.tcl 9 May 2018 15:33:30 -0000 1.6 @@ -54,7 +54,7 @@ set extra_url [content::url_passthrough $passthrough] - set clauses {} + set clauses [list] set search_in [element get_values user_search search_in] set keyword [string tolower "%$keyword%"] Index: openacs-4/packages/connections/tcl/connections-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/connections/tcl/connections-procs.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/connections/tcl/connections-procs.tcl 26 Apr 2018 08:56:38 -0000 1.2 +++ openacs-4/packages/connections/tcl/connections-procs.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -69,7 +69,7 @@ set category_ids [category::get_mapped_categories -tree_id $tree_id $object_id] # generate the list of connection keywords with the appropriate links for display - set connections {} + set connections [list] set preurl [connections::get_url] foreach id $category_ids { Index: openacs-4/packages/connections/www/xmlhttp/getlatestobj.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/connections/www/xmlhttp/getlatestobj.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/connections/www/xmlhttp/getlatestobj.tcl 26 Apr 2018 08:56:38 -0000 1.2 +++ openacs-4/packages/connections/www/xmlhttp/getlatestobj.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -12,7 +12,7 @@ db_multirow objectlist "getobjects" "select a.object_id, b.title, a.category_id, b.object_type, c.pretty_name from category_object_map a, acs_objects b, acs_object_types c where a.object_id=b.object_id and b.object_type=c.object_type and a.category_id=:category_id" { } -set objlist {} +set objlist [list] template::multirow foreach objectlist { lappend objlist "$title ($pretty_name)" Index: openacs-4/packages/contacts/lib/contacts-master.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/lib/contacts-master.tcl,v diff -u -N -r1.18 -r1.19 --- openacs-4/packages/contacts/lib/contacts-master.tcl 25 Apr 2018 19:47:46 -0000 1.18 +++ openacs-4/packages/contacts/lib/contacts-master.tcl 9 May 2018 15:33:30 -0000 1.19 @@ -98,7 +98,7 @@ if { ![exists_and_not_null title] } { set title [ad_conn instance_name] - set context {} + set context [list] } else { set context [list $title] } Index: openacs-4/packages/contacts/lib/contacts.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/lib/contacts.tcl,v diff -u -N -r1.75 -r1.76 --- openacs-4/packages/contacts/lib/contacts.tcl 26 Apr 2018 08:56:38 -0000 1.75 +++ openacs-4/packages/contacts/lib/contacts.tcl 9 May 2018 15:33:30 -0000 1.76 @@ -1,7 +1,7 @@ -set required_param_list {} +set required_param_list [list] set optional_param_list [list base_url extend_p extend_values attr_val_name] set default_param_list [list orderby format query page page_size package_id search_id group_id] -set optional_unset_list {} +set optional_unset_list [list] # default values for default params set _orderby "first_names,asc" @@ -110,7 +110,7 @@ # We clear the list when no value is submited, otherwise # we acumulate the extend values. if { [empty_string_p $extend_option] } { - set extend_values {} + set extend_values [list] } else { lappend extend_values [list $extend_option] } @@ -149,7 +149,7 @@ } callback contacts::bulk_actions -multirow "bulk_acts" -set bulk_actions {} +set bulk_actions [list] template::multirow foreach bulk_acts { lappend bulk_actions $pretty $link $detailed } @@ -288,7 +288,7 @@ } -set elements {} +set elements [list] lappend elements contact [list \ label {$name_label} \ display_template { @@ -360,7 +360,7 @@ set date_format [lc_get formbuilder_date_format] -set actions {} +set actions [list] if { $admin_p && [exists_and_not_null search_id] } { set actions [list "[_ contacts.Set_default_extend]" "admin/ext-search-options?search_id=$search_id" "[_ contacts.Set_default_extend]" ] } @@ -379,17 +379,17 @@ -object_type $actual_object_type -set add_columns {} -set remove_columns {} -set db_extend_columns {} +set add_columns [list] +set remove_columns [list] +set db_extend_columns [list] if { $search_id ne "" } { # now we get the extensions for this specific search set db_extend_columns [contact::search::get_extensions -search_id $search_id] } set combined_extended_columns [lsort -unique [concat $db_extend_columns $extended_columns]] # we run through the multirow here to determine wether or not the columns are allowed -set report_elements {} +set report_elements [list] template::multirow foreach ext { set selected_p 0 set immutable_p 0 @@ -546,7 +546,7 @@ } - set party_ids {} + set party_ids [list] db_multirow contacts report_contacts_select {} { lappend party_ids $party_id } @@ -597,9 +597,9 @@ eval $command - set keys {} + set keys [list] template::multirow foreach contacts { - set key {} + set key [list] foreach {element details} $report_elements { if { $element ne "party_id" } { lappend key [set $element] Index: openacs-4/packages/contacts/lib/email-search.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/lib/email-search.tcl,v diff -u -N -r1.9 -r1.10 --- openacs-4/packages/contacts/lib/email-search.tcl 26 Apr 2018 08:56:38 -0000 1.9 +++ openacs-4/packages/contacts/lib/email-search.tcl 9 May 2018 15:33:30 -0000 1.10 @@ -107,7 +107,7 @@ set tracking_p [apm_package_installed_p "mail-tracking"] if { [exists_and_not_null file_ids] } { - set files {} + set files [list] foreach file $file_ids { set file_item_id [content::revision::item_id -revision_id $file] if {$file_item_id eq ""} { @@ -139,7 +139,7 @@ # because if we put something like this {value $value} the value # of the variable is not interpreted - set element {} + set element [list] lappend element "${var}:text(hidden)" lappend element "value $var_value" @@ -277,9 +277,9 @@ set valid_party_ids [contact::search::results -search_id $search_id -package_id $package_id] } - set party_ids {} - set invalid_party_ids {} - set invalid_recipients {} + set party_ids [list] + set invalid_party_ids [list] + set invalid_recipients [list] foreach party_id $valid_party_ids { if { [party::email -party_id $party_id] eq "" } { # We are going to check if there is an employee relationship @@ -331,7 +331,7 @@ set attribute_id [attribute::id -object_type "person" -attribute_name "salutation"] # List to store know which emails received the message - set recipients_addr {} + set recipients_addr [list] set from [ad_conn user_id] set from_addr [contact::email -party_id $from] @@ -366,7 +366,7 @@ set date [lc_time_fmt [dt_sysdate] "%q"] - set values {} + set values [list] foreach element [list first_names last_name salutation name date username] { lappend values [list "{$element}" [set $element]] } Index: openacs-4/packages/contacts/lib/email.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/lib/email.tcl,v diff -u -N -r1.42 -r1.43 --- openacs-4/packages/contacts/lib/email.tcl 26 Apr 2018 08:56:38 -0000 1.42 +++ openacs-4/packages/contacts/lib/email.tcl 9 May 2018 15:33:30 -0000 1.43 @@ -28,7 +28,7 @@ # Somehow when the form is submited the party_ids values became # only one element of a list, this avoid that problem -set recipients {} +set recipients [list] foreach party_id $party_ids { if {![empty_string_p $party_id]} { lappend recipients [list "[contact::name -party_id $party_id] ([contact::message::email_address -party_id $party_id])" $party_id] @@ -122,7 +122,7 @@ set tracking_p [apm_package_installed_p "mail-tracking"] if { [exists_and_not_null file_ids] } { - set files {} + set files [list] foreach file $file_ids { set file_item_id [content::revision::item_id -revision_id $file] if {$file_item_id eq ""} { @@ -157,7 +157,7 @@ # because if we put something like this {value $value} the value # of the variable is not interpreted - set element {} + set element [list] lappend element "${var}:text(hidden)" lappend element "value $var_value" @@ -247,7 +247,7 @@ set attribute_id [attribute::id -object_type "person" -attribute_name "salutation"] # List to store know which emails received the message - set recipients_addr {} + set recipients_addr [list] set from [ad_conn user_id] set from_addr [contact::email -party_id $from] @@ -302,7 +302,7 @@ set username [db_string user "select username from users where user_id = :party_id" -default ""] set date [lc_time_fmt [dt_sysdate] "%q"] - set values {} + set values [list] foreach element [list first_names last_name salutation name date username] { lappend values [list "{$element}" [set $element]] } Index: openacs-4/packages/contacts/lib/envelope.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/lib/envelope.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/contacts/lib/envelope.tcl 25 Apr 2018 19:47:46 -0000 1.2 +++ openacs-4/packages/contacts/lib/envelope.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -53,7 +53,7 @@ -message_1 [_ contacts.lt_Generating_the_envelopes_] \ -message_2 [_ contacts.lt_Once_finished_you_get] - set envelopes {} + set envelopes [list] foreach party_id $party_ids { set name [contact::name -party_id $party_id] set mailing_address [contact::message::mailing_address -party_id $party_id -format "text/plain"] Index: openacs-4/packages/contacts/lib/label.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/lib/label.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/contacts/lib/label.tcl 25 Apr 2018 19:47:46 -0000 1.4 +++ openacs-4/packages/contacts/lib/label.tcl 9 May 2018 15:33:30 -0000 1.5 @@ -51,7 +51,7 @@ -message_1 [_ contacts.lt_Generating_the_labels_] \ -message_2 [_ contacts.lt_Once_finished_you_get] - set labels {} + set labels [list] foreach party_id $party_ids { set mailing_address [contact::message::mailing_address -party_id $party_id -format "text/plain" -with_name] Index: openacs-4/packages/contacts/lib/letter.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/lib/letter.tcl,v diff -u -N -r1.14 -r1.15 --- openacs-4/packages/contacts/lib/letter.tcl 26 Apr 2018 08:56:38 -0000 1.14 +++ openacs-4/packages/contacts/lib/letter.tcl 9 May 2018 15:33:30 -0000 1.15 @@ -132,7 +132,7 @@ set content_html "${content_html}\n\n${footer}" } - set messages {} + set messages [list] set date [join [template::util::date::get_property linear_date_no_time $date] "-"] if { $include_address eq "1" } { @@ -175,7 +175,7 @@ append letter "\n
$name
[contact::message::mailing_address -party_id $party_id -format "text/html"]
" } append letter "\n
${content_html}
" - set values {} + set values [list] foreach element [list first_names last_name name date salutation mailing_address directphone] { lappend values [list "{$element}" [set $element]] } Index: openacs-4/packages/contacts/lib/list-parties-add.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/lib/list-parties-add.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/contacts/lib/list-parties-add.tcl 26 Apr 2018 08:56:38 -0000 1.3 +++ openacs-4/packages/contacts/lib/list-parties-add.tcl 9 May 2018 15:33:30 -0000 1.4 @@ -23,7 +23,7 @@ } if { [exists_and_not_null party_id] } { - set party_ids {} + set party_ids [list] foreach party_id $party_id { lappend party_ids $party_id } @@ -47,7 +47,7 @@ set peeraddr [ad_conn peeraddr] set context [list $title] set package_id [ad_conn package_id] -set recipients {} +set recipients [list] foreach party_id $party_ids { lappend recipients "[contact::name -party_id $party_id]" } Index: openacs-4/packages/contacts/lib/list-parties-remove.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/lib/list-parties-remove.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/contacts/lib/list-parties-remove.tcl 26 Apr 2018 08:56:38 -0000 1.3 +++ openacs-4/packages/contacts/lib/list-parties-remove.tcl 9 May 2018 15:33:30 -0000 1.4 @@ -23,7 +23,7 @@ } if { [exists_and_not_null party_id] } { - set party_ids {} + set party_ids [list] foreach party_id $party_id { lappend party_ids $party_id } @@ -47,7 +47,7 @@ set peeraddr [ad_conn peeraddr] set context [list $title] set package_id [ad_conn package_id] -set recipients {} +set recipients [list] foreach party_id $party_ids { lappend recipients "[contact::name -party_id $party_id]" } Index: openacs-4/packages/contacts/lib/oo_mailing.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/lib/oo_mailing.tcl,v diff -u -N -r1.21 -r1.22 --- openacs-4/packages/contacts/lib/oo_mailing.tcl 26 Apr 2018 08:56:38 -0000 1.21 +++ openacs-4/packages/contacts/lib/oo_mailing.tcl 9 May 2018 15:33:30 -0000 1.22 @@ -196,7 +196,7 @@ set num_of_users [llength $party_ids] set seconds_to_finish [expr $num_of_users * $seconds_per_user] set package_id [ad_conn package_id] - set pdf_filenames {} + set pdf_filenames [list] set from [ad_conn user_id] set from_addr [contact::email -party_id $from] @@ -297,7 +297,7 @@ } set to_addr [contact::message::email_address -party_id $party_id] - set values {} + set values [list] foreach element [list first_names last_name name date salutation mailing_address directphone] { lappend values [list "{$element}" [set $element]] } Index: openacs-4/packages/contacts/lib/spouse-sync.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/lib/spouse-sync.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/contacts/lib/spouse-sync.tcl 25 Apr 2018 19:47:46 -0000 1.2 +++ openacs-4/packages/contacts/lib/spouse-sync.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -65,7 +65,7 @@ } - set options {} + set options [list] if { $party_value ne "" } { set attr${attribute_id}_value $party_value_id lappend options [list "$party_name:
$party_value

" $party_value_id] Index: openacs-4/packages/contacts/lib/werbemailing.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/lib/werbemailing.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/contacts/lib/werbemailing.tcl 26 Apr 2018 08:56:38 -0000 1.5 +++ openacs-4/packages/contacts/lib/werbemailing.tcl 9 May 2018 15:33:30 -0000 1.6 @@ -79,7 +79,7 @@ template::multirow create messages revision_id to_addr to_party_id subject content_body - set file_revisions {} + set file_revisions [list] # We need to set the original date here set orig_date $date @@ -162,7 +162,7 @@ set locale [lang::user::site_wide_locale -user_id $party_id] } - set values {} + set values [list] foreach element [list first_names last_name name date salutation mailing_address directphone] { lappend values [list "{$element}" [set $element]] } Index: openacs-4/packages/contacts/tcl/contact-employee-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/tcl/contact-employee-procs.tcl,v diff -u -N -r1.7 -r1.8 --- openacs-4/packages/contacts/tcl/contact-employee-procs.tcl 26 Apr 2018 08:56:38 -0000 1.7 +++ openacs-4/packages/contacts/tcl/contact-employee-procs.tcl 9 May 2018 15:33:30 -0000 1.8 @@ -112,7 +112,7 @@ set employee_rev_id [content::item::get_best_revision -item_id $employee_id] # Get employers, if any - set employers {} + set employers [list] set employers [contact::util::get_employers -employee_id $employee_id -package_id $package_id] # If employer(s) exist @@ -244,7 +244,7 @@ if {$phone == "" && [person::person_p -party_id $employee_id]} { # Get employers, if any - set employers {} + set employers [list] set employers [contact::util::get_employers -employee_id $employee_id -package_id $package_id] # If employer(s) exist @@ -336,7 +336,7 @@ get employees of an organization in a list of list suitable for inclusion in options the list is made up of employee_name and employee_id } { - set contact_list {} + set contact_list [list] db_foreach select_employee_ids { select CASE WHEN object_id_one = :organization_id THEN object_id_two @@ -379,7 +379,7 @@ @creation-date 2005-10-17 @return List of lists, each containing the ID and name of an employer, or an empty list if no employers exist. } { - set contact_list {} + set contact_list [list] db_foreach select_employer_ids { select CASE WHEN object_id_one = :employee_id THEN object_id_two Index: openacs-4/packages/contacts/tcl/contact-search-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/tcl/contact-search-procs.tcl,v diff -u -N -r1.41 -r1.42 --- openacs-4/packages/contacts/tcl/contact-search-procs.tcl 25 Apr 2018 19:47:46 -0000 1.41 +++ openacs-4/packages/contacts/tcl/contact-search-procs.tcl 9 May 2018 15:33:30 -0000 1.42 @@ -490,7 +490,7 @@ @param and Set this flag if you want the result to start with an 'and' if the list of where clauses returned is non-empty. } { set query [string trim $query] - set search_clauses {} + set search_clauses [list] set where_clause [contact::search::where_clause -search_id $search_id -party_id $party_id -revision_id $revision_id -limit_type_p $limit_type_p] if { [exists_and_not_null where_clause] } { @@ -549,7 +549,7 @@ # query is a condition. We are limited to 3 levels of database access for most # openacs installs so this bypasses that problem set db_conditions [db_list_of_lists select_conditions {}] - set conditions {} + set conditions [list] foreach condition $db_conditions { lappend conditions [contacts::search::condition_type \ -type [lindex $condition 0] \ @@ -596,7 +596,7 @@ set query [string trim $query] regsub -all "'" $query "''" query - set query_clauses {} + set query_clauses [list] set callback_query_clauses [callback contact::search::query_clauses -query $query -party_id $party_id] if { [llength $callback_query_clauses] > 0 } { # the callback returns a list of the lists from the callbacks @@ -746,7 +746,7 @@ } { } { db_0or1row get_search_info {} - set where_clauses {} + set where_clauses [list] if { [exists_and_not_null all_or_any] } { set result {} Index: openacs-4/packages/contacts/tcl/contact-search-widget-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/tcl/contact-search-widget-procs.tcl,v diff -u -N -r1.7 -r1.8 --- openacs-4/packages/contacts/tcl/contact-search-widget-procs.tcl 25 Apr 2018 19:47:46 -0000 1.7 +++ openacs-4/packages/contacts/tcl/contact-search-widget-procs.tcl 9 May 2018 15:33:30 -0000 1.8 @@ -154,8 +154,8 @@ error "You cannot use the contact_search widget without specifying a package_id of a contacts instance in which to search (done the same way you would specifiy html attributes)" } } - set person_ids {} - set organization_ids {} + set person_ids [list] + set organization_ids [list] # search in persons if { $persons_p } { @@ -175,7 +175,7 @@ } else { # we need to return a select list - set options {} + set options [list] if { [llength $person_ids] > 0 } { if { [llength $person_ids] > 50 } { set options [list [list [_ contacts.lt_Search_again_over_50_people] ":search:"]] Index: openacs-4/packages/contacts/tcl/contacts-callback-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/tcl/contacts-callback-procs.tcl,v diff -u -N -r1.64 -r1.65 --- openacs-4/packages/contacts/tcl/contacts-callback-procs.tcl 25 Apr 2018 19:47:47 -0000 1.64 +++ openacs-4/packages/contacts/tcl/contacts-callback-procs.tcl 9 May 2018 15:33:30 -0000 1.65 @@ -275,7 +275,7 @@ } { set object_type [contact::type -party_id $party_id] - set element_list {} + set element_list [list] if { [lsearch [list person user] $object_type] >= 0 } { lappend element_list first_names last_name email } elseif {$object_type == "organization" } { @@ -731,7 +731,7 @@ } set object_type $type - set results {} + set results [list] if { $object_type eq "party" && [lsearch [list email url] $key] >= 0 } { db_foreach get_party_info " select $key as value, party_id from parties where party_id in ( $select_query ) " { if { $format eq "html" && $value ne "" } { @@ -906,7 +906,7 @@ if { ![array exists roles_list] } { return [list] } else { - set results {} + set results [list] foreach {party_id related_parties} [array get roles_list] { lappend results $party_id [join [lsort -dictionary $related_parties] ", "] } @@ -967,7 +967,7 @@ {-format "html"} } { } { - set results {} + set results [list] if { $type eq "groups" && [string is integer $key] && $key ne ""} { set true [_ contacts.True] set false [_ contacts.False] @@ -996,7 +996,7 @@ {-object_type} } { } { - set groups_list {} + set groups_list [list] foreach group [contact::groups_list -package_id $package_id] { util_unlist $group group_id group_name member_count component_count mapped_p default_p if { [string is true $mapped_p] } { @@ -1021,7 +1021,7 @@ {-format "html"} } { } { - set results {} + set results [list] if { $type eq "privacy" } { set true [_ contacts.True] set false [_ contacts.False] @@ -1153,7 +1153,7 @@ } { # Allow for organizations and persons to set the locale - set list_of_locales {} + set list_of_locales [list] db_foreach locale_loop { select label, locale from enabled_locales Index: openacs-4/packages/contacts/www/bulk-update.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/www/bulk-update.tcl,v diff -u -N -r1.8 -r1.9 --- openacs-4/packages/contacts/www/bulk-update.tcl 26 Apr 2018 08:56:38 -0000 1.8 +++ openacs-4/packages/contacts/www/bulk-update.tcl 9 May 2018 15:33:30 -0000 1.9 @@ -22,7 +22,7 @@ set user_id [ad_conn user_id] set context [list $title] set package_id [ad_conn package_id] -set recipients {} +set recipients [list] if { [exists_and_not_null party_id] } { foreach party_id $party_id { contact::require_visiblity -party_id $party_id @@ -37,13 +37,13 @@ set person_count [llength $person_ids] -set people {} +set people [list] foreach party_id $person_ids { lappend people "[person::name -person_id $party_id]" } set people [join $people ", "] -set organizations {} +set organizations [list] foreach party_id $organization_ids { lappend organizations "[organizations::name -organization_id $party_id]" } Index: openacs-4/packages/contacts/www/contact-groups.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/www/contact-groups.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/contacts/www/contact-groups.tcl 26 Apr 2018 08:56:38 -0000 1.5 +++ openacs-4/packages/contacts/www/contact-groups.tcl 9 May 2018 15:33:30 -0000 1.6 @@ -12,7 +12,7 @@ set user_id [ad_conn user_id] set package_id [ad_conn package_id] -set recipients {} +set recipients [list] lappend recipients "[contact::name -party_id $party_id]" Index: openacs-4/packages/contacts/www/files.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/www/files.tcl,v diff -u -N -r1.7 -r1.8 --- openacs-4/packages/contacts/www/files.tcl 25 Apr 2018 19:47:47 -0000 1.7 +++ openacs-4/packages/contacts/www/files.tcl 9 May 2018 15:33:30 -0000 1.8 @@ -32,7 +32,7 @@ # is why we try if there is an organization that has the user as an # employee - set organization_list {} + set organization_list [list] db_foreach select_employee_ids "select CASE WHEN object_id_one = :party_id THEN object_id_two ELSE object_id_one END as other_party_id from acs_rels, acs_rel_types @@ -68,7 +68,7 @@ ad_form -name upload_files -html {enctype multipart/form-data} -form $form_elements -on_request { } -on_submit { set upload_number 1 - set message {} + set message [list] while {$upload_number <= $upload_count} { set file [set "upload_file${upload_number}"] set title [set "upload_title${upload_number}"] Index: openacs-4/packages/contacts/www/group-parties-add.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/www/group-parties-add.tcl,v diff -u -N -r1.10 -r1.11 --- openacs-4/packages/contacts/www/group-parties-add.tcl 26 Apr 2018 08:56:38 -0000 1.10 +++ openacs-4/packages/contacts/www/group-parties-add.tcl 9 May 2018 15:33:30 -0000 1.11 @@ -16,7 +16,7 @@ } } if { [exists_and_not_null party_id] } { - set party_ids {} + set party_ids [list] foreach party_id $party_id { lappend party_ids $party_id } @@ -31,7 +31,7 @@ set peeraddr [ad_conn peeraddr] set context [list $title] set package_id [ad_conn package_id] -set recipients {} +set recipients [list] foreach party_id $party_ids { lappend recipients "[contact::name -party_id $party_id]" } Index: openacs-4/packages/contacts/www/group-parties-remove.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/www/group-parties-remove.tcl,v diff -u -N -r1.13 -r1.14 --- openacs-4/packages/contacts/www/group-parties-remove.tcl 26 Apr 2018 08:56:38 -0000 1.13 +++ openacs-4/packages/contacts/www/group-parties-remove.tcl 9 May 2018 15:33:30 -0000 1.14 @@ -18,7 +18,7 @@ } } if { [exists_and_not_null party_id] } { - set party_ids {} + set party_ids [list] foreach party_id $party_id { lappend party_ids $party_id } @@ -31,9 +31,9 @@ set group_ids $group_id db_transaction { - set message {} + set message [list] foreach group_id $group_ids { - set contacts {} + set contacts [list] foreach party_id $party_ids { # relation_add verifies that they aren't already in the group set contact_name [contact::name -party_id $party_id] @@ -80,7 +80,7 @@ set user_id [ad_conn user_id] set context [list $title] set package_id [ad_conn package_id] -set recipients {} +set recipients [list] foreach party_id $party_ids { lappend recipients "[contact::name -party_id $party_id]" } Index: openacs-4/packages/contacts/www/group-party.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/www/group-party.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/contacts/www/group-party.tcl 26 Apr 2018 08:56:38 -0000 1.4 +++ openacs-4/packages/contacts/www/group-party.tcl 9 May 2018 15:33:30 -0000 1.5 @@ -11,7 +11,7 @@ } -validate { } if { [exists_and_not_null party_id] } { - set party_ids {} + set party_ids [list] foreach party_id $party_id { lappend party_ids $party_id } @@ -23,7 +23,7 @@ set user_id [ad_conn user_id] set context [list $title] set package_id [ad_conn package_id] -set recipients {} +set recipients [list] foreach party_id $party_ids { contact::require_visiblity -party_id $party_id lappend recipients "[contact::name -party_id $party_id]" Index: openacs-4/packages/contacts/www/messages.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/www/messages.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/contacts/www/messages.tcl 26 Apr 2018 08:56:38 -0000 1.3 +++ openacs-4/packages/contacts/www/messages.tcl 9 May 2018 15:33:30 -0000 1.4 @@ -23,7 +23,7 @@ -list [db_list_of_lists get_message_types { select pretty_name, message_type from contact_message_types}] \ ] -set actions {} +set actions [list] foreach type $message_types { lappend actions "[_ contacts.Add] [lindex $type 0]" [export_vars -base message-ae -url [list [list message_type [lindex $type 1]]]] "[_ contacts.Add] [lindex $type 0]" set type_pretty_name([lindex $type 1]) [lindex $type 0] Index: openacs-4/packages/contacts/www/relationship-bulk-add.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/www/relationship-bulk-add.tcl,v diff -u -N -r1.6 -r1.7 --- openacs-4/packages/contacts/www/relationship-bulk-add.tcl 26 Apr 2018 08:56:38 -0000 1.6 +++ openacs-4/packages/contacts/www/relationship-bulk-add.tcl 9 May 2018 15:33:30 -0000 1.7 @@ -15,15 +15,15 @@ set title [_ contacts.Add_Relationship] set context [list $title] -set names {} -set contact_type {} +set names [list] +set contact_type [list] if { ![exists_and_not_null party_ids] } { set party_ids $party_id } -set organizations {} -set organization_ids {} -set people {} -set person_ids {} +set organizations [list] +set organization_ids [list] +set people [list] +set person_ids [list] foreach party $party_ids { contact::require_visiblity -party_id $party if { [contact::type -party_id $party] eq "organization" } { Index: openacs-4/packages/contacts/www/search.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/www/search.tcl,v diff -u -N -r1.34 -r1.35 --- openacs-4/packages/contacts/www/search.tcl 25 Apr 2018 19:47:47 -0000 1.34 +++ openacs-4/packages/contacts/www/search.tcl 9 May 2018 15:33:30 -0000 1.35 @@ -32,7 +32,7 @@ } valid_search_id -requires {search_id} { if { [db_0or1row condition_exists_p {}] } { - set valid_owner_ids {} + set valid_owner_ids [list] lappend valid_owner_ids [ad_conn user_id] if { [permission::permission_p -object_id [ad_conn package_id] -privilege "admin"] } { lappend valid_owner_ids [ad_conn package_id] @@ -72,7 +72,7 @@ set search_exists_p 0 -# set query_pretty {} +# set query_pretty [list] if { [exists_and_not_null search_id] } { if { [contact::search::exists_p -search_id $search_id] } { db_1row get_search_info { } @@ -100,8 +100,8 @@ -package_id [ad_conn package_id] \ -object_type $actual_object_type - set add_columns {} - set remove_columns {} + set add_columns [list] + set remove_columns [list] set extended_columns [contact::search::get_extensions -search_id $search_id] if { [lsearch $extended_columns $remove_column] >= 0 && $remove_column ne "" } { # remove this extension @@ -187,7 +187,7 @@ } if { $search_exists_p } { - set conditions {} + set conditions [list] db_foreach selectqueries {} { set condition_name [contacts::search::condition_type -type $query_type -request pretty -var_list $query_var_list] if { [empty_string_p $condition_name] } { @@ -219,7 +219,7 @@ {all_or_any:text(select),optional {label ""} {options {{[_ contacts.All] all} {[_ contacts.Any] any}}} {after_html "[_ contacts.lt_of_the_following_cond]$query_pretty"}} } } else { - set object_type_options {} + set object_type_options [list] set object_types [list party person organization] if { $display_employers_p } { lappend object_types "employee" Index: openacs-4/packages/contacts/www/admin/full-organizations.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/www/admin/full-organizations.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/contacts/www/admin/full-organizations.tcl 26 Apr 2018 08:56:38 -0000 1.2 +++ openacs-4/packages/contacts/www/admin/full-organizations.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -9,7 +9,7 @@ } { } -set party_ids {} +set party_ids [list] db_multirow organizations get_organizations " select party_id, name, @@ -49,7 +49,7 @@ set output {"Organization ID","Name","Email","URL"} -set extended_columns {} +set extended_columns [list] template::multirow foreach ext { if { ( $type eq "organization" || $type eq "party" ) && [lsearch $preset_columns $key] >= 0 } { # we aren't adding the columns that are provided by the parties and organizations tables @@ -88,7 +88,7 @@ # we create a command here because it more efficient then # iterating over all the columns in the multirow foreach -set command {} +set command [list] foreach column [template::multirow columns organizations] { lappend command "\[template::list::csv_quote \$${column}\]" } Index: openacs-4/packages/contacts/www/admin/full-people.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/www/admin/full-people.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/contacts/www/admin/full-people.tcl 26 Apr 2018 08:56:38 -0000 1.2 +++ openacs-4/packages/contacts/www/admin/full-people.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -9,7 +9,7 @@ } { } -set party_ids {} +set party_ids [list] db_multirow people get_people " select party_id, first_names, @@ -50,7 +50,7 @@ set output {"Person ID","First Names","Last Name","Email","URL"} -set extended_columns {} +set extended_columns [list] template::multirow foreach ext { if { ( $type eq "person" || $type eq "party" ) && [lsearch $preset_columns $key] >= 0 } { # we aren't adding the columns that are provided by the parties and persons tables @@ -89,7 +89,7 @@ # we create a command here because it more efficient then # iterating over all the columns in the multirow foreach -set command {} +set command [list] foreach column [template::multirow columns people] { lappend command "\[template::list::csv_quote \$${column}\]" } Index: openacs-4/packages/content-portlet/misc/portlets/ges-categories.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/content-portlet/misc/portlets/ges-categories.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/content-portlet/misc/portlets/ges-categories.tcl 25 Apr 2018 19:47:47 -0000 1.2 +++ openacs-4/packages/content-portlet/misc/portlets/ges-categories.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -34,7 +34,7 @@ if {!$no_tree_name} { append content "

$my_tree_name

" } - set categories {} + set categories [list] set pos 0 set cattree(0) [::xowiki::CatTree new -volatile -orderby pos -name $my_tree_name] foreach category_info [category_tree::get_tree $tree_id] { Index: openacs-4/packages/cronjob/tcl/cronjob-init.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/cronjob/tcl/cronjob-init.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/cronjob/tcl/cronjob-init.tcl 25 Apr 2018 19:47:47 -0000 1.5 +++ openacs-4/packages/cronjob/tcl/cronjob-init.tcl 9 May 2018 15:33:30 -0000 1.6 @@ -22,8 +22,8 @@ } { ns_log Debug "Running qd_write_query_select with $package $attrs" - set query {} - set in_args {} + set query [list] + set in_args [list] set args [concat $attrs] foreach {attr sign value} $args { lappend in_args $attr @@ -135,7 +135,7 @@ proc qd_write_query {package args} { - set query {} + set query [list] set attrs_and_defaults [eval qd_choose_function $package $args] foreach {attr default_value} $attrs_and_defaults { if {[lsearch $args $attr] < 0 } { @@ -153,7 +153,7 @@ proc qd_write_query_upvar {package listvar} { - set query {} + set query [list] upvar $listvar args set attrs_and_defaults [eval qd_choose_function $package $args] if {[string match "!NO MATCH:*" $attrs_and_defaults ]} { Index: openacs-4/packages/cronjob/www/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/cronjob/www/index.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/cronjob/www/index.tcl 26 Apr 2018 08:56:38 -0000 1.5 +++ openacs-4/packages/cronjob/www/index.tcl 9 May 2018 15:33:30 -0000 1.6 @@ -31,4 +31,4 @@ # Set the context bar. -set context {} +set context [list] Index: openacs-4/packages/curriculum/lib/curriculum-ave.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/curriculum/lib/curriculum-ave.tcl,v diff -u -N -r1.14 -r1.15 --- openacs-4/packages/curriculum/lib/curriculum-ave.tcl 26 Apr 2018 08:56:38 -0000 1.14 +++ openacs-4/packages/curriculum/lib/curriculum-ave.tcl 9 May 2018 15:33:30 -0000 1.15 @@ -16,7 +16,7 @@ set package_id [curriculum::conn package_id] set user_id [ad_conn user_id] -set actions {} +set actions [list] set element_mode {} set desc_help_text "[_ curriculum.lt_This_text_should_desc]" Index: openacs-4/packages/curriculum/tcl/curriculum-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/curriculum/tcl/curriculum-procs.tcl,v diff -u -N -r1.17 -r1.18 --- openacs-4/packages/curriculum/tcl/curriculum-procs.tcl 25 Apr 2018 19:47:47 -0000 1.17 +++ openacs-4/packages/curriculum/tcl/curriculum-procs.tcl 9 May 2018 15:33:30 -0000 1.18 @@ -100,7 +100,7 @@ } { upvar $array row - array set assignments {} + array set assignments [list] set role_prefix "role_" @@ -607,7 +607,7 @@ } # Build up the details list - set details_list {} + set details_list [list] foreach field $fields { lappend details_list $label($field) $value($field) } Index: openacs-4/packages/curriculum-central/tcl/admin-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/curriculum-central/tcl/admin-procs.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/curriculum-central/tcl/admin-procs.tcl 25 Apr 2018 19:47:47 -0000 1.2 +++ openacs-4/packages/curriculum-central/tcl/admin-procs.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -72,7 +72,7 @@ set limit [parameter::get -parameter "DefaultNumDegreeStreamYears" \ -default 5] - set names {} + set names [list] set x 1 while { $x <= $limit } { @@ -150,7 +150,7 @@ @param package_id Package ID of Curriculum Central that we want to insert default values for. } { - set attribute_names {} + set attribute_names [list] lappend attribute_names \ "#curriculum-central.research_and_inquiry#" @@ -188,7 +188,7 @@ set limit [parameter::get -parameter "DefaultNumScheduleWeeks" \ -default 13] - set names {} + set names [list] set x 1 while { $x <= $limit } { Index: openacs-4/packages/curriculum-central/tcl/staff-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/curriculum-central/tcl/staff-procs.tcl,v diff -u -N -r1.6 -r1.7 --- openacs-4/packages/curriculum-central/tcl/staff-procs.tcl 25 Apr 2018 19:47:47 -0000 1.6 +++ openacs-4/packages/curriculum-central/tcl/staff-procs.tcl 9 May 2018 15:33:30 -0000 1.7 @@ -35,7 +35,7 @@ @param name_ids List of name IDs. @return Returns a concatenated string of pretty names. } { - set names {} + set names [list] foreach name_id $name_ids { set pretty_name [curriculum_central::staff::pretty_name $name_id] Index: openacs-4/packages/curriculum-central/tcl/uos-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/curriculum-central/tcl/uos-procs.tcl,v diff -u -N -r1.37 -r1.38 --- openacs-4/packages/curriculum-central/tcl/uos-procs.tcl 25 Apr 2018 19:47:47 -0000 1.37 +++ openacs-4/packages/curriculum-central/tcl/uos-procs.tcl 9 May 2018 15:33:30 -0000 1.38 @@ -571,7 +571,7 @@ upvar $array row - array set assignments {} + array set assignments [list] if { $user_id eq "" } { set user_id [ad_conn user_id] @@ -1361,7 +1361,7 @@ set user_id [ad_conn user_id] } - set ga_list {} + set ga_list [list] db_foreach select_ga {} { set ga_name "[lang::util::localize $name] ($identifier)" @@ -1552,7 +1552,7 @@ set one_line [curriculum_central::uos::get_pretty_name -uos_id $object_id] - set details_list {} + set details_list [list] if { [db_0or1row uos_details {}] } { lappend details_list [_ curriculum-central.credit_value] $credit_value @@ -1783,7 +1783,7 @@ set package_id [ad_conn package_id] } - array set row {} + array set row [list] if { ![db_0or1row latest_grade_set {} -column_array row] } { set row(grade_set_id) "" @@ -1899,7 +1899,7 @@ template::form::section $form_name $section_name } - array set row {} + array set row [list] if { ![db_0or1row latest_schedule_set {} -column_array row] } { set row(schedule_set_id) "" Index: openacs-4/packages/curriculum-central/www/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/curriculum-central/www/index.tcl,v diff -u -N -r1.6 -r1.7 --- openacs-4/packages/curriculum-central/www/index.tcl 26 Apr 2018 08:56:38 -0000 1.6 +++ openacs-4/packages/curriculum-central/www/index.tcl 9 May 2018 15:33:30 -0000 1.7 @@ -7,7 +7,7 @@ } set page_title [ad_conn instance_name] -set context {} +set context [list] set package_id [ad_conn package_id] set admin_p [permission::permission_p -object_id $package_id -privilege admin] Index: openacs-4/packages/curriculum-central/www/admin/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/curriculum-central/www/admin/index.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/curriculum-central/www/admin/index.tcl 26 Apr 2018 08:56:38 -0000 1.2 +++ openacs-4/packages/curriculum-central/www/admin/index.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -7,4 +7,4 @@ } set page_title "[_ curriculum-central.admin]" -set context {} +set context [list] Index: openacs-4/packages/curriculum-central/www/coordinate/uos-edit.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/curriculum-central/www/coordinate/uos-edit.tcl,v diff -u -N -r1.24 -r1.25 --- openacs-4/packages/curriculum-central/www/coordinate/uos-edit.tcl 26 Apr 2018 08:56:38 -0000 1.24 +++ openacs-4/packages/curriculum-central/www/coordinate/uos-edit.tcl 9 May 2018 15:33:30 -0000 1.25 @@ -59,7 +59,7 @@ } # Buttons -set actions {} +set actions [list] if { $enabled_action_id eq "" } { foreach available_enabled_action_id [workflow::case::get_available_enabled_action_ids -case_id $case_id] { workflow::case::enabled_action_get -enabled_action_id $available_enabled_action_id -array enabled_action @@ -475,7 +475,7 @@ # Export filters -set filters {} +set filters [list] foreach name [curriculum_central::get_export_variables] { if { [info exists $name] } { lappend filters [list "${name}:text(hidden),optional" [list value [set $name]]] @@ -531,7 +531,7 @@ # on_submit block ad_form -extend -name uos -on_submit { - array set row {} + array set row [list] if { $enabled_action_id ne "" } { foreach field [workflow::action::get_element \ @@ -603,7 +603,7 @@ # For Grade Descriptor fields - set grade_descriptors {} + set grade_descriptors [list] if { $enabled_action_id ne "" } { # Get the grade descriptors, and the information @@ -626,7 +626,7 @@ } elseif { $action_info(short_name) eq "edit_schedule" } { # For schedule fields - set schedule_fields {} + set schedule_fields [list] if { $enabled_action_id ne "" } { # Get the schedule fields, and the information Index: openacs-4/packages/curriculum-tracker/www/import-degree.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/curriculum-tracker/www/import-degree.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/curriculum-tracker/www/import-degree.tcl 26 Apr 2018 08:56:38 -0000 1.2 +++ openacs-4/packages/curriculum-tracker/www/import-degree.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -9,7 +9,7 @@ } set page_title "[_ curriculum-tracker.import_degree]" -set context {} +set context [list] set package_id [ad_conn package_id] set owner_id [ad_conn user_id] Index: openacs-4/packages/curriculum-tracker/www/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/curriculum-tracker/www/index.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/curriculum-tracker/www/index.tcl 26 Apr 2018 08:56:38 -0000 1.2 +++ openacs-4/packages/curriculum-tracker/www/index.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -7,7 +7,7 @@ } set page_title [ad_conn instance_name] -set context {} +set context [list] set package_id [ad_conn package_id] set owner_id [ad_conn user_id] Index: openacs-4/packages/datamanager/CALLBACKS_CHANGES/news-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/datamanager/CALLBACKS_CHANGES/news-procs.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/datamanager/CALLBACKS_CHANGES/news-procs.tcl 25 Apr 2018 19:47:47 -0000 1.2 +++ openacs-4/packages/datamanager/CALLBACKS_CHANGES/news-procs.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -197,7 +197,7 @@ # TODO make limit a parameter set limit 15 - set items {} + set items [list] set counter 0 set package_url [news_util_get_url $summary_context_id] db_foreach get_news_items {} { Index: openacs-4/packages/datamanager/CALLBACKS_CHANGES/static-portlet-callback-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/datamanager/CALLBACKS_CHANGES/static-portlet-callback-procs.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/datamanager/CALLBACKS_CHANGES/static-portlet-callback-procs.tcl 25 Apr 2018 19:47:47 -0000 1.2 +++ openacs-4/packages/datamanager/CALLBACKS_CHANGES/static-portlet-callback-procs.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -67,7 +67,7 @@ } { Export a static portlet } { - set lista {} + set lista [list] db_1row select_static {} lappend lista "" Index: openacs-4/packages/datamanager/www/import.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/datamanager/www/import.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/datamanager/www/import.tcl 26 Apr 2018 08:56:38 -0000 1.2 +++ openacs-4/packages/datamanager/www/import.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -3,7 +3,7 @@ {mode:optional ""} } -properties { } -set context {} +set context [list] set community_id [dotlrn_community::get_community_id] #only administrator or professor must be allowed to enter this page dotlrn::require_user_admin_community -community_id $community_id Index: openacs-4/packages/datamanager/www/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/datamanager/www/index.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/datamanager/www/index.tcl 26 Apr 2018 08:56:38 -0000 1.3 +++ openacs-4/packages/datamanager/www/index.tcl 9 May 2018 15:33:30 -0000 1.4 @@ -2,7 +2,7 @@ } -query { } -properties { } -set context {} +set context [list] set community_id [dotlrn_community::get_community_id] set user_id [ad_conn user_id] Index: openacs-4/packages/datamanager/www/admin/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/datamanager/www/admin/index.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/datamanager/www/admin/index.tcl 26 Apr 2018 08:56:38 -0000 1.2 +++ openacs-4/packages/datamanager/www/admin/index.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -2,7 +2,7 @@ } -query { } -properties { } -set context {} +set context [list] set community_id [dotlrn_community::get_community_id] #dotlrn::require_user_admin_community -community_id $community_id Index: openacs-4/packages/dbm/tcl/dbm-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dbm/tcl/dbm-procs.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/dbm/tcl/dbm-procs.tcl 25 Apr 2018 19:47:47 -0000 1.2 +++ openacs-4/packages/dbm/tcl/dbm-procs.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -11,7 +11,7 @@ } { Simple procedure to create options for dropdown menu } { - set opts {} + set opts [list] if {!$no_empty_option_p} { set opts [linsert $opts 0 ""] } @@ -37,7 +37,7 @@ } { A simple proc to highlight sql } { - set result {} + set result [list] regsub -all {([^ \n\t]+)} $sql {\0} sql set sql [split $sql " "] @@ -169,7 +169,7 @@ @author Nima Mazloumi @creation-date 2005-08-24 } { - set fields {} + set fields [list] set count [llength $elements] Index: openacs-4/packages/dbm/www/addforeignkey2.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dbm/www/addforeignkey2.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/dbm/www/addforeignkey2.tcl 25 Apr 2018 19:47:47 -0000 1.2 +++ openacs-4/packages/dbm/www/addforeignkey2.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -53,8 +53,8 @@ } -on_submit { - set output {} - set output2 {} + set output [list] + set output2 [list] foreach el $column { lappend output [concat \"$el\"] Index: openacs-4/packages/dbm/www/addprimarykey.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dbm/www/addprimarykey.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/dbm/www/addprimarykey.tcl 25 Apr 2018 19:47:47 -0000 1.2 +++ openacs-4/packages/dbm/www/addprimarykey.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -19,7 +19,7 @@ } } -on_submit { - set output {} + set output [list] foreach el $column { lappend output [concat \"$el\"] Index: openacs-4/packages/dbm/www/adduniquekey.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dbm/www/adduniquekey.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/dbm/www/adduniquekey.tcl 25 Apr 2018 19:47:47 -0000 1.2 +++ openacs-4/packages/dbm/www/adduniquekey.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -19,7 +19,7 @@ } } -on_submit { - set output {} + set output [list] foreach el $column { lappend output [concat \"$el\"] Index: openacs-4/packages/dbm/www/createindex.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dbm/www/createindex.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/dbm/www/createindex.tcl 25 Apr 2018 19:47:47 -0000 1.2 +++ openacs-4/packages/dbm/www/createindex.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -36,7 +36,7 @@ set unique "UNIQUE" } - set output {} + set output [list] foreach el $column { lappend output [concat \"$el\"] Index: openacs-4/packages/dbm/www/createtable2.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dbm/www/createtable2.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/dbm/www/createtable2.tcl 26 Apr 2018 08:56:38 -0000 1.2 +++ openacs-4/packages/dbm/www/createtable2.tcl 9 May 2018 15:33:30 -0000 1.3 @@ -8,14 +8,14 @@ # now retrieve the data -set field_ids {} +set field_ids [list] for {set i 0} {$i<$amount} {incr i} { lappend field_ids f_$i } set form_name createtable2 -set elements {} +set elements [list] for {set i 0} {$i<$amount} {incr i} { lappend elements $i } Index: openacs-4/packages/diagram/tcl/diagram-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/diagram/tcl/diagram-procs.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/diagram/tcl/diagram-procs.tcl 26 Apr 2018 08:56:38 -0000 1.4 +++ openacs-4/packages/diagram/tcl/diagram-procs.tcl 9 May 2018 15:33:30 -0000 1.5 @@ -303,7 +303,7 @@ set diagram_properties(count) $count for {set j 1} {$j <= [llength $diagram_properties(display_elements)]} {incr j} { - set col$j {} + set col$j [list] } #iterate over the multirow @@ -329,8 +329,8 @@ set y_max "" set scales $diagram_properties(scales) - set minima {} - set sum {} + set minima [list] + set sum [list] #lets iterate over all columns and get the borders for {set j 1} {$j <= [llength $diagram_properties(display_elements)]} {incr j} { @@ -343,7 +343,7 @@ #we need to update min and max - set list {} + set list [list] #its the x axis if {$xy == 1} { @@ -446,7 +446,7 @@ set __output {} # Output header row - set __cols {} + set __cols [list] foreach __element_name $diagram_properties(display_elements) { lappend __cols [csv_quote $__element_name] } @@ -455,7 +455,7 @@ # Output rows template::multirow foreach $diagram_properties(multirow) { - set __cols {} + set __cols [list] foreach __element_name $diagram_properties(display_elements) { template::diagram::element::get_reference \ Index: openacs-4/packages/dotfolio/tcl/dotfolio-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotfolio/tcl/dotfolio-procs.tcl,v diff -u -N -r1.9 -r1.10 --- openacs-4/packages/dotfolio/tcl/dotfolio-procs.tcl 26 Apr 2018 08:56:38 -0000 1.9 +++ openacs-4/packages/dotfolio/tcl/dotfolio-procs.tcl 9 May 2018 15:33:30 -0000 1.10 @@ -18,7 +18,7 @@ @see dotfolio::packages } { # need to strip nodes which have no mounted package... - set packages {} + set packages [list] foreach package [site_node::get_children -all -node_id $node_id -element package_id] { if {![empty_string_p $package]} { lappend packages $package Index: openacs-4/packages/dotlrn/tcl/apm-callback-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn/tcl/apm-callback-procs.tcl,v diff -u -N -r1.16 -r1.17 --- openacs-4/packages/dotlrn/tcl/apm-callback-procs.tcl 25 Apr 2018 19:47:47 -0000 1.16 +++ openacs-4/packages/dotlrn/tcl/apm-callback-procs.tcl 9 May 2018 15:33:30 -0000 1.17 @@ -266,7 +266,7 @@ } 2.3.0d1 2.3.0d2 { # Set access keys for all pages that have known titles - set params {} + set params [list] db_foreach get_default_values {} { set params [concat $params [split [string trimright $default_value ";"] ";"]] } Index: openacs-4/packages/dotlrn/tcl/applets-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn/tcl/applets-procs.tcl,v diff -u -N -r1.28 -r1.29 --- openacs-4/packages/dotlrn/tcl/applets-procs.tcl 25 Apr 2018 19:47:47 -0000 1.28 +++ openacs-4/packages/dotlrn/tcl/applets-procs.tcl 9 May 2018 15:33:30 -0000 1.29 @@ -134,7 +134,7 @@ ad_proc -public list_mounted_applets {} { list all applets that are mounted } { - set applets {} + set applets [list] foreach applet [list_applets] { if {[is_applet_mounted -applet_key $applet]} { Index: openacs-4/packages/dotlrn/tcl/community-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn/tcl/community-procs.tcl,v diff -u -N -r1.225 -r1.226 --- openacs-4/packages/dotlrn/tcl/community-procs.tcl 30 Apr 2018 09:14:23 -0000 1.225 +++ openacs-4/packages/dotlrn/tcl/community-procs.tcl 9 May 2018 15:33:30 -0000 1.226 @@ -435,9 +435,9 @@ set default_roles [concat {*}[get_default_roles -community_id $community_id]] set attributes [concat {*}[get_attributes -community_id $community_id]] - set roles {} + set roles [list] foreach {rel_type role pretty_name pretty_plural} $default_roles { - set new_role {} + set new_role [list] lappend new_role $rel_type lappend new_role $role @@ -515,7 +515,7 @@ ad_proc -public get_all_roles_as_options {} { return the list of roles used in dotLRN } { - set role_options {} + set role_options [list] foreach {rel_type role pretty_name pretty_plural} [concat {*}[get_all_roles]] { lappend role_options [list [lang::util::localize $pretty_name] $rel_type] @@ -944,7 +944,7 @@ } { Return a datasource of the communities that a user belongs to in a particular type } { - set list_of_communities {} + set list_of_communities [list] db_foreach select_communities {} { lappend list_of_communities [list $community_id $community_type $pretty_name $description [get_url -package_id $package_id]] @@ -1454,7 +1454,7 @@ @author Peter Marklund } { - set context {} + set context [list] if {[subcommunity_p -community_id $community_id]} { set parent_name [get_parent_name -community_id $community_id] Index: openacs-4/packages/dotlrn/tcl/spam-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn/tcl/spam-procs.tcl,v diff -u -N -r1.12 -r1.13 --- openacs-4/packages/dotlrn/tcl/spam-procs.tcl 25 Apr 2018 19:47:47 -0000 1.12 +++ openacs-4/packages/dotlrn/tcl/spam-procs.tcl 9 May 2018 15:33:30 -0000 1.13 @@ -74,7 +74,7 @@ set errors "" db_foreach select_recipient_info {} { # replace some values in the subject and the message - set values {} + set values [list] lappend values [list \{email\} $email] lappend values [list \{first_names\} $first_names] lappend values [list \{last_name\} $last_name] Index: openacs-4/packages/dotlrn/www/admin/users-search.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn/www/admin/users-search.tcl,v diff -u -N -r1.34 -r1.35 --- openacs-4/packages/dotlrn/www/admin/users-search.tcl 25 Apr 2018 19:47:47 -0000 1.34 +++ openacs-4/packages/dotlrn/www/admin/users-search.tcl 9 May 2018 15:33:30 -0000 1.35 @@ -174,7 +174,7 @@ "dotlrn_users.email" \ "dotlrn_users.type" \ ] - set wheres {} + set wheres [list] if {$name ne ""} { lappend wheres "(lower(dotlrn_users.last_name) like lower('%' || :name || '%') or lower(dotlrn_users.first_names) like lower('%' || :name || '%') or lower(dotlrn_users.email) like lower('%' || :name || '%'))" @@ -235,7 +235,7 @@ } set in_clause "(dotlrn_users.user_id = acs_rels.object_id_two and acs_rels.rel_type in (" - set in_elements {} + set in_elements [list] for {set i 0} {$i < $role_list_length} {incr i} { set in_element__${i} [lindex $role_list $i] lappend in_elements ":in_element__${i}" @@ -260,8 +260,8 @@ } set referer [ns_conn url] - set selected_users_options {} - set selected_users_values {} + set selected_users_options [list] + set selected_users_values [list] db_foreach select_users $sql { set href [export_vars -base user user_id] lappend selected_users_options [list [subst {$last_name, $first_names ($email)}] $user_id] Index: openacs-4/packages/dotlrn-admin/www/admin/cockpit.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn-admin/www/admin/cockpit.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/dotlrn-admin/www/admin/cockpit.tcl 26 Apr 2018 08:56:38 -0000 1.4 +++ openacs-4/packages/dotlrn-admin/www/admin/cockpit.tcl 9 May 2018 15:33:30 -0000 1.5 @@ -79,7 +79,7 @@ } -set users {} +set users [list] set count 0 Index: openacs-4/packages/dotlrn-admin/www/admin/users-search.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn-admin/www/admin/users-search.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/dotlrn-admin/www/admin/users-search.tcl 25 Apr 2018 19:47:47 -0000 1.4 +++ openacs-4/packages/dotlrn-admin/www/admin/users-search.tcl 9 May 2018 15:33:30 -0000 1.5 @@ -171,7 +171,7 @@ "dotlrn_users.email" \ "dotlrn_users.type" \ ] - set wheres {} + set wheres [list] if {$name ne ""} { lappend wheres "(lower(dotlrn_users.last_name) like lower('%' || :name || '%') or lower(dotlrn_users.first_names) like lower('%' || :name || '%') or lower(dotlrn_users.email) like lower('%' || :name || '%'))" @@ -232,7 +232,7 @@ } set in_clause "(dotlrn_users.user_id = acs_rels.object_id_two and acs_rels.rel_type in (" - set in_elements {} + set in_elements [list] for {set i 0} {$i < $role_list_length} {incr i} { set in_element__${i} [lindex $role_list $i] lappend in_elements ":in_element__${i}" @@ -257,8 +257,8 @@ } set referer [ns_conn url] - set selected_users_options {} - set selected_users_values {} + set selected_users_options [list] + set selected_users_values [list] db_foreach select_users $sql { set href [export_vars -base user user_id] lappend selected_users_options [list [subst {$last_name, $first_names ($email)}] $user_id] Index: openacs-4/packages/dotlrn-catalog/lib/tree-chunk.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn-catalog/lib/tree-chunk.tcl,v diff -u -N -r1.7 -r1.8 --- openacs-4/packages/dotlrn-catalog/lib/tree-chunk.tcl 26 Apr 2018 08:56:38 -0000 1.7 +++ openacs-4/packages/dotlrn-catalog/lib/tree-chunk.tcl 9 May 2018 15:33:30 -0000 1.8 @@ -24,7 +24,7 @@ set tree_length [llength $tree_list] # Create a list of values for the list filter -set tree {} +set tree [list] foreach element $tree_list { set ident [lindex $element 3] Index: openacs-4/packages/dotlrn-ecommerce/lib/cal-view.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn-ecommerce/lib/cal-view.tcl,v diff -u -N -r1.14 -r1.15 --- openacs-4/packages/dotlrn-ecommerce/lib/cal-view.tcl 26 Apr 2018 08:56:38 -0000 1.14 +++ openacs-4/packages/dotlrn-ecommerce/lib/cal-view.tcl 9 May 2018 15:33:30 -0000 1.15 @@ -38,7 +38,7 @@ if { [exists_and_not_null zone_f] } { append currently_viewing ", Zone"} if { [exists_and_not_null zone_f] } { append currently_viewing ", Instructor"} -set calendar_id_list {} +set calendar_id_list [list] set package_id [ad_conn package_id] set user_id [ad_conn user_id] @@ -63,8 +63,8 @@ set form [rp_getform] set category_trees [concat [category_tree::get_mapped_trees $cc_package_id] [category_tree::get_mapped_trees $package_id]] -set course_categories {} -set section_categories {} +set course_categories [list] +set section_categories [list] foreach tree [category_tree::get_mapped_trees $cc_package_id] { set tree_name [lindex $tree 1] @@ -160,7 +160,7 @@ } # Create a list of values for the list filter - set $name {} + set $name [list] foreach element $tree_list { if { ! $show_used_categories_only_p || [lsearch $used_categories [lindex $element 0]] != -1 } { @@ -317,7 +317,7 @@ set date set item_template "one-section?cal_item_id=\$item_id" -set export {} +set export [list] foreach {name discard} $filters { lappend export $name } Index: openacs-4/packages/dotlrn-ecommerce/lib/section.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn-ecommerce/lib/section.tcl,v diff -u -N -r1.45 -r1.46 --- openacs-4/packages/dotlrn-ecommerce/lib/section.tcl 26 Apr 2018 08:56:38 -0000 1.45 +++ openacs-4/packages/dotlrn-ecommerce/lib/section.tcl 9 May 2018 15:33:30 -0000 1.46 @@ -41,7 +41,7 @@ #set item_id [dotlrn_catalog::get_item_id -revision_id $course_id] set package_id [ad_conn package_id] -set validate {} +set validate [list] set show_price_option_p [dotlrn_ecommerce::util::param::get -default 1 ShowPriceOptionP] catch { @@ -163,7 +163,7 @@ # community_id is valid # list users set _instructors [dotlrn_community::list_users $instructor_community_id] - set instructors_list {} + set instructors_list [list] foreach instructor $_instructors { set instructor_user_id [ns_set get $instructor user_id] set instructor_name "[ns_set get $instructor first_names] [ns_set get $instructor last_name]" @@ -183,7 +183,7 @@ } else { # community_id is valid set _assistants [dotlrn_community::list_users $assistant_community_id] - set assistants_list {} + set assistants_list [list] foreach assistant $_assistants { set assistant_user_id [ns_set get $assistant user_id] set assistant_name "[ns_set get $assistant first_names] [ns_set get $assistant last_name]" @@ -228,7 +228,7 @@ } -set tree_options {} +set tree_options [list] if { [parameter::get -package_id [ad_conn package_id] -parameter GradePrerequisitesP -default 1 ] } { db_foreach prerequisites { select tree_id @@ -323,7 +323,7 @@ if { [info exists template_calendar_id] } { set sessions_list [db_list_of_lists sessions { }] } else { - set sessions_list {} + set sessions_list [list] } if { [llength $sessions_list] } { @@ -333,7 +333,7 @@ } if { ! [info exists sessions] || ![llength $sessions] } { - set sessions {} + set sessions [list] # allow setting start/end date if there aren't sessions predefined # DAVEB 20070112 Adding active_state_date and active_end_date Index: openacs-4/packages/dotlrn-ecommerce/lib/tree-chunk.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn-ecommerce/lib/tree-chunk.tcl,v diff -u -N -r1.89 -r1.90 --- openacs-4/packages/dotlrn-ecommerce/lib/tree-chunk.tcl 26 Apr 2018 08:56:38 -0000 1.89 +++ openacs-4/packages/dotlrn-ecommerce/lib/tree-chunk.tcl 9 May 2018 15:33:30 -0000 1.90 @@ -51,8 +51,8 @@ set form [rp_getform] set category_trees [concat [category_tree::get_mapped_trees $cc_package_id] [category_tree::get_mapped_trees $package_id]] -set course_categories {} -set section_categories {} +set course_categories [list] +set section_categories [list] foreach tree [category_tree::get_mapped_trees $cc_package_id] { set tree_name [lindex $tree 1] @@ -135,7 +135,7 @@ db_1row get_tree_name { } # Create a list of values for the list filter - set $name {} + set $name [list] foreach element $tree_list { if { ! $show_used_categories_only_p || [lsearch $used_categories [lindex $element 0]] != -1 } { @@ -211,7 +211,7 @@ set instructor_community_id [parameter::get -package_id [ad_conn package_id] -parameter InstructorCommunityId -default 0 ] set _instructors [dotlrn_community::list_users $instructor_community_id] -set __instructors {} +set __instructors [list] if { [llength $_instructors] == 0 } { set _instructors 0 set instructors_filter "" @@ -265,7 +265,7 @@ set show_hidden_not_exists_clause "" } -set actions {} +set actions [list] if {$show_filters_p} { lappend actions "[_ dotlrn-ecommerce.View_All]" ? "[_ dotlrn-ecommerce.View_All]" @@ -615,8 +615,8 @@ set instructors [util_memoize [list dotlrn_ecommerce::section::instructors $community_id $__instructors] $memoize_max_age] - set instructor_names {} - set instructor_ids {} + set instructor_names [list] + set instructor_ids [list] set bios_present_p 0 foreach instructor $instructors { lappend instructor_names [lindex $instructor 1] Index: openacs-4/packages/dotlrn-ecommerce/lib/user-new.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn-ecommerce/lib/user-new.tcl,v diff -u -N -r1.14 -r1.15 --- openacs-4/packages/dotlrn-ecommerce/lib/user-new.tcl 26 Apr 2018 08:56:38 -0000 1.14 +++ openacs-4/packages/dotlrn-ecommerce/lib/user-new.tcl 9 May 2018 15:33:30 -0000 1.15 @@ -56,7 +56,7 @@ set formlen [llength $form] set allow_no_email_p [parameter::get -parameter AllowNoEmailForPurchaser] -set validate {} +set validate [list] # if { $user_type == "purchaser" && $allow_no_email_p } { } if { $allow_no_email_p } { Index: openacs-4/packages/dotlrn-ecommerce/tcl/section-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn-ecommerce/tcl/section-procs.tcl,v diff -u -N -r1.44 -r1.45 --- openacs-4/packages/dotlrn-ecommerce/tcl/section-procs.tcl 25 Apr 2018 19:47:47 -0000 1.44 +++ openacs-4/packages/dotlrn-ecommerce/tcl/section-procs.tcl 9 May 2018 15:33:30 -0000 1.45 @@ -87,14 +87,14 @@ if { ! [db_0or1row session_type { }] } { set item_type_id [calendar::item_type_new -calendar_id $calendar_id -type "Session"] } - set text_sessions {} - array set arr_sessions {} + set text_sessions [list] + array set arr_sessions [list] db_foreach sessions { } { lappend arr_sessions(${month}_${timestart}_${timeend}_${startampm}_${endampm}) $day lappend arr_sessions_sort(${month}_${timestart}_${timeend}_${startampm}_${endampm}) [clock scan $datenum] } - set days {} + set days [list] foreach times [array names arr_sessions] { set times [split $times _] set month [lindex $times 0] @@ -135,7 +135,7 @@ # Sort dates set _text_sessions [lsort -index end $text_sessions] - set text_sessions {} + set text_sessions [list] foreach _text_session $_text_sessions { lappend text_sessions [join [lrange $_text_session 0 2]] } @@ -194,7 +194,7 @@ } set instructor_community_id [parameter::get -package_id [ad_conn package_id] -parameter InstructorCommunityId -default 0 ] set _instructors [dotlrn_community::list_users $instructor_community_id] - set __instructors {} + set __instructors [list] if { [llength $_instructors] == 0 } { set _instructors 0 } else { @@ -650,7 +650,7 @@ set section_folder_id [dotlrn_ecommerce::section::get_public_folder_id $section_id] set section_pages_url "pages/${section_id}/" set __adp_stub "" - set __adp_include_optional_output {} + set __adp_include_optional_output [list] return [template::adp_include "/packages/dotlrn-ecommerce/lib/fs-chunk" [list section_folder_id $section_folder_id section_pages_url $section_pages_url]] Index: openacs-4/packages/dotlrn-ecommerce/www/application-bulk-payments.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn-ecommerce/www/application-bulk-payments.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/dotlrn-ecommerce/www/application-bulk-payments.tcl 26 Apr 2018 08:56:38 -0000 1.3 +++ openacs-4/packages/dotlrn-ecommerce/www/application-bulk-payments.tcl 9 May 2018 15:33:30 -0000 1.4 @@ -87,8 +87,8 @@ } set method_count 0 -set new_payment_methods {} -set validate {} +set new_payment_methods [list] +set validate [list] foreach payment_method [split $payment_methods] { set _payment_method [split $payment_method :] if { [llength $_payment_method] == 2 } { Index: openacs-4/packages/dotlrn-ecommerce/www/admin/membership-add.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn-ecommerce/www/admin/membership-add.tcl,v diff -u -N -r1.9 -r1.10 --- openacs-4/packages/dotlrn-ecommerce/www/admin/membership-add.tcl 26 Apr 2018 08:56:38 -0000 1.9 +++ openacs-4/packages/dotlrn-ecommerce/www/admin/membership-add.tcl 9 May 2018 15:33:30 -0000 1.10 @@ -84,7 +84,7 @@ ns_set put $form __refreshing_p 0 } -set validate {} +set validate [list] if { ( [empty_string_p $patron] || [llength $patron_list] == 1 ) && ! $patron_id } { ad_form -name "patron" -export { {patron_id 0} } -form { Index: openacs-4/packages/dotlrn-ecommerce/www/admin/process-purchase-course.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn-ecommerce/www/admin/process-purchase-course.tcl,v diff -u -N -r1.25 -r1.26 --- openacs-4/packages/dotlrn-ecommerce/www/admin/process-purchase-course.tcl 26 Apr 2018 08:56:38 -0000 1.25 +++ openacs-4/packages/dotlrn-ecommerce/www/admin/process-purchase-course.tcl 9 May 2018 15:33:30 -0000 1.26 @@ -78,7 +78,7 @@ dotlrn_ecommerce::check_user -user_id $participant_id } -set validate {} +set validate [list] # Search course or section set section_list [linsert [db_list_of_lists sections { Index: openacs-4/packages/dotlrn-ecommerce/www/admin/ecommerce/invoice-payment.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn-ecommerce/www/admin/ecommerce/invoice-payment.tcl,v diff -u -N -r1.7 -r1.8 --- openacs-4/packages/dotlrn-ecommerce/www/admin/ecommerce/invoice-payment.tcl 26 Apr 2018 08:56:38 -0000 1.7 +++ openacs-4/packages/dotlrn-ecommerce/www/admin/ecommerce/invoice-payment.tcl 9 May 2018 15:33:30 -0000 1.8 @@ -28,7 +28,7 @@ set form [rp_getform] ns_set delkey $form creditcard_expires -set validate {} +set validate [list] set billing_address_id [db_list get_billing_address_id " select address_id @@ -51,7 +51,7 @@ } set method_count 0 -set new_payment_methods {} +set new_payment_methods [list] foreach payment_method [split $payment_methods] { set _payment_method [split $payment_method :] if { [llength $_payment_method] == 2 } { Index: openacs-4/packages/dotlrn-ecommerce/www/ecommerce/checkout-one-form.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn-ecommerce/www/ecommerce/checkout-one-form.tcl,v diff -u -N -r1.24 -r1.25 --- openacs-4/packages/dotlrn-ecommerce/www/ecommerce/checkout-one-form.tcl 26 Apr 2018 08:56:38 -0000 1.24 +++ openacs-4/packages/dotlrn-ecommerce/www/ecommerce/checkout-one-form.tcl 9 May 2018 15:33:30 -0000 1.25 @@ -158,7 +158,7 @@ set lowest_price [lindex [ec_lowest_price_and_price_name_for_an_item $product_id $user_id $offer_code] 0] } } - set option_list {} + set option_list [list] if { ![empty_string_p $color_choice] } { lappend option_list "Color: $color_choice" } @@ -445,7 +445,7 @@ select state_name, abbrev from us_states order by state_name }] 0 {"Select a state" ""}] -set validate {} +set validate [list] ad_form -name checkout -export {billing_address_id shipping_address_id user_id participant_id} -form { {bill_to_first_names:text {label "First name(s)"} {html {size 40}}} @@ -535,7 +535,7 @@ } set method_count 0 -set new_payment_methods {} +set new_payment_methods [list] foreach payment_method [split $payment_methods] { set _payment_method [split $payment_method :] if { [llength $_payment_method] == 2 } { Index: openacs-4/packages/dotlrn-ecommerce/www/manage/membership-add.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn-ecommerce/www/manage/membership-add.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/dotlrn-ecommerce/www/manage/membership-add.tcl 26 Apr 2018 08:56:38 -0000 1.2 +++ openacs-4/packages/dotlrn-ecommerce/www/manage/membership-add.tcl 9 May 2018 15:33:31 -0000 1.3 @@ -84,7 +84,7 @@ ns_set put $form __refreshing_p 0 } -set validate {} +set validate [list] if { ( [empty_string_p $patron] || [llength $patron_list] == 1 ) && ! $patron_id } { ad_form -name "patron" -export { {patron_id 0} } -form { Index: openacs-4/packages/dotlrn-ecommerce/www/manage/ecommerce/invoice-payment.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn-ecommerce/www/manage/ecommerce/invoice-payment.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/dotlrn-ecommerce/www/manage/ecommerce/invoice-payment.tcl 26 Apr 2018 08:56:38 -0000 1.2 +++ openacs-4/packages/dotlrn-ecommerce/www/manage/ecommerce/invoice-payment.tcl 9 May 2018 15:33:31 -0000 1.3 @@ -28,7 +28,7 @@ set form [rp_getform] ns_set delkey $form creditcard_expires -set validate {} +set validate [list] set billing_address_id [db_list get_billing_address_id " select address_id @@ -51,7 +51,7 @@ } set method_count 0 -set new_payment_methods {} +set new_payment_methods [list] foreach payment_method [split $payment_methods] { set _payment_method [split $payment_method :] if { [llength $_payment_method] == 2 } { Index: openacs-4/packages/dynamic-types/tcl/dynamic-type-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dynamic-types/tcl/dynamic-type-procs.tcl,v diff -u -N -r1.11 -r1.12 --- openacs-4/packages/dynamic-types/tcl/dynamic-type-procs.tcl 25 Apr 2018 19:47:47 -0000 1.11 +++ openacs-4/packages/dynamic-types/tcl/dynamic-type-procs.tcl 9 May 2018 15:33:31 -0000 1.12 @@ -32,7 +32,7 @@ set attributes_list [dtype::get_attributes_list -name $object_type -start_with acs_object -storage_types type_specific -exclude_static_p $exclude_static_p] upvar $array local - set columns {} + set columns [list] foreach attribute_info $attributes_list { foreach {name pretty_name attribute_id datatype table_name column_name default_value min_n_values max_n_values static_p} $attribute_info break Index: openacs-4/packages/dynamic-types/tcl/event-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dynamic-types/tcl/event-procs.tcl,v diff -u -N -r1.7 -r1.8 --- openacs-4/packages/dynamic-types/tcl/event-procs.tcl 25 Apr 2018 19:47:47 -0000 1.7 +++ openacs-4/packages/dynamic-types/tcl/event-procs.tcl 9 May 2018 15:33:31 -0000 1.8 @@ -66,7 +66,7 @@ if {[nsv_exists util_events $event]} { set handlers [nsv_get util_events $event] - set result {} + set result [list] foreach handler $handlers { set cand_match [lindex $handler 0] set cand_script [lindex $handler 1] @@ -122,7 +122,7 @@ lappend type_bins "[join [lrange $type_elms 0 $i] "."]." } - set results {} + set results [list] foreach type_bin $type_bins { if {[nsv_exists util_events $type_bin]} { Index: openacs-4/packages/dynamic-types/tcl/form-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dynamic-types/tcl/form-procs.tcl,v diff -u -N -r1.18 -r1.19 --- openacs-4/packages/dynamic-types/tcl/form-procs.tcl 25 Apr 2018 19:47:47 -0000 1.18 +++ openacs-4/packages/dynamic-types/tcl/form-procs.tcl 9 May 2018 15:33:31 -0000 1.19 @@ -291,8 +291,8 @@ ####################################################### # Build up insert statement from metadata # - set columns {} - set values {} + set columns [list] + set values [list] # set default fields with provided values foreach var_spec $default_fields { @@ -480,7 +480,7 @@ insert into ${type_info(table_name)}i ([join $columns ", "]) values ([join $values ", "])" } else { - set updates {} + set updates [list] set all_columns [concat $columns $missing_columns] set all_values [concat $values $missing_columns] @@ -551,8 +551,8 @@ # Generate form elements for each attribute / widget for {set w 1} {$w <= $widget_count} {incr w} { template::multirow get widgets $w - set html_options {} - set widget_options {} + set html_options [list] + set widget_options [list] # exclude specified widgets if {[lsearch -exact $exclude $widgets(attribute_name)] > -1} { @@ -823,7 +823,7 @@ # if the option list is empty, return # somethign the select widget can use if {$value eq ""} { - set value [list {}] + set value [list [list]] } } } Index: openacs-4/packages/dynamic-types/tcl/table-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dynamic-types/tcl/table-procs.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/dynamic-types/tcl/table-procs.tcl 25 Apr 2018 19:47:47 -0000 1.4 +++ openacs-4/packages/dynamic-types/tcl/table-procs.tcl 9 May 2018 15:33:31 -0000 1.5 @@ -45,7 +45,7 @@ @error } { set cols_lists [db_list_of_lists get_cols ""] - set cols {} + set cols [list] foreach l $cols_lists { lappend cols [lindex $l 0] [lindex $l 1] } Index: openacs-4/packages/ecommerce/tcl/ecommerce-widgets-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ecommerce/tcl/ecommerce-widgets-procs.tcl,v diff -u -N -r1.25 -r1.26 --- openacs-4/packages/ecommerce/tcl/ecommerce-widgets-procs.tcl 25 Apr 2018 19:47:47 -0000 1.25 +++ openacs-4/packages/ecommerce/tcl/ecommerce-widgets-procs.tcl 9 May 2018 15:33:31 -0000 1.26 @@ -146,7 +146,7 @@ set to_return " $label" @@ -226,7 +226,7 @@ } "checkbox" { - set choices {} + set choices [list] db_foreach question_choices_3 "" { if { [info exists selected_choices($choice_id)] } { lappend choices " $label" Index: openacs-4/packages/survey/www/respond.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/survey/www/respond.tcl,v diff -u -N -r1.13 -r1.14 --- openacs-4/packages/survey/www/respond.tcl 26 Apr 2018 08:56:38 -0000 1.13 +++ openacs-4/packages/survey/www/respond.tcl 9 May 2018 15:33:33 -0000 1.14 @@ -71,7 +71,7 @@ set rownum 0 # for double-click protection set new_response_id [db_nextval acs_object_id_seq] -set questions {} +set questions [list] db_foreach survey_sections {} { Index: openacs-4/packages/survey/www/admin/respond.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/survey/www/admin/respond.tcl,v diff -u -N -r1.8 -r1.9 --- openacs-4/packages/survey/www/admin/respond.tcl 26 Apr 2018 08:56:38 -0000 1.8 +++ openacs-4/packages/survey/www/admin/respond.tcl 9 May 2018 15:33:33 -0000 1.9 @@ -72,7 +72,7 @@ set rownum 0 # for double-click protection set new_response_id [db_nextval acs_object_id_seq] -set questions {} +set questions [list] db_foreach survey_sections {} { Index: openacs-4/packages/survey/www/admin/survey-preview.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/survey/www/admin/survey-preview.tcl,v diff -u -N -r1.10 -r1.11 --- openacs-4/packages/survey/www/admin/survey-preview.tcl 26 Apr 2018 08:56:38 -0000 1.10 +++ openacs-4/packages/survey/www/admin/survey-preview.tcl 9 May 2018 15:33:33 -0000 1.11 @@ -52,7 +52,7 @@ # build a list containing the HTML (generated with survey_question_display) for each question set rownum 0 -set questions {} +set questions [list] db_foreach survey_sections {} { Index: openacs-4/packages/survey-reports/www/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/survey-reports/www/index.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/survey-reports/www/index.tcl 25 Apr 2018 19:47:48 -0000 1.3 +++ openacs-4/packages/survey-reports/www/index.tcl 9 May 2018 15:33:33 -0000 1.4 @@ -196,7 +196,7 @@ set properties(survey_id) $survey_id if {[string equal "t" $rtf]} { set master "/home/prodcomp/openacs/packages/survey/lib/print-report-master" - set vars {} + set vars [list] foreach var $var_names { lappend vars $var [set $var] } Index: openacs-4/packages/survey-reports/www/view.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/survey-reports/www/view.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/survey-reports/www/view.tcl 26 Apr 2018 08:56:38 -0000 1.3 +++ openacs-4/packages/survey-reports/www/view.tcl 9 May 2018 15:33:33 -0000 1.4 @@ -43,9 +43,9 @@ set screen_name $user(screen_name) set current_date [ns_fmttime [ns_time] "%B %e, %Y"] -set var_names {} +set var_names [list] -set used_list {} +set used_list [list] set orig_survey_id $survey_id db_multirow surveys_used surveys_used { @@ -411,7 +411,7 @@ set properties(manage_url) "[ad_conn package_url]manage/${item(name)}" set properties(admin_p) [permission::permission_p -object_id $package_id -privilege admin] -set vars {} +set vars [list] foreach var $var_names { lappend vars $var [set $var] } Index: openacs-4/packages/tasks/lib/contacts-bulk-add-process.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/tasks/lib/contacts-bulk-add-process.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/tasks/lib/contacts-bulk-add-process.tcl 26 Apr 2018 08:56:38 -0000 1.2 +++ openacs-4/packages/tasks/lib/contacts-bulk-add-process.tcl 9 May 2018 15:33:33 -0000 1.3 @@ -23,7 +23,7 @@ set context [list $title] set package_id [ad_conn package_id] -set assigneees {} +set assigneees [list] foreach party $party_id { contact::require_visiblity -party_id $party if { $process_id ne "" } { Index: openacs-4/packages/tasks/lib/task-form.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/tasks/lib/task-form.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/tasks/lib/task-form.tcl 26 Apr 2018 08:56:38 -0000 1.5 +++ openacs-4/packages/tasks/lib/task-form.tcl 9 May 2018 15:33:33 -0000 1.6 @@ -24,7 +24,7 @@ } set task_form_vars [list task_id names assignee_id task_prescribed task due_date status priority description comment creator] -set export_vars {} +set export_vars [list] foreach {key value} $export_vars_list { if { [lsearch $task_form_vars $key] < 0 } { set $key $value @@ -97,7 +97,7 @@ append assign_parties_options " [db_list_of_lists get_all_users { }]" -set names {} +set names [list] foreach object $object_id { lappend names "[db_string get_acs_object_name { select acs_object__name(:object) }]" } Index: openacs-4/packages/tasks/tcl/tasks-callback-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/tasks/tcl/tasks-callback-procs.tcl,v diff -u -N -r1.11 -r1.12 --- openacs-4/packages/tasks/tcl/tasks-callback-procs.tcl 25 Apr 2018 19:47:48 -0000 1.11 +++ openacs-4/packages/tasks/tcl/tasks-callback-procs.tcl 9 May 2018 15:33:33 -0000 1.12 @@ -23,7 +23,7 @@ } { Add task history to this party. Return as list } { - set tasks {} + set tasks [list] db_foreach get_tasks { select t.task_id, t.completed_date as completion_date, Index: openacs-4/packages/theme-ges/tcl/theme-ges-procs.tcl.txt =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/theme-ges/tcl/theme-ges-procs.tcl.txt,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/theme-ges/tcl/theme-ges-procs.tcl.txt 26 Apr 2018 08:56:38 -0000 1.3 +++ openacs-4/packages/theme-ges/tcl/theme-ges-procs.tcl.txt 9 May 2018 15:33:33 -0000 1.4 @@ -118,9 +118,9 @@ set user_name {} } - set navbar {} + set navbar [list] - set tabs_list {} + set tabs_list [list] # Verifying if the user is external then this package does not add the # following tabs, cursos actuales, comunidad y panel de control @@ -249,7 +249,7 @@ regsub -all {[^0-9]} $page_num {} page_num } - set subnavbar {} + set subnavbar [list] db_foreach list_page_nums_select {} { if {[string equal $page_num $sort_key]} { Index: openacs-4/packages/tsoap/tcl/utils-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/tsoap/tcl/utils-procs.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/tsoap/tcl/utils-procs.tcl 25 Apr 2018 19:47:48 -0000 1.3 +++ openacs-4/packages/tsoap/tcl/utils-procs.tcl 9 May 2018 15:33:33 -0000 1.4 @@ -48,7 +48,7 @@ proc ::SOAP::Utils::selectNode {doc path} { set path [split [string trimleft $path {/}] {/}] set node [$doc documentElement] - set log {} + set log [list] if {[lindex [SOAP::xpath::xmlnsSplit [$node nodeName]] 1] != [lindex $path 0]} { return "" Index: openacs-4/packages/webmail/tcl/wm-util-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/webmail/tcl/wm-util-procs.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/webmail/tcl/wm-util-procs.tcl 25 Apr 2018 19:47:48 -0000 1.4 +++ openacs-4/packages/webmail/tcl/wm-util-procs.tcl 9 May 2018 15:33:33 -0000 1.5 @@ -101,7 +101,7 @@ "Name" , the corresponding output will be similar (including both names and email), but only the actual email address will be checked. } { - set return_emails {} + set return_emails [list] foreach email $email_list { set email [string trim $email] if { ![regexp {<([^>]+)>} $email match email_value] } { @@ -170,11 +170,11 @@ @param content_types The name of the variable you want the list of content-type headers stored in. @return A list of header value pairs. } { - set return_fields {} + set return_fields [list] upvar $references_var rvar - set rvar {} + set rvar [list] upvar $content_types c_types - set c_types {} + set c_types [list] if { $header_display_style == "short" } { set header_restriction_clause " and lower(name) in ('cc', 'in-response-to', 'references', 'reply-to', 'to', 'from', 'subject', 'date', 'content-type')" } else { @@ -188,7 +188,7 @@ ORDER BY sort_order desc"] # Re-order four main headers to always be first - set new_header_fields {} + set new_header_fields [list] foreach name { from to subject date } { set pos [lsearch -regexp $header_fields "^${name} (.*)"] lappend new_header_fields [lindex $header_fields $pos] @@ -301,7 +301,7 @@ } set last $msg_id } - set nav_links {} + set nav_links [list] return [list [list "Previous Unread" $prev_unread] \ [list "Previous" $prev] [list "Next" $next] \ [list "Next Unread" $next_unread] ] Index: openacs-4/packages/webmail-system/tcl/webmail-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/webmail-system/tcl/webmail-procs.tcl,v diff -u -N -r1.6 -r1.7 --- openacs-4/packages/webmail-system/tcl/webmail-procs.tcl 25 Apr 2018 19:47:48 -0000 1.6 +++ openacs-4/packages/webmail-system/tcl/webmail-procs.tcl 9 May 2018 15:33:33 -0000 1.7 @@ -675,7 +675,7 @@ @param attr The list of attributes to disable Disables all passed HTML Attributes. } { - set attributes {} + set attributes [list] for { set i [string first < $html] } { $i != -1 } { set i [string first < $html $i] } { incr i regexp -indices -start $i {\A/?([-_a-zA-Z0-9]+)\s*} $html match name_idx Index: openacs-4/packages/webmail-system/www/account.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/webmail-system/www/account.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/webmail-system/www/account.tcl 26 Apr 2018 08:56:39 -0000 1.2 +++ openacs-4/packages/webmail-system/www/account.tcl 9 May 2018 15:33:33 -0000 1.3 @@ -25,7 +25,7 @@ set id [ad_get_client_property webmail-system conn_id] set user_id [ad_conn user_id] -set opts {} +set opts [list] db_multirow -extend { server_line } servers get_servers {} { set server_line "$neat_name ($host_addr)" Index: openacs-4/packages/webmail-system/www/compose.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/webmail-system/www/compose.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/webmail-system/www/compose.tcl 26 Apr 2018 08:56:39 -0000 1.4 +++ openacs-4/packages/webmail-system/www/compose.tcl 9 May 2018 15:33:33 -0000 1.5 @@ -44,7 +44,7 @@ # ------------------------- CREATE FORM ------------------------- # -#set opts {} +#set opts [list] #db_multirow emails get_emails {} { # lappend opts [list $email] @@ -170,7 +170,7 @@ set has_attach_p 0 } - set emailList {} + set emailList [list] package require smtp package require mime Index: openacs-4/packages/webmail-system/www/folder-delete.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/webmail-system/www/folder-delete.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/webmail-system/www/folder-delete.tcl 26 Apr 2018 08:56:39 -0000 1.3 +++ openacs-4/packages/webmail-system/www/folder-delete.tcl 9 May 2018 15:33:33 -0000 1.4 @@ -46,7 +46,7 @@ # -------------------------- PROCESSING ------------------------- # set folders [ns_imap list $id $mailbox *] -set fnames {} +set fnames [list] foreach {odd even} $folders { lappend fnames $odd Index: openacs-4/packages/webmail-system/www/folders.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/webmail-system/www/folders.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/webmail-system/www/folders.tcl 26 Apr 2018 08:56:39 -0000 1.2 +++ openacs-4/packages/webmail-system/www/folders.tcl 9 May 2018 15:33:33 -0000 1.3 @@ -64,7 +64,7 @@ # -------------------------- PROCESSING ------------------------- # set folders [ns_imap list $id $mailbox *] -set fnames {} +set fnames [list] set number 0 foreach {odd even} $folders { incr number Index: openacs-4/packages/webmail-system/www/mail-reply.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/webmail-system/www/mail-reply.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/webmail-system/www/mail-reply.tcl 26 Apr 2018 08:56:39 -0000 1.3 +++ openacs-4/packages/webmail-system/www/mail-reply.tcl 9 May 2018 15:33:33 -0000 1.4 @@ -74,7 +74,7 @@ set use_wysiwyg_p [parameter::get -parameter "UseWysiwygP" -default "f"] -set opts {} +set opts [list] db_multirow emails get_emails {} { lappend opts [list "$username@$host_addr"] Index: openacs-4/packages/webmail-system/www/preferences.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/webmail-system/www/preferences.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/webmail-system/www/preferences.tcl 26 Apr 2018 08:56:39 -0000 1.2 +++ openacs-4/packages/webmail-system/www/preferences.tcl 9 May 2018 15:33:33 -0000 1.3 @@ -28,13 +28,13 @@ # ------------------------- CREATE FORM ------------------------- # -set options {} +set options [list] lappend options [list "[_ webmail-system.Full_HTML]" 0] lappend options [list "[_ webmail-system.HTML_without_CSS]" 1] lappend options [list "[_ webmail-system.Enhanced_Text]" 2] lappend options [list "[_ webmail-system.Plain_Text]" 3] -set opts {} +set opts [list] lappend opts [list "[_ webmail-system.Text]" 0] lappend opts [list "[_ webmail-system.Icons]" 1] Index: openacs-4/packages/webmail-system/www/admin/account.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/webmail-system/www/admin/account.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/webmail-system/www/admin/account.tcl 26 Apr 2018 08:56:39 -0000 1.2 +++ openacs-4/packages/webmail-system/www/admin/account.tcl 9 May 2018 15:33:33 -0000 1.3 @@ -24,14 +24,14 @@ set address "Administrator" set id [ad_get_client_property webmail-system conn_id] -set opts {} +set opts [list] db_multirow -extend { server_line } servers get_servers {} { set server_line "$neat_name ($host_addr)" lappend opts [list $server_line $server_id ] } -set uopts {} +set uopts [list] db_multirow -extend { name } users get_users {} { acs_user::get -user_id $user_id -array user Index: openacs-4/packages/webmail-system/www/admin/server.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/webmail-system/www/admin/server.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/webmail-system/www/admin/server.tcl 26 Apr 2018 08:56:39 -0000 1.2 +++ openacs-4/packages/webmail-system/www/admin/server.tcl 9 May 2018 15:33:33 -0000 1.3 @@ -25,12 +25,12 @@ set user_id [ad_conn user_id] -set opts {} +set opts [list] db_multirow auth_types get_auth_types {} { lappend opts [list $type $type_id] } -set options {} +set options [list] db_multirow server_types get_serv_types {} { lappend options [list $type $type_id] } Index: openacs-4/packages/workflow/tcl/action-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/workflow/tcl/action-procs.tcl,v diff -u -N -r1.39 -r1.40 --- openacs-4/packages/workflow/tcl/action-procs.tcl 25 Apr 2018 19:47:48 -0000 1.39 +++ openacs-4/packages/workflow/tcl/action-procs.tcl 9 May 2018 15:33:33 -0000 1.40 @@ -105,7 +105,7 @@ } { # Wrapper for workflow::action::edit - array set row {} + array set row [list] foreach col { initial_action_p sort_order short_name pretty_name pretty_past_tense edit_fields allowed_roles assigned_role @@ -269,9 +269,9 @@ unset missing_elm(initial_action_p) } - set update_clauses {} - set insert_names {} - set insert_values {} + set update_clauses [list] + set insert_names [list] + set insert_values [list] # Handle columns in the workflow_actions table foreach attr { short_name @@ -673,7 +673,7 @@ # Loop over the callbacks and return the impl_names of those with a matching # contract name - set impl_names {} + set impl_names [list] foreach callback_id $callback_ids { array set one_callback $callbacks($callback_id) @@ -707,7 +707,7 @@ @param ignore_action_id If specified, the short_name for the given action will not be included in the result set. } { - set result {} + set result [list] foreach action_id [workflow::get_actions -all -workflow_id $workflow_id] { if { $ignore_action_id eq "" || $ignore_action_id ne $action_id } { @@ -775,7 +775,7 @@ return $action_data(action_ids) } - set action_ids {} + set action_ids [list] foreach action_id $action_data(action_ids) { if { [workflow::action::get_element \ -action_id $action_id \ @@ -794,7 +794,7 @@ } { Get an options list of actions for use with form builder. } { - set result {} + set result [list] foreach action_id [workflow::get_actions \ -all=$all_p \ -workflow_id $workflow_id \ @@ -874,7 +874,7 @@ } { # Wrapper for workflow::action::edit - array set row {} + array set row [list] foreach col { initial_action_p sort_order short_name pretty_name pretty_past_tense edit_fields allowed_roles assigned_role @@ -1000,9 +1000,9 @@ unset row(new_state) } - set update_clauses {} - set insert_names {} - set insert_values {} + set update_clauses [list] + set insert_names [list] + set insert_values [list] # Handle columns in the workflow_fsm_actions table foreach attr { @@ -1040,7 +1040,7 @@ if { [info exists row(enabled_state_ids)] } { error "You cannot supply both enabled_states and enabled_state_ids" } - set row(enabled_state_ids) {} + set row(enabled_state_ids) [list] foreach state_short_name $row(enabled_states) { lappend row(enabled_state_ids) [workflow::state::fsm::get_id \ -workflow_id $workflow_id \ @@ -1052,7 +1052,7 @@ if { [info exists row(assigned_state_ids)] } { error "You cannot supply both assigned_states and assigned_state_ids" } - set row(assigned_state_ids) {} + set row(assigned_state_ids) [list] foreach state_short_name $row(assigned_states) { lappend row(assigned_state_ids) [workflow::state::fsm::get_id \ -workflow_id $workflow_id \ @@ -1062,7 +1062,7 @@ } # Handle auxiliary rows - array set aux {} + array set aux [list] foreach attr { enabled_state_ids assigned_state_ids } { @@ -1384,7 +1384,7 @@ # LARS: Ugly as hell with the string range to cut from 'actions' to 'action_ids' if { [info exists row(child_[string range $type 0 end-1]_ids)] } { - set row(child_${type}) {} + set row(child_${type}) [list] foreach child_id $row(child_[string range $type 0 end-1]_ids) { set child_short_name [${namespace}::get_element \ -one_id $child_id \ @@ -1406,7 +1406,7 @@ always_enabled_p f } - set spec {} + set spec [list] foreach name [lsort [array names row]] { if { $row($name) ne "" && ![exists_and_equal defaults($name) $row($name)] } { lappend spec $name $row($name) @@ -1520,7 +1520,7 @@ array set action_data {} # This will be a list of all action_id's - set action_ids {} + set action_ids [list] # Get basic action info db_foreach action_info {} -column_array action_row { @@ -1555,8 +1555,8 @@ foreach action_id $action_ids { if { ![info exists action_array_${action_id}(child_action_ids)] } { - set action_array_${action_id}(child_action_ids) {} - set action_array_${action_id}(child_actios) {} + set action_array_${action_id}(child_action_ids) [list] + set action_array_${action_id}(child_actios) [list] } } Index: openacs-4/packages/workflow/tcl/case-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/workflow/tcl/case-procs.tcl,v diff -u -N -r1.52 -r1.53 --- openacs-4/packages/workflow/tcl/case-procs.tcl 25 Apr 2018 19:47:48 -0000 1.52 +++ openacs-4/packages/workflow/tcl/case-procs.tcl 9 May 2018 15:33:33 -0000 1.53 @@ -383,7 +383,7 @@ set user_id [ad_conn user_id] } - set action_list {} + set action_list [list] foreach enabled_action_id [workflow::case::get_enabled_action_ids -case_id $case_id] { if { [workflow::case::action::permission_p -enabled_action_id $enabled_action_id -user_id $user_id] } { @@ -412,7 +412,7 @@ set user_id [ad_conn user_id] } - set action_list {} + set action_list [list] foreach enabled_action_id [get_enabled_action_ids -case_id $case_id] { if { [workflow::case::action::permission_p -enabled_action_id $enabled_action_id -user_id $user_id] } { @@ -623,12 +623,12 @@ set counter 1 set last_entry_id {} - set data_arraylist {} + set data_arraylist [list] # Then iterate over the multirow to build up the activity log HTML # We need to peek ahead, because this is an outer join to get the rows in workflow_case_log_data - set entries {} + set entries [list] template::multirow -local foreach entries { if { $key ne "" } { @@ -637,7 +637,7 @@ if { $counter == $rowcount || $last_entry_id ne [set "entries:[expr {$counter + 1}](entry_id)"] } { - set log_title_elements {} + set log_title_elements [list] foreach impl_name $impl_names { set result [acs_sc::invoke \ -contract $contract_name \ @@ -650,7 +650,7 @@ } set log_title [ad_decode [llength $log_title_elements] 0 "" "([join $log_title_elements ", "])"] - set row {} + set row [list] foreach var { comment comment_mime_type creation_date_pretty action_pretty_past_tense log_title user_first_names user_last_name user_email creation_user data_arraylist @@ -659,7 +659,7 @@ } lappend entries $row - set data_arraylist {} + set data_arraylist [list] } set last_entry_id $entry_id incr counter @@ -1001,7 +1001,7 @@ } { set contract_name [workflow::service_contract::role_assignee_pick_list] - set party_id_list {} + set party_id_list [list] db_transaction { @@ -1841,7 +1841,7 @@ } # Output notification info - set object_details_lines {} + set object_details_lines [list] foreach { label value } $object_details_list { if { $label ne "" } { lappend object_details_lines "$label[string repeat " " [expr {$max_label_len - [string length $label]}]] : $value" @@ -1860,7 +1860,7 @@ #XXXXX Verify this ... probably wrong set assigned_role_id [workflow::action::get_assigned_role -action_id $action_id] - set assignee_list {} + set assignee_list [list] foreach assignee_array [workflow::case::role::get_assignees \ -case_id $case_id \ -role_id $assigned_role_id] { @@ -1917,7 +1917,7 @@ set subset(workflow_assignee) $assignee_list set subset(workflow_my_cases) $case_player_list - set notified_list {} + set notified_list [list] foreach type { workflow_assignee workflow_my_cases workflow_case workflow @@ -2188,7 +2188,7 @@ array set enable_action_ids [array get assigned_p] # List of enabled_action_id's of actions that are no longer enabled - set unenable_enabled_action_ids {} + set unenable_enabled_action_ids [list] #---------------------------------------------------------------------- # 2. Get the rows in workflow_case_enabled_actions Index: openacs-4/packages/workflow/tcl/role-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/workflow/tcl/role-procs.tcl,v diff -u -N -r1.27 -r1.28 --- openacs-4/packages/workflow/tcl/role-procs.tcl 25 Apr 2018 19:47:48 -0000 1.27 +++ openacs-4/packages/workflow/tcl/role-procs.tcl 9 May 2018 15:33:33 -0000 1.28 @@ -143,9 +143,9 @@ # Parse column values switch $operation { insert - update { - set update_clauses {} - set insert_names {} - set insert_values {} + set update_clauses [list] + set insert_names [list] + set insert_values [list] # Handle columns in the workflow_roles table foreach attr { @@ -292,7 +292,7 @@ @author Lars Pind (lars@collaboraid.biz) } { - set result {} + set result [list] # workflow::get_roles returns the roles in sort_order foreach role_id [workflow::get_roles -workflow_id $workflow_id] { @@ -598,7 +598,7 @@ @author Peter Marklund } { # For performance we avoid nested queries in this proc - set role_ids {} + set role_ids [list] db_foreach role_info {} -column_array row { set role_id $row(role_id) @@ -620,8 +620,8 @@ foreach role_id $role_ids { set role,${role_id}(callbacks) {} set role,${role_id}(callback_ids) {} - array set callback_impl_names,$role_id {} - array set callbacks_array,$role_id {} + array set callback_impl_names,$role_id [list] + array set callbacks_array,$role_id [list] } db_foreach role_callbacks {} -column_array row { @@ -674,7 +674,7 @@ @param ignore_role_id If specified, the short_name for the given role will not be included in the result set. } { - set result {} + set result [list] foreach role_id [workflow::get_roles -all -workflow_id $workflow_id] { if { $ignore_role_id eq "" || $ignore_role_id ne $role_id } { @@ -779,7 +779,7 @@ } { set contract_name [workflow::service_contract::role_assignee_pick_list] - set party_id_list {} + set party_id_list [list] db_transaction { Index: openacs-4/packages/workflow/tcl/state-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/workflow/tcl/state-procs.tcl,v diff -u -N -r1.21 -r1.22 --- openacs-4/packages/workflow/tcl/state-procs.tcl 25 Apr 2018 19:47:48 -0000 1.21 +++ openacs-4/packages/workflow/tcl/state-procs.tcl 9 May 2018 15:33:33 -0000 1.22 @@ -177,9 +177,9 @@ unset missing_elm(parent_action) } - set update_clauses {} - set insert_names {} - set insert_values {} + set update_clauses [list] + set insert_names [list] + set insert_values [list] # Handle columns in the workflow_fsm_states table foreach attr { @@ -229,7 +229,7 @@ if { [info exists row(enabled_action_ids)] } { error "You cannot supply both enabled_actions and enabled_actions_ids" } - set row(enabled_action_ids) {} + set row(enabled_action_ids) [list] foreach action_short_name $row(enabled_actions) { lappend row(enabled_action_ids) [workflow::action::get_id \ -workflow_id $workflow_id \ @@ -243,7 +243,7 @@ if { [info exists row(assigned_action_ids)] } { error "You cannot supply both assigned_actions and assigned_action_ids" } - set row(assigned_action_ids) {} + set row(assigned_action_ids) [list] foreach action_short_name $row(assigned_actions) { lappend row(assigned_action_ids) [workflow::action::get_id \ -workflow_id $workflow_id \ @@ -253,7 +253,7 @@ } # Handle auxiliary rows - array set aux {} + array set aux [list] foreach attr { enabled_action_ids assigned_action_ids } { @@ -373,7 +373,7 @@ @param ignore_state_id If specified, the short_name for the given state will not be included in the result set. } { - set result {} + set result [list] foreach state_id [workflow::fsm::get_states -all -workflow_id $workflow_id] { if { $ignore_state_id eq "" || $ignore_state_id ne $state_id } { @@ -540,7 +540,7 @@ if { $all_p } { return $state_data(state_ids) } - set state_ids {} + set state_ids [list] foreach state_id $state_data(state_ids) { if { [workflow::state::fsm::get_element \ -state_id $state_id \ @@ -659,7 +659,7 @@ @author Lars Pind (lars@collaboraid.biz) } { # states(short_name) { ... state-spec ... } - set states_list {} + set states_list [list] foreach state_id [workflow::fsm::get_states -workflow_id $workflow_id] { lappend states_list [get_element -state_id $state_id -element short_name] [generate_spec -state_id $state_id] } @@ -715,7 +715,7 @@ # enabled_actions, enabled_action_ids, assigned_actions, assigned_action_ids # In addition: # state_data(state_ids) = [list of state_ids in sort order] - array set state_data {} + array set state_data [list] # state_array_$state_id is an internal datastructure. It's the array for each state_id entry # but as a separate array making it easier to lappend to individual entries @@ -725,7 +725,7 @@ #---------------------------------------------------------------------- # Use a list to be able to retrieve states in sort order - set state_ids {} + set state_ids [list] db_foreach select_states {} -column_array state_row { # Cache the state_id -> workflow_id lookup util_memoize_seed \ @@ -740,7 +740,7 @@ } set state_data(state_ids) $state_ids - array set action_short_name {} + array set action_short_name [list] #---------------------------------------------------------------------- # Build state-action map @@ -805,10 +805,10 @@ # 3. Put stuff back into the output array foreach state_id $state_ids { - set state_array_${state_id}(enabled_action_ids) {} - set state_array_${state_id}(enabled_actions) {} - set state_array_${state_id}(assigned_action_ids) {} - set state_array_${state_id}(assigned_actions) {} + set state_array_${state_id}(enabled_action_ids) [list] + set state_array_${state_id}(enabled_actions) [list] + set state_array_${state_id}(assigned_action_ids) [list] + set state_array_${state_id}(assigned_actions) [list] if { [info exists assigned_p_${state_id}] } { foreach action_id [array names assigned_p_${state_id}] { Index: openacs-4/packages/workflow/tcl/workflow-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/workflow/tcl/workflow-procs.tcl,v diff -u -N -r1.33 -r1.34 --- openacs-4/packages/workflow/tcl/workflow-procs.tcl 25 Apr 2018 19:47:48 -0000 1.33 +++ openacs-4/packages/workflow/tcl/workflow-procs.tcl 9 May 2018 15:33:33 -0000 1.34 @@ -195,9 +195,9 @@ # Parse column values switch $operation { insert - update { - set update_clauses {} - set insert_names {} - set insert_values {} + set update_clauses [list] + set insert_names [list] + set insert_values [list] # Handle columns in the workflows table foreach attr { @@ -477,7 +477,7 @@ @param ignore_workflow_id If specified, the short_name for the given workflow will not be included in the result set. } { - set result {} + set result [list] db_foreach select_workflows { select workflow_id, @@ -573,7 +573,7 @@ array unset row description_mime_type } - set spec {} + set spec [list] # Output sorted, and with no empty elements foreach name [lsort [array names row]] { @@ -583,7 +583,7 @@ } foreach { key namespace } $handlers { - set subspec {} + set subspec [list] foreach sub_id [${namespace}::get_ids -workflow_id $workflow_id] { set sub_short_name [${namespace}::get_element \ @@ -752,9 +752,9 @@ } # Pull out the extra types, roles/actions/states, so we don't try to create the workflow with them - array set aux {} - array set counter {} - array set remain {} + array set aux [list] + array set counter [list] + array set remain [list] foreach { key namespace } $handlers { if { [info exists workflow($key)] } { set aux($key) $workflow($key) @@ -768,7 +768,7 @@ } } - array set sub_id {} + array set sub_id [list] db_transaction { # Create the workflow @@ -908,10 +908,10 @@ } { db_1row workflow_info {} -column_array row - set callbacks {} - set callback_ids {} - array set callback_impl_names {} - array set callbacks_array {} + set callbacks [list] + set callback_ids [list] + array set callback_impl_names [list] + array set callbacks_array [list] db_foreach workflow_callbacks {} -column_array callback_row { lappend callbacks "$callback_row(impl_owner_name).$callback_row(impl_name)" Index: openacs-4/packages/wp-slim/www/add-edit-slide.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/wp-slim/www/add-edit-slide.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/wp-slim/www/add-edit-slide.tcl 26 Apr 2018 08:56:39 -0000 1.5 +++ openacs-4/packages/wp-slim/www/add-edit-slide.tcl 9 May 2018 15:33:33 -0000 1.6 @@ -116,7 +116,7 @@ # Creates the bullets list dynamically. The list of list elements has the bullets # ################################################################################### -set elements {} +set elements [list] for {set j 1} {$j <= $array_max} {incr j} { set element [list bullet.$j:text(text),optional \ {html { size 60 }} \ @@ -202,7 +202,7 @@ ad_form -extend -name f -new_data { # makes a bullet list to send to the procedure - set bullet_list {} + set bullet_list [list] for {set i 1} {$i <= $array_max} {incr i} { set bullet_value [set bullet.$i] if { $bullet_value ne "" } { @@ -224,7 +224,7 @@ } -edit_data { # makes a bullet list to send to the procedure - set bullet_items {} + set bullet_items [list] for {set i 1} {$i <= $array_max} {incr i} { set bullet_value [set bullet.$i] if { $bullet_value ne "" } { Index: openacs-4/packages/wp-slim/www/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/wp-slim/www/index.tcl,v diff -u -N -r1.11 -r1.12 --- openacs-4/packages/wp-slim/www/index.tcl 26 Apr 2018 08:56:39 -0000 1.11 +++ openacs-4/packages/wp-slim/www/index.tcl 9 May 2018 15:33:33 -0000 1.12 @@ -16,7 +16,7 @@ set package_id [ad_conn package_id] -set context {} +set context [list] set user_id [ad_conn user_id] Index: openacs-4/packages/wp-slim/www/style-edit.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/wp-slim/www/style-edit.tcl,v diff -u -N -r1.8 -r1.9 --- openacs-4/packages/wp-slim/www/style-edit.tcl 26 Apr 2018 08:56:39 -0000 1.8 +++ openacs-4/packages/wp-slim/www/style-edit.tcl 9 May 2018 15:33:33 -0000 1.9 @@ -55,8 +55,8 @@ " } else { - set names {} - set values {} + set names [list] + set values [list] foreach image $items { lappend names [lindex $image 1] lappend values [lindex $image 0] @@ -73,7 +73,7 @@ [ad_generic_optionlist [list "[_ wp-slim.Yes]" "[_ wp-slim.No]"] [list t f] $public_p]\n" -set values {} +set values [list] set context "[list [list "style-list.tcl" "Your Styles"] $header "[_ wp-slim.role_Style]"]" Index: openacs-4/packages/xml-rpc/tcl/system-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xml-rpc/tcl/system-procs.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/xml-rpc/tcl/system-procs.tcl 25 Apr 2018 19:47:48 -0000 1.2 +++ openacs-4/packages/xml-rpc/tcl/system-procs.tcl 9 May 2018 15:33:33 -0000 1.3 @@ -17,7 +17,7 @@ implemented by the server. @author Vinod Kurup } { - set result {} + set result [list] foreach proc_name [xmlrpc::list_methods] { lappend result [list -string $proc_name] } @@ -66,7 +66,7 @@ standard <fault> element. @author Vinod Kurup } { - set responses {} + set responses [list] foreach call $array { # parse the call for methodName and params Index: openacs-4/packages/xml-rpc/tcl/validator-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xml-rpc/tcl/validator-procs.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/xml-rpc/tcl/validator-procs.tcl 25 Apr 2018 19:47:48 -0000 1.4 +++ openacs-4/packages/xml-rpc/tcl/validator-procs.tcl 9 May 2018 15:33:33 -0000 1.5 @@ -255,11 +255,11 @@ # for each year for {set y $startyear} {$y <= $endyear} {incr y} { - set year {} + set year [list] # for each month for {set m 1} {$m <= 12} {incr m} { - set month {} + set month [list] # for each day set mstr [format %02d $m] for {set d 1} {$d <= 31} {incr d} { Index: openacs-4/packages/xml-rpc/tcl/xml-rpc-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xml-rpc/tcl/xml-rpc-procs.tcl,v diff -u -N -r1.14 -r1.15 --- openacs-4/packages/xml-rpc/tcl/xml-rpc-procs.tcl 25 Apr 2018 19:47:48 -0000 1.14 +++ openacs-4/packages/xml-rpc/tcl/xml-rpc-procs.tcl 9 May 2018 15:33:33 -0000 1.15 @@ -19,7 +19,7 @@ } # setup nsv array to hold procs that are registered for xml-rpc access -nsv_array set xmlrpc_procs {} +nsv_array set xmlrpc_procs [list] namespace eval xmlrpc {} @@ -672,7 +672,7 @@ [lindex \ [xml_node_get_children_by_name $data methodName] 0 ]] - set arguments {} + set arguments [list] set params [xml_node_get_children_by_name $data params] if {$params ne ""} { foreach parameter [xml_node_get_children_by_name $params param] { Index: openacs-4/packages/xolp/tcl/xolp-indicator-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xolp/tcl/xolp-indicator-procs.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/xolp/tcl/xolp-indicator-procs.tcl 25 Apr 2018 19:47:48 -0000 1.4 +++ openacs-4/packages/xolp/tcl/xolp-indicator-procs.tcl 9 May 2018 15:33:33 -0000 1.5 @@ -199,8 +199,8 @@ } } set sql "" - set dimensions {} - set where_clause {} + set dimensions [list] + set where_clause [list] # Dimension: Activities if {$activity_iris ne ""} { set dimension_table "xolp_activity_dimension" Index: openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl,v diff -u -N -r1.89 -r1.90 --- openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl 25 Apr 2018 19:47:48 -0000 1.89 +++ openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl 9 May 2018 15:33:33 -0000 1.90 @@ -216,7 +216,7 @@ namespace eval ::xo { proc slotobjects cl { - set so {} + set so [list] array set names "" foreach c [list $cl {*}[$cl info heritage]] { foreach s [$c info slots] { Index: openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl,v diff -u -N -r1.14 -r1.15 --- openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl 25 Apr 2018 19:47:48 -0000 1.14 +++ openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl 9 May 2018 15:33:33 -0000 1.15 @@ -261,7 +261,7 @@ } :public object method source_to_html {{-width 100} string} { - set lines {} + set lines [list] foreach l [split $string \n] { while {[string length $l] > $width} { set pos [string last " \{" $l $width] @@ -457,7 +457,7 @@ dict set doc default_values {} dict set doc positionals {} } else { - set defaults {} + set defaults [list] foreach a [::xo::getObjectProperty $obj ${inst}args $proc_name] { if {[::xo::getObjectProperty $obj ${inst}argdefault $proc_name $a d]} { lappend defaults $a $d Index: openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl,v diff -u -N -r1.121 -r1.122 --- openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl 25 Apr 2018 19:47:48 -0000 1.121 +++ openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl 9 May 2018 15:33:33 -0000 1.122 @@ -474,7 +474,7 @@ if {$bind ne ""} {set bindOpt [list -bind $bind]} {set bindOpt ""} db_with_handle -dbn $dbn db { if {[info exists prepare]} {set sql [:prepare -handle $db -argtypes $prepare $sql]} - set result {} + set result [list] set answers [uplevel [list ns_pg_bind select $db {*}$bindOpt $sql]] while { [::db_getrow $db $answers] } { lappend result [ns_set copy $answers] @@ -585,10 +585,10 @@ if {$bind ne ""} {set bindOpt [list -bind $bind]} {set bindOpt ""} db_with_handle db { if {[info exists prepare]} {set sql [:prepare -handle $db -argtypes $prepare $sql]} - set result {} + set result [list] set answers [uplevel [list ns_pg_bind select $db {*}$bindOpt $sql]] while { [db_getrow $db $answers] } { - set row {} + set row [list] foreach {att value} [ns_set array $answers] {lappend row $value} lappend result $row } @@ -601,7 +601,7 @@ if {$bind ne ""} {set bindOpt [list -bind $bind]} {set bindOpt ""} db_with_handle db { if {[info exists prepare]} {set sql [:prepare -handle $db -argtypes $prepare $sql]} - set result {} + set result [list] set answers [uplevel [list ns_pg_bind select $db {*}$bindOpt $sql]] while { [::db_getrow $db $answers] } { lappend result [ns_set value $answers 0] @@ -1307,7 +1307,7 @@ order by pronargs desc, proargtypes desc } { set n 1 - set function_args {} + set function_args [list] foreach line [split $prosrc \n] { if {[regexp -nocase "alias +for +\\\$$n" $line]} { if {![regexp {^[^a-zA-Z]+([a-zA-Z0-9_]+)\s} $line _ fq_name]} { @@ -1366,8 +1366,8 @@ ::xo::db::DBI instproc sql_arg_info {function_args package_name object_name} { set defined {} - set psql_args {} - set arg_order {} + set psql_args [list] + set arg_order [list] # TODO function args not needed in dict foreach arg $function_args { lassign $arg arg_name default_value @@ -1548,7 +1548,7 @@ return $function_args } array set additional_defaults [::xo::db::SQL set fallback_defaults(${package_name}__$object_name)] - set result {} + set result [list] foreach arg $function_args { lassign $arg arg_name default_value if {$default_value eq "" && [info exists additional_defaults($arg_name)]} { @@ -1565,8 +1565,8 @@ ::xo::db::SQL instproc sql_arg_info {function_args package_name object_name} { set defined {} - set psql_args {} - set arg_order {} + set psql_args [list] + set arg_order [list] foreach arg $function_args { lassign $arg arg_name default_value lappend psql_args \$_$arg_name @@ -1898,8 +1898,8 @@ ::xo::db::Class instproc db_slots {} { - array set :db_slot {} - array set :db_constraints {} + array set :db_slot [list] + array set :db_constraints [list] # # First get all ::xo::db::Attribute slots and check later, # if we have to add the id_column automatically. @@ -1954,7 +1954,7 @@ } ::xo::db::Class instproc table_definition {} { - array set column_specs {} + array set column_specs [list] # # iterate over the slots and collect the column_specs for table generation # @@ -2007,7 +2007,7 @@ if {![info exists column_specs(${:id_column})]} { error "no ::xo::db::Attribute slot for id_column '${:id_column}' specified" } - set table_specs {} + set table_specs [list] foreach {att spec} [array get column_specs] {lappend table_specs $att $spec} set table_definition $table_specs } else { @@ -2018,8 +2018,8 @@ } ::xo::db::Class instproc mk_update_method {} { - set updates {} - set vars {} + set updates [list] + set vars [list] foreach {slot_name slot} [array get :db_slot] { $slot instvar name column_name if {$column_name ne [:id_column]} { @@ -2282,7 +2282,7 @@ set __result [::xo::OrderedComposite new] if {$destroy_on_cleanup} {$__result destroy_on_cleanup} } else { - set __result {} + set __result [list] } if {$named_objects} { if {$object_named_after eq ""} { @@ -2340,8 +2340,8 @@ } ::xo::db::Class instproc fetch_query {id} { - set tables {} - set attributes {} + set tables [list] + set attributes [list] set id_column [:id_column] set join_expressions [list "[:table_name].$id_column = $id"] foreach cl [list [self] {*}[:info heritage]] { @@ -2385,7 +2385,7 @@ @param count return the query for counting the solutions @return SQL query } { - set tables {} + set tables [list] set id_column [:id_column] if {$count} { @@ -2395,7 +2395,7 @@ } set all_attributes [expr {$select_attributes eq ""}] - set join_expressions {} + set join_expressions [list] foreach cl [list [self] {*}[:info heritage]] { #if {$cl eq "::xo::db::Object"} break if {$cl eq "::xotcl::Object"} break Index: openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl,v diff -u -N -r1.66 -r1.67 --- openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl 30 Apr 2018 09:46:43 -0000 1.66 +++ openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl 9 May 2018 15:33:34 -0000 1.67 @@ -137,7 +137,7 @@ @return flattened list of attribute value pairs } { - set pairs {} + set pairs [list] foreach attribute $args { set l [split $attribute] if {[llength $l] > 1} { @@ -161,7 +161,7 @@ @return flattened list of attribute value pairs } { - set pairs {} + set pairs [list] foreach attribute $args { set l [split $attribute] if {[llength $l] > 1} { @@ -245,7 +245,7 @@ #ns_log notice "--local $text $inline" set obj [uplevel self] if {![$obj exists __localizer]} { - $obj set __localizer {} + $obj set __localizer [list] } if {[string first \x02 $text] == -1} { return $text @@ -349,7 +349,7 @@ $l destroy } } - set :__localizer {} + set :__localizer [list] } \ -instproc render-data args { next @@ -411,7 +411,7 @@ set M [OrderedComposite create [self]::__columns] namespace eval $M [list namespace import -force [self class]::*] $M contains $cmd - set slots {} + set slots [list] foreach c [$M children] { lappend slots {*}[$c get-slots] } @@ -446,7 +446,7 @@ {-delimiter ","} } { set output "" - set line {} + set line [list] foreach column [[self]::__columns children] { if {[$column exists no_csv]} continue set label [$column label] @@ -458,7 +458,7 @@ } append output [join $line $delimiter] \n foreach row [:children] { - set line {} + set line [list] foreach column [[self]::__columns children] { if {[$column exists no_csv]} continue set value [string map {\" \\\" \n \r} [$row set [$column set name]]] @@ -477,7 +477,7 @@ Class create Table::Line \ -superclass ::xo::Drawable \ -instproc attlist {name atts {extra ""}} { - set result {} + set result [list] foreach att $atts { set varname $name.$att if {[info exists :$varname]} { @@ -992,8 +992,8 @@ return [list] } Page proc sort_keys_by_value {{-comparison integer} {-direction increasing} pairs} { - set result {} - set a {} + set result [list] + set a [list] foreach {key value} $pairs { lappend a [list $key $value] } Index: openacs-4/packages/xotcl-core/tcl/bgdelivery-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-core/tcl/bgdelivery-procs.tcl,v diff -u -N -r1.59 -r1.60 --- openacs-4/packages/xotcl-core/tcl/bgdelivery-procs.tcl 1 May 2018 08:38:40 -0000 1.59 +++ openacs-4/packages/xotcl-core/tcl/bgdelivery-procs.tcl 9 May 2018 15:33:34 -0000 1.60 @@ -289,7 +289,7 @@ ::xotcl::Class create Subscriber -parameter {key channel user_id mode} Subscriber proc current {-key } { - set result {} + set result [list] if {[info exists key]} { if {[info exists :subscriptions($key)]} { return [list $key [set :subscriptions($key)]] @@ -356,7 +356,7 @@ Subscriber proc foreachSubscriber {key method {argument ""}} { :msg "$key $method '$argument'" if {[info exists :subscriptions($key)]} { - set subs1 {} + set subs1 [list] foreach s [set :subscriptions($key)] { if {[catch {$s $method $argument} errMsg]} { ns_log error "error in $method to subscriber $s (key=$key): $errMsg" @@ -419,7 +419,7 @@ set :running 0 set :release 0 set :spooling 0 - set :queue {} + set :queue [list] } ::HttpSpooler instproc all_done {} { catch {close [:channel]} @@ -598,7 +598,7 @@ set range [ns_set iget [ns_conn headers] range] if {[regexp {bytes=(.*)$} $range _ range]} { - set ranges {} + set ranges [list] set bytes 0 set pos 0 foreach r [split $range ,] { Index: openacs-4/packages/xotcl-core/tcl/cr-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-core/tcl/cr-procs.tcl,v diff -u -N -r1.62 -r1.63 --- openacs-4/packages/xotcl-core/tcl/cr-procs.tcl 25 Apr 2018 19:47:48 -0000 1.62 +++ openacs-4/packages/xotcl-core/tcl/cr-procs.tcl 9 May 2018 15:33:34 -0000 1.63 @@ -132,7 +132,7 @@ @return list of item_ids } { - set items {} + set items [list] foreach item_id [::xo::dc list get_child_items \ "select item_id from cr_items where parent_id = :item_id"] { lappend items $item_id {*}[my [self proc] -item_id $item_id] @@ -429,7 +429,7 @@ set raw_atts [::xo::db::CrClass set common_query_atts] #my log "-- raw_atts = '$raw_atts'" - set atts {} + set atts [list] foreach v $raw_atts { switch -glob -- $v { publish_status {set fq i.$v} @@ -622,7 +622,7 @@ set attribute_selection [join $attributes ,] } - set cond {} + set cond [list] if {$type_selection_clause ne ""} {lappend cond $type_selection_clause} if {$where_clause ne ""} {lappend cond $where_clause} if {[info exists publish_status]} {lappend cond "ci.publish_status = :publish_status"} @@ -815,8 +815,8 @@ # view. So we postpone these updates and perform these # as separate statements. # - set values {} - set attributes {} + set values [list] + set attributes [list] #my msg "--long_text_slots: [array get :long_text_slots]" foreach a $atts v $vars { @@ -1399,7 +1399,7 @@ set attribute_selection [join $attributes ,] } - set cond {} + set cond [list] if {$type_selection_clause ne ""} {lappend cond $type_selection_clause} if {$where_clause ne ""} {lappend cond $where_clause} if {[info exists publish_status]} {lappend cond "ci.publish_status = :publish_status"} Index: openacs-4/packages/xotcl-core/tcl/doc-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-core/tcl/doc-procs.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/xotcl-core/tcl/doc-procs.tcl 26 Apr 2018 08:56:39 -0000 1.4 +++ openacs-4/packages/xotcl-core/tcl/doc-procs.tcl 9 May 2018 15:33:34 -0000 1.5 @@ -13,7 +13,7 @@ } proc dotquotel {l} { - set result {} + set result [list] foreach e $l { lappend result \"$e\" } return $result } @@ -57,7 +57,7 @@ } append definition "|" ::xo::api scope_from_object_reference scope e - set methods {} + set methods [list] dot_append_method -documented_methods $documented_methods $e methods proc dot_append_method -documented_methods $documented_methods $e methods instproc dot_append_method -documented_methods $documented_methods $e methods instforward @@ -103,7 +103,7 @@ set superclasses "" foreach e $classes { if {![::nsf::is object $e]} continue - set reduced_sc {} + set reduced_sc [list] foreach sc [::xo::getObjectProperty $e superclass] { if {$omit_base_classes && [::nsf::is baseclass $sc]} continue lappend reduced_sc $sc Index: openacs-4/packages/xotcl-core/tcl/generic-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-core/tcl/generic-procs.tcl,v diff -u -N -r1.107 -r1.108 --- openacs-4/packages/xotcl-core/tcl/generic-procs.tcl 1 May 2018 08:40:01 -0000 1.107 +++ openacs-4/packages/xotcl-core/tcl/generic-procs.tcl 9 May 2018 15:33:34 -0000 1.108 @@ -72,7 +72,7 @@ } Form instproc form_vars {} { - set vars {} + set vars [list] foreach varspec [:fields] { lappend vars [lindex [split [lindex $varspec 0] :] 0] } Index: openacs-4/packages/xotcl-core/www/show-object.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-core/www/show-object.tcl,v diff -u -N -r1.24 -r1.25 --- openacs-4/packages/xotcl-core/www/show-object.tcl 25 Apr 2018 19:47:48 -0000 1.24 +++ openacs-4/packages/xotcl-core/www/show-object.tcl 9 May 2018 15:33:34 -0000 1.25 @@ -108,7 +108,7 @@ if {$dosort} {set list [lsort $list]} - set refs {} + set refs [list] foreach e $list { lappend refs [::xo::api object_link $scope $e] } @@ -126,7 +126,7 @@ set result "" if {0} { set methods [lsort [DO xo::getObjectProperty $c instcommand]] - set pretty {} + set pretty [list] foreach m $methods { if {[info exists param($m)]} continue set entry [::xo::api method_link $c instproc $m] @@ -136,7 +136,7 @@ append result "
Methods for instances:
[join $pretty {, }]
" } set methods [lsort [DO xo::getObjectProperty $c command -callprotection all]] - set pretty {} + set pretty [list] foreach m $methods { if {![DO xo::getObjectProperty ${c}::$m isobject]} { lappend pretty [::xo::api method_link $c proc $m] Index: openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl,v diff -u -N -r1.55 -r1.56 --- openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl 26 Apr 2018 08:56:39 -0000 1.55 +++ openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl 9 May 2018 15:33:34 -0000 1.56 @@ -135,7 +135,7 @@ } Throttle instproc call_statistics {} { - set l {} + set l [list] foreach t {seconds minutes hours} { lappend l [list $t [$t set last] [$t set trend] [$t set stats]] } @@ -582,7 +582,7 @@ array unset :cnt } UrlCounter instproc url_stats {} { - set result {} + set result [list] foreach url [array names :stat] { lappend result [list $url [set :stat($url)] [set :cnt($url)]] } @@ -680,7 +680,7 @@ @return list with detailed user info } { if {$full} { - set info {} + set info [list] foreach key [array names :pa] { set entry [list $key [set :pa($key)]] foreach var [list timestamp hits expSmooth switches] { @@ -747,7 +747,7 @@ } Users proc last_requests {uid} { if {[info exists :pa($uid)]} { - set urls {} + set urls [list] foreach i [Users info instances] { if {[$i exists urls($uid)]} { foreach u [$i set urls($uid)] { lappend urls $u } @@ -779,7 +779,7 @@ } Users proc in_community {community_id} { - set users {} + set users [list] foreach i [Users info instances] { if {[$i exists in_community($community_id)]} { set time [$i point_in_time] @@ -1191,7 +1191,7 @@ return [list ${:ip24} ${:auth24}] } Users proc users_per_day {} { - set ip {}; set auth {} + set ip [list]; set auth [list] foreach i [array names :timestamp] { if {[::xo::is_ip $i]} { set var ip @@ -1264,7 +1264,7 @@ dump set file ${logdir}/throttle-data.dump dump proc read {} { # make sure, timestamp exists as an array - array set Users::timestamp {} + array set Users::timestamp [list] if {[file readable ${:file}]} { # in case of disk-full, the file might be damaged, so make sure, # we can continue Index: openacs-4/packages/xotcl-request-monitor/www/last100.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-request-monitor/www/last100.tcl,v diff -u -N -r1.9 -r1.10 --- openacs-4/packages/xotcl-request-monitor/www/last100.tcl 26 Apr 2018 08:56:39 -0000 1.9 +++ openacs-4/packages/xotcl-request-monitor/www/last100.tcl 9 May 2018 15:33:34 -0000 1.10 @@ -15,7 +15,7 @@ set context [list $title] set admin_p [acs_user::site_wide_admin_p] -set stat {} +set stat [list] foreach {key value} [throttle last100] {lappend stat $value} Class create CustomField -volatile \ Index: openacs-4/packages/xotcl-request-monitor/www/last101.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-request-monitor/www/last101.tcl,v diff -u -N -r1.6 -r1.7 --- openacs-4/packages/xotcl-request-monitor/www/last101.tcl 26 Apr 2018 08:56:39 -0000 1.6 +++ openacs-4/packages/xotcl-request-monitor/www/last101.tcl 9 May 2018 15:33:34 -0000 1.7 @@ -13,7 +13,7 @@ set title "Last 100 Requests" set context [list "Last 100 Requests"] -set stat {} +set stat [list] foreach {key value} [throttle last100] {lappend stat $value} Class create CustomField -volatile \ Index: openacs-4/packages/xotcl-request-monitor/www/stat-details.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-request-monitor/www/stat-details.tcl,v diff -u -N -r1.10 -r1.11 --- openacs-4/packages/xotcl-request-monitor/www/stat-details.tcl 25 Apr 2018 19:47:48 -0000 1.10 +++ openacs-4/packages/xotcl-request-monitor/www/stat-details.tcl 9 May 2018 15:33:34 -0000 1.11 @@ -58,7 +58,7 @@ # # truncate tails, if we have VUHs # - set url_list {} + set url_list [list] foreach p [split $url /] { if {[info exists vuh($p)]} { lappend url_list $p @@ -75,7 +75,7 @@ } set aggr_stat($url) [list $time $cnt] } - set stat {} + set stat [list] foreach url [array names aggr_stat] { lassign $aggr_stat($url) time cnt lappend stat [list $url $time $cnt] @@ -88,7 +88,7 @@ lassign $l url time cnt set param "" regexp {^(.*)([?].*$)} $url _ url param - set url_list {} + set url_list [list] foreach p [split $url /] { if {[info exists apps($p)]} { if {[llength $url_list]>0} {set url_list [list .../$p]} @@ -104,7 +104,7 @@ } set aggr_stat($url) [list $time $cnt] } - set stat {} + set stat [list] foreach url [array names aggr_stat] { lassign $aggr_stat($url) time cnt lappend stat [list $url $time $cnt] Index: openacs-4/packages/xotcl-request-monitor/www/users-in-community.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-request-monitor/www/users-in-community.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/xotcl-request-monitor/www/users-in-community.tcl 26 Apr 2018 08:56:39 -0000 1.5 +++ openacs-4/packages/xotcl-request-monitor/www/users-in-community.tcl 9 May 2018 15:33:34 -0000 1.6 @@ -14,7 +14,7 @@ set title "Users in Community $community_name" set context [list $title] -set stat {} +set stat [list] TableWidget create t1 \ -columns { Index: openacs-4/packages/xotcl-request-monitor/www/whos-online-today.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-request-monitor/www/whos-online-today.tcl,v diff -u -N -r1.6 -r1.7 --- openacs-4/packages/xotcl-request-monitor/www/whos-online-today.tcl 26 Apr 2018 08:56:39 -0000 1.6 +++ openacs-4/packages/xotcl-request-monitor/www/whos-online-today.tcl 9 May 2018 15:33:34 -0000 1.7 @@ -37,7 +37,7 @@ -no_data "no registered online today" -set users {} +set users [list] lassign [throttle users users_per_day] ip auth if {!$all} {set elements [concat $ip $auth]} {set elements $auth} set summary "We noticed in [expr {[llength $ip]+[llength $auth]}] users in total, containing [llength $auth] authenticated users" Index: openacs-4/packages/xotcl-request-monitor/www/whos-online.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-request-monitor/www/whos-online.tcl,v diff -u -N -r1.13 -r1.14 --- openacs-4/packages/xotcl-request-monitor/www/whos-online.tcl 26 Apr 2018 08:56:39 -0000 1.13 +++ openacs-4/packages/xotcl-request-monitor/www/whos-online.tcl 9 May 2018 15:33:34 -0000 1.14 @@ -60,7 +60,7 @@ #return "$peer" } -set users {} +set users [list] foreach element [throttle users active -full] { lassign $element user_id pa timestamp hits smooth switches if {[string is integer $user_id]} { Index: openacs-4/packages/xotcl-request-monitor/www/whos-online.tcl-old =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-request-monitor/www/whos-online.tcl-old,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/xotcl-request-monitor/www/whos-online.tcl-old 26 Apr 2018 08:56:39 -0000 1.2 +++ openacs-4/packages/xotcl-request-monitor/www/whos-online.tcl-old 9 May 2018 15:33:34 -0000 1.3 @@ -81,7 +81,7 @@ -no_data "no registered users online" \ -elements $template_elements -set users {} +set users [list] foreach element [throttle users active -full] { foreach {user_id pa timestamp hits smooth switches} $element break if {[string first . $user_id] > 0} { Index: openacs-4/packages/xowf/tcl/xowf-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowf/tcl/xowf-procs.tcl,v diff -u -N -r1.20 -r1.21 --- openacs-4/packages/xowf/tcl/xowf-procs.tcl 26 Apr 2018 08:56:39 -0000 1.20 +++ openacs-4/packages/xowf/tcl/xowf-procs.tcl 9 May 2018 15:33:34 -0000 1.21 @@ -271,15 +271,15 @@ } Context instproc get_actions {} { - set actions {} + set actions [list] foreach action [${:current_state} get_actions] { lappend actions ${:wf_container}::$action } #:msg "for ${:current_state} actions '$actions" return $actions } Context instproc defined {what} { - set result {} + set result [list] foreach c [${:wf_container} info children] { if {[$c istype $what]} {lappend result $c} } @@ -636,7 +636,7 @@ View method: $view_method, Form loader: $form_loader,\ Context class: [:info class]" - #set conds {} + #set conds [list] #foreach c [:defined Condition] { # lappend conds "[$c name] [$c]" #} @@ -907,7 +907,7 @@ } } WorkflowConstruct instproc get_value_set {values} { - set result {} + set result [list] foreach {cond value} [:get_cond_values $values] { foreach v $value {lappend result $v} } @@ -1413,7 +1413,7 @@ set tokens [mime::initialize -canonical "multipart/mixed" -parts $tokens] } - set headers_list {} + set headers_list [list] lappend headers_list \ [list From $from_info(email)] \ [list To $to_info(email)] \ @@ -1521,7 +1521,7 @@ Compute solution set in form of attribute=value pairs based on "answer" attribute of form fields. } { - set solutions {} + set solutions [list] foreach f [:instantiated_form_fields] { if {![$f exists answer]} continue lappend solutions [$f name]=[$f answer] @@ -1796,7 +1796,7 @@ if {[info exists $key]} {append $key ",$value"} else {set $key $value} } } - set result {} + set result [list] foreach {att value} [array get __c1] {lappend result $att:$value} return $result } @@ -1872,7 +1872,7 @@ set wf [self] set wf_base [$wf pretty_link] - set button_objs {} + set button_objs [list] # create new workflow instance button with start form #if {[:parent_id] != [$package_id folder_id]} { @@ -1909,7 +1909,7 @@ set entry_form_item_id [:wf_property wf_form_id] set work_flow_form [::xo::db::CrClass get_instance_from_db -item_id $form_item_id] set work_flow_base [$work_flow_form pretty_link] - set button_objs {} + set button_objs [list] #:msg entry_form_item_id=$entry_form_item_id-exists?=[:isobject $entry_form_item_id] Index: openacs-4/packages/xowiki/tcl/category-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/category-procs.tcl,v diff -u -N -r1.29 -r1.30 --- openacs-4/packages/xowiki/tcl/category-procs.tcl 25 Apr 2018 19:47:48 -0000 1.29 +++ openacs-4/packages/xowiki/tcl/category-procs.tcl 9 May 2018 15:33:34 -0000 1.30 @@ -24,7 +24,7 @@ set mapped_trees [expr {$have_locale ? [category_tree::get_mapped_trees $object_id $locale] : [category_tree::get_mapped_trees $object_id]}] - set trees {} + set trees [list] foreach tree $mapped_trees { lassign $tree tree_id my_tree_name ... @@ -50,7 +50,7 @@ # Get the values from info in "tree" into separate variables given by output. # Note, that the order matters! lassign $tree {*}$output - set l {} + set l [list] foreach __var $output {lappend l [set $__var]} lappend trees $l } Index: openacs-4/packages/xowiki/tcl/folder-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/folder-procs.tcl,v diff -u -N -r1.48 -r1.49 --- openacs-4/packages/xowiki/tcl/folder-procs.tcl 25 Apr 2018 19:47:48 -0000 1.48 +++ openacs-4/packages/xowiki/tcl/folder-procs.tcl 9 May 2018 15:33:34 -0000 1.49 @@ -136,7 +136,7 @@ {-subtree_query ""} {-depth 3} } { - set folders {} + set folders [list] # safety belt, for recursive structures if {$depth < 1} {return $folders} @@ -422,8 +422,8 @@ set current_object [$node object] set current_item_id [$current_object item_id] - set sub_folders {} - set remaining_folders {} + set sub_folders [list] + set remaining_folders [list] foreach f $folders { if {[$f parent_id] ne $current_item_id} { Index: openacs-4/packages/xowiki/tcl/form-field-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/form-field-procs.tcl,v diff -u -N -r1.269 -r1.270 --- openacs-4/packages/xowiki/tcl/form-field-procs.tcl 25 Apr 2018 19:47:48 -0000 1.269 +++ openacs-4/packages/xowiki/tcl/form-field-procs.tcl 9 May 2018 15:33:34 -0000 1.270 @@ -1695,7 +1695,7 @@ set editor_class [self class]::$editor if {$editor ne "" && ![:hasclass $editor_class]} { if {![:isclass $editor_class]} { - set editors {} + set editors [list] foreach c [::xowiki::formfield::richtext info subclass] { if {![$c exists editor_mixin]} continue lappend editors [namespace tail $c] @@ -1867,7 +1867,7 @@ } richtext::ckeditor instproc pathNames {fileNames} { - set result {} + set result [list] foreach fn $fileNames { if {[regexp {^[./]} $fn]} { append result $fn @@ -2067,7 +2067,7 @@ } richtext::ckeditor4 instproc pathNames {fileNames} { - set result {} + set result [list] foreach fn $fileNames { if {[regexp {^[./]} $fn]} { append result $fn @@ -2412,7 +2412,7 @@ # we use for the time being the initialization of xinha based on # the blank master set ::acs_blank_master(xinha) 1 - set quoted {} + set quoted [list] foreach e [:plugins] {lappend quoted '$e'} set ::acs_blank_master(xinha.plugins) [join $quoted ", "] @@ -2482,7 +2482,7 @@ enumeration instproc get_labels {values} { if {[:multiple]} { - set labels {} + set labels [list] foreach v $values {lappend labels [list [:get_entry_label $v] $v]} return $labels } else { @@ -2499,7 +2499,7 @@ lassign $o label value set labels($value) [:localize $label] } - set values {} + set values [list] foreach i $v {lappend values $labels($i)} return [join $values {, }] } else { @@ -2534,7 +2534,7 @@ return } set subtree_id "" - set options {} + set options [list] foreach category [::xowiki::Category get_category_infos \ -subtree_id $subtree_id -tree_id $tree_id] { @@ -2803,7 +2803,7 @@ set href [${:package_id} pretty_link -parent_id $parent_id $value] set labels($value) "$label" } - set hrefs {} + set hrefs [list] foreach i $v { if {![info exists labels($i)]} { #:msg "can't determine label for value '$i' (values=$v, l=[array names labels])" @@ -2861,7 +2861,7 @@ #set form_obj [${:object} resolve_included_page_name $form_name] if {$form_objs eq ""} {error "Cannot lookup Form '$form_name'"} - set :form_object_item_ids {} + set :form_object_item_ids [list] foreach form_obj $form_objs {lappend :form_object_item_ids [$form_obj item_id]} } form_page instproc compute_options {} { @@ -2892,7 +2892,7 @@ -package_id ${:package_id} \ -from_package_ids $from_package_ids] - set :options {} + set :options [list] foreach i [$items children] { # # If the form_page has a different package_id, prepend the @@ -2939,7 +2939,7 @@ } set package_id [${:object} package_id] - set :options {} + set :options [list] ::xo::dc foreach instance_select \ [${:type} instance_select_query \ -folder_id [$package_id folder_id] \ @@ -3389,7 +3389,7 @@ CompoundField instproc get_compound_value {} { # Set the internal representation based on the components values. - set value {} + set value [list] foreach c [:components] { #:msg "$c [$c info class] lappending [list [$c name] [$c value]]" lappend value [$c name] [$c value] @@ -3416,7 +3416,7 @@ # of the form {name spec}. # set :structure $spec_list - set :components {} + set :components [list] foreach entry $spec_list { lassign $entry name spec # @@ -3501,7 +3501,7 @@ } CompoundField instproc generate_fieldnames {{-prefix "v-"} n} { - set names {} + set names [list] for {set i 1} {$i <= $n} {incr i} {lappend names $prefix$i} return $names } @@ -3856,7 +3856,7 @@ Class create scale -superclass radio -parameter {{n 5} {horizontal true}} scale instproc initialize {} { - set :options {} + set :options [list] for {set i 1} {$i <= ${:n}} {incr i} { lappend :options [list $i $i] } Index: openacs-4/packages/xowiki/tcl/includelet-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/includelet-procs.tcl,v diff -u -N -r1.219 -r1.220 --- openacs-4/packages/xowiki/tcl/includelet-procs.tcl 25 Apr 2018 19:47:48 -0000 1.219 +++ openacs-4/packages/xowiki/tcl/includelet-procs.tcl 9 May 2018 15:33:34 -0000 1.220 @@ -137,7 +137,7 @@ set publish_status_clause "" } else { array set valid_state [list production 1 ready 1 live 1 expired 1] - set clauses {} + set clauses [list] foreach state [split $value |] { if {![info exists valid_state($state)]} { error "no such state: '$state'; valid states are: production, ready, live, expired" @@ -189,11 +189,11 @@ # pipe symbols are or-operations, commas are and-operations; # no parenthesis are permitted set extra_where_clause "" - set or_names {} - set ors {} + set or_names [list] + set ors [list] foreach cid_or [split $category_spec |] { - set ands {} - set and_names {} + set ands [list] + set and_names [list] foreach cid_and [split $cid_or ,] { if {![string is integer -strict $cid_and]} { ad_return_complaint 1 "invalid category id '[ns_quotehtml $cid_and]'" @@ -743,7 +743,7 @@ } elseif {$edit_html ne ""} { append content "$edit_html
" } - set categories {} + set categories [list] set pos 0 set cattree(0) [::xowiki::Tree new -volatile -orderby pos \ -id [:id]-$my_tree_name -name $my_tree_name] @@ -766,7 +766,7 @@ } if {[info exists ordered_composite]} { - set items {} + set items [list] foreach c [$ordered_composite children] {lappend items [$c item_id]} # If we have no item, provide a dummy one to avoid sql error @@ -1371,13 +1371,13 @@ set sql "select count(*) as nr,tag from xowiki_tags where \ user_id = :user_id and package_id = :package_id group by tag order by tag" } - set entries {} + set entries [list] if {![info exists page]} {set page [$package_id get_parameter weblog_page]} set href [$package_id package_url]tag/ ::xo::dc foreach get_tag_counts $sql { - set q {} + set q [list] if {$summary} {lappend q "summary=[ad_urlencode_query $summary]"} if {$popular} {lappend q "popular=[ad_urlencode_query $popular]"} set link $href$tag?[join $q &] @@ -1413,7 +1413,7 @@ set :tags [lsort [::xowiki::Page get_tags -user_id [::xo::cc user_id] \ -item_id [${:__including_page} item_id] -package_id $package_id]] - set entries {} + set entries [list] foreach tag ${:tags} { set href [export_vars -base [$package_id package_url]/tag/$tag {summary}] @@ -1460,7 +1460,7 @@ set content "" set weblog_page [$package_id get_parameter weblog_page weblog] - set entries {} + set entries [list] set href [export_vars -base [$package_id package_url]$weblog_page {summary}] set notification_type "" if {[$package_id get_parameter "with_notifications" 1] && @@ -1615,7 +1615,7 @@ :get_parameters set item_id [${:__including_page} item_id] - set refs {} + set refs [list] # The same image might be linked both, as img or file on one page, # so we need DISTINCT. @@ -1663,7 +1663,7 @@ :get_parameters set item_id [${:__including_page} item_id] - set refs {} + set refs [list] ::xo::dc foreach get_refers "SELECT DISTINCT reference,ci.name,ci.parent_id,o.package_id as pid \ from xowiki_references,cr_items ci,acs_objects o \ @@ -2364,7 +2364,7 @@ } } - set menu {} + set menu [list] foreach b $menu_buttons { if {[info commands ::xowiki::includelet::$b] eq ""} { set b $b-item-button @@ -2460,7 +2460,7 @@ -level:required } { $object instvar page_order title name - set menu {} + set menu [list] foreach b $menu_buttons { if {[info commands ::xowiki::includelet::$b] eq ""} { set b $b-item-button @@ -3239,7 +3239,7 @@ if {$collab($x) > $max} {set max $collab($x)} } - set edges {} + set edges [list] foreach x [array names collab] { lappend edges [list $x $collab($x) [expr {$collab($x)*5.0/$max}]] } @@ -3331,7 +3331,7 @@ if {$collab($x) > $max} {set max $collab($x)} } - set edges {} + set edges [list] foreach x [array names collab] { lappend edges [list $x $collab($x) [expr {$collab($x)*5.0/$max}]] } @@ -3559,7 +3559,7 @@ lappend button_objs $obj } } - set links {} + set links [list] foreach b $button_objs { lappend links [$b render] } return "
[join $links { · }]
\n" } @@ -3618,7 +3618,7 @@ # # experimental highcharts pie renderer # - set percentages {} + set percentages [list] foreach {value count} [array get __count] { lappend percentages $value [format %.2f [expr {$count*100.0/$sum}]] } @@ -3660,7 +3660,7 @@ set title [:title] if {![info exists :id]} {set :id [::xowiki::Includelet html_id [self]]} set id [:id] - set values {} + set values [list] foreach {name value} $data { lappend values "\['[::xowiki::Includelet js_encode $name]', $value\]" } @@ -3848,7 +3848,7 @@ } # finally, evaluate conditions if included - set field_names {} + set field_names [list] foreach f $raw_field_names { set _ [string trim [::xowiki::formfield::FormField get_single_spec \ -object $o -package_id $package_id $f]] @@ -3941,7 +3941,7 @@ # # Compute filter clauses # - set init_vars {} + set init_vars [list] array set uc {tcl false h "" vars "" sql ""} if {[info exists unless]} { array set uc [::xowiki::FormPage filter_expression $unless ||] @@ -4080,7 +4080,7 @@ return "" } - set links {} + set links [list] set base [$form_item pretty_link] set label [$form_item name] @@ -4124,14 +4124,14 @@ # corresponding to the wanted field name. This is guaranteed by the construction # in form-usages. set count 0 - set table_field_names {} + set table_field_names [list] foreach t [$t1 children] { incr count lappend table_field_names $count # In most situations, it seems useful to have just one field in # the voting table. If there are multiple, we use a comma to # separate the values (looks bettern than separate columns). - set field_contents {} + set field_contents [list] foreach __fn $field_names { lappend field_contents [$t set $__fn] } @@ -4470,7 +4470,7 @@ -initialize false \ -publish_status $publish_status \ -package_id $package_id] - set result {} + set result [list] foreach item [$items children] { lappend result [$item name] } Index: openacs-4/packages/xowiki/tcl/lcs-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/lcs-procs.tcl,v diff -u -N -r1.6 -r1.7 --- openacs-4/packages/xowiki/tcl/lcs-procs.tcl 25 Apr 2018 19:47:48 -0000 1.6 +++ openacs-4/packages/xowiki/tcl/lcs-procs.tcl 9 May 2018 15:33:34 -0000 1.7 @@ -35,8 +35,8 @@ proc list::longestCommonSubsequence { sequence1 sequence2 } { - set seta {} - set setb {} + set seta [list] + set setb [list] # Construct a set of equivalence classes of lines in file 2 Index: openacs-4/packages/xowiki/tcl/menu-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/menu-procs.tcl,v diff -u -N -r1.16 -r1.17 --- openacs-4/packages/xowiki/tcl/menu-procs.tcl 25 Apr 2018 19:47:48 -0000 1.16 +++ openacs-4/packages/xowiki/tcl/menu-procs.tcl 9 May 2018 15:33:34 -0000 1.17 @@ -151,7 +151,7 @@ } ::xowiki::MenuBar instproc init {} { - set :Menues {} + set :Menues [list] :destroy_on_cleanup } @@ -233,7 +233,7 @@ # such an entry. # set updated 0 - set newitems {} + set newitems [list] foreach {n i} [set :Menu($menu)] { if {$n eq $name} { lappend newitems $name $item Index: openacs-4/packages/xowiki/tcl/package-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/package-procs.tcl,v diff -u -N -r1.316 -r1.317 --- openacs-4/packages/xowiki/tcl/package-procs.tcl 25 Apr 2018 19:47:48 -0000 1.316 +++ openacs-4/packages/xowiki/tcl/package-procs.tcl 9 May 2018 15:33:34 -0000 1.317 @@ -1183,7 +1183,7 @@ # Compute a list fo package objects which should be used for # resolving ("inheritance of objects from other instances"). # - set packages {} + set packages [list] set package_url [string trimright [:package_url] /] set package_path [:get_parameter PackagePath] # Index: openacs-4/packages/xowiki/tcl/xowiki-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/xowiki-procs.tcl,v diff -u -N -r1.518 -r1.519 --- openacs-4/packages/xowiki/tcl/xowiki-procs.tcl 1 May 2018 08:37:12 -0000 1.518 +++ openacs-4/packages/xowiki/tcl/xowiki-procs.tcl 9 May 2018 15:33:34 -0000 1.519 @@ -640,7 +640,7 @@ # mapped with the same name. set tree_id [lindex $tree_ids 0] array set data [category_tree::get_data $tree_id] - set categories {} + set categories [list] if {[info exists :__category_map]} {array set cm ${:__category_map}} foreach category [::xowiki::Category get_category_infos -tree_id $tree_id] { lassign $category category_id category_name deprecated_p level @@ -739,7 +739,7 @@ FormPage instproc map_values {map_type values} { # Map a list of values (for multi-valued form fields) # :log "map_values $map_type, $values" - set mapped_values {} + set mapped_values [list] foreach value $values {lappend mapped_values [:map_value $map_type $value]} return $mapped_values } @@ -802,7 +802,7 @@ # :log "+++ starting with instance_attributes [:instance_attributes]" array set use ${:__instance_attribute_map} array set multiple_index [list category 2 party_id 1 file 1] - set ia {} + set ia [list] foreach {name value} [:instance_attributes] { #:log "marshall check $name $value [info exists use($name)]" if {[info exists use($name)]} { @@ -835,7 +835,7 @@ } ad_try { acs_user::get -user_id $party_id -array info - set result {} + set result [list] foreach a {username email first_names last_name screen_name url} { lappend result $a $info($a) } @@ -987,7 +987,7 @@ # Apply reverse_map_value to a list of values (for multi-valued # form fields) :upvar $category_ids_name category_ids - set mapped_values {} + set mapped_values [list] foreach value $values { lappend mapped_values [:reverse_map_value \ -creation_user $creation_user -create_user_ids $create_user_ids \ @@ -1027,7 +1027,7 @@ # # The function will compute the category_ids, which are were used # to categorize this objects in the source instance. - set category_ids {} + set category_ids [list] #:msg "[:name] check cm=[info exists ::__xowiki_reverse_category_map] && iam=[info exists :__instance_attribute_map]" @@ -1039,7 +1039,7 @@ # # replace all symbolic category values by the mapped IDs # - set ia {} + set ia [list] array set use ${:__instance_attribute_map} array set multiple_index [list category 2 party_id 1 file 1] foreach {name value} [:instance_attributes] { @@ -2451,7 +2451,7 @@ # available variables. # # compute list of possible variables - set __varlist {} + set __varlist [list] set __template_variables__ "
    \n" foreach __v [lsort $__vars] { if {[array exists $__v]} continue ;# don't report arrays @@ -2935,7 +2935,7 @@ } if {$name ni {langmarks fontname fontsize formatblock}} { - set names {} + set names [list] foreach f $form_fields {lappend names [$f name]} :msg "No form field with name '$name' found\ (available fields: [lsort [array names ::_form_field_names]])" @@ -3389,7 +3389,7 @@ set spec [::xowiki::PageInstance get_short_spec_from_form_constraints \ -name $name \ -form_constraints $form_constraints] - set result {} + set result [list] foreach spec [split $spec ,] { if {[regexp {^([^=]+)=(.*)$} $spec _ attr value]} { lappend result $attr $value @@ -3572,7 +3572,7 @@ return "
    [:substitute_markup $html]
    " } PageInstance instproc template_vars {content} { - set result {} + set result [list] foreach {_ _ v} [regexp -inline -all [template::adp_variable_regexp] $content] { lappend result $v "" } @@ -3664,7 +3664,7 @@ Form proc dom_disable_input_fields {{-with_submit 0} root} { set fields [$root selectNodes "//button | //input | //optgroup | //option | //select | //textarea "] - set disabled {} + set disabled [list] foreach field $fields { set type "" if {[$field hasAttribute type]} {set type [$field getAttribute type]} @@ -3740,7 +3740,7 @@ # Since create_raw_form_field uses destroy_on_cleanup, we do not # have to care here about destroying the objects. # - set form_fields {} + set form_fields [list] foreach name_and_spec $form_constraints { regexp {^([^:]+):(.*)$} $name_and_spec _ spec_name short_spec if {[string match "@table*" $spec_name] || $spec_name eq "@categories"} continue @@ -3833,10 +3833,10 @@ array set op_map {contains,sql {$lhs_var like '%$rhs%'} contains,tcl {{$rhs} in $lhs_var}} #:msg unless=$unless #example for unless: wf_current_state = closed|accepted || x = 1 - set tcl_clause {} - set h_clause {} - set vars {} - set sql_clause {} + set tcl_clause [list] + set h_clause [list] + set vars [list] + set sql_clause [list] foreach clause [split [string map [list $logical_op \x00] $input_expr] \x00] { if {[regexp {^(.*[^<>])\s*([=<>]|<=|>=|contains)\s*([^=]?.*)$} $clause _ lhs op rhs_expr]} { set lhs [string trim $lhs] @@ -4362,7 +4362,7 @@ #:msg template=$template #set field_names [list _name _title _description _creator _nls_language _page_order] - set field_names {} + set field_names [list] if {$form eq ""} {set form [:get_form]} if {$form eq ""} { foreach {var _} [:template_vars $template] { Index: openacs-4/packages/xowiki/tcl/xowiki-utility-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/xowiki-utility-procs.tcl,v diff -u -N -r1.48 -r1.49 --- openacs-4/packages/xowiki/tcl/xowiki-utility-procs.tcl 30 Apr 2018 08:47:40 -0000 1.48 +++ openacs-4/packages/xowiki/tcl/xowiki-utility-procs.tcl 9 May 2018 15:33:34 -0000 1.49 @@ -213,8 +213,8 @@ in acs_objects; this proc updates the package_ids of all items and revisions in acs_objects } { - set folder_ids {} - set package_ids {} + set folder_ids [list] + set package_ids [list] foreach package_id [::xowiki::Package instances] { ns_log notice "checking package_id $package_id" set folder_id [::xo::dc list get_folder_id "select f.folder_id from cr_items c, cr_folders f \ @@ -661,7 +661,7 @@ } :proc get_page_order_items {-parent_id {-publish_status "production"} page_orders} { - set likes {} + set likes [list] foreach page_order $page_orders { if {[::xowiki::page_order_uses_ltree]} { lappend likes "p.page_order <@ '$page_order'" @@ -692,7 +692,7 @@ #:log "pages=$pages" array set npo [::xowiki::utility page_order_compute_new_names $start $to] #:log npo=[array get npo]=>to='$to' - set renames {} + set renames [list] foreach tuple $pages { lassign $tuple old_page_order page_id item_id name if {[info exists npo($old_page_order)]} { @@ -755,7 +755,7 @@ } #ns_log notice "--cpo from=$from, to=$to, clean=$clean" - set gap_renames {} + set gap_renames [list] # # We distinguish two cases: # - pure reordering: length(to) == length(from) @@ -779,7 +779,7 @@ # # Compute the remaining list. # - set remaining {} + set remaining [list] foreach e $clean {if {$e ne $inserted} {lappend remaining $e}} # # Compute rename commands for it. @@ -856,7 +856,7 @@ if {[ns_info name] eq "NaviServer"} { :proc urlencode {string} {ns_urlencode $string} } else { - set ue_map {} + set ue_map [list] for {set i 0} {$i < 256} {incr i} { set c [format %c $i] set x %[format %02x $i] Index: openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl,v diff -u -N -r1.352 -r1.353 --- openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl 25 Apr 2018 19:47:48 -0000 1.352 +++ openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl 9 May 2018 15:33:34 -0000 1.353 @@ -45,7 +45,7 @@ if {![:exists_form_parameter "objects"]} { :msg "nothing to copy" } - set ids {} + set ids [list] foreach page_name [:form_parameter objects] { # the page_name is the name exactly as stored in the content repository set item_id [::xo::db::CrClass lookup -name $page_name -parent_id ${:item_id}] @@ -153,7 +153,7 @@ # # collect some default values from query parameters # - set default_variables {} + set default_variables [list] foreach key {name title page_order last_page_id nls_language} { if {[:exists_query_parameter $key]} { lappend default_variables $key [:query_parameter $key] @@ -183,7 +183,7 @@ } # load the instance attributes from the form parameters - set instance_attributes {} + set instance_attributes [list] foreach {_att _value} [::xo::cc get_all_form_parameter] { if {[string match _* $_att]} continue lappend instance_attributes $_att $_value @@ -837,7 +837,7 @@ # problems. # if {[$package_id exists __batch_mode]} { - set errors {} + set errors [list] foreach f $form_fields { if {[$f error_msg] ne ""} { lappend errors [list field [$f name] value [$f set value] error [$f error_msg]] @@ -1201,7 +1201,7 @@ set weblog_page [${:package_id} get_parameter weblog_page weblog] set href [${:package_id} pretty_link -parent_id [${:package_id} folder_id] $weblog_page]?summary=1 - set entries {} + set entries [list] xo::dc foreach get_popular_tags \ [::xo::dc select \ -vars "count(*) as nr, tag" \ @@ -1226,8 +1226,8 @@ page without adding a new revision. } { set field_names [:field_names] - set form_fields {} - set query_field_names {} + set form_fields [list] + set query_field_names [list] set validation_errors 0 foreach field_name $field_names { @@ -1774,7 +1774,7 @@ $slot destroy_on_cleanup } - set spec_list {} + set spec_list [list] if {[$slot exists spec]} {lappend spec_list [$slot set spec]} if {$spec ne ""} {lappend spec_list $spec} #:msg "[self args] spec_list $spec_list" @@ -1835,7 +1835,7 @@ } #:log "create form-field '$name', short_spec '$short_spec' spec '$spec', slot=$slot" - set spec_list {} + set spec_list [list] if {$spec ne ""} {lappend spec_list $spec} if {$short_spec ne ""} {lappend spec_list $short_spec} #:log "$name: short_spec '$short_spec', spec_list 1 = '[join $spec_list ,]'" @@ -1856,7 +1856,7 @@ if {$f eq "off"} {return ""} } - set category_fields {} + set category_fields [list] set container_object_id ${:package_id} set category_trees [category_tree::get_mapped_trees $container_object_id] set category_ids [category::get_mapped_categories ${:item_id}] @@ -1865,9 +1865,9 @@ foreach category_tree $category_trees { lassign $category_tree tree_id tree_name subtree_id assign_single_p require_category_p - set options {} + set options [list] #if {!$require_category_p} {lappend options [list "--" ""]} - set value {} + set value [list] foreach category [::xowiki::Category get_category_infos \ -subtree_id $subtree_id -tree_id $tree_id] { lassign $category category_id category_name deprecated_p level @@ -2062,8 +2062,8 @@ } { set validation_errors 0 - set category_ids {} - array set containers {} + set category_ids [list] + array set containers [list] set cc [${:package_id} context] if {![info exists field_names]} { @@ -2342,7 +2342,7 @@ Page instproc field_names {{-form ""}} { array set dont_modify [list item_id 1 revision_id 1 object_id 1 object_title 1 page_id 1 name 1] - set field_names {} + set field_names [list] foreach field_name [[:info class] array names db_slot] { if {[info exists dont_modify($field_name)]} continue lappend field_names _$field_name Index: openacs-4/packages/xowiki/tcl/yui-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/yui-procs.tcl,v diff -u -N -r1.12 -r1.13 --- openacs-4/packages/xowiki/tcl/yui-procs.tcl 25 Apr 2018 19:47:48 -0000 1.12 +++ openacs-4/packages/xowiki/tcl/yui-procs.tcl 9 May 2018 15:33:34 -0000 1.13 @@ -53,16 +53,16 @@ # split the list of entries into groups, which will be separated # with lines in the rendering # - set result {} + set result [list] if {[llength $list] < 1} {return $result} set group_name [[lindex $list 0] group] - set group_list {} + set group_list [list] foreach e $list { set gn [$e group] if {$gn ne $group_name} { lappend result $group_list set group_name $gn - set group_list {} + set group_list [list] } lappend group_list $e } @@ -494,14 +494,14 @@ append js "$datasource.responseType = YAHOO.util.DataSource.TYPE_HTMLTABLE; \n" append js "$datasource.responseSchema = \{ \n" append js " fields: \[ \n" - set js_fields {} + set js_fields [list] foreach field [[self]::__columns children] { if {[$field hide]} continue lappend js_fields " \{ key: \"[$field set name]\" \}" } append js [join $js_fields ", "] " \] \n\};\n" append js "var $coldef = \[\n" - set js_fields {} + set js_fields [list] foreach field [[self]::__columns children] { if {[$field hide]} continue if {[$field istype HiddenField]} continue Index: openacs-4/packages/xowiki/www/admin/import.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/www/admin/import.tcl,v diff -u -N -r1.26 -r1.27 --- openacs-4/packages/xowiki/www/admin/import.tcl 25 Apr 2018 19:47:48 -0000 1.26 +++ openacs-4/packages/xowiki/www/admin/import.tcl 9 May 2018 15:33:34 -0000 1.27 @@ -57,7 +57,7 @@ } } } on ok {r} { - set objects {} + set objects [list] foreach o [::xowiki::Page allinstances] { if {![info exists preexists($o)]} {lappend objects $o} } Index: openacs-4/packages/xowiki/www/admin/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/www/admin/index.tcl,v diff -u -N -r1.30 -r1.31 --- openacs-4/packages/xowiki/www/admin/index.tcl 26 Apr 2018 08:56:39 -0000 1.30 +++ openacs-4/packages/xowiki/www/admin/index.tcl 9 May 2018 15:33:34 -0000 1.31 @@ -10,7 +10,7 @@ {-object_type ::xowiki::Page} } -set context {} +set context [list] set pretty_plural [$object_type set pretty_plural] set title [_ xowiki.admin_all_title] Index: openacs-4/packages/xowiki/www/prototypes/categories-portlet.page =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/www/prototypes/categories-portlet.page,v diff -u -N -r1.13 -r1.14 --- openacs-4/packages/xowiki/www/prototypes/categories-portlet.page 25 Apr 2018 19:47:48 -0000 1.13 +++ openacs-4/packages/xowiki/www/prototypes/categories-portlet.page 9 May 2018 15:33:34 -0000 1.14 @@ -42,7 +42,7 @@ if {!$no_tree_name} { append content "

    $my_tree_name

    " } - set categories {} + set categories [list] set pos 0 set cattree(0) [::xowiki::Tree new -volatile -orderby pos -name $my_tree_name] foreach category_info [::xowiki::Category get_category_infos -tree_id $tree_id] {