Index: openacs-4/packages/acs-outdated/tcl/acs-tcl-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-outdated/tcl/acs-tcl-procs.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/acs-outdated/tcl/acs-tcl-procs.tcl 7 Aug 2017 23:47:57 -0000 1.2 +++ openacs-4/packages/acs-outdated/tcl/acs-tcl-procs.tcl 25 Apr 2018 19:47:46 -0000 1.3 @@ -2,7 +2,7 @@ Applies proc_name to each item of the list, appending the result of each call to a new list that is the return value. } { - set lmap [list] + set lmap {} foreach item $list { lappend lmap [safe_eval $proc_name $item] } Index: openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl,v diff -u -N -r1.15 -r1.16 --- openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl 25 Apr 2018 08:46:13 -0000 1.15 +++ openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl 25 Apr 2018 19:47:46 -0000 1.16 @@ -228,7 +228,7 @@ # #################### - array set export [list] + array set export {} set override_p 0 foreach argument { include override } { @@ -283,13 +283,13 @@ #################### if { !$form_p } { - set export_list [list] + set export_list {} foreach varname [array names export] { lappend export_list "[ns_urlencode $varname]=[ns_urlencode $export($varname)]" } return [join $export_list &] } else { - set export_list [list] + set export_list {} foreach varname [array names export] { lappend export_list "" @@ -815,7 +815,7 @@ $page_title " - array set attrs [list] + array set attrs {} set attrs(bgcolor) [parameter::get -package_id [ad_acs_kernel_id] -parameter bgcolor -default "white"] set attrs(text) [parameter::get -package_id [ad_acs_kernel_id] -parameter textcolor -default "black"] @@ -1773,8 +1773,8 @@ # build the map of currently selected columns set full_column [split $sort_spec ","] - set sel_columns [list] - set direction [list] + set sel_columns {} + set direction {} foreach col $full_column { regexp {([^*,]+)([*])?} $col match coln dirn if {$dirn eq "*"} { @@ -2153,7 +2153,7 @@ ad_proc -deprecated set_intersection { u v } {

Returns the intersection of sets $u and $v.

} { - set result [list] + set result {} foreach ue $u { if { [set_member? $v $ue] } { @@ -2171,7 +2171,7 @@ to that intersection, and also returns that intersection.

} { upvar $u-name u - set result [list] + set result {} foreach ue $u { if { [set_member? $v $ue] } { @@ -2187,7 +2187,7 @@

Returns the difference of sets $u and $v. (i.e. The set of all members of u that aren't also members of $v.)

} { - set result [list] + set result {} foreach ue $u { if { ![set_member? $v $ue] } { @@ -2205,7 +2205,7 @@ to that difference, and also returns that difference.

} { upvar $u-name u - set result [list] + set result {} foreach ue $u { if { ![set_member? $v $ue] } { @@ -2663,7 +2663,7 @@ } - set variables [list] + set variables {} switch -- $mode { array { set variables $formvars Index: openacs-4/packages/ajax-filestorage-ui/lib/ajaxfs-include.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ajax-filestorage-ui/lib/ajaxfs-include.tcl,v diff -u -N -r1.12 -r1.13 --- openacs-4/packages/ajax-filestorage-ui/lib/ajaxfs-include.tcl 11 May 2009 03:22:28 -0000 1.12 +++ openacs-4/packages/ajax-filestorage-ui/lib/ajaxfs-include.tcl 25 Apr 2018 19:47:46 -0000 1.13 @@ -70,7 +70,7 @@ if { [exists_and_not_null package_id] } { - set options [list] + set options {} # get the root folder set rootfolder_id [fs_get_root_folder -package_id $package_id] Index: openacs-4/packages/ajax-photoalbum-ui/lib/ajaxpa-include.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ajax-photoalbum-ui/lib/ajaxpa-include.tcl,v diff -u -N -r1.1 -r1.2 --- openacs-4/packages/ajax-photoalbum-ui/lib/ajaxpa-include.tcl 11 Apr 2009 15:46:44 -0000 1.1 +++ openacs-4/packages/ajax-photoalbum-ui/lib/ajaxpa-include.tcl 25 Apr 2018 19:47:46 -0000 1.2 @@ -16,7 +16,7 @@ if { [exists_and_not_null package_id] } { set user_id [ad_conn user_id] - set options [list] + set options {} set rootfolder_id [pa_get_root_folder $package_id] set instance_name [db_string "get_folder_name" "select name as instance_name from fs_folders where folder_id = :rootfolder_id"] Index: openacs-4/packages/ajax-photoalbum-ui/www/doc/photo-album-ajaxpa.diff =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ajax-photoalbum-ui/www/doc/photo-album-ajaxpa.diff,v diff -u -N -r1.1 -r1.2 --- openacs-4/packages/ajax-photoalbum-ui/www/doc/photo-album-ajaxpa.diff 11 Apr 2009 15:56:13 -0000 1.1 +++ openacs-4/packages/ajax-photoalbum-ui/www/doc/photo-album-ajaxpa.diff 25 Apr 2018 19:47:46 -0000 1.2 @@ -65,7 +65,7 @@ } { return the image information from a given file } { - set info [list] + set info {} + if { ![exists_and_not_null package_id] } { set package_id [ad_conn package_id] } if { [catch {set size [file size $file]} errMsg] } { return -code error $errMsg Index: openacs-4/packages/ajaxhelper/tcl/ajax-listbuilder-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ajaxhelper/tcl/ajax-listbuilder-procs.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/ajaxhelper/tcl/ajax-listbuilder-procs.tcl 28 Mar 2018 17:00:40 -0000 1.5 +++ openacs-4/packages/ajaxhelper/tcl/ajax-listbuilder-procs.tcl 25 Apr 2018 19:47:46 -0000 1.6 @@ -33,13 +33,13 @@ if {[info exists _hide_column]} { set hide_column $_hide_column } else { - set hide_column [list] + set hide_column {} } upvar move _move if {[info exists _move]} { set move $_move } else { - set move [list] + set move {} } upvar groupby _groupby set previous_index 0 @@ -49,7 +49,7 @@ template::list::get_reference -name $list_name upvar #[template::adp_level] ${list_name}:filter:groupby:properties groupby_ref - set groupbys [list] + set groupbys {} foreach elm $groupby_ref(values) { set value [lindex $elm 1] lappend groupbys [lindex $value 0 1] @@ -73,16 +73,16 @@ set first_not_checkbox 1 } - set sortmenuitems [list] + set sortmenuitems {} lappend sortmenuitems [list [list "text" "A-Z"] [list "url" "[filter_url -list_name $list_name -filter_name orderby -filter_value ${element},asc -return_url $return_url]"]] lappend sortmenuitems [list [list "text" "Z-A"] [list "url" "[filter_url -list_name $list_name -filter_name orderby -filter_value ${element},desc -return_url $return_url]"]] - set groupmenuitems [list] + set groupmenuitems {} lappend groupmenuitems [list [list "text" "By Exact Value"] [list "url" "[filter_url -list_name $list_name -filter_name groupby -filter_value $element -return_url $return_url]"] ] # lappend groupmenuitems [list [list "text" "By First Letter"] [list "url" "javascript:void(0)"] ] - set movemenuitems [list] + set movemenuitems {} set this_move $move if {[set this_move_index [lsearch $move $element]] > -1} { set this_move [lreplace $move $this_move_index [expr {$this_move_index + 1}]] @@ -97,7 +97,7 @@ lappend movemenuitems [list [list "text" "First"] [list "url" "[filter_url -list_name $list_name -filter_name move -filter_value [concat $this_move [list $element $first_not_checkbox]] -return_url $return_url]"]] } - set menulist [list] + set menulist {} if {[lsearch $list_properties(orderby_refs) "*${element_properties(name)}*"] > -1} { lappend menulist [list [list "text" "Sort"] [list "submenu" [list [list "id" "sort-$element_properties(name)"] [list "itemdata" $sortmenuitems] ] ] ] } @@ -180,9 +180,9 @@ if {[info exists _add_column]} { set add_column $_add_column } else { - set add_column [list] + set add_column {} } - set addcolumnlist [list] + set addcolumnlist {} template::list::get_reference -name $list_name lappend list_properties(actions) [_ acs-templating.Add_Column] "javascript:void(0)" [_ acs-templating.Add_Column] @@ -252,7 +252,7 @@ foreach view $view_names { set view_name [lindex $view 0] set value [lindex $view 1] - set viewmenuitems [list] + set viewmenuitems {} lappend viewlist [list [list "text" $view_name] [list "url" "[filter_url -list_name $list_name -filter_name __list_view -filter_value $value -return_url [ad_conn url]]" ]] } @@ -455,7 +455,7 @@ } if {[info exists hide]} { - set reset_filters [list] + set reset_filters {} if {[info exists orderby] && [lsearch $hide [lindex [split $orderby ,] 0]] > -1} { unset orderby lappend reset_filters orderby Index: openacs-4/packages/ajaxhelper/tcl/ajax-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ajaxhelper/tcl/ajax-procs.tcl,v diff -u -N -r1.17 -r1.18 --- openacs-4/packages/ajaxhelper/tcl/ajax-procs.tcl 4 Apr 2018 08:11:26 -0000 1.17 +++ openacs-4/packages/ajaxhelper/tcl/ajax-procs.tcl 25 Apr 2018 19:47:46 -0000 1.18 @@ -240,16 +240,16 @@ Converts a properly structured list of lists into JSON format. The list of lists may look something like - set data [list] + set data {} lappend data [list [list "x" "1"] [list "y" "10"] ] lappend data [list [list "x" "5"] [list "y" "20"] ] each line represents a row composed of lists. Each list in the row holds a pair that will be joined by ":". } { - set rows [list] + set rows {} foreach row $lists_of_pairs { - set pairs [list] + set pairs {} foreach pair $row { lappend pairs [join $pair ":"] } Index: openacs-4/packages/ajaxhelper/tcl/ajax-yahoo-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ajaxhelper/tcl/ajax-yahoo-procs.tcl,v diff -u -N -r1.13 -r1.14 --- openacs-4/packages/ajaxhelper/tcl/ajax-yahoo-procs.tcl 7 Aug 2017 23:48:03 -0000 1.13 +++ openacs-4/packages/ajaxhelper/tcl/ajax-yahoo-procs.tcl 25 Apr 2018 19:47:46 -0000 1.14 @@ -367,7 +367,7 @@ This is an example of a node list. - set nodes [list] + set nodes {} lappend nodes [list "fld1" "Folder 1" "tree" "" "" "" ""] lappend nodes [list "fld2" "Folder 2" "tree" "javascript:alert('this is a tree node')" "" "" ""] @@ -531,17 +531,17 @@ Converts a properly structured list of menu items into JSON format. The list of lists may look something like - set submenu [list] + set submenu {} lappend submenu [list [list "text" "Submenu1"] [list "url" "http://www.google.com"] ] lappend submenu [list [list "text" "Submenu2"] [list "url" "http://www.yahoo.com"] ] each line represents a row composed of lists. Each list in the row holds a pair that will be joined by ":". } { - set rows [list] + set rows {} foreach row $lists_of_pairs { - set pairs [list] + set pairs {} foreach pair $row { if { [lindex $pair 0] eq "submenu" } { set submenulist [lindex $pair 1] @@ -695,17 +695,17 @@ if { [llength [lindex $suggestlist 0]] > 1} { # yes , let's create the array for the innerlist and put each array into one big array - set outerlist [list] + set outerlist {} foreach onelist $suggestlist { - set escaped_list [list] + set escaped_list {} foreach elm $onelist { lappend escaped_list [string map {' \\'} $elm] } lappend outerlist "\[ '[join $escaped_list "','"]' \]" } set script "var ${varname}Arr = \[ [join $outerlist ","] \];" - set markup [list] + set markup {} for { set x 0} { $x < [llength [lindex $suggestlist 0]] } { incr x} { lappend markup "oResultItem\[${x}\]" } Index: openacs-4/packages/ajaxhelper/tcl/json-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ajaxhelper/tcl/json-procs.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/ajaxhelper/tcl/json-procs.tcl 31 Dec 2017 09:40:04 -0000 1.3 +++ openacs-4/packages/ajaxhelper/tcl/json-procs.tcl 25 Apr 2018 19:47:46 -0000 1.4 @@ -67,7 +67,7 @@ # we are dealing with an Object getc set state OBJECT - set dictVal [list] + set dictVal {} } VALUE { # this object element's value is an Object Index: openacs-4/packages/ajaxhelper/www/doc/head-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ajaxhelper/www/doc/head-procs.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/ajaxhelper/www/doc/head-procs.tcl 18 Apr 2018 22:25:03 -0000 1.4 +++ openacs-4/packages/ajaxhelper/www/doc/head-procs.tcl 25 Apr 2018 19:47:46 -0000 1.5 @@ -20,28 +20,28 @@ } { variable ::template::head::scripts array unset scripts - array set scripts [list] + array set scripts {} variable ::template::head::links array unset links - array set links [list] + array set links {} variable ::template::head::metas array unset metas - array set metas [list] + array set metas {} variable ::template::body_handlers array unset body_handlers - array set body_handlers [list] + array set body_handlers {} variable ::template::body_scripts array unset body_scripts - set body_scripts [list] + set body_scripts {} variable ::template::headers - set headers [list] + set headers {} variable ::template::footers - set footers [list] + set footers {} } ad_proc -public template::head::add_script { Index: openacs-4/packages/ajaxhelper/www/tests/test_dojochartengine.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ajaxhelper/www/tests/test_dojochartengine.tcl,v diff -u -N -r1.1 -r1.2 --- openacs-4/packages/ajaxhelper/www/tests/test_dojochartengine.tcl 25 Dec 2006 16:40:04 -0000 1.1 +++ openacs-4/packages/ajaxhelper/www/tests/test_dojochartengine.tcl 25 Apr 2018 19:47:46 -0000 1.2 @@ -25,7 +25,7 @@ return $type } $objname proc bindings_from_list {lists_of_pairs} { - set pairs [list] + set pairs {} foreach pair $lists_of_pairs { lappend pairs [join $pair ":"] } @@ -58,7 +58,7 @@ return $varname } $objname proc range_from_list {rangelist} { - set pairs [list] + set pairs {} foreach pair $rangelist { lappend pairs [join $pair ":"] } @@ -100,7 +100,7 @@ return $varname } $objname proc range_from_list {rangelist} { - set pairs [list] + set pairs {} foreach pair $rangelist { lappend pairs [join $pair ":"] } @@ -135,7 +135,7 @@ $objname set axis_obj_list [list "axis1" "axis2"] $objname proc createscript { } { my instvar varname series_obj_list axis_obj_list - set axislist [list] + set axislist {} foreach axis $axis_obj_list { lappend axislist [$axis getvarname] } Index: openacs-4/packages/ajaxhelper/www/tests/test_yahoomenu-js.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ajaxhelper/www/tests/test_yahoomenu-js.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/ajaxhelper/www/tests/test_yahoomenu-js.tcl 7 Aug 2017 23:48:03 -0000 1.3 +++ openacs-4/packages/ajaxhelper/www/tests/test_yahoomenu-js.tcl 25 Apr 2018 19:47:46 -0000 1.4 @@ -2,7 +2,7 @@ # Menu 1 -# set menulist1 [list] +# set menulist1 {} # lappend menulist1 [list [list "text" "Google"] [list "url" "http://www.google.com"] ] # lappend menulist1 [list [list "text" "Yahoo"] [list "url" "http://www.yahoo.com"] ] @@ -19,11 +19,11 @@ # Menu 2 -# set submenuitems [list] +# set submenuitems {} # lappend submenuitems [list [list "text" "Home Page"] [list "url" "http://www.solutiongrove.com"] ] # lappend submenuitems [list [list "text" "Blog"] [list "url" "http://www.solutiongrove.com/blogger/"] ] # set submenulist1 [list [list "id" "sgrovelinks"] [list "itemdata" $submenuitems] ] -# set menulist2 [list] +# set menulist2 {} # lappend menulist2 [list [list "text" "OpenACS"] [list "url" "http://www.openacs.org"] ] # lappend menulist2 [list [list "text" "Solution Grove"] [list "submenu" $submenulist1] ] Index: openacs-4/packages/ams/tcl/address-widget-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ams/tcl/address-widget-procs.tcl,v diff -u -N -r1.19 -r1.20 --- openacs-4/packages/ams/tcl/address-widget-procs.tcl 18 Dec 2006 19:14:23 -0000 1.19 +++ openacs-4/packages/ams/tcl/address-widget-procs.tcl 25 Apr 2018 19:47:46 -0000 1.20 @@ -156,7 +156,7 @@ Returns the country list. } { set country_code_list [db_list get_country_codes {}] - set return_country_list [list] + set return_country_list {} set reserved_country_codes [parameter::get_from_package_key -parameter "DefaultISOCountryCode" -package_key "ams" -default ""] foreach country $country_code_list { @@ -165,7 +165,7 @@ } } set return_country_list [ams::util::sort_list_of_lists -list $return_country_list] - set country_code [list] + set country_code {} if { [exists_and_not_null reserved_country_codes] } { foreach country $reserved_country_codes { set country [string toupper $country] @@ -215,7 +215,7 @@ set additional_text [template::util::address::get_property additional_text $address_list] set postal_type [template::util::address::get_property postal_type $address_list] - set message [list] + set message {} # this is used to make sure there are no invalid characters in the address set address_temp "$delivery_address $municipality $region $postal_code $country_code $additional_text $postal_type" if { [::string match "\{" $address_temp] || [::string match "\}" $address_temp] } { @@ -371,7 +371,7 @@ } if { $country_code == "US" || $country_code == "CA" } { # make the city pretty - set municipality_temp [list] + set municipality_temp {} foreach word $municipality { # I am sure there are more then "Mc" words when they come up add them here if { [regexp {^MC([a-zA-Z]+?)} [string toupper $word]] } { Index: openacs-4/packages/ams/tcl/ams-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ams/tcl/ams-procs.tcl,v diff -u -N -r1.54 -r1.55 --- openacs-4/packages/ams/tcl/ams-procs.tcl 5 Apr 2018 14:44:08 -0000 1.54 +++ openacs-4/packages/ams/tcl/ams-procs.tcl 25 Apr 2018 19:47:46 -0000 1.55 @@ -202,9 +202,9 @@ } { localize the elements of a list_of_lists } { - set list_output [list] + set list_output {} foreach item $list { - set item_output [list] + set item_output {} foreach part $item { lappend item_output [lang::util::localize $part] } @@ -219,7 +219,7 @@ } { sort a list_of_lists } { -# set sort_output [list] +# set sort_output {} # foreach item $list { # set sort_key [string toupper [lindex $item $position]] # we need to replace spaces because it prevents @@ -229,7 +229,7 @@ # lappend sort_output [list $sort_key $item] # } # set sort_output [lsort $sort_output] -# set list_output [list] +# set list_output {} # foreach item $sort_output { # lappend list_output [lindex $item 1] # } @@ -461,7 +461,7 @@ @param list_names A list of list_names to get the list_ids from. Either this or list_name must be provided. @param key The key element to use in the form. } { - set list_ids [list] + set list_ids {} if { [empty_string_p $list_names] && [empty_string_p $list_name] } { ad_return_complaint 1 "[_ ams.you_must_provide_list_name]" ad_script_abort @@ -499,11 +499,11 @@ # Control list to know which attributes are already in the # elements list so we don't en up with duplicates - set control_list [list] + set control_list {} # If we do not have a list_id then don't bother to try and get any attributes... if {[string eq "" $list_ids]} { - set all_attributes [list] + set all_attributes {} } else { set all_attributes [db_list_of_lists select_elements " "] } @@ -664,7 +664,7 @@ set list_names $list_name } - set list_ids [list] + set list_ids {} foreach l_name $list_names { set list_id [ams::list::get_list_id -package_key $package_key -object_type $object_type -list_name $l_name] if {![empty_string_p $list_id]} { @@ -677,7 +677,7 @@ set list_ids [template::util::tcl_to_sql_list $list_ids] if { [exists_and_not_null list_ids] } { - set values [list] + set values {} set heading "" # Control list to know which attributes are already in the Index: openacs-4/packages/ams/tcl/ams-widget-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ams/tcl/ams-widget-procs.tcl,v diff -u -N -r1.38 -r1.39 --- openacs-4/packages/ams/tcl/ams-widget-procs.tcl 23 Mar 2018 22:56:43 -0000 1.38 +++ openacs-4/packages/ams/tcl/ams-widget-procs.tcl 25 Apr 2018 19:47:46 -0000 1.39 @@ -67,7 +67,7 @@ value_text - value_html { if { [exists_and_not_null value] } { if { [::ams::widget_has_options_p -widget $widget] } { - set output [list] + set output {} foreach option [::ams::widget_options -attribute_id $attribute_id -locale $locale] { if { [lsearch $value [lindex $option 1]] >= 0 } { lappend output [lindex $option 0] @@ -106,7 +106,7 @@ } { Return all widget procs. Each list element is a list of the first then pretty_name then the widget } { - set return_list [list] + set return_list {} db_foreach get_options {} { set pretty_name "[lang::util::localize $pretty_name $locale]" lappend return_list [list $pretty_name $option_id] @@ -126,7 +126,7 @@ } { Return all widget procs. Each list element is a list of the first then pretty_name then the widget } { - set widgets [list] + set widgets {} set all_procs [::info procs "::ams::widget::*"] foreach widget $all_procs { if { [string is false [regsub {__arg_parser} $widget {} widget]] } { @@ -141,7 +141,7 @@ } { Initialize all widgets. Deprecated widgets that no longer exist in the tcl api. } { - set proc_widgets [list] + set proc_widgets {} foreach widget [ams::widget_list] { lappend proc_widgets [lindex $widget 1] } @@ -422,7 +422,7 @@ switch $request { ad_form_widget { set help_text [attribute::help_text -attribute_id $attribute_id] - set element [list] + set element {} if { [string is true $optional_p] } { return "${attribute_name}:mobile_number(mobile_number),optional {help_text \"$help_text\"} {[list label ${pretty_name}]} {[list html ${html_options}]}" } else { @@ -513,7 +513,7 @@ switch $request { ad_form_widget { set help_text [attribute::help_text -attribute_id $attribute_id] - set element [list] + set element {} if { [string is true $optional_p] } { lappend element ${attribute_name}:text(text),optional } else { @@ -606,7 +606,7 @@ switch $request { ad_form_widget { set help_text [attribute::help_text -attribute_id $attribute_id] - set element [list] + set element {} if { [string is true $optional_p] } { lappend element ${attribute_name}:text(text),optional } else { Index: openacs-4/packages/ams/www/attribute-add-2.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ams/www/attribute-add-2.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/ams/www/attribute-add-2.tcl 28 May 2005 15:37:27 -0000 1.4 +++ openacs-4/packages/ams/www/attribute-add-2.tcl 25 Apr 2018 19:47:46 -0000 1.5 @@ -91,7 +91,7 @@ } -on_submit { set i 1 - set options [list] + set options {} while { $i <= "9" } { set option_value [string trim [set option${i}]] ns_log notice $option_value Index: openacs-4/packages/ams/www/attribute-add.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ams/www/attribute-add.tcl,v diff -u -N -r1.10 -r1.11 --- openacs-4/packages/ams/www/attribute-add.tcl 31 Jul 2007 00:53:01 -0000 1.10 +++ openacs-4/packages/ams/www/attribute-add.tcl 25 Apr 2018 19:47:46 -0000 1.11 @@ -41,7 +41,7 @@ set default_number_of_options 5 set option_fields_count $default_number_of_options set i 1 - set elements [list] + set elements {} lappend elements [list option_fields_count:integer(hidden) [list value $option_fields_count]] # lappend elements [list options_on_last_screen:integer(hidden),optional] while { $i <= $option_fields_count } { Index: openacs-4/packages/assessment/tcl/as-checks-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/tcl/as-checks-procs.tcl,v diff -u -N -r1.29 -r1.30 --- openacs-4/packages/assessment/tcl/as-checks-procs.tcl 7 Aug 2017 23:48:03 -0000 1.29 +++ openacs-4/packages/assessment/tcl/as-checks-procs.tcl 25 Apr 2018 19:47:46 -0000 1.30 @@ -274,7 +274,7 @@ } set admin [db_list_of_lists get_assessment_admin {}] - set to [list] + set to {} foreach notify_user $admin { lappend to $notify_user } @@ -348,7 +348,7 @@ db_dml update_actions_log {} set admin [db_list_of_lists get_assessment_admin {}] - set to [list] + set to {} foreach notify_user $admin { lappend to $notify_user } Index: openacs-4/packages/assessment/tcl/as-list-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/tcl/as-list-procs.tcl,v diff -u -N -r1.7 -r1.8 --- openacs-4/packages/assessment/tcl/as-list-procs.tcl 7 Aug 2017 23:48:03 -0000 1.7 +++ openacs-4/packages/assessment/tcl/as-list-procs.tcl 25 Apr 2018 19:47:46 -0000 1.8 @@ -27,7 +27,7 @@ set paramlist [list] if { [set form [rp_getform]] ne "" } { array set formarr [util_ns_set_to_list -set $form] - set paramlist [list] + set paramlist {} foreach param [array names formarr] { if { [regexp -nocase {^as_item_id_(\d+)$} $param match one_item_id] } { @@ -53,7 +53,7 @@ set as_item_ids [list] if { [set form [rp_getform]] ne "" } { array set formarr [util_ns_set_to_list -set $form] - set paramlist [list] + set paramlist {} foreach param [array names formarr] { if { [regexp -nocase {^as_item_id_(\d+)$} $param match one_item_id] } { @@ -102,15 +102,15 @@ @param assessment_ids List of IDs of the assessments to get the items from } { - set elements [list] + set elements {} set multirow __as_list_$list_name as::list::get_items_multirow \ -assessment_ids $assessment_ids \ -multirow $multirow # don't query the same item more than one - array set visited_items [list] + array set visited_items {} template::multirow foreach $multirow { if {![info exists visited_items($item_id)] && $as_item_id == $latest_revision} { set visited_items($item_id) $item_id @@ -182,7 +182,7 @@ #get all the items - set filters [list] + set filters {} # we just want the questions that are in all the assessments we received set multirow __as_list_$list_name @@ -191,7 +191,7 @@ -multirow $multirow # don't query the same item more than one - array set visited_items [list] + array set visited_items {} template::multirow foreach $multirow { if {![info exists visited_items($item_id)]} { set visited_items($item_id) $item_id @@ -271,7 +271,7 @@ } else { set multiple_assessment_where "" } - array set visited_sections [list] + array set visited_sections {} foreach section [db_list_of_lists sections {}] { set option_section_title [lindex $section 0] set option_section_id [lindex $section 1] @@ -295,7 +295,7 @@ #get all the items - set groupbys [list] + set groupbys {} # we just want the questions that are in all the assessments we received set multirow __as_list_$list_name @@ -304,7 +304,7 @@ -multirow $multirow # don't query the same item more than one - array set visited_items [list] + array set visited_items {} template::multirow foreach $multirow { if {![info exists visited_items($item_id)]} { set visited_items($item_id) $item_id @@ -331,7 +331,7 @@ #get all the items - set orderbys [list] + set orderbys {} # we just want the questions that are in all the assessments we received set multirow __as_list_$list_name @@ -340,7 +340,7 @@ -multirow $multirow # don't query the same item more than one - array set visited_items [list] + array set visited_items {} template::multirow foreach $multirow { if {![info exists visited_items($item_id)]} { set visited_items($item_id) $item_id Index: openacs-4/packages/assessment/www/asm-admin/action-params.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/www/asm-admin/action-params.tcl,v diff -u -N -r1.11 -r1.12 --- openacs-4/packages/assessment/www/asm-admin/action-params.tcl 20 Jan 2018 22:38:28 -0000 1.11 +++ openacs-4/packages/assessment/www/asm-admin/action-params.tcl 25 Apr 2018 19:47:46 -0000 1.12 @@ -68,7 +68,7 @@ } db_foreach get_params {} { - set choices [list] + set choices {} if { $type eq "n" } { if { $action_perform eq "aa" || $action_perform eq "m" || $action_perform eq "or" || $action_perform eq "sa"} { set choices [db_list_of_lists choices {}] Index: openacs-4/packages/assessment/www/asm-admin/item-stats.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/www/asm-admin/item-stats.tcl,v diff -u -N -r1.8 -r1.9 --- openacs-4/packages/assessment/www/asm-admin/item-stats.tcl 7 Aug 2017 23:48:04 -0000 1.8 +++ openacs-4/packages/assessment/www/asm-admin/item-stats.tcl 25 Apr 2018 19:47:46 -0000 1.9 @@ -33,7 +33,7 @@ if {[info exists session_id_list]} { set session_ids $session_id_list - set session_id_list [list] + set session_id_list {} foreach elm [split $session_id_list] { if {$elm ne ""} { lappend session_id_list $elm @@ -95,8 +95,8 @@ set total_correct 0 set total_choices 0 - set choices [list] - set visited_session_ids [list] + set choices {} + set visited_session_ids {} set item_choices_limit_session "" if { ([info exists limit_to_section_clause] && $limit_to_section_clause ne "") } { set item_choices_limit_session "and d.session_id in $limit_to_section_clause" } @@ -210,7 +210,7 @@ "float" { set stats "\n" - set number_answers [list] + set number_answers {} set total_responses 0 db_foreach get_number_answers { select count(*) as n_responses, numeric_answer Index: openacs-4/packages/auth-ldap/tcl/auth-ldap-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/auth-ldap/tcl/auth-ldap-procs.tcl,v diff -u -N -r1.14 -r1.15 --- openacs-4/packages/auth-ldap/tcl/auth-ldap-procs.tcl 27 Mar 2018 17:08:50 -0000 1.14 +++ openacs-4/packages/auth-ldap/tcl/auth-ldap-procs.tcl 25 Apr 2018 19:47:46 -0000 1.15 @@ -523,7 +523,7 @@ } append dn ",$params(BaseDN)" - set attributes [list] + set attributes {} foreach elm [split $params(Attributes) ";"] { set elmv [split $elm "="] set attribute [string trim [lindex $elmv 0]] @@ -603,7 +603,7 @@ } # Set up mapping data structure - array set map [list] + array set map {} foreach elm [split $params(InfoAttributeMap) ";"] { set elmv [split $elm "="] set oacs_elm [string trim [lindex $elmv 0]] @@ -613,7 +613,7 @@ } # Map LDAP attributes to OpenACS elements - array set user [list] + array set user {} foreach { attribute value } [lindex $search_result 0] { if { [info exists map($attribute)] } { foreach oacs_elm $map($attribute) { Index: openacs-4/packages/b-responsive-theme/www/blank-master.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/b-responsive-theme/www/blank-master.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/b-responsive-theme/www/blank-master.tcl 12 Apr 2018 07:47:22 -0000 1.2 +++ openacs-4/packages/b-responsive-theme/www/blank-master.tcl 25 Apr 2018 19:47:46 -0000 1.3 @@ -100,7 +100,7 @@ if { [llength $css] == 2 && [llength [lindex $css 0]] == 1 } { template::head::add_css -href [lindex $css 0] -media [lindex $css 1] } else { - set params [list] + set params {} foreach param $css { lappend params -[lindex $param 0] [lindex $param 1] } @@ -172,7 +172,7 @@ # we are using TinyMCE template::head::add_javascript -src "/resources/acs-templating/tinymce/jscripts/tiny_mce/tiny_mce_src.js" -order tinymce0 # get the textareas where we apply tinymce - set tinymce_elements [list] + set tinymce_elements {} foreach htmlarea_id [lsort -unique $::acs_blank_master__htmlareas] { lappend tinymce_elements $htmlarea_id } Index: openacs-4/packages/bug-tracker/tcl/bug-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/tcl/bug-procs.tcl,v diff -u -N -r1.39 -r1.40 --- openacs-4/packages/bug-tracker/tcl/bug-procs.tcl 8 Apr 2018 05:29:43 -0000 1.39 +++ openacs-4/packages/bug-tracker/tcl/bug-procs.tcl 25 Apr 2018 19:47:46 -0000 1.40 @@ -262,7 +262,7 @@ } { upvar $array row - array set assignments [list] + array set assignments {} set role_prefix "role_" foreach name [array names row "${role_prefix}*"] { @@ -710,7 +710,7 @@ } # Build up the details list - set details_list [list] + set details_list {} foreach field $fields { lappend details_list $label($field) $value($field) } @@ -824,7 +824,7 @@ } } - set category_defaults [list] + set category_defaults {} foreach { parent_id parent_heading } [bug_tracker::category_types] { @@ -1048,7 +1048,7 @@ fixed_in_version_name } - set category_defaults [list] + set category_defaults {} foreach { parent_id parent_heading } [bug_tracker::category_types] { lappend category_defaults $parent_id {} @@ -1115,7 +1115,7 @@ bug_tracker::bug::get_list -ulevel 2 bug_tracker::bug::get_multirow - set filter_bug_numbers [list] + set filter_bug_numbers {} template::multirow foreach bugs { lappend filter_bug_numbers $bug_number } Index: openacs-4/packages/bug-tracker/tcl/bug-tracker-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/tcl/bug-tracker-procs.tcl,v diff -u -N -r1.55 -r1.56 --- openacs-4/packages/bug-tracker/tcl/bug-tracker-procs.tcl 24 Apr 2018 16:13:07 -0000 1.55 +++ openacs-4/packages/bug-tracker/tcl/bug-tracker-procs.tcl 25 Apr 2018 19:47:46 -0000 1.56 @@ -331,7 +331,7 @@ set workflow_id [bug_tracker::bug::get_instance_workflow_id -package_id $package_id] set state_ids [workflow::fsm::get_states -workflow_id $workflow_id] - set option_list [list] + set option_list {} foreach state_id $state_ids { workflow::state::fsm::get -state_id $state_id -array state lappend option_list [list "$state(pretty_name)" $state(short_name)] @@ -470,8 +470,8 @@ @return Returns the category types for this instance as an array-list of { parent_id1 heading1 parent_id2 heading2 ... } } { - array set heading [list] - set parent_ids [list] + array set heading {} + set parent_ids {} set last_parent_id {} foreach elm [get_keywords -package_id $package_id] { @@ -484,7 +484,7 @@ } } - set result [list] + set result {} foreach parent_id $parent_ids { lappend result $parent_id $heading($parent_id) } @@ -533,7 +533,7 @@ @param parent_id The category type's keyword_id @return options-list for a select widget for the given category type } { - set options [list] + set options {} foreach elm [get_keywords -package_id $package_id] { lassign $elm elm_child_id elm_child_heading elm_parent_id @@ -1147,7 +1147,7 @@ Return a list of lists with the bug number in the first element and the bug summary in the second. } { - set bug_list [list] + set bug_list {} set package_id [ad_conn package_id] if { $only_open_p } { @@ -1177,7 +1177,7 @@ {-write_or_submitter_p:required} } { set bug_list [get_mapped_bugs -patch_number $patch_number] - set bug_link_list [list] + set bug_link_list {} if { [llength $bug_list] == 0} { return "" @@ -1211,7 +1211,7 @@ {-bug_id:required} {-show_patch_status open} } { - set patch_list [list] + set patch_list {} switch -- $show_patch_status { open { @@ -1452,7 +1452,7 @@ ad_proc bug_tracker::get_related_files_links { {-bug_id:required} } { - set related_files_list [list] + set related_files_list {} set user_id [ad_conn user_id] set admin_p [permission::permission_p \ -party_id $user_id \ @@ -1503,7 +1503,7 @@ ad_proc bug_tracker::get_related_files_links { {-bug_id:required} } { - set related_files_list [list] + set related_files_list {} set user_id [ad_conn user_id] set admin_p [permission::permission_p \ -party_id $user_id \ Index: openacs-4/packages/bug-tracker/tcl/bug-tracker-scheduled-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/tcl/bug-tracker-scheduled-procs.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/bug-tracker/tcl/bug-tracker-scheduled-procs.tcl 28 Mar 2018 23:36:17 -0000 1.4 +++ openacs-4/packages/bug-tracker/tcl/bug-tracker-scheduled-procs.tcl 25 Apr 2018 19:47:46 -0000 1.5 @@ -32,7 +32,7 @@ workflow::action::get -action_id $enabled_action(action_id) -array available_action if {$available_action(short_name) eq "resolve"} { set action_id $enabled_action(action_id) - array set row [list] + array set row {} foreach field [workflow::action::get_element -action_id $action_id -element edit_fields] { set row($field) "" } @@ -52,7 +52,7 @@ workflow::action::get -action_id $enabled_action(action_id) -array available_action if {$available_action(short_name) eq "close"} { set action_id $enabled_action(action_id) - array set row [list] + array set row {} foreach field [workflow::action::get_element -action_id $action_id -element edit_fields] { set row($field) "" } Index: openacs-4/packages/bug-tracker/www/bug.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/www/bug.tcl,v diff -u -N -r1.54 -r1.55 --- openacs-4/packages/bug-tracker/www/bug.tcl 7 Apr 2018 11:27:06 -0000 1.54 +++ openacs-4/packages/bug-tracker/www/bug.tcl 25 Apr 2018 19:47:46 -0000 1.55 @@ -258,7 +258,7 @@ # on_submit block ad_form -extend -name bug -on_submit { - array set row [list] + array set row {} if { $enabled_action_id ne "" } { foreach field [workflow::action::get_element -action_id $action_id -element edit_fields] { Index: openacs-4/packages/bug-tracker/www/related-file-add.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/www/related-file-add.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/bug-tracker/www/related-file-add.tcl 30 Sep 2017 18:12:52 -0000 1.4 +++ openacs-4/packages/bug-tracker/www/related-file-add.tcl 25 Apr 2018 19:47:46 -0000 1.5 @@ -82,7 +82,7 @@ workflow::action::get -action_id $enabled_action(action_id) -array available_action if {$available_action(short_name) eq "comment"} { set action_id $enabled_action(action_id) - array set row [list] + array set row {} foreach field [workflow::action::get_element -action_id $action_id -element edit_fields] { set row($field) "" } Index: openacs-4/packages/bug-tracker/www/related-file-delete.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/www/related-file-delete.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/bug-tracker/www/related-file-delete.tcl 29 May 2016 10:50:02 -0000 1.5 +++ openacs-4/packages/bug-tracker/www/related-file-delete.tcl 25 Apr 2018 19:47:46 -0000 1.6 @@ -66,7 +66,7 @@ workflow::action::get -action_id $enabled_action(action_id) -array available_action if {$available_action(short_name) eq "comment"} { set action_id $enabled_action(action_id) - array set row [list] + array set row {} foreach field [workflow::action::get_element -action_id $action_id -element edit_fields] { set row($field) "" } Index: openacs-4/packages/bug-tracker/www/related-file-update.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/www/related-file-update.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/bug-tracker/www/related-file-update.tcl 30 Sep 2017 18:12:52 -0000 1.5 +++ openacs-4/packages/bug-tracker/www/related-file-update.tcl 25 Apr 2018 19:47:46 -0000 1.6 @@ -87,7 +87,7 @@ workflow::action::get -action_id $enabled_action(action_id) -array available_action if {$available_action(short_name) eq "comment"} { set action_id $enabled_action(action_id) - array set row [list] + array set row {} foreach field [workflow::action::get_element -action_id $action_id -element edit_fields] { set row($field) "" } Index: openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl,v diff -u -N -r1.16 -r1.17 --- openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl 12 Apr 2018 07:47:22 -0000 1.16 +++ openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl 25 Apr 2018 19:47:46 -0000 1.17 @@ -194,7 +194,7 @@ # for strings of the format {column_name} in the subject # and message and replace them with the value of that # column as returned by the query - set pairs [list] + set pairs {} for {set i 0} {$i < [ns_set size $recipient]} {incr i} { lappend pairs [list \{[ns_set key $recipient $i]\} [ns_set value $recipient $i]] } Index: openacs-4/packages/calendar/tcl/cal-item-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/calendar/tcl/cal-item-procs.tcl,v diff -u -N -r1.30 -r1.31 --- openacs-4/packages/calendar/tcl/cal-item-procs.tcl 22 Apr 2018 18:05:23 -0000 1.30 +++ openacs-4/packages/calendar/tcl/cal-item-procs.tcl 25 Apr 2018 19:47:46 -0000 1.31 @@ -249,7 +249,7 @@ db_exec_plsql update_interval {} # Update the item_type_id and calendar_id - set colspecs [list] + set colspecs {} lappend colspecs "item_type_id = :item_type_id" if { $calendar_id ne "" } { lappend colspecs "on_which_calendar = :calendar_id" @@ -333,7 +333,7 @@ -cal_item_id $event_id \ -array orig_event - set colspecs [list] + set colspecs {} foreach col {name description} { if {$orig_event($col) ne [set $col]} { lappend colspecs "$col = :$col" @@ -342,7 +342,7 @@ if {[llength $colspecs]} { db_dml recurrence_events_update {} } - set colspecs [list] + set colspecs {} lappend colspecs {item_type_id = :item_type_id} if { $calendar_id ne "" } { lappend colspecs {on_which_calendar = :calendar_id} Index: openacs-4/packages/categories/tcl/categories-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/categories/tcl/categories-procs.tcl,v diff -u -N -r1.31 -r1.32 --- openacs-4/packages/categories/tcl/categories-procs.tcl 31 Jan 2018 08:23:12 -0000 1.31 +++ openacs-4/packages/categories/tcl/categories-procs.tcl 25 Apr 2018 19:47:46 -0000 1.32 @@ -379,7 +379,7 @@ @return list of names corresponding to the list of category_id's supplied. @author Timo Hentschel (timo@timohentschel.de) } { - set result [list] + set result {} foreach category_id $category_ids { lappend result [category::get_name $category_id $locale] } Index: openacs-4/packages/categories/tcl/category-trees-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/categories/tcl/category-trees-procs.tcl,v diff -u -N -r1.27 -r1.28 --- openacs-4/packages/categories/tcl/category-trees-procs.tcl 7 Aug 2017 23:48:05 -0000 1.27 +++ openacs-4/packages/categories/tcl/category-trees-procs.tcl 25 Apr 2018 19:47:46 -0000 1.28 @@ -32,7 +32,7 @@ returns the main categories of a given tree } { set locale [ad_conn locale] - set result [list] + set result {} set categories [db_list get_categories ""] foreach category_id $categories { lappend result $category_id @@ -223,7 +223,7 @@ assign_single_p require_category_p @author Timo Hentschel (timo@timohentschel.de) } { - set result [list] + set result {} db_foreach get_mapped_trees "" { lappend result [list $tree_id [get_name $tree_id $locale] $subtree_category_id $assign_single_p $require_category_p $widget] @@ -238,7 +238,7 @@ @return Tcl list of tree_ids @author Peter Kreuzinger (peter.kreuzinger@wu-wien.ac.at) } { - set result [list] + set result {} db_foreach get_trees "" { lappend result $tree_id @@ -272,7 +272,7 @@ assign_single_p require_category_p widget @author Jade Rubick (jader@bread.com) } { - set result [list] + set result {} db_foreach get_mapped_trees_from_object_list "" { lappend result [list $tree_id [get_name $tree_id $locale] $subtree_category_id $assign_single_p $require_category_p $widget] @@ -347,16 +347,16 @@ catch {nsv_unset category_trees} set tree_id_old 0 set cur_level 1 - set stack [list] + set stack {} set invalid_p "" - set tree [list] + set tree {} db_foreach reset_cache "" { if {$tree_id != $tree_id_old && $tree_id_old != 0} { nsv_set category_trees $tree_id_old $tree set cur_level 1 - set stack [list] + set stack {} set invalid_p "" - set tree [list] + set tree {} } set tree_id_old $tree_id lappend tree [list $category_id [ad_decode "$invalid_p$deprecated_p" "" f t] $cur_level] @@ -386,9 +386,9 @@ @author Timo Hentschel (timo@timohentschel.de) } { set cur_level 1 - set stack [list] + set stack {} set invalid_p "" - set tree [list] + set tree {} db_foreach flush_cache "" { lappend tree [list $category_id [ad_decode "$invalid_p$deprecated_p" "" f t] $cur_level] if { $right_ind - $left_ind > 1} { @@ -574,7 +574,7 @@ && [llength $category_counts] > 1} { array set counts $category_counts } else { - array set counts [list] + array set counts {} } # If we should append, then don't create the datasource if it already exists @@ -611,12 +611,12 @@ # given level set size [template::multirow size $datasource] - set rollup [list] + set rollup {} for {set i $size} {$i > 0} {incr i -1} { set level [template::multirow get $datasource $i level] set count [template::multirow get $datasource $i count] set j 1 - set nrollup [list] + set nrollup {} foreach r $rollup { if {$j < $level} { lappend nrollup [expr {$r + $count}] Index: openacs-4/packages/categories/tcl/widget-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/categories/tcl/widget-procs.tcl,v diff -u -N -r1.24 -r1.25 --- openacs-4/packages/categories/tcl/widget-procs.tcl 7 Aug 2017 23:48:05 -0000 1.24 +++ openacs-4/packages/categories/tcl/widget-procs.tcl 25 Apr 2018 19:47:46 -0000 1.25 @@ -104,7 +104,7 @@ set mapped_categories [ns_querygetall $element(id)] # QUIRK: ns_querygetall returns a single-element list {{}} for no values if { [string equal $mapped_categories {{}}] } { - set mapped_categories [list] + set mapped_categories {} } } set output {} @@ -184,7 +184,7 @@ # author: Timo Hentschel (timo@timohentschel.de) upvar 2 $message_ref message $value_ref values - set invalid_values [list] + set invalid_values {} foreach value $values { if {![regexp {^[+-]?\d+$} $value]} { @@ -261,11 +261,11 @@ if {$require_category_p == "t"} { set trees [list [list $tree_id $subtree_id]] } else { - set trees [list] + set trees {} } } - set trees_without_category [list] + set trees_without_category {} foreach tree $trees { lassign $tree tree_id subtree_id # get categories of every tree requiring a categorization Index: openacs-4/packages/categories/www/cadmin/tree-order-update.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/categories/www/cadmin/tree-order-update.tcl,v diff -u -N -r1.8 -r1.9 --- openacs-4/packages/categories/www/cadmin/tree-order-update.tcl 19 Jan 2018 14:50:04 -0000 1.8 +++ openacs-4/packages/categories/www/cadmin/tree-order-update.tcl 25 Apr 2018 19:47:46 -0000 1.9 @@ -34,8 +34,8 @@ set last_ind [expr {($count / 5) + 1}] set count 1 - set stack [list] - set done_list [list] + set stack {} + set done_list {} # put toplevel categories on stack if {[info exists child(-1)]} { set stack [lsort -integer -index 0 $child(-1)] Index: openacs-4/packages/chat/tcl/chat-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/chat/tcl/chat-procs.tcl,v diff -u -N -r1.15 -r1.16 --- openacs-4/packages/chat/tcl/chat-procs.tcl 1 Feb 2018 20:47:36 -0000 1.15 +++ openacs-4/packages/chat/tcl/chat-procs.tcl 25 Apr 2018 19:47:46 -0000 1.16 @@ -634,7 +634,7 @@ # do we have to create a transcript for the room if { $room_info(auto_transcript_p) == "t" } { # build a list of all messages - set contents [list] + set contents {} foreach message [db_list_of_lists get_archives_messages {}] { lassign $message msg creation_user creation_date set user_name [expr {$creation_user > 0 ? [chat_user_name $creation_user] : "system"}] Index: openacs-4/packages/cms/tcl/browser-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/cms/tcl/browser-procs.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/cms/tcl/browser-procs.tcl 5 Apr 2018 14:44:08 -0000 1.4 +++ openacs-4/packages/cms/tcl/browser-procs.tcl 25 Apr 2018 19:47:46 -0000 1.5 @@ -24,7 +24,7 @@ } { - set state [list] + set state {} foreach mount_point [buildMountPoints $user_id] { lappend state [stateNodeCreate [folderAccess mount_point $mount_point] [list]] } @@ -44,7 +44,7 @@ } { - set new_children [list] + set new_children {} upvar $stateRef state foreach child $children { @@ -89,7 +89,7 @@ collapse { # Collapse: empty the children list ns_log debug "updateTreeStateChildren: COLLAPSING: [folderPath $user_id $mount_point $target_id]" - set child_children [list] + set child_children {} } expand { @@ -172,7 +172,7 @@ } # Merge the new children, preserving the sorted order - set child_children [list] + set child_children {} foreach new_child $folder_children { set old_child_id [stateNodeAccess id $new_child] # If the old child exists, use it instead of the new one @@ -222,7 +222,7 @@ # Reference the state upvar $stateRef state - set folderList [list] + set folderList {} foreach node $state { @@ -366,7 +366,7 @@ the folders in the process } { - set child_ids [list] + set child_ids {} foreach subfolder $subfolder_list { if { ![template::util::is_nil user_id] } { cacheOneFolder $user_id $subfolder 1 Index: openacs-4/packages/cms/tcl/clipboard-ui-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/cms/tcl/clipboard-ui-procs.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/cms/tcl/clipboard-ui-procs.tcl 1 Nov 2003 08:45:38 -0000 1.3 +++ openacs-4/packages/cms/tcl/clipboard-ui-procs.tcl 25 Apr 2018 19:47:46 -0000 1.4 @@ -24,7 +24,7 @@ set elements $opts(elements) unset opts(elements) } else { - set elements [list] + set elements {} } set v_args [template::util::list_opts] @@ -72,7 +72,7 @@ # Set defaults set row(html) "" set row(hidden) "" - set row(elements) [list] + set row(elements) {} # Create the checkbox set element_code [list check -datatype text -widget checkbox \ @@ -214,7 +214,7 @@ return } - set header [list] + set header {} foreach element_name $row(elements) { upvar "${form_name}:${element_name}_${row_index}" element if { ![string equal $element(widget) hidden] } { Index: openacs-4/packages/cms/tcl/form-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/cms/tcl/form-procs.tcl,v diff -u -N -r1.30 -r1.31 --- openacs-4/packages/cms/tcl/form-procs.tcl 5 Apr 2018 14:44:08 -0000 1.30 +++ openacs-4/packages/cms/tcl/form-procs.tcl 25 Apr 2018 19:47:46 -0000 1.31 @@ -57,8 +57,8 @@ upvar content_type content_type upvar opts opts - set code_params [list] - set html_params [list] + set code_params {} + set html_params {} # Process the results of the query. for { set i $start_row } { $i <= $rowcount } { incr i } { @@ -207,8 +207,8 @@ set last_attribute_name "" set new_section_p 1 - set code_params [list] - set html_params [list] + set code_params {} + set html_params {} # Perform a gigantic query to retrieve all metadata query_form_metadata @@ -250,8 +250,8 @@ ns_log debug "content::get_revision_form: type_label: $last_type" eval $form_element - set code_params [list] - set html_params [list] + set code_params {} + set html_params {} } @@ -396,8 +396,8 @@ if { $i != 1 } { content::process_revision_form_dml } - set columns [list] - set values [list] + set columns {} + set values {} } # fetch the value of the attribute from the form @@ -493,8 +493,8 @@ if { $i != 1 } { content::process_insert_statement } - set columns [list] - set values [list] + set columns {} + set values {} } # fetch the value of the attribute from the form @@ -552,7 +552,7 @@ Assemble a passthrough list out of variables } { - set result [list] + set result {} foreach varname $args { upvar $varname var lappend result [list $varname $var] @@ -783,9 +783,9 @@ # initialize the column and value list set columns [list item_id revision_id creation_user creation_ip] set values [list :item_id :revision_id null null] - set default_columns [list] - set default_values [list] - set missing_columns [list] + set default_columns {} + set default_values {} + set missing_columns {} # query for attribute names and datatypes foreach attribute [get_attributes $content_type attribute_name datatype default_value ancestor] { @@ -1344,7 +1344,7 @@ set attribute_data [eval get_type_attribute_params [array names type_lookup]] - set attribute_names [list] + set attribute_names {} array set attributes_by_type $attribute_data foreach row $attribute_list { @@ -1754,8 +1754,8 @@ # Assemble the list of columns to query, handling dates # correctly - set columns [list] - set attr_types [list] + set columns {} + set attr_types {} foreach attr $attributes { if { [template::element exists $form_name "$prefix$attr"] } { set datatype [template::element get_property $form_name "$prefix$attr" datatype] Index: openacs-4/packages/cms/tcl/module-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/cms/tcl/module-procs.tcl,v diff -u -N -r1.10 -r1.11 --- openacs-4/packages/cms/tcl/module-procs.tcl 5 Apr 2018 14:44:08 -0000 1.10 +++ openacs-4/packages/cms/tcl/module-procs.tcl 25 Apr 2018 19:47:46 -0000 1.11 @@ -192,7 +192,7 @@ } { - set children [list] + set children {} if { [string equal $id {}] } { set id [getRootFolderID [ad_conn package_id]] @@ -222,7 +222,7 @@ } { - set children [list] + set children {} if { [string equal $id {}] } { set where_clause "k.parent_id is null" @@ -307,7 +307,7 @@ return [list] } - set children [list] + set children {} set module_name [namespace tail [namespace current]] Index: openacs-4/packages/cms/www/doc/dev-guide.html =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/cms/www/doc/dev-guide.html,v diff -u -N -r1.1 -r1.2 --- openacs-4/packages/cms/www/doc/dev-guide.html 20 Apr 2001 20:51:09 -0000 1.1 +++ openacs-4/packages/cms/www/doc/dev-guide.html 25 Apr 2018 19:47:46 -0000 1.2 @@ -1903,7 +1903,7 @@ 1 2 3 4 % set factor 3 3 - % set b [list] + % set b {} % list_map $a {lappend b [expr $list_item * $factor]} % set b 3 6 9 12 Index: openacs-4/packages/cms/www/doc/xml/uplevels-namespaces.xml =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/cms/www/doc/xml/uplevels-namespaces.xml,v diff -u -N -r1.1 -r1.2 --- openacs-4/packages/cms/www/doc/xml/uplevels-namespaces.xml 20 Apr 2001 20:51:10 -0000 1.1 +++ openacs-4/packages/cms/www/doc/xml/uplevels-namespaces.xml 25 Apr 2018 19:47:46 -0000 1.2 @@ -964,7 +964,7 @@ 1 2 3 4 % set factor 3 3 -% set b [list] +% set b {} % list_map $a {lappend b [expr $list_item * $factor]} % set b 3 6 9 12 Index: openacs-4/packages/cms/www/modules/sitemap/delete-items.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/cms/www/modules/sitemap/delete-items.tcl,v diff -u -N -r1.8 -r1.9 --- openacs-4/packages/cms/www/modules/sitemap/delete-items.tcl 13 Apr 2005 20:15:19 -0000 1.8 +++ openacs-4/packages/cms/www/modules/sitemap/delete-items.tcl 25 Apr 2018 19:47:46 -0000 1.9 @@ -69,7 +69,7 @@ db_transaction { - set parents [list] + set parents {} foreach del_item_id $deleted_items { set is_symlink [element get_values delete "is_symlink_$del_item_id"] set is_folder [element get_values delete "is_folder_$del_item_id"] Index: openacs-4/packages/cms/www/modules/users/user-search.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/cms/www/modules/users/user-search.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/cms/www/modules/users/user-search.tcl 20 Aug 2002 11:17:31 -0000 1.4 +++ openacs-4/packages/cms/www/modules/users/user-search.tcl 25 Apr 2018 19:47:46 -0000 1.5 @@ -54,7 +54,7 @@ set extra_url [content::url_passthrough $passthrough] - set clauses [list] + set clauses {} set search_in [element get_values user_search search_in] set keyword [string tolower "%$keyword%"] Index: openacs-4/packages/contacts/lib/contacts-master.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/lib/contacts-master.tcl,v diff -u -N -r1.17 -r1.18 --- openacs-4/packages/contacts/lib/contacts-master.tcl 8 Feb 2008 17:13:27 -0000 1.17 +++ openacs-4/packages/contacts/lib/contacts-master.tcl 25 Apr 2018 19:47:46 -0000 1.18 @@ -98,7 +98,7 @@ if { ![exists_and_not_null title] } { set title [ad_conn instance_name] - set context [list] + set context {} } else { set context [list $title] } Index: openacs-4/packages/contacts/lib/contacts.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/lib/contacts.tcl,v diff -u -N -r1.73 -r1.74 --- openacs-4/packages/contacts/lib/contacts.tcl 25 Jun 2007 16:25:39 -0000 1.73 +++ openacs-4/packages/contacts/lib/contacts.tcl 25 Apr 2018 19:47:46 -0000 1.74 @@ -110,7 +110,7 @@ # We clear the list when no value is submited, otherwise # we acumulate the extend values. if { [empty_string_p $extend_option] } { - set extend_values [list] + set extend_values {} } else { lappend extend_values [list $extend_option] } @@ -546,7 +546,7 @@ } - set party_ids [list] + set party_ids {} db_multirow contacts report_contacts_select {} { lappend party_ids $party_id } @@ -597,7 +597,7 @@ eval $command - set keys [list] + set keys {} template::multirow foreach contacts { set key [list] foreach {element details} $report_elements { Index: openacs-4/packages/contacts/lib/email-search.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/lib/email-search.tcl,v diff -u -N -r1.7 -r1.8 --- openacs-4/packages/contacts/lib/email-search.tcl 17 Apr 2018 14:47:02 -0000 1.7 +++ openacs-4/packages/contacts/lib/email-search.tcl 25 Apr 2018 19:47:46 -0000 1.8 @@ -107,7 +107,7 @@ set tracking_p [apm_package_installed_p "mail-tracking"] if { [exists_and_not_null file_ids] } { - set files [list] + set files {} foreach file $file_ids { set file_item_id [content::revision::item_id -revision_id $file] if {$file_item_id eq ""} { @@ -139,7 +139,7 @@ # because if we put something like this {value $value} the value # of the variable is not interpreted - set element [list] + set element {} lappend element "${var}:text(hidden)" lappend element "value $var_value" @@ -277,9 +277,9 @@ set valid_party_ids [contact::search::results -search_id $search_id -package_id $package_id] } - set party_ids [list] - set invalid_party_ids [list] - set invalid_recipients [list] + set party_ids {} + set invalid_party_ids {} + set invalid_recipients {} foreach party_id $valid_party_ids { if { [party::email -party_id $party_id] eq "" } { # We are going to check if there is an employee relationship @@ -331,7 +331,7 @@ set attribute_id [attribute::id -object_type "person" -attribute_name "salutation"] # List to store know which emails received the message - set recipients_addr [list] + set recipients_addr {} set from [ad_conn user_id] set from_addr [contact::email -party_id $from] Index: openacs-4/packages/contacts/lib/email.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/lib/email.tcl,v diff -u -N -r1.40 -r1.41 --- openacs-4/packages/contacts/lib/email.tcl 17 Apr 2018 14:47:02 -0000 1.40 +++ openacs-4/packages/contacts/lib/email.tcl 25 Apr 2018 19:47:46 -0000 1.41 @@ -122,7 +122,7 @@ set tracking_p [apm_package_installed_p "mail-tracking"] if { [exists_and_not_null file_ids] } { - set files [list] + set files {} foreach file $file_ids { set file_item_id [content::revision::item_id -revision_id $file] if {$file_item_id eq ""} { @@ -157,7 +157,7 @@ # because if we put something like this {value $value} the value # of the variable is not interpreted - set element [list] + set element {} lappend element "${var}:text(hidden)" lappend element "value $var_value" @@ -302,7 +302,7 @@ set username [db_string user "select username from users where user_id = :party_id" -default ""] set date [lc_time_fmt [dt_sysdate] "%q"] - set values [list] + set values {} foreach element [list first_names last_name salutation name date username] { lappend values [list "{$element}" [set $element]] } Index: openacs-4/packages/contacts/lib/envelope.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/lib/envelope.tcl,v diff -u -N -r1.1 -r1.2 --- openacs-4/packages/contacts/lib/envelope.tcl 20 Feb 2006 09:10:12 -0000 1.1 +++ openacs-4/packages/contacts/lib/envelope.tcl 25 Apr 2018 19:47:46 -0000 1.2 @@ -53,7 +53,7 @@ -message_1 [_ contacts.lt_Generating_the_envelopes_] \ -message_2 [_ contacts.lt_Once_finished_you_get] - set envelopes [list] + set envelopes {} foreach party_id $party_ids { set name [contact::name -party_id $party_id] set mailing_address [contact::message::mailing_address -party_id $party_id -format "text/plain"] Index: openacs-4/packages/contacts/lib/label.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/lib/label.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/contacts/lib/label.tcl 5 Oct 2006 14:15:20 -0000 1.3 +++ openacs-4/packages/contacts/lib/label.tcl 25 Apr 2018 19:47:46 -0000 1.4 @@ -51,7 +51,7 @@ -message_1 [_ contacts.lt_Generating_the_labels_] \ -message_2 [_ contacts.lt_Once_finished_you_get] - set labels [list] + set labels {} foreach party_id $party_ids { set mailing_address [contact::message::mailing_address -party_id $party_id -format "text/plain" -with_name] Index: openacs-4/packages/contacts/lib/letter.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/lib/letter.tcl,v diff -u -N -r1.12 -r1.13 --- openacs-4/packages/contacts/lib/letter.tcl 5 Apr 2018 14:44:08 -0000 1.12 +++ openacs-4/packages/contacts/lib/letter.tcl 25 Apr 2018 19:47:46 -0000 1.13 @@ -175,7 +175,7 @@ append letter "\n
$name
[contact::message::mailing_address -party_id $party_id -format "text/html"]
" } append letter "\n
${content_html}
" - set values [list] + set values {} foreach element [list first_names last_name name date salutation mailing_address directphone] { lappend values [list "{$element}" [set $element]] } Index: openacs-4/packages/contacts/lib/spouse-sync.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/lib/spouse-sync.tcl,v diff -u -N -r1.1 -r1.2 --- openacs-4/packages/contacts/lib/spouse-sync.tcl 28 May 2006 01:50:21 -0000 1.1 +++ openacs-4/packages/contacts/lib/spouse-sync.tcl 25 Apr 2018 19:47:46 -0000 1.2 @@ -65,7 +65,7 @@ } - set options [list] + set options {} if { $party_value ne "" } { set attr${attribute_id}_value $party_value_id lappend options [list "$party_name:
$party_value

" $party_value_id] Index: openacs-4/packages/contacts/tcl/contact-employee-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/tcl/contact-employee-procs.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/contacts/tcl/contact-employee-procs.tcl 6 Nov 2006 18:08:21 -0000 1.5 +++ openacs-4/packages/contacts/tcl/contact-employee-procs.tcl 25 Apr 2018 19:47:46 -0000 1.6 @@ -112,7 +112,7 @@ set employee_rev_id [content::item::get_best_revision -item_id $employee_id] # Get employers, if any - set employers [list] + set employers {} set employers [contact::util::get_employers -employee_id $employee_id -package_id $package_id] # If employer(s) exist @@ -336,7 +336,7 @@ get employees of an organization in a list of list suitable for inclusion in options the list is made up of employee_name and employee_id } { - set contact_list [list] + set contact_list {} db_foreach select_employee_ids { select CASE WHEN object_id_one = :organization_id THEN object_id_two @@ -379,7 +379,7 @@ @creation-date 2005-10-17 @return List of lists, each containing the ID and name of an employer, or an empty list if no employers exist. } { - set contact_list [list] + set contact_list {} db_foreach select_employer_ids { select CASE WHEN object_id_one = :employee_id THEN object_id_two Index: openacs-4/packages/contacts/tcl/contact-search-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/tcl/contact-search-procs.tcl,v diff -u -N -r1.40 -r1.41 --- openacs-4/packages/contacts/tcl/contact-search-procs.tcl 5 Apr 2018 14:44:09 -0000 1.40 +++ openacs-4/packages/contacts/tcl/contact-search-procs.tcl 25 Apr 2018 19:47:46 -0000 1.41 @@ -490,7 +490,7 @@ @param and Set this flag if you want the result to start with an 'and' if the list of where clauses returned is non-empty. } { set query [string trim $query] - set search_clauses [list] + set search_clauses {} set where_clause [contact::search::where_clause -search_id $search_id -party_id $party_id -revision_id $revision_id -limit_type_p $limit_type_p] if { [exists_and_not_null where_clause] } { @@ -549,7 +549,7 @@ # query is a condition. We are limited to 3 levels of database access for most # openacs installs so this bypasses that problem set db_conditions [db_list_of_lists select_conditions {}] - set conditions [list] + set conditions {} foreach condition $db_conditions { lappend conditions [contacts::search::condition_type \ -type [lindex $condition 0] \ @@ -596,7 +596,7 @@ set query [string trim $query] regsub -all "'" $query "''" query - set query_clauses [list] + set query_clauses {} set callback_query_clauses [callback contact::search::query_clauses -query $query -party_id $party_id] if { [llength $callback_query_clauses] > 0 } { # the callback returns a list of the lists from the callbacks @@ -746,7 +746,7 @@ } { } { db_0or1row get_search_info {} - set where_clauses [list] + set where_clauses {} if { [exists_and_not_null all_or_any] } { set result {} Index: openacs-4/packages/contacts/tcl/contact-search-widget-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/tcl/contact-search-widget-procs.tcl,v diff -u -N -r1.6 -r1.7 --- openacs-4/packages/contacts/tcl/contact-search-widget-procs.tcl 17 Apr 2018 14:47:02 -0000 1.6 +++ openacs-4/packages/contacts/tcl/contact-search-widget-procs.tcl 25 Apr 2018 19:47:46 -0000 1.7 @@ -154,8 +154,8 @@ error "You cannot use the contact_search widget without specifying a package_id of a contacts instance in which to search (done the same way you would specifiy html attributes)" } } - set person_ids [list] - set organization_ids [list] + set person_ids {} + set organization_ids {} # search in persons if { $persons_p } { @@ -175,7 +175,7 @@ } else { # we need to return a select list - set options [list] + set options {} if { [llength $person_ids] > 0 } { if { [llength $person_ids] > 50 } { set options [list [list [_ contacts.lt_Search_again_over_50_people] ":search:"]] Index: openacs-4/packages/contacts/tcl/contacts-callback-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/tcl/contacts-callback-procs.tcl,v diff -u -N -r1.63 -r1.64 --- openacs-4/packages/contacts/tcl/contacts-callback-procs.tcl 28 Mar 2018 23:36:17 -0000 1.63 +++ openacs-4/packages/contacts/tcl/contacts-callback-procs.tcl 25 Apr 2018 19:47:47 -0000 1.64 @@ -275,7 +275,7 @@ } { set object_type [contact::type -party_id $party_id] - set element_list [list] + set element_list {} if { [lsearch [list person user] $object_type] >= 0 } { lappend element_list first_names last_name email } elseif {$object_type == "organization" } { @@ -731,7 +731,7 @@ } set object_type $type - set results [list] + set results {} if { $object_type eq "party" && [lsearch [list email url] $key] >= 0 } { db_foreach get_party_info " select $key as value, party_id from parties where party_id in ( $select_query ) " { if { $format eq "html" && $value ne "" } { @@ -906,7 +906,7 @@ if { ![array exists roles_list] } { return [list] } else { - set results [list] + set results {} foreach {party_id related_parties} [array get roles_list] { lappend results $party_id [join [lsort -dictionary $related_parties] ", "] } @@ -967,7 +967,7 @@ {-format "html"} } { } { - set results [list] + set results {} if { $type eq "groups" && [string is integer $key] && $key ne ""} { set true [_ contacts.True] set false [_ contacts.False] @@ -996,7 +996,7 @@ {-object_type} } { } { - set groups_list [list] + set groups_list {} foreach group [contact::groups_list -package_id $package_id] { util_unlist $group group_id group_name member_count component_count mapped_p default_p if { [string is true $mapped_p] } { @@ -1021,7 +1021,7 @@ {-format "html"} } { } { - set results [list] + set results {} if { $type eq "privacy" } { set true [_ contacts.True] set false [_ contacts.False] @@ -1153,7 +1153,7 @@ } { # Allow for organizations and persons to set the locale - set list_of_locales [list] + set list_of_locales {} db_foreach locale_loop { select label, locale from enabled_locales Index: openacs-4/packages/contacts/www/files.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/www/files.tcl,v diff -u -N -r1.6 -r1.7 --- openacs-4/packages/contacts/www/files.tcl 15 Feb 2006 10:06:36 -0000 1.6 +++ openacs-4/packages/contacts/www/files.tcl 25 Apr 2018 19:47:47 -0000 1.7 @@ -32,7 +32,7 @@ # is why we try if there is an organization that has the user as an # employee - set organization_list [list] + set organization_list {} db_foreach select_employee_ids "select CASE WHEN object_id_one = :party_id THEN object_id_two ELSE object_id_one END as other_party_id from acs_rels, acs_rel_types @@ -68,7 +68,7 @@ ad_form -name upload_files -html {enctype multipart/form-data} -form $form_elements -on_request { } -on_submit { set upload_number 1 - set message [list] + set message {} while {$upload_number <= $upload_count} { set file [set "upload_file${upload_number}"] set title [set "upload_title${upload_number}"] Index: openacs-4/packages/contacts/www/group-parties-remove.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/www/group-parties-remove.tcl,v diff -u -N -r1.11 -r1.12 --- openacs-4/packages/contacts/www/group-parties-remove.tcl 8 Nov 2006 18:30:53 -0000 1.11 +++ openacs-4/packages/contacts/www/group-parties-remove.tcl 25 Apr 2018 19:47:47 -0000 1.12 @@ -18,7 +18,7 @@ } } if { [exists_and_not_null party_id] } { - set party_ids [list] + set party_ids {} foreach party_id $party_id { lappend party_ids $party_id } @@ -31,7 +31,7 @@ set group_ids $group_id db_transaction { - set message [list] + set message {} foreach group_id $group_ids { set contacts [list] foreach party_id $party_ids { Index: openacs-4/packages/contacts/www/search.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/www/search.tcl,v diff -u -N -r1.33 -r1.34 --- openacs-4/packages/contacts/www/search.tcl 19 May 2006 18:36:56 -0000 1.33 +++ openacs-4/packages/contacts/www/search.tcl 25 Apr 2018 19:47:47 -0000 1.34 @@ -32,7 +32,7 @@ } valid_search_id -requires {search_id} { if { [db_0or1row condition_exists_p {}] } { - set valid_owner_ids [list] + set valid_owner_ids {} lappend valid_owner_ids [ad_conn user_id] if { [permission::permission_p -object_id [ad_conn package_id] -privilege "admin"] } { lappend valid_owner_ids [ad_conn package_id] @@ -72,7 +72,7 @@ set search_exists_p 0 -# set query_pretty [list] +# set query_pretty {} if { [exists_and_not_null search_id] } { if { [contact::search::exists_p -search_id $search_id] } { db_1row get_search_info { } @@ -100,8 +100,8 @@ -package_id [ad_conn package_id] \ -object_type $actual_object_type - set add_columns [list] - set remove_columns [list] + set add_columns {} + set remove_columns {} set extended_columns [contact::search::get_extensions -search_id $search_id] if { [lsearch $extended_columns $remove_column] >= 0 && $remove_column ne "" } { # remove this extension @@ -187,7 +187,7 @@ } if { $search_exists_p } { - set conditions [list] + set conditions {} db_foreach selectqueries {} { set condition_name [contacts::search::condition_type -type $query_type -request pretty -var_list $query_var_list] if { [empty_string_p $condition_name] } { @@ -219,7 +219,7 @@ {all_or_any:text(select),optional {label ""} {options {{[_ contacts.All] all} {[_ contacts.Any] any}}} {after_html "[_ contacts.lt_of_the_following_cond]$query_pretty"}} } } else { - set object_type_options [list] + set object_type_options {} set object_types [list party person organization] if { $display_employers_p } { lappend object_types "employee" Index: openacs-4/packages/content-portlet/misc/portlets/ges-categories.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/content-portlet/misc/portlets/ges-categories.tcl,v diff -u -N -r1.1 -r1.2 --- openacs-4/packages/content-portlet/misc/portlets/ges-categories.tcl 24 Oct 2007 22:50:25 -0000 1.1 +++ openacs-4/packages/content-portlet/misc/portlets/ges-categories.tcl 25 Apr 2018 19:47:47 -0000 1.2 @@ -34,7 +34,7 @@ if {!$no_tree_name} { append content "

$my_tree_name

" } - set categories [list] + set categories {} set pos 0 set cattree(0) [::xowiki::CatTree new -volatile -orderby pos -name $my_tree_name] foreach category_info [category_tree::get_tree $tree_id] { Index: openacs-4/packages/cronjob/tcl/cronjob-init.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/cronjob/tcl/cronjob-init.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/cronjob/tcl/cronjob-init.tcl 29 May 2009 09:11:28 -0000 1.4 +++ openacs-4/packages/cronjob/tcl/cronjob-init.tcl 25 Apr 2018 19:47:47 -0000 1.5 @@ -22,8 +22,8 @@ } { ns_log Debug "Running qd_write_query_select with $package $attrs" - set query [list] - set in_args [list] + set query {} + set in_args {} set args [concat $attrs] foreach {attr sign value} $args { lappend in_args $attr @@ -135,7 +135,7 @@ proc qd_write_query {package args} { - set query [list] + set query {} set attrs_and_defaults [eval qd_choose_function $package $args] foreach {attr default_value} $attrs_and_defaults { if {[lsearch $args $attr] < 0 } { @@ -153,7 +153,7 @@ proc qd_write_query_upvar {package listvar} { - set query [list] + set query {} upvar $listvar args set attrs_and_defaults [eval qd_choose_function $package $args] if {[string match "!NO MATCH:*" $attrs_and_defaults ]} { Index: openacs-4/packages/curriculum/tcl/curriculum-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/curriculum/tcl/curriculum-procs.tcl,v diff -u -N -r1.16 -r1.17 --- openacs-4/packages/curriculum/tcl/curriculum-procs.tcl 5 Jul 2004 14:07:21 -0000 1.16 +++ openacs-4/packages/curriculum/tcl/curriculum-procs.tcl 25 Apr 2018 19:47:47 -0000 1.17 @@ -100,7 +100,7 @@ } { upvar $array row - array set assignments [list] + array set assignments {} set role_prefix "role_" @@ -607,7 +607,7 @@ } # Build up the details list - set details_list [list] + set details_list {} foreach field $fields { lappend details_list $label($field) $value($field) } Index: openacs-4/packages/curriculum-central/tcl/admin-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/curriculum-central/tcl/admin-procs.tcl,v diff -u -N -r1.1 -r1.2 --- openacs-4/packages/curriculum-central/tcl/admin-procs.tcl 23 Feb 2006 08:29:55 -0000 1.1 +++ openacs-4/packages/curriculum-central/tcl/admin-procs.tcl 25 Apr 2018 19:47:47 -0000 1.2 @@ -72,7 +72,7 @@ set limit [parameter::get -parameter "DefaultNumDegreeStreamYears" \ -default 5] - set names [list] + set names {} set x 1 while { $x <= $limit } { @@ -150,7 +150,7 @@ @param package_id Package ID of Curriculum Central that we want to insert default values for. } { - set attribute_names [list] + set attribute_names {} lappend attribute_names \ "#curriculum-central.research_and_inquiry#" @@ -188,7 +188,7 @@ set limit [parameter::get -parameter "DefaultNumScheduleWeeks" \ -default 13] - set names [list] + set names {} set x 1 while { $x <= $limit } { Index: openacs-4/packages/curriculum-central/tcl/staff-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/curriculum-central/tcl/staff-procs.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/curriculum-central/tcl/staff-procs.tcl 16 Jun 2006 06:33:58 -0000 1.5 +++ openacs-4/packages/curriculum-central/tcl/staff-procs.tcl 25 Apr 2018 19:47:47 -0000 1.6 @@ -35,7 +35,7 @@ @param name_ids List of name IDs. @return Returns a concatenated string of pretty names. } { - set names [list] + set names {} foreach name_id $name_ids { set pretty_name [curriculum_central::staff::pretty_name $name_id] Index: openacs-4/packages/curriculum-central/tcl/uos-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/curriculum-central/tcl/uos-procs.tcl,v diff -u -N -r1.36 -r1.37 --- openacs-4/packages/curriculum-central/tcl/uos-procs.tcl 16 Jun 2006 11:56:40 -0000 1.36 +++ openacs-4/packages/curriculum-central/tcl/uos-procs.tcl 25 Apr 2018 19:47:47 -0000 1.37 @@ -571,7 +571,7 @@ upvar $array row - array set assignments [list] + array set assignments {} if { $user_id eq "" } { set user_id [ad_conn user_id] @@ -1361,7 +1361,7 @@ set user_id [ad_conn user_id] } - set ga_list [list] + set ga_list {} db_foreach select_ga {} { set ga_name "[lang::util::localize $name] ($identifier)" @@ -1552,7 +1552,7 @@ set one_line [curriculum_central::uos::get_pretty_name -uos_id $object_id] - set details_list [list] + set details_list {} if { [db_0or1row uos_details {}] } { lappend details_list [_ curriculum-central.credit_value] $credit_value @@ -1783,7 +1783,7 @@ set package_id [ad_conn package_id] } - array set row [list] + array set row {} if { ![db_0or1row latest_grade_set {} -column_array row] } { set row(grade_set_id) "" @@ -1899,7 +1899,7 @@ template::form::section $form_name $section_name } - array set row [list] + array set row {} if { ![db_0or1row latest_schedule_set {} -column_array row] } { set row(schedule_set_id) "" Index: openacs-4/packages/curriculum-central/www/coordinate/uos-edit.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/curriculum-central/www/coordinate/uos-edit.tcl,v diff -u -N -r1.22 -r1.23 --- openacs-4/packages/curriculum-central/www/coordinate/uos-edit.tcl 3 Jun 2006 09:49:27 -0000 1.22 +++ openacs-4/packages/curriculum-central/www/coordinate/uos-edit.tcl 25 Apr 2018 19:47:47 -0000 1.23 @@ -531,7 +531,7 @@ # on_submit block ad_form -extend -name uos -on_submit { - array set row [list] + array set row {} if { $enabled_action_id ne "" } { foreach field [workflow::action::get_element \ Index: openacs-4/packages/datamanager/CALLBACKS_CHANGES/news-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/datamanager/CALLBACKS_CHANGES/news-procs.tcl,v diff -u -N -r1.1 -r1.2 --- openacs-4/packages/datamanager/CALLBACKS_CHANGES/news-procs.tcl 22 Jun 2006 14:21:34 -0000 1.1 +++ openacs-4/packages/datamanager/CALLBACKS_CHANGES/news-procs.tcl 25 Apr 2018 19:47:47 -0000 1.2 @@ -197,7 +197,7 @@ # TODO make limit a parameter set limit 15 - set items [list] + set items {} set counter 0 set package_url [news_util_get_url $summary_context_id] db_foreach get_news_items {} { Index: openacs-4/packages/datamanager/CALLBACKS_CHANGES/static-portlet-callback-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/datamanager/CALLBACKS_CHANGES/static-portlet-callback-procs.tcl,v diff -u -N -r1.1 -r1.2 --- openacs-4/packages/datamanager/CALLBACKS_CHANGES/static-portlet-callback-procs.tcl 22 Jun 2006 14:21:34 -0000 1.1 +++ openacs-4/packages/datamanager/CALLBACKS_CHANGES/static-portlet-callback-procs.tcl 25 Apr 2018 19:47:47 -0000 1.2 @@ -67,7 +67,7 @@ } { Export a static portlet } { - set lista [list] + set lista {} db_1row select_static {} lappend lista "" Index: openacs-4/packages/dbm/tcl/dbm-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dbm/tcl/dbm-procs.tcl,v diff -u -N -r1.1 -r1.2 --- openacs-4/packages/dbm/tcl/dbm-procs.tcl 7 Jun 2006 10:43:18 -0000 1.1 +++ openacs-4/packages/dbm/tcl/dbm-procs.tcl 25 Apr 2018 19:47:47 -0000 1.2 @@ -11,7 +11,7 @@ } { Simple procedure to create options for dropdown menu } { - set opts [list] + set opts {} if {!$no_empty_option_p} { set opts [linsert $opts 0 ""] } @@ -37,7 +37,7 @@ } { A simple proc to highlight sql } { - set result [list] + set result {} regsub -all {([^ \n\t]+)} $sql {\0} sql set sql [split $sql " "] @@ -169,7 +169,7 @@ @author Nima Mazloumi @creation-date 2005-08-24 } { - set fields [list] + set fields {} set count [llength $elements] Index: openacs-4/packages/dbm/www/addforeignkey2.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dbm/www/addforeignkey2.tcl,v diff -u -N -r1.1 -r1.2 --- openacs-4/packages/dbm/www/addforeignkey2.tcl 7 Jun 2006 10:43:18 -0000 1.1 +++ openacs-4/packages/dbm/www/addforeignkey2.tcl 25 Apr 2018 19:47:47 -0000 1.2 @@ -53,8 +53,8 @@ } -on_submit { - set output [list] - set output2 [list] + set output {} + set output2 {} foreach el $column { lappend output [concat \"$el\"] Index: openacs-4/packages/dbm/www/addprimarykey.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dbm/www/addprimarykey.tcl,v diff -u -N -r1.1 -r1.2 --- openacs-4/packages/dbm/www/addprimarykey.tcl 7 Jun 2006 10:43:18 -0000 1.1 +++ openacs-4/packages/dbm/www/addprimarykey.tcl 25 Apr 2018 19:47:47 -0000 1.2 @@ -19,7 +19,7 @@ } } -on_submit { - set output [list] + set output {} foreach el $column { lappend output [concat \"$el\"] Index: openacs-4/packages/dbm/www/adduniquekey.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dbm/www/adduniquekey.tcl,v diff -u -N -r1.1 -r1.2 --- openacs-4/packages/dbm/www/adduniquekey.tcl 7 Jun 2006 10:43:18 -0000 1.1 +++ openacs-4/packages/dbm/www/adduniquekey.tcl 25 Apr 2018 19:47:47 -0000 1.2 @@ -19,7 +19,7 @@ } } -on_submit { - set output [list] + set output {} foreach el $column { lappend output [concat \"$el\"] Index: openacs-4/packages/dbm/www/createindex.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dbm/www/createindex.tcl,v diff -u -N -r1.1 -r1.2 --- openacs-4/packages/dbm/www/createindex.tcl 7 Jun 2006 10:43:18 -0000 1.1 +++ openacs-4/packages/dbm/www/createindex.tcl 25 Apr 2018 19:47:47 -0000 1.2 @@ -36,7 +36,7 @@ set unique "UNIQUE" } - set output [list] + set output {} foreach el $column { lappend output [concat \"$el\"] Index: openacs-4/packages/diagram/tcl/diagram-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/diagram/tcl/diagram-procs.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/diagram/tcl/diagram-procs.tcl 23 Mar 2018 23:53:01 -0000 1.2 +++ openacs-4/packages/diagram/tcl/diagram-procs.tcl 25 Apr 2018 19:47:47 -0000 1.3 @@ -329,8 +329,8 @@ set y_max "" set scales $diagram_properties(scales) - set minima [list] - set sum [list] + set minima {} + set sum {} #lets iterate over all columns and get the borders for {set j 1} {$j <= [llength $diagram_properties(display_elements)]} {incr j} { @@ -446,7 +446,7 @@ set __output {} # Output header row - set __cols [list] + set __cols {} foreach __element_name $diagram_properties(display_elements) { lappend __cols [csv_quote $__element_name] } @@ -455,7 +455,7 @@ # Output rows template::multirow foreach $diagram_properties(multirow) { - set __cols [list] + set __cols {} foreach __element_name $diagram_properties(display_elements) { template::diagram::element::get_reference \ Index: openacs-4/packages/dotlrn/tcl/apm-callback-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn/tcl/apm-callback-procs.tcl,v diff -u -N -r1.15 -r1.16 --- openacs-4/packages/dotlrn/tcl/apm-callback-procs.tcl 27 Mar 2018 14:32:16 -0000 1.15 +++ openacs-4/packages/dotlrn/tcl/apm-callback-procs.tcl 25 Apr 2018 19:47:47 -0000 1.16 @@ -266,7 +266,7 @@ } 2.3.0d1 2.3.0d2 { # Set access keys for all pages that have known titles - set params [list] + set params {} db_foreach get_default_values {} { set params [concat $params [split [string trimright $default_value ";"] ";"]] } Index: openacs-4/packages/dotlrn/tcl/applets-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn/tcl/applets-procs.tcl,v diff -u -N -r1.27 -r1.28 --- openacs-4/packages/dotlrn/tcl/applets-procs.tcl 25 Jan 2018 12:36:53 -0000 1.27 +++ openacs-4/packages/dotlrn/tcl/applets-procs.tcl 25 Apr 2018 19:47:47 -0000 1.28 @@ -134,7 +134,7 @@ ad_proc -public list_mounted_applets {} { list all applets that are mounted } { - set applets [list] + set applets {} foreach applet [list_applets] { if {[is_applet_mounted -applet_key $applet]} { Index: openacs-4/packages/dotlrn/tcl/community-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn/tcl/community-procs.tcl,v diff -u -N -r1.223 -r1.224 --- openacs-4/packages/dotlrn/tcl/community-procs.tcl 11 Apr 2018 10:12:52 -0000 1.223 +++ openacs-4/packages/dotlrn/tcl/community-procs.tcl 25 Apr 2018 19:47:47 -0000 1.224 @@ -435,9 +435,9 @@ set default_roles [concat {*}[get_default_roles -community_id $community_id]] set attributes [concat {*}[get_attributes -community_id $community_id]] - set roles [list] + set roles {} foreach {rel_type role pretty_name pretty_plural} $default_roles { - set new_role [list] + set new_role {} lappend new_role $rel_type lappend new_role $role @@ -515,7 +515,7 @@ ad_proc -public get_all_roles_as_options {} { return the list of roles used in dotLRN } { - set role_options [list] + set role_options {} foreach {rel_type role pretty_name pretty_plural} [concat {*}[get_all_roles]] { lappend role_options [list [lang::util::localize $pretty_name] $rel_type] @@ -944,7 +944,7 @@ } { Return a datasource of the communities that a user belongs to in a particular type } { - set list_of_communities [list] + set list_of_communities {} db_foreach select_communities {} { lappend list_of_communities [list $community_id $community_type $pretty_name $description [get_url -package_id $package_id]] @@ -1454,7 +1454,7 @@ @author Peter Marklund } { - set context [list] + set context {} if {[subcommunity_p -community_id $community_id]} { set parent_name [get_parent_name -community_id $community_id] Index: openacs-4/packages/dotlrn/tcl/spam-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn/tcl/spam-procs.tcl,v diff -u -N -r1.11 -r1.12 --- openacs-4/packages/dotlrn/tcl/spam-procs.tcl 7 Aug 2017 23:48:09 -0000 1.11 +++ openacs-4/packages/dotlrn/tcl/spam-procs.tcl 25 Apr 2018 19:47:47 -0000 1.12 @@ -74,7 +74,7 @@ set errors "" db_foreach select_recipient_info {} { # replace some values in the subject and the message - set values [list] + set values {} lappend values [list \{email\} $email] lappend values [list \{first_names\} $first_names] lappend values [list \{last_name\} $last_name] Index: openacs-4/packages/dotlrn/www/admin/users-search.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn/www/admin/users-search.tcl,v diff -u -N -r1.33 -r1.34 --- openacs-4/packages/dotlrn/www/admin/users-search.tcl 21 Jan 2018 00:38:38 -0000 1.33 +++ openacs-4/packages/dotlrn/www/admin/users-search.tcl 25 Apr 2018 19:47:47 -0000 1.34 @@ -174,7 +174,7 @@ "dotlrn_users.email" \ "dotlrn_users.type" \ ] - set wheres [list] + set wheres {} if {$name ne ""} { lappend wheres "(lower(dotlrn_users.last_name) like lower('%' || :name || '%') or lower(dotlrn_users.first_names) like lower('%' || :name || '%') or lower(dotlrn_users.email) like lower('%' || :name || '%'))" @@ -235,7 +235,7 @@ } set in_clause "(dotlrn_users.user_id = acs_rels.object_id_two and acs_rels.rel_type in (" - set in_elements [list] + set in_elements {} for {set i 0} {$i < $role_list_length} {incr i} { set in_element__${i} [lindex $role_list $i] lappend in_elements ":in_element__${i}" @@ -260,8 +260,8 @@ } set referer [ns_conn url] - set selected_users_options [list] - set selected_users_values [list] + set selected_users_options {} + set selected_users_values {} db_foreach select_users $sql { set href [export_vars -base user user_id] lappend selected_users_options [list [subst {$last_name, $first_names ($email)}] $user_id] Index: openacs-4/packages/dotlrn-admin/www/admin/users-search.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn-admin/www/admin/users-search.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/dotlrn-admin/www/admin/users-search.tcl 21 Jan 2018 00:38:38 -0000 1.3 +++ openacs-4/packages/dotlrn-admin/www/admin/users-search.tcl 25 Apr 2018 19:47:47 -0000 1.4 @@ -171,7 +171,7 @@ "dotlrn_users.email" \ "dotlrn_users.type" \ ] - set wheres [list] + set wheres {} if {$name ne ""} { lappend wheres "(lower(dotlrn_users.last_name) like lower('%' || :name || '%') or lower(dotlrn_users.first_names) like lower('%' || :name || '%') or lower(dotlrn_users.email) like lower('%' || :name || '%'))" @@ -232,7 +232,7 @@ } set in_clause "(dotlrn_users.user_id = acs_rels.object_id_two and acs_rels.rel_type in (" - set in_elements [list] + set in_elements {} for {set i 0} {$i < $role_list_length} {incr i} { set in_element__${i} [lindex $role_list $i] lappend in_elements ":in_element__${i}" @@ -257,8 +257,8 @@ } set referer [ns_conn url] - set selected_users_options [list] - set selected_users_values [list] + set selected_users_options {} + set selected_users_values {} db_foreach select_users $sql { set href [export_vars -base user user_id] lappend selected_users_options [list [subst {$last_name, $first_names ($email)}] $user_id] Index: openacs-4/packages/dotlrn-ecommerce/lib/section.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn-ecommerce/lib/section.tcl,v diff -u -N -r1.43 -r1.44 --- openacs-4/packages/dotlrn-ecommerce/lib/section.tcl 27 Mar 2018 14:22:30 -0000 1.43 +++ openacs-4/packages/dotlrn-ecommerce/lib/section.tcl 25 Apr 2018 19:47:47 -0000 1.44 @@ -323,7 +323,7 @@ if { [info exists template_calendar_id] } { set sessions_list [db_list_of_lists sessions { }] } else { - set sessions_list [list] + set sessions_list {} } if { [llength $sessions_list] } { @@ -333,7 +333,7 @@ } if { ! [info exists sessions] || ![llength $sessions] } { - set sessions [list] + set sessions {} # allow setting start/end date if there aren't sessions predefined # DAVEB 20070112 Adding active_state_date and active_end_date Index: openacs-4/packages/dotlrn-ecommerce/tcl/section-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn-ecommerce/tcl/section-procs.tcl,v diff -u -N -r1.43 -r1.44 --- openacs-4/packages/dotlrn-ecommerce/tcl/section-procs.tcl 2 Sep 2008 21:47:19 -0000 1.43 +++ openacs-4/packages/dotlrn-ecommerce/tcl/section-procs.tcl 25 Apr 2018 19:47:47 -0000 1.44 @@ -87,14 +87,14 @@ if { ! [db_0or1row session_type { }] } { set item_type_id [calendar::item_type_new -calendar_id $calendar_id -type "Session"] } - set text_sessions [list] - array set arr_sessions [list] + set text_sessions {} + array set arr_sessions {} db_foreach sessions { } { lappend arr_sessions(${month}_${timestart}_${timeend}_${startampm}_${endampm}) $day lappend arr_sessions_sort(${month}_${timestart}_${timeend}_${startampm}_${endampm}) [clock scan $datenum] } - set days [list] + set days {} foreach times [array names arr_sessions] { set times [split $times _] set month [lindex $times 0] @@ -135,7 +135,7 @@ # Sort dates set _text_sessions [lsort -index end $text_sessions] - set text_sessions [list] + set text_sessions {} foreach _text_session $_text_sessions { lappend text_sessions [join [lrange $_text_session 0 2]] } @@ -194,7 +194,7 @@ } set instructor_community_id [parameter::get -package_id [ad_conn package_id] -parameter InstructorCommunityId -default 0 ] set _instructors [dotlrn_community::list_users $instructor_community_id] - set __instructors [list] + set __instructors {} if { [llength $_instructors] == 0 } { set _instructors 0 } else { @@ -650,7 +650,7 @@ set section_folder_id [dotlrn_ecommerce::section::get_public_folder_id $section_id] set section_pages_url "pages/${section_id}/" set __adp_stub "" - set __adp_include_optional_output [list] + set __adp_include_optional_output {} return [template::adp_include "/packages/dotlrn-ecommerce/lib/fs-chunk" [list section_folder_id $section_folder_id section_pages_url $section_pages_url]] Index: openacs-4/packages/dynamic-types/tcl/dynamic-type-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dynamic-types/tcl/dynamic-type-procs.tcl,v diff -u -N -r1.10 -r1.11 --- openacs-4/packages/dynamic-types/tcl/dynamic-type-procs.tcl 28 Mar 2018 17:00:40 -0000 1.10 +++ openacs-4/packages/dynamic-types/tcl/dynamic-type-procs.tcl 25 Apr 2018 19:47:47 -0000 1.11 @@ -32,7 +32,7 @@ set attributes_list [dtype::get_attributes_list -name $object_type -start_with acs_object -storage_types type_specific -exclude_static_p $exclude_static_p] upvar $array local - set columns [list] + set columns {} foreach attribute_info $attributes_list { foreach {name pretty_name attribute_id datatype table_name column_name default_value min_n_values max_n_values static_p} $attribute_info break Index: openacs-4/packages/dynamic-types/tcl/event-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dynamic-types/tcl/event-procs.tcl,v diff -u -N -r1.6 -r1.7 --- openacs-4/packages/dynamic-types/tcl/event-procs.tcl 29 Mar 2018 15:03:01 -0000 1.6 +++ openacs-4/packages/dynamic-types/tcl/event-procs.tcl 25 Apr 2018 19:47:47 -0000 1.7 @@ -66,7 +66,7 @@ if {[nsv_exists util_events $event]} { set handlers [nsv_get util_events $event] - set result [list] + set result {} foreach handler $handlers { set cand_match [lindex $handler 0] set cand_script [lindex $handler 1] @@ -122,7 +122,7 @@ lappend type_bins "[join [lrange $type_elms 0 $i] "."]." } - set results [list] + set results {} foreach type_bin $type_bins { if {[nsv_exists util_events $type_bin]} { Index: openacs-4/packages/dynamic-types/tcl/form-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dynamic-types/tcl/form-procs.tcl,v diff -u -N -r1.17 -r1.18 --- openacs-4/packages/dynamic-types/tcl/form-procs.tcl 29 Aug 2007 14:58:47 -0000 1.17 +++ openacs-4/packages/dynamic-types/tcl/form-procs.tcl 25 Apr 2018 19:47:47 -0000 1.18 @@ -291,8 +291,8 @@ ####################################################### # Build up insert statement from metadata # - set columns [list] - set values [list] + set columns {} + set values {} # set default fields with provided values foreach var_spec $default_fields { @@ -480,7 +480,7 @@ insert into ${type_info(table_name)}i ([join $columns ", "]) values ([join $values ", "])" } else { - set updates [list] + set updates {} set all_columns [concat $columns $missing_columns] set all_values [concat $values $missing_columns] @@ -551,8 +551,8 @@ # Generate form elements for each attribute / widget for {set w 1} {$w <= $widget_count} {incr w} { template::multirow get widgets $w - set html_options [list] - set widget_options [list] + set html_options {} + set widget_options {} # exclude specified widgets if {[lsearch -exact $exclude $widgets(attribute_name)] > -1} { @@ -823,7 +823,7 @@ # if the option list is empty, return # somethign the select widget can use if {$value eq ""} { - set value [list [list]] + set value [list {}] } } } Index: openacs-4/packages/dynamic-types/tcl/table-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dynamic-types/tcl/table-procs.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/dynamic-types/tcl/table-procs.tcl 26 May 2005 10:27:58 -0000 1.3 +++ openacs-4/packages/dynamic-types/tcl/table-procs.tcl 25 Apr 2018 19:47:47 -0000 1.4 @@ -45,7 +45,7 @@ @error } { set cols_lists [db_list_of_lists get_cols ""] - set cols [list] + set cols {} foreach l $cols_lists { lappend cols [lindex $l 0] [lindex $l 1] } Index: openacs-4/packages/ecommerce/tcl/ecommerce-widgets-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ecommerce/tcl/ecommerce-widgets-procs.tcl,v diff -u -N -r1.24 -r1.25 --- openacs-4/packages/ecommerce/tcl/ecommerce-widgets-procs.tcl 5 Apr 2018 14:44:09 -0000 1.24 +++ openacs-4/packages/ecommerce/tcl/ecommerce-widgets-procs.tcl 25 Apr 2018 19:47:47 -0000 1.25 @@ -146,7 +146,7 @@ set to_return " $label" Index: openacs-4/packages/survey-reports/www/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/survey-reports/www/index.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/survey-reports/www/index.tcl 14 Nov 2005 04:31:01 -0000 1.2 +++ openacs-4/packages/survey-reports/www/index.tcl 25 Apr 2018 19:47:48 -0000 1.3 @@ -196,7 +196,7 @@ set properties(survey_id) $survey_id if {[string equal "t" $rtf]} { set master "/home/prodcomp/openacs/packages/survey/lib/print-report-master" - set vars [list] + set vars {} foreach var $var_names { lappend vars $var [set $var] } Index: openacs-4/packages/tasks/tcl/tasks-callback-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/tasks/tcl/tasks-callback-procs.tcl,v diff -u -N -r1.10 -r1.11 --- openacs-4/packages/tasks/tcl/tasks-callback-procs.tcl 21 Aug 2007 03:33:50 -0000 1.10 +++ openacs-4/packages/tasks/tcl/tasks-callback-procs.tcl 25 Apr 2018 19:47:48 -0000 1.11 @@ -23,7 +23,7 @@ } { Add task history to this party. Return as list } { - set tasks [list] + set tasks {} db_foreach get_tasks { select t.task_id, t.completed_date as completion_date, Index: openacs-4/packages/tsoap/tcl/utils-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/tsoap/tcl/utils-procs.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/tsoap/tcl/utils-procs.tcl 23 Mar 2018 23:53:02 -0000 1.2 +++ openacs-4/packages/tsoap/tcl/utils-procs.tcl 25 Apr 2018 19:47:48 -0000 1.3 @@ -48,7 +48,7 @@ proc ::SOAP::Utils::selectNode {doc path} { set path [split [string trimleft $path {/}] {/}] set node [$doc documentElement] - set log [list] + set log {} if {[lindex [SOAP::xpath::xmlnsSplit [$node nodeName]] 1] != [lindex $path 0]} { return "" Index: openacs-4/packages/webmail/tcl/wm-util-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/webmail/tcl/wm-util-procs.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/webmail/tcl/wm-util-procs.tcl 1 Mar 2005 00:01:45 -0000 1.3 +++ openacs-4/packages/webmail/tcl/wm-util-procs.tcl 25 Apr 2018 19:47:48 -0000 1.4 @@ -101,7 +101,7 @@ "Name" , the corresponding output will be similar (including both names and email), but only the actual email address will be checked. } { - set return_emails [list] + set return_emails {} foreach email $email_list { set email [string trim $email] if { ![regexp {<([^>]+)>} $email match email_value] } { @@ -170,11 +170,11 @@ @param content_types The name of the variable you want the list of content-type headers stored in. @return A list of header value pairs. } { - set return_fields [list] + set return_fields {} upvar $references_var rvar - set rvar [list] + set rvar {} upvar $content_types c_types - set c_types [list] + set c_types {} if { $header_display_style == "short" } { set header_restriction_clause " and lower(name) in ('cc', 'in-response-to', 'references', 'reply-to', 'to', 'from', 'subject', 'date', 'content-type')" } else { @@ -188,7 +188,7 @@ ORDER BY sort_order desc"] # Re-order four main headers to always be first - set new_header_fields [list] + set new_header_fields {} foreach name { from to subject date } { set pos [lsearch -regexp $header_fields "^${name} (.*)"] lappend new_header_fields [lindex $header_fields $pos] @@ -301,7 +301,7 @@ } set last $msg_id } - set nav_links [list] + set nav_links {} return [list [list "Previous Unread" $prev_unread] \ [list "Previous" $prev] [list "Next" $next] \ [list "Next Unread" $next_unread] ] Index: openacs-4/packages/webmail-system/tcl/webmail-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/webmail-system/tcl/webmail-procs.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/webmail-system/tcl/webmail-procs.tcl 28 Mar 2018 21:55:34 -0000 1.5 +++ openacs-4/packages/webmail-system/tcl/webmail-procs.tcl 25 Apr 2018 19:47:48 -0000 1.6 @@ -675,7 +675,7 @@ @param attr The list of attributes to disable Disables all passed HTML Attributes. } { - set attributes [list] + set attributes {} for { set i [string first < $html] } { $i != -1 } { set i [string first < $html $i] } { incr i regexp -indices -start $i {\A/?([-_a-zA-Z0-9]+)\s*} $html match name_idx Index: openacs-4/packages/webmail-system/www/compose.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/webmail-system/www/compose.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/webmail-system/www/compose.tcl 30 Sep 2017 18:12:53 -0000 1.2 +++ openacs-4/packages/webmail-system/www/compose.tcl 25 Apr 2018 19:47:48 -0000 1.3 @@ -170,7 +170,7 @@ set has_attach_p 0 } - set emailList [list] + set emailList {} package require smtp package require mime Index: openacs-4/packages/workflow/tcl/action-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/workflow/tcl/action-procs.tcl,v diff -u -N -r1.38 -r1.39 --- openacs-4/packages/workflow/tcl/action-procs.tcl 26 May 2017 17:41:51 -0000 1.38 +++ openacs-4/packages/workflow/tcl/action-procs.tcl 25 Apr 2018 19:47:48 -0000 1.39 @@ -105,7 +105,7 @@ } { # Wrapper for workflow::action::edit - array set row [list] + array set row {} foreach col { initial_action_p sort_order short_name pretty_name pretty_past_tense edit_fields allowed_roles assigned_role @@ -269,9 +269,9 @@ unset missing_elm(initial_action_p) } - set update_clauses [list] - set insert_names [list] - set insert_values [list] + set update_clauses {} + set insert_names {} + set insert_values {} # Handle columns in the workflow_actions table foreach attr { short_name @@ -673,7 +673,7 @@ # Loop over the callbacks and return the impl_names of those with a matching # contract name - set impl_names [list] + set impl_names {} foreach callback_id $callback_ids { array set one_callback $callbacks($callback_id) @@ -707,7 +707,7 @@ @param ignore_action_id If specified, the short_name for the given action will not be included in the result set. } { - set result [list] + set result {} foreach action_id [workflow::get_actions -all -workflow_id $workflow_id] { if { $ignore_action_id eq "" || $ignore_action_id ne $action_id } { @@ -775,7 +775,7 @@ return $action_data(action_ids) } - set action_ids [list] + set action_ids {} foreach action_id $action_data(action_ids) { if { [workflow::action::get_element \ -action_id $action_id \ @@ -794,7 +794,7 @@ } { Get an options list of actions for use with form builder. } { - set result [list] + set result {} foreach action_id [workflow::get_actions \ -all=$all_p \ -workflow_id $workflow_id \ @@ -874,7 +874,7 @@ } { # Wrapper for workflow::action::edit - array set row [list] + array set row {} foreach col { initial_action_p sort_order short_name pretty_name pretty_past_tense edit_fields allowed_roles assigned_role @@ -1000,9 +1000,9 @@ unset row(new_state) } - set update_clauses [list] - set insert_names [list] - set insert_values [list] + set update_clauses {} + set insert_names {} + set insert_values {} # Handle columns in the workflow_fsm_actions table foreach attr { @@ -1040,7 +1040,7 @@ if { [info exists row(enabled_state_ids)] } { error "You cannot supply both enabled_states and enabled_state_ids" } - set row(enabled_state_ids) [list] + set row(enabled_state_ids) {} foreach state_short_name $row(enabled_states) { lappend row(enabled_state_ids) [workflow::state::fsm::get_id \ -workflow_id $workflow_id \ @@ -1052,7 +1052,7 @@ if { [info exists row(assigned_state_ids)] } { error "You cannot supply both assigned_states and assigned_state_ids" } - set row(assigned_state_ids) [list] + set row(assigned_state_ids) {} foreach state_short_name $row(assigned_states) { lappend row(assigned_state_ids) [workflow::state::fsm::get_id \ -workflow_id $workflow_id \ @@ -1062,7 +1062,7 @@ } # Handle auxiliary rows - array set aux [list] + array set aux {} foreach attr { enabled_state_ids assigned_state_ids } { @@ -1384,7 +1384,7 @@ # LARS: Ugly as hell with the string range to cut from 'actions' to 'action_ids' if { [info exists row(child_[string range $type 0 end-1]_ids)] } { - set row(child_${type}) [list] + set row(child_${type}) {} foreach child_id $row(child_[string range $type 0 end-1]_ids) { set child_short_name [${namespace}::get_element \ -one_id $child_id \ @@ -1406,7 +1406,7 @@ always_enabled_p f } - set spec [list] + set spec {} foreach name [lsort [array names row]] { if { $row($name) ne "" && ![exists_and_equal defaults($name) $row($name)] } { lappend spec $name $row($name) @@ -1520,7 +1520,7 @@ array set action_data {} # This will be a list of all action_id's - set action_ids [list] + set action_ids {} # Get basic action info db_foreach action_info {} -column_array action_row { @@ -1555,8 +1555,8 @@ foreach action_id $action_ids { if { ![info exists action_array_${action_id}(child_action_ids)] } { - set action_array_${action_id}(child_action_ids) [list] - set action_array_${action_id}(child_actios) [list] + set action_array_${action_id}(child_action_ids) {} + set action_array_${action_id}(child_actios) {} } } Index: openacs-4/packages/workflow/tcl/case-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/workflow/tcl/case-procs.tcl,v diff -u -N -r1.51 -r1.52 --- openacs-4/packages/workflow/tcl/case-procs.tcl 8 Apr 2018 05:35:24 -0000 1.51 +++ openacs-4/packages/workflow/tcl/case-procs.tcl 25 Apr 2018 19:47:48 -0000 1.52 @@ -383,7 +383,7 @@ set user_id [ad_conn user_id] } - set action_list [list] + set action_list {} foreach enabled_action_id [workflow::case::get_enabled_action_ids -case_id $case_id] { if { [workflow::case::action::permission_p -enabled_action_id $enabled_action_id -user_id $user_id] } { @@ -412,7 +412,7 @@ set user_id [ad_conn user_id] } - set action_list [list] + set action_list {} foreach enabled_action_id [get_enabled_action_ids -case_id $case_id] { if { [workflow::case::action::permission_p -enabled_action_id $enabled_action_id -user_id $user_id] } { @@ -623,12 +623,12 @@ set counter 1 set last_entry_id {} - set data_arraylist [list] + set data_arraylist {} # Then iterate over the multirow to build up the activity log HTML # We need to peek ahead, because this is an outer join to get the rows in workflow_case_log_data - set entries [list] + set entries {} template::multirow -local foreach entries { if { $key ne "" } { @@ -637,7 +637,7 @@ if { $counter == $rowcount || $last_entry_id ne [set "entries:[expr {$counter + 1}](entry_id)"] } { - set log_title_elements [list] + set log_title_elements {} foreach impl_name $impl_names { set result [acs_sc::invoke \ -contract $contract_name \ @@ -650,7 +650,7 @@ } set log_title [ad_decode [llength $log_title_elements] 0 "" "([join $log_title_elements ", "])"] - set row [list] + set row {} foreach var { comment comment_mime_type creation_date_pretty action_pretty_past_tense log_title user_first_names user_last_name user_email creation_user data_arraylist @@ -659,7 +659,7 @@ } lappend entries $row - set data_arraylist [list] + set data_arraylist {} } set last_entry_id $entry_id incr counter @@ -1001,7 +1001,7 @@ } { set contract_name [workflow::service_contract::role_assignee_pick_list] - set party_id_list [list] + set party_id_list {} db_transaction { @@ -1841,7 +1841,7 @@ } # Output notification info - set object_details_lines [list] + set object_details_lines {} foreach { label value } $object_details_list { if { $label ne "" } { lappend object_details_lines "$label[string repeat " " [expr {$max_label_len - [string length $label]}]] : $value" @@ -1860,7 +1860,7 @@ #XXXXX Verify this ... probably wrong set assigned_role_id [workflow::action::get_assigned_role -action_id $action_id] - set assignee_list [list] + set assignee_list {} foreach assignee_array [workflow::case::role::get_assignees \ -case_id $case_id \ -role_id $assigned_role_id] { @@ -1917,7 +1917,7 @@ set subset(workflow_assignee) $assignee_list set subset(workflow_my_cases) $case_player_list - set notified_list [list] + set notified_list {} foreach type { workflow_assignee workflow_my_cases workflow_case workflow @@ -2188,7 +2188,7 @@ array set enable_action_ids [array get assigned_p] # List of enabled_action_id's of actions that are no longer enabled - set unenable_enabled_action_ids [list] + set unenable_enabled_action_ids {} #---------------------------------------------------------------------- # 2. Get the rows in workflow_case_enabled_actions Index: openacs-4/packages/workflow/tcl/role-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/workflow/tcl/role-procs.tcl,v diff -u -N -r1.26 -r1.27 --- openacs-4/packages/workflow/tcl/role-procs.tcl 23 Jun 2015 09:45:18 -0000 1.26 +++ openacs-4/packages/workflow/tcl/role-procs.tcl 25 Apr 2018 19:47:48 -0000 1.27 @@ -143,9 +143,9 @@ # Parse column values switch $operation { insert - update { - set update_clauses [list] - set insert_names [list] - set insert_values [list] + set update_clauses {} + set insert_names {} + set insert_values {} # Handle columns in the workflow_roles table foreach attr { @@ -292,7 +292,7 @@ @author Lars Pind (lars@collaboraid.biz) } { - set result [list] + set result {} # workflow::get_roles returns the roles in sort_order foreach role_id [workflow::get_roles -workflow_id $workflow_id] { @@ -598,7 +598,7 @@ @author Peter Marklund } { # For performance we avoid nested queries in this proc - set role_ids [list] + set role_ids {} db_foreach role_info {} -column_array row { set role_id $row(role_id) @@ -620,8 +620,8 @@ foreach role_id $role_ids { set role,${role_id}(callbacks) {} set role,${role_id}(callback_ids) {} - array set callback_impl_names,$role_id [list] - array set callbacks_array,$role_id [list] + array set callback_impl_names,$role_id {} + array set callbacks_array,$role_id {} } db_foreach role_callbacks {} -column_array row { @@ -674,7 +674,7 @@ @param ignore_role_id If specified, the short_name for the given role will not be included in the result set. } { - set result [list] + set result {} foreach role_id [workflow::get_roles -all -workflow_id $workflow_id] { if { $ignore_role_id eq "" || $ignore_role_id ne $role_id } { @@ -779,7 +779,7 @@ } { set contract_name [workflow::service_contract::role_assignee_pick_list] - set party_id_list [list] + set party_id_list {} db_transaction { Index: openacs-4/packages/workflow/tcl/state-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/workflow/tcl/state-procs.tcl,v diff -u -N -r1.20 -r1.21 --- openacs-4/packages/workflow/tcl/state-procs.tcl 26 May 2017 17:41:51 -0000 1.20 +++ openacs-4/packages/workflow/tcl/state-procs.tcl 25 Apr 2018 19:47:48 -0000 1.21 @@ -177,9 +177,9 @@ unset missing_elm(parent_action) } - set update_clauses [list] - set insert_names [list] - set insert_values [list] + set update_clauses {} + set insert_names {} + set insert_values {} # Handle columns in the workflow_fsm_states table foreach attr { @@ -229,7 +229,7 @@ if { [info exists row(enabled_action_ids)] } { error "You cannot supply both enabled_actions and enabled_actions_ids" } - set row(enabled_action_ids) [list] + set row(enabled_action_ids) {} foreach action_short_name $row(enabled_actions) { lappend row(enabled_action_ids) [workflow::action::get_id \ -workflow_id $workflow_id \ @@ -243,7 +243,7 @@ if { [info exists row(assigned_action_ids)] } { error "You cannot supply both assigned_actions and assigned_action_ids" } - set row(assigned_action_ids) [list] + set row(assigned_action_ids) {} foreach action_short_name $row(assigned_actions) { lappend row(assigned_action_ids) [workflow::action::get_id \ -workflow_id $workflow_id \ @@ -253,7 +253,7 @@ } # Handle auxiliary rows - array set aux [list] + array set aux {} foreach attr { enabled_action_ids assigned_action_ids } { @@ -373,7 +373,7 @@ @param ignore_state_id If specified, the short_name for the given state will not be included in the result set. } { - set result [list] + set result {} foreach state_id [workflow::fsm::get_states -all -workflow_id $workflow_id] { if { $ignore_state_id eq "" || $ignore_state_id ne $state_id } { @@ -540,7 +540,7 @@ if { $all_p } { return $state_data(state_ids) } - set state_ids [list] + set state_ids {} foreach state_id $state_data(state_ids) { if { [workflow::state::fsm::get_element \ -state_id $state_id \ @@ -659,7 +659,7 @@ @author Lars Pind (lars@collaboraid.biz) } { # states(short_name) { ... state-spec ... } - set states_list [list] + set states_list {} foreach state_id [workflow::fsm::get_states -workflow_id $workflow_id] { lappend states_list [get_element -state_id $state_id -element short_name] [generate_spec -state_id $state_id] } @@ -715,7 +715,7 @@ # enabled_actions, enabled_action_ids, assigned_actions, assigned_action_ids # In addition: # state_data(state_ids) = [list of state_ids in sort order] - array set state_data [list] + array set state_data {} # state_array_$state_id is an internal datastructure. It's the array for each state_id entry # but as a separate array making it easier to lappend to individual entries @@ -725,7 +725,7 @@ #---------------------------------------------------------------------- # Use a list to be able to retrieve states in sort order - set state_ids [list] + set state_ids {} db_foreach select_states {} -column_array state_row { # Cache the state_id -> workflow_id lookup util_memoize_seed \ @@ -740,7 +740,7 @@ } set state_data(state_ids) $state_ids - array set action_short_name [list] + array set action_short_name {} #---------------------------------------------------------------------- # Build state-action map @@ -805,10 +805,10 @@ # 3. Put stuff back into the output array foreach state_id $state_ids { - set state_array_${state_id}(enabled_action_ids) [list] - set state_array_${state_id}(enabled_actions) [list] - set state_array_${state_id}(assigned_action_ids) [list] - set state_array_${state_id}(assigned_actions) [list] + set state_array_${state_id}(enabled_action_ids) {} + set state_array_${state_id}(enabled_actions) {} + set state_array_${state_id}(assigned_action_ids) {} + set state_array_${state_id}(assigned_actions) {} if { [info exists assigned_p_${state_id}] } { foreach action_id [array names assigned_p_${state_id}] { Index: openacs-4/packages/workflow/tcl/workflow-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/workflow/tcl/workflow-procs.tcl,v diff -u -N -r1.32 -r1.33 --- openacs-4/packages/workflow/tcl/workflow-procs.tcl 23 Jun 2015 09:55:43 -0000 1.32 +++ openacs-4/packages/workflow/tcl/workflow-procs.tcl 25 Apr 2018 19:47:48 -0000 1.33 @@ -195,9 +195,9 @@ # Parse column values switch $operation { insert - update { - set update_clauses [list] - set insert_names [list] - set insert_values [list] + set update_clauses {} + set insert_names {} + set insert_values {} # Handle columns in the workflows table foreach attr { @@ -477,7 +477,7 @@ @param ignore_workflow_id If specified, the short_name for the given workflow will not be included in the result set. } { - set result [list] + set result {} db_foreach select_workflows { select workflow_id, @@ -573,7 +573,7 @@ array unset row description_mime_type } - set spec [list] + set spec {} # Output sorted, and with no empty elements foreach name [lsort [array names row]] { @@ -583,7 +583,7 @@ } foreach { key namespace } $handlers { - set subspec [list] + set subspec {} foreach sub_id [${namespace}::get_ids -workflow_id $workflow_id] { set sub_short_name [${namespace}::get_element \ @@ -752,9 +752,9 @@ } # Pull out the extra types, roles/actions/states, so we don't try to create the workflow with them - array set aux [list] - array set counter [list] - array set remain [list] + array set aux {} + array set counter {} + array set remain {} foreach { key namespace } $handlers { if { [info exists workflow($key)] } { set aux($key) $workflow($key) @@ -768,7 +768,7 @@ } } - array set sub_id [list] + array set sub_id {} db_transaction { # Create the workflow @@ -908,10 +908,10 @@ } { db_1row workflow_info {} -column_array row - set callbacks [list] - set callback_ids [list] - array set callback_impl_names [list] - array set callbacks_array [list] + set callbacks {} + set callback_ids {} + array set callback_impl_names {} + array set callbacks_array {} db_foreach workflow_callbacks {} -column_array callback_row { lappend callbacks "$callback_row(impl_owner_name).$callback_row(impl_name)" Index: openacs-4/packages/wp-slim/www/style-edit.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/wp-slim/www/style-edit.tcl,v diff -u -N -r1.6 -r1.7 --- openacs-4/packages/wp-slim/www/style-edit.tcl 27 Jun 2015 20:34:42 -0000 1.6 +++ openacs-4/packages/wp-slim/www/style-edit.tcl 25 Apr 2018 19:47:48 -0000 1.7 @@ -55,8 +55,8 @@ " } else { - set names [list] - set values [list] + set names {} + set values {} foreach image $items { lappend names [lindex $image 1] lappend values [lindex $image 0] Index: openacs-4/packages/xml-rpc/tcl/system-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xml-rpc/tcl/system-procs.tcl,v diff -u -N -r1.1 -r1.2 --- openacs-4/packages/xml-rpc/tcl/system-procs.tcl 26 Nov 2003 02:59:13 -0000 1.1 +++ openacs-4/packages/xml-rpc/tcl/system-procs.tcl 25 Apr 2018 19:47:48 -0000 1.2 @@ -17,7 +17,7 @@ implemented by the server. @author Vinod Kurup } { - set result [list] + set result {} foreach proc_name [xmlrpc::list_methods] { lappend result [list -string $proc_name] } @@ -66,7 +66,7 @@ standard <fault> element. @author Vinod Kurup } { - set responses [list] + set responses {} foreach call $array { # parse the call for methodName and params Index: openacs-4/packages/xml-rpc/tcl/validator-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xml-rpc/tcl/validator-procs.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/xml-rpc/tcl/validator-procs.tcl 10 Apr 2008 15:29:34 -0000 1.3 +++ openacs-4/packages/xml-rpc/tcl/validator-procs.tcl 25 Apr 2018 19:47:48 -0000 1.4 @@ -255,11 +255,11 @@ # for each year for {set y $startyear} {$y <= $endyear} {incr y} { - set year [list] + set year {} # for each month for {set m 1} {$m <= 12} {incr m} { - set month [list] + set month {} # for each day set mstr [format %02d $m] for {set d 1} {$d <= 31} {incr d} { Index: openacs-4/packages/xml-rpc/tcl/xml-rpc-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xml-rpc/tcl/xml-rpc-procs.tcl,v diff -u -N -r1.13 -r1.14 --- openacs-4/packages/xml-rpc/tcl/xml-rpc-procs.tcl 24 Apr 2018 16:13:07 -0000 1.13 +++ openacs-4/packages/xml-rpc/tcl/xml-rpc-procs.tcl 25 Apr 2018 19:47:48 -0000 1.14 @@ -19,7 +19,7 @@ } # setup nsv array to hold procs that are registered for xml-rpc access -nsv_array set xmlrpc_procs [list] +nsv_array set xmlrpc_procs {} namespace eval xmlrpc {} @@ -672,7 +672,7 @@ [lindex \ [xml_node_get_children_by_name $data methodName] 0 ]] - set arguments [list] + set arguments {} set params [xml_node_get_children_by_name $data params] if {$params ne ""} { foreach parameter [xml_node_get_children_by_name $params param] { Index: openacs-4/packages/xolp/tcl/xolp-indicator-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xolp/tcl/xolp-indicator-procs.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/xolp/tcl/xolp-indicator-procs.tcl 27 Jan 2017 16:25:57 -0000 1.3 +++ openacs-4/packages/xolp/tcl/xolp-indicator-procs.tcl 25 Apr 2018 19:47:48 -0000 1.4 @@ -199,8 +199,8 @@ } } set sql "" - set dimensions [list] - set where_clause [list] + set dimensions {} + set where_clause {} # Dimension: Activities if {$activity_iris ne ""} { set dimension_table "xolp_activity_dimension" Index: openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl,v diff -u -N -r1.88 -r1.89 --- openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl 7 Apr 2018 17:14:54 -0000 1.88 +++ openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl 25 Apr 2018 19:47:48 -0000 1.89 @@ -216,7 +216,7 @@ namespace eval ::xo { proc slotobjects cl { - set so [list] + set so {} array set names "" foreach c [list $cl {*}[$cl info heritage]] { foreach s [$c info slots] { Index: openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl,v diff -u -N -r1.13 -r1.14 --- openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl 25 Apr 2018 08:52:58 -0000 1.13 +++ openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl 25 Apr 2018 19:47:48 -0000 1.14 @@ -261,7 +261,7 @@ } :public object method source_to_html {{-width 100} string} { - set lines [list] + set lines {} foreach l [split $string \n] { while {[string length $l] > $width} { set pos [string last " \{" $l $width] @@ -457,7 +457,7 @@ dict set doc default_values {} dict set doc positionals {} } else { - set defaults [list] + set defaults {} foreach a [::xo::getObjectProperty $obj ${inst}args $proc_name] { if {[::xo::getObjectProperty $obj ${inst}argdefault $proc_name $a d]} { lappend defaults $a $d Index: openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl,v diff -u -N -r1.120 -r1.121 --- openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl 25 Apr 2018 08:52:58 -0000 1.120 +++ openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl 25 Apr 2018 19:47:48 -0000 1.121 @@ -474,7 +474,7 @@ if {$bind ne ""} {set bindOpt [list -bind $bind]} {set bindOpt ""} db_with_handle -dbn $dbn db { if {[info exists prepare]} {set sql [:prepare -handle $db -argtypes $prepare $sql]} - set result [list] + set result {} set answers [uplevel [list ns_pg_bind select $db {*}$bindOpt $sql]] while { [::db_getrow $db $answers] } { lappend result [ns_set copy $answers] @@ -585,10 +585,10 @@ if {$bind ne ""} {set bindOpt [list -bind $bind]} {set bindOpt ""} db_with_handle db { if {[info exists prepare]} {set sql [:prepare -handle $db -argtypes $prepare $sql]} - set result [list] + set result {} set answers [uplevel [list ns_pg_bind select $db {*}$bindOpt $sql]] while { [db_getrow $db $answers] } { - set row [list] + set row {} foreach {att value} [ns_set array $answers] {lappend row $value} lappend result $row } @@ -601,7 +601,7 @@ if {$bind ne ""} {set bindOpt [list -bind $bind]} {set bindOpt ""} db_with_handle db { if {[info exists prepare]} {set sql [:prepare -handle $db -argtypes $prepare $sql]} - set result [list] + set result {} set answers [uplevel [list ns_pg_bind select $db {*}$bindOpt $sql]] while { [::db_getrow $db $answers] } { lappend result [ns_set value $answers 0] @@ -1307,7 +1307,7 @@ order by pronargs desc, proargtypes desc } { set n 1 - set function_args [list] + set function_args {} foreach line [split $prosrc \n] { if {[regexp -nocase "alias +for +\\\$$n" $line]} { if {![regexp {^[^a-zA-Z]+([a-zA-Z0-9_]+)\s} $line _ fq_name]} { @@ -1366,8 +1366,8 @@ ::xo::db::DBI instproc sql_arg_info {function_args package_name object_name} { set defined {} - set psql_args [list] - set arg_order [list] + set psql_args {} + set arg_order {} # TODO function args not needed in dict foreach arg $function_args { lassign $arg arg_name default_value @@ -1548,7 +1548,7 @@ return $function_args } array set additional_defaults [::xo::db::SQL set fallback_defaults(${package_name}__$object_name)] - set result [list] + set result {} foreach arg $function_args { lassign $arg arg_name default_value if {$default_value eq "" && [info exists additional_defaults($arg_name)]} { @@ -1565,8 +1565,8 @@ ::xo::db::SQL instproc sql_arg_info {function_args package_name object_name} { set defined {} - set psql_args [list] - set arg_order [list] + set psql_args {} + set arg_order {} foreach arg $function_args { lassign $arg arg_name default_value lappend psql_args \$_$arg_name @@ -1898,8 +1898,8 @@ ::xo::db::Class instproc db_slots {} { - array set :db_slot [list] - array set :db_constraints [list] + array set :db_slot {} + array set :db_constraints {} # # First get all ::xo::db::Attribute slots and check later, # if we have to add the id_column automatically. @@ -1954,7 +1954,7 @@ } ::xo::db::Class instproc table_definition {} { - array set column_specs [list] + array set column_specs {} # # iterate over the slots and collect the column_specs for table generation # @@ -2007,7 +2007,7 @@ if {![info exists column_specs(${:id_column})]} { error "no ::xo::db::Attribute slot for id_column '${:id_column}' specified" } - set table_specs [list] + set table_specs {} foreach {att spec} [array get column_specs] {lappend table_specs $att $spec} set table_definition $table_specs } else { @@ -2018,8 +2018,8 @@ } ::xo::db::Class instproc mk_update_method {} { - set updates [list] - set vars [list] + set updates {} + set vars {} foreach {slot_name slot} [array get :db_slot] { $slot instvar name column_name if {$column_name ne [:id_column]} { @@ -2282,7 +2282,7 @@ set __result [::xo::OrderedComposite new] if {$destroy_on_cleanup} {$__result destroy_on_cleanup} } else { - set __result [list] + set __result {} } if {$named_objects} { if {$object_named_after eq ""} { @@ -2340,8 +2340,8 @@ } ::xo::db::Class instproc fetch_query {id} { - set tables [list] - set attributes [list] + set tables {} + set attributes {} set id_column [:id_column] set join_expressions [list "[:table_name].$id_column = $id"] foreach cl [list [self] {*}[:info heritage]] { @@ -2385,7 +2385,7 @@ @param count return the query for counting the solutions @return SQL query } { - set tables [list] + set tables {} set id_column [:id_column] if {$count} { @@ -2395,7 +2395,7 @@ } set all_attributes [expr {$select_attributes eq ""}] - set join_expressions [list] + set join_expressions {} foreach cl [list [self] {*}[:info heritage]] { #if {$cl eq "::xo::db::Object"} break if {$cl eq "::xotcl::Object"} break Index: openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl,v diff -u -N -r1.64 -r1.65 --- openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl 21 Mar 2018 19:37:57 -0000 1.64 +++ openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl 25 Apr 2018 19:47:48 -0000 1.65 @@ -137,7 +137,7 @@ @return flattened list of attribute value pairs } { - set pairs [list] + set pairs {} foreach attribute $args { set l [split $attribute] if {[llength $l] > 1} { @@ -161,7 +161,7 @@ @return flattened list of attribute value pairs } { - set pairs [list] + set pairs {} foreach attribute $args { set l [split $attribute] if {[llength $l] > 1} { @@ -245,7 +245,7 @@ #ns_log notice "--local $text $inline" set obj [uplevel self] if {![$obj exists __localizer]} { - $obj set __localizer [list] + $obj set __localizer {} } if {[string first \x02 $text] == -1} { return $text @@ -349,7 +349,7 @@ $l destroy } } - set :__localizer [list] + set :__localizer {} } \ -instproc render-data args { next @@ -411,7 +411,7 @@ set M [OrderedComposite create [self]::__columns] namespace eval $M [list namespace import -force [self class]::*] $M contains $cmd - set slots [list] + set slots {} foreach c [$M children] { lappend slots {*}[$c get-slots] } @@ -446,7 +446,7 @@ {-delimiter ","} } { set output "" - set line [list] + set line {} foreach column [[self]::__columns children] { if {[$column exists no_csv]} continue set label [$column label] @@ -458,7 +458,7 @@ } append output [join $line $delimiter] \n foreach row [:children] { - set line [list] + set line {} foreach column [[self]::__columns children] { if {[$column exists no_csv]} continue set value [string map {\" \\\" \n \r} [$row set [$column set name]]] @@ -477,7 +477,7 @@ Class create Table::Line \ -superclass ::xo::Drawable \ -instproc attlist {name atts {extra ""}} { - set result [list] + set result {} foreach att $atts { set varname $name.$att if {[info exists :$varname]} { @@ -992,8 +992,8 @@ return [list] } Page proc sort_keys_by_value {{-comparison integer} {-direction increasing} pairs} { - set result [list] - set a [list] + set result {} + set a {} foreach {key value} $pairs { lappend a [list $key $value] } Index: openacs-4/packages/xotcl-core/tcl/bgdelivery-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-core/tcl/bgdelivery-procs.tcl,v diff -u -N -r1.57 -r1.58 --- openacs-4/packages/xotcl-core/tcl/bgdelivery-procs.tcl 9 Jan 2018 10:06:13 -0000 1.57 +++ openacs-4/packages/xotcl-core/tcl/bgdelivery-procs.tcl 25 Apr 2018 19:47:48 -0000 1.58 @@ -289,7 +289,7 @@ ::xotcl::Class create Subscriber -parameter {key channel user_id mode} Subscriber proc current {-key } { - set result [list] + set result {} if {[info exists key]} { if {[info exists :subscriptions($key)]} { return [list $key [set :subscriptions($key)]] @@ -356,7 +356,7 @@ Subscriber proc foreachSubscriber {key method {argument ""}} { :msg "$key $method '$argument'" if {[info exists :subscriptions($key)]} { - set subs1 [list] + set subs1 {} foreach s [set :subscriptions($key)] { if {[catch {$s $method $argument} errMsg]} { ns_log error "error in $method to subscriber $s (key=$key): $errMsg" @@ -419,7 +419,7 @@ set :running 0 set :release 0 set :spooling 0 - set :queue [list] + set :queue {} } ::HttpSpooler instproc all_done {} { catch {close [:channel]} @@ -598,7 +598,7 @@ set range [ns_set iget [ns_conn headers] range] if {[regexp {bytes=(.*)$} $range _ range]} { - set ranges [list] + set ranges {} set bytes 0 set pos 0 foreach r [split $range ,] { Index: openacs-4/packages/xotcl-core/tcl/cr-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-core/tcl/cr-procs.tcl,v diff -u -N -r1.61 -r1.62 --- openacs-4/packages/xotcl-core/tcl/cr-procs.tcl 25 Mar 2018 22:13:40 -0000 1.61 +++ openacs-4/packages/xotcl-core/tcl/cr-procs.tcl 25 Apr 2018 19:47:48 -0000 1.62 @@ -132,7 +132,7 @@ @return list of item_ids } { - set items [list] + set items {} foreach item_id [::xo::dc list get_child_items \ "select item_id from cr_items where parent_id = :item_id"] { lappend items $item_id {*}[my [self proc] -item_id $item_id] @@ -429,7 +429,7 @@ set raw_atts [::xo::db::CrClass set common_query_atts] #my log "-- raw_atts = '$raw_atts'" - set atts [list] + set atts {} foreach v $raw_atts { switch -glob -- $v { publish_status {set fq i.$v} @@ -622,7 +622,7 @@ set attribute_selection [join $attributes ,] } - set cond [list] + set cond {} if {$type_selection_clause ne ""} {lappend cond $type_selection_clause} if {$where_clause ne ""} {lappend cond $where_clause} if {[info exists publish_status]} {lappend cond "ci.publish_status = :publish_status"} @@ -815,8 +815,8 @@ # view. So we postpone these updates and perform these # as separate statements. # - set values [list] - set attributes [list] + set values {} + set attributes {} #my msg "--long_text_slots: [array get :long_text_slots]" foreach a $atts v $vars { @@ -1399,7 +1399,7 @@ set attribute_selection [join $attributes ,] } - set cond [list] + set cond {} if {$type_selection_clause ne ""} {lappend cond $type_selection_clause} if {$where_clause ne ""} {lappend cond $where_clause} if {[info exists publish_status]} {lappend cond "ci.publish_status = :publish_status"} Index: openacs-4/packages/xotcl-core/tcl/generic-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-core/tcl/generic-procs.tcl,v diff -u -N -r1.104 -r1.105 --- openacs-4/packages/xotcl-core/tcl/generic-procs.tcl 12 Apr 2018 06:40:32 -0000 1.104 +++ openacs-4/packages/xotcl-core/tcl/generic-procs.tcl 25 Apr 2018 19:47:48 -0000 1.105 @@ -72,7 +72,7 @@ } Form instproc form_vars {} { - set vars [list] + set vars {} foreach varspec [:fields] { lappend vars [lindex [split [lindex $varspec 0] :] 0] } Index: openacs-4/packages/xotcl-core/www/show-object.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-core/www/show-object.tcl,v diff -u -N -r1.23 -r1.24 --- openacs-4/packages/xotcl-core/www/show-object.tcl 7 Aug 2017 23:48:30 -0000 1.23 +++ openacs-4/packages/xotcl-core/www/show-object.tcl 25 Apr 2018 19:47:48 -0000 1.24 @@ -108,7 +108,7 @@ if {$dosort} {set list [lsort $list]} - set refs [list] + set refs {} foreach e $list { lappend refs [::xo::api object_link $scope $e] } @@ -126,7 +126,7 @@ set result "" if {0} { set methods [lsort [DO xo::getObjectProperty $c instcommand]] - set pretty [list] + set pretty {} foreach m $methods { if {[info exists param($m)]} continue set entry [::xo::api method_link $c instproc $m] @@ -136,7 +136,7 @@ append result "
Methods for instances:
[join $pretty {, }]
" } set methods [lsort [DO xo::getObjectProperty $c command -callprotection all]] - set pretty [list] + set pretty {} foreach m $methods { if {![DO xo::getObjectProperty ${c}::$m isobject]} { lappend pretty [::xo::api method_link $c proc $m] Index: openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl,v diff -u -N -r1.53 -r1.54 --- openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl 18 Apr 2018 22:25:03 -0000 1.53 +++ openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl 25 Apr 2018 19:47:48 -0000 1.54 @@ -135,7 +135,7 @@ } Throttle instproc call_statistics {} { - set l [list] + set l {} foreach t {seconds minutes hours} { lappend l [list $t [$t set last] [$t set trend] [$t set stats]] } @@ -582,7 +582,7 @@ array unset :cnt } UrlCounter instproc url_stats {} { - set result [list] + set result {} foreach url [array names :stat] { lappend result [list $url [set :stat($url)] [set :cnt($url)]] } @@ -680,7 +680,7 @@ @return list with detailed user info } { if {$full} { - set info [list] + set info {} foreach key [array names :pa] { set entry [list $key [set :pa($key)]] foreach var [list timestamp hits expSmooth switches] { @@ -747,7 +747,7 @@ } Users proc last_requests {uid} { if {[info exists :pa($uid)]} { - set urls [list] + set urls {} foreach i [Users info instances] { if {[$i exists urls($uid)]} { foreach u [$i set urls($uid)] { lappend urls $u } @@ -779,7 +779,7 @@ } Users proc in_community {community_id} { - set users [list] + set users {} foreach i [Users info instances] { if {[$i exists in_community($community_id)]} { set time [$i point_in_time] @@ -1191,7 +1191,7 @@ return [list ${:ip24} ${:auth24}] } Users proc users_per_day {} { - set ip [list]; set auth [list] + set ip [list]; set auth {} foreach i [array names :timestamp] { if {[::xo::is_ip $i]} { set var ip @@ -1264,7 +1264,7 @@ dump set file ${logdir}/throttle-data.dump dump proc read {} { # make sure, timestamp exists as an array - array set Users::timestamp [list] + array set Users::timestamp {} if {[file readable ${:file}]} { # in case of disk-full, the file might be damaged, so make sure, # we can continue Index: openacs-4/packages/xotcl-request-monitor/www/stat-details.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-request-monitor/www/stat-details.tcl,v diff -u -N -r1.9 -r1.10 --- openacs-4/packages/xotcl-request-monitor/www/stat-details.tcl 22 Dec 2017 13:52:24 -0000 1.9 +++ openacs-4/packages/xotcl-request-monitor/www/stat-details.tcl 25 Apr 2018 19:47:48 -0000 1.10 @@ -58,7 +58,7 @@ # # truncate tails, if we have VUHs # - set url_list [list] + set url_list {} foreach p [split $url /] { if {[info exists vuh($p)]} { lappend url_list $p @@ -75,7 +75,7 @@ } set aggr_stat($url) [list $time $cnt] } - set stat [list] + set stat {} foreach url [array names aggr_stat] { lassign $aggr_stat($url) time cnt lappend stat [list $url $time $cnt] @@ -88,7 +88,7 @@ lassign $l url time cnt set param "" regexp {^(.*)([?].*$)} $url _ url param - set url_list [list] + set url_list {} foreach p [split $url /] { if {[info exists apps($p)]} { if {[llength $url_list]>0} {set url_list [list .../$p]} @@ -104,7 +104,7 @@ } set aggr_stat($url) [list $time $cnt] } - set stat [list] + set stat {} foreach url [array names aggr_stat] { lassign $aggr_stat($url) time cnt lappend stat [list $url $time $cnt] Index: openacs-4/packages/xowf/tcl/xowf-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowf/tcl/xowf-procs.tcl,v diff -u -N -r1.18 -r1.19 --- openacs-4/packages/xowf/tcl/xowf-procs.tcl 25 Apr 2018 08:51:36 -0000 1.18 +++ openacs-4/packages/xowf/tcl/xowf-procs.tcl 25 Apr 2018 19:47:48 -0000 1.19 @@ -271,15 +271,15 @@ } Context instproc get_actions {} { - set actions [list] + set actions {} foreach action [${:current_state} get_actions] { lappend actions ${:wf_container}::$action } #:msg "for ${:current_state} actions '$actions" return $actions } Context instproc defined {what} { - set result [list] + set result {} foreach c [${:wf_container} info children] { if {[$c istype $what]} {lappend result $c} } @@ -907,7 +907,7 @@ } } WorkflowConstruct instproc get_value_set {values} { - set result [list] + set result {} foreach {cond value} [:get_cond_values $values] { foreach v $value {lappend result $v} } @@ -1413,7 +1413,7 @@ set tokens [mime::initialize -canonical "multipart/mixed" -parts $tokens] } - set headers_list [list] + set headers_list {} lappend headers_list \ [list From $from_info(email)] \ [list To $to_info(email)] \ @@ -1521,7 +1521,7 @@ Compute solution set in form of attribute=value pairs based on "answer" attribute of form fields. } { - set solutions [list] + set solutions {} foreach f [:instantiated_form_fields] { if {![$f exists answer]} continue lappend solutions [$f name]=[$f answer] @@ -1796,7 +1796,7 @@ if {[info exists $key]} {append $key ",$value"} else {set $key $value} } } - set result [list] + set result {} foreach {att value} [array get __c1] {lappend result $att:$value} return $result } @@ -1872,7 +1872,7 @@ set wf [self] set wf_base [$wf pretty_link] - set button_objs [list] + set button_objs {} # create new workflow instance button with start form #if {[:parent_id] != [$package_id folder_id]} { @@ -1909,7 +1909,7 @@ set entry_form_item_id [:wf_property wf_form_id] set work_flow_form [::xo::db::CrClass get_instance_from_db -item_id $form_item_id] set work_flow_base [$work_flow_form pretty_link] - set button_objs [list] + set button_objs {} #:msg entry_form_item_id=$entry_form_item_id-exists?=[:isobject $entry_form_item_id] Index: openacs-4/packages/xowiki/tcl/category-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/category-procs.tcl,v diff -u -N -r1.28 -r1.29 --- openacs-4/packages/xowiki/tcl/category-procs.tcl 7 Aug 2017 23:48:30 -0000 1.28 +++ openacs-4/packages/xowiki/tcl/category-procs.tcl 25 Apr 2018 19:47:48 -0000 1.29 @@ -24,7 +24,7 @@ set mapped_trees [expr {$have_locale ? [category_tree::get_mapped_trees $object_id $locale] : [category_tree::get_mapped_trees $object_id]}] - set trees [list] + set trees {} foreach tree $mapped_trees { lassign $tree tree_id my_tree_name ... @@ -50,7 +50,7 @@ # Get the values from info in "tree" into separate variables given by output. # Note, that the order matters! lassign $tree {*}$output - set l [list] + set l {} foreach __var $output {lappend l [set $__var]} lappend trees $l } Index: openacs-4/packages/xowiki/tcl/folder-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/folder-procs.tcl,v diff -u -N -r1.47 -r1.48 --- openacs-4/packages/xowiki/tcl/folder-procs.tcl 10 Apr 2018 06:52:09 -0000 1.47 +++ openacs-4/packages/xowiki/tcl/folder-procs.tcl 25 Apr 2018 19:47:48 -0000 1.48 @@ -136,7 +136,7 @@ {-subtree_query ""} {-depth 3} } { - set folders [list] + set folders {} # safety belt, for recursive structures if {$depth < 1} {return $folders} @@ -422,8 +422,8 @@ set current_object [$node object] set current_item_id [$current_object item_id] - set sub_folders [list] - set remaining_folders [list] + set sub_folders {} + set remaining_folders {} foreach f $folders { if {[$f parent_id] ne $current_item_id} { Index: openacs-4/packages/xowiki/tcl/form-field-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/form-field-procs.tcl,v diff -u -N -r1.268 -r1.269 --- openacs-4/packages/xowiki/tcl/form-field-procs.tcl 25 Apr 2018 08:51:36 -0000 1.268 +++ openacs-4/packages/xowiki/tcl/form-field-procs.tcl 25 Apr 2018 19:47:48 -0000 1.269 @@ -1695,7 +1695,7 @@ set editor_class [self class]::$editor if {$editor ne "" && ![:hasclass $editor_class]} { if {![:isclass $editor_class]} { - set editors [list] + set editors {} foreach c [::xowiki::formfield::richtext info subclass] { if {![$c exists editor_mixin]} continue lappend editors [namespace tail $c] @@ -1867,7 +1867,7 @@ } richtext::ckeditor instproc pathNames {fileNames} { - set result [list] + set result {} foreach fn $fileNames { if {[regexp {^[./]} $fn]} { append result $fn @@ -2067,7 +2067,7 @@ } richtext::ckeditor4 instproc pathNames {fileNames} { - set result [list] + set result {} foreach fn $fileNames { if {[regexp {^[./]} $fn]} { append result $fn @@ -2412,7 +2412,7 @@ # we use for the time being the initialization of xinha based on # the blank master set ::acs_blank_master(xinha) 1 - set quoted [list] + set quoted {} foreach e [:plugins] {lappend quoted '$e'} set ::acs_blank_master(xinha.plugins) [join $quoted ", "] @@ -2482,7 +2482,7 @@ enumeration instproc get_labels {values} { if {[:multiple]} { - set labels [list] + set labels {} foreach v $values {lappend labels [list [:get_entry_label $v] $v]} return $labels } else { @@ -2499,7 +2499,7 @@ lassign $o label value set labels($value) [:localize $label] } - set values [list] + set values {} foreach i $v {lappend values $labels($i)} return [join $values {, }] } else { @@ -2534,7 +2534,7 @@ return } set subtree_id "" - set options [list] + set options {} foreach category [::xowiki::Category get_category_infos \ -subtree_id $subtree_id -tree_id $tree_id] { @@ -2803,7 +2803,7 @@ set href [${:package_id} pretty_link -parent_id $parent_id $value] set labels($value) "$label" } - set hrefs [list] + set hrefs {} foreach i $v { if {![info exists labels($i)]} { #:msg "can't determine label for value '$i' (values=$v, l=[array names labels])" @@ -2861,7 +2861,7 @@ #set form_obj [${:object} resolve_included_page_name $form_name] if {$form_objs eq ""} {error "Cannot lookup Form '$form_name'"} - set :form_object_item_ids [list] + set :form_object_item_ids {} foreach form_obj $form_objs {lappend :form_object_item_ids [$form_obj item_id]} } form_page instproc compute_options {} { @@ -2892,7 +2892,7 @@ -package_id ${:package_id} \ -from_package_ids $from_package_ids] - set :options [list] + set :options {} foreach i [$items children] { # # If the form_page has a different package_id, prepend the @@ -2939,7 +2939,7 @@ } set package_id [${:object} package_id] - set :options [list] + set :options {} ::xo::dc foreach instance_select \ [${:type} instance_select_query \ -folder_id [$package_id folder_id] \ @@ -3389,7 +3389,7 @@ CompoundField instproc get_compound_value {} { # Set the internal representation based on the components values. - set value [list] + set value {} foreach c [:components] { #:msg "$c [$c info class] lappending [list [$c name] [$c value]]" lappend value [$c name] [$c value] @@ -3416,7 +3416,7 @@ # of the form {name spec}. # set :structure $spec_list - set :components [list] + set :components {} foreach entry $spec_list { lassign $entry name spec # @@ -3501,7 +3501,7 @@ } CompoundField instproc generate_fieldnames {{-prefix "v-"} n} { - set names [list] + set names {} for {set i 1} {$i <= $n} {incr i} {lappend names $prefix$i} return $names } @@ -3856,7 +3856,7 @@ Class create scale -superclass radio -parameter {{n 5} {horizontal true}} scale instproc initialize {} { - set :options [list] + set :options {} for {set i 1} {$i <= ${:n}} {incr i} { lappend :options [list $i $i] } Index: openacs-4/packages/xowiki/tcl/includelet-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/includelet-procs.tcl,v diff -u -N -r1.218 -r1.219 --- openacs-4/packages/xowiki/tcl/includelet-procs.tcl 25 Apr 2018 08:50:36 -0000 1.218 +++ openacs-4/packages/xowiki/tcl/includelet-procs.tcl 25 Apr 2018 19:47:48 -0000 1.219 @@ -137,7 +137,7 @@ set publish_status_clause "" } else { array set valid_state [list production 1 ready 1 live 1 expired 1] - set clauses [list] + set clauses {} foreach state [split $value |] { if {![info exists valid_state($state)]} { error "no such state: '$state'; valid states are: production, ready, live, expired" @@ -189,11 +189,11 @@ # pipe symbols are or-operations, commas are and-operations; # no parenthesis are permitted set extra_where_clause "" - set or_names [list] - set ors [list] + set or_names {} + set ors {} foreach cid_or [split $category_spec |] { - set ands [list] - set and_names [list] + set ands {} + set and_names {} foreach cid_and [split $cid_or ,] { if {![string is integer -strict $cid_and]} { ad_return_complaint 1 "invalid category id '[ns_quotehtml $cid_and]'" @@ -743,7 +743,7 @@ } elseif {$edit_html ne ""} { append content "$edit_html
" } - set categories [list] + set categories {} set pos 0 set cattree(0) [::xowiki::Tree new -volatile -orderby pos \ -id [:id]-$my_tree_name -name $my_tree_name] @@ -766,7 +766,7 @@ } if {[info exists ordered_composite]} { - set items [list] + set items {} foreach c [$ordered_composite children] {lappend items [$c item_id]} # If we have no item, provide a dummy one to avoid sql error @@ -1371,13 +1371,13 @@ set sql "select count(*) as nr,tag from xowiki_tags where \ user_id = :user_id and package_id = :package_id group by tag order by tag" } - set entries [list] + set entries {} if {![info exists page]} {set page [$package_id get_parameter weblog_page]} set href [$package_id package_url]tag/ ::xo::dc foreach get_tag_counts $sql { - set q [list] + set q {} if {$summary} {lappend q "summary=[ad_urlencode_query $summary]"} if {$popular} {lappend q "popular=[ad_urlencode_query $popular]"} set link $href$tag?[join $q &] @@ -1413,7 +1413,7 @@ set :tags [lsort [::xowiki::Page get_tags -user_id [::xo::cc user_id] \ -item_id [${:__including_page} item_id] -package_id $package_id]] - set entries [list] + set entries {} foreach tag ${:tags} { set href [export_vars -base [$package_id package_url]/tag/$tag {summary}] @@ -1460,7 +1460,7 @@ set content "" set weblog_page [$package_id get_parameter weblog_page weblog] - set entries [list] + set entries {} set href [export_vars -base [$package_id package_url]$weblog_page {summary}] set notification_type "" if {[$package_id get_parameter "with_notifications" 1] && @@ -1615,7 +1615,7 @@ :get_parameters set item_id [${:__including_page} item_id] - set refs [list] + set refs {} # The same image might be linked both, as img or file on one page, # so we need DISTINCT. @@ -1663,7 +1663,7 @@ :get_parameters set item_id [${:__including_page} item_id] - set refs [list] + set refs {} ::xo::dc foreach get_refers "SELECT DISTINCT reference,ci.name,ci.parent_id,o.package_id as pid \ from xowiki_references,cr_items ci,acs_objects o \ @@ -2364,7 +2364,7 @@ } } - set menu [list] + set menu {} foreach b $menu_buttons { if {[info commands ::xowiki::includelet::$b] eq ""} { set b $b-item-button @@ -2460,7 +2460,7 @@ -level:required } { $object instvar page_order title name - set menu [list] + set menu {} foreach b $menu_buttons { if {[info commands ::xowiki::includelet::$b] eq ""} { set b $b-item-button @@ -3239,7 +3239,7 @@ if {$collab($x) > $max} {set max $collab($x)} } - set edges [list] + set edges {} foreach x [array names collab] { lappend edges [list $x $collab($x) [expr {$collab($x)*5.0/$max}]] } @@ -3331,7 +3331,7 @@ if {$collab($x) > $max} {set max $collab($x)} } - set edges [list] + set edges {} foreach x [array names collab] { lappend edges [list $x $collab($x) [expr {$collab($x)*5.0/$max}]] } @@ -3559,7 +3559,7 @@ lappend button_objs $obj } } - set links [list] + set links {} foreach b $button_objs { lappend links [$b render] } return "
[join $links { · }]
\n" } @@ -3618,7 +3618,7 @@ # # experimental highcharts pie renderer # - set percentages [list] + set percentages {} foreach {value count} [array get __count] { lappend percentages $value [format %.2f [expr {$count*100.0/$sum}]] } @@ -3660,7 +3660,7 @@ set title [:title] if {![info exists :id]} {set :id [::xowiki::Includelet html_id [self]]} set id [:id] - set values [list] + set values {} foreach {name value} $data { lappend values "\['[::xowiki::Includelet js_encode $name]', $value\]" } @@ -3848,7 +3848,7 @@ } # finally, evaluate conditions if included - set field_names [list] + set field_names {} foreach f $raw_field_names { set _ [string trim [::xowiki::formfield::FormField get_single_spec \ -object $o -package_id $package_id $f]] @@ -3941,7 +3941,7 @@ # # Compute filter clauses # - set init_vars [list] + set init_vars {} array set uc {tcl false h "" vars "" sql ""} if {[info exists unless]} { array set uc [::xowiki::FormPage filter_expression $unless ||] @@ -4080,7 +4080,7 @@ return "" } - set links [list] + set links {} set base [$form_item pretty_link] set label [$form_item name] @@ -4124,14 +4124,14 @@ # corresponding to the wanted field name. This is guaranteed by the construction # in form-usages. set count 0 - set table_field_names [list] + set table_field_names {} foreach t [$t1 children] { incr count lappend table_field_names $count # In most situations, it seems useful to have just one field in # the voting table. If there are multiple, we use a comma to # separate the values (looks bettern than separate columns). - set field_contents [list] + set field_contents {} foreach __fn $field_names { lappend field_contents [$t set $__fn] } @@ -4470,7 +4470,7 @@ -initialize false \ -publish_status $publish_status \ -package_id $package_id] - set result [list] + set result {} foreach item [$items children] { lappend result [$item name] } Index: openacs-4/packages/xowiki/tcl/lcs-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/lcs-procs.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/xowiki/tcl/lcs-procs.tcl 27 Oct 2014 16:42:04 -0000 1.5 +++ openacs-4/packages/xowiki/tcl/lcs-procs.tcl 25 Apr 2018 19:47:48 -0000 1.6 @@ -35,8 +35,8 @@ proc list::longestCommonSubsequence { sequence1 sequence2 } { - set seta [list] - set setb [list] + set seta {} + set setb {} # Construct a set of equivalence classes of lines in file 2 Index: openacs-4/packages/xowiki/tcl/menu-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/menu-procs.tcl,v diff -u -N -r1.15 -r1.16 --- openacs-4/packages/xowiki/tcl/menu-procs.tcl 9 Apr 2018 07:58:06 -0000 1.15 +++ openacs-4/packages/xowiki/tcl/menu-procs.tcl 25 Apr 2018 19:47:48 -0000 1.16 @@ -151,7 +151,7 @@ } ::xowiki::MenuBar instproc init {} { - set :Menues [list] + set :Menues {} :destroy_on_cleanup } @@ -233,7 +233,7 @@ # such an entry. # set updated 0 - set newitems [list] + set newitems {} foreach {n i} [set :Menu($menu)] { if {$n eq $name} { lappend newitems $name $item Index: openacs-4/packages/xowiki/tcl/package-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/package-procs.tcl,v diff -u -N -r1.315 -r1.316 --- openacs-4/packages/xowiki/tcl/package-procs.tcl 25 Apr 2018 08:51:36 -0000 1.315 +++ openacs-4/packages/xowiki/tcl/package-procs.tcl 25 Apr 2018 19:47:48 -0000 1.316 @@ -1183,7 +1183,7 @@ # Compute a list fo package objects which should be used for # resolving ("inheritance of objects from other instances"). # - set packages [list] + set packages {} set package_url [string trimright [:package_url] /] set package_path [:get_parameter PackagePath] # Index: openacs-4/packages/xowiki/tcl/xowiki-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/xowiki-procs.tcl,v diff -u -N -r1.516 -r1.517 --- openacs-4/packages/xowiki/tcl/xowiki-procs.tcl 25 Apr 2018 08:51:36 -0000 1.516 +++ openacs-4/packages/xowiki/tcl/xowiki-procs.tcl 25 Apr 2018 19:47:48 -0000 1.517 @@ -640,7 +640,7 @@ # mapped with the same name. set tree_id [lindex $tree_ids 0] array set data [category_tree::get_data $tree_id] - set categories [list] + set categories {} if {[info exists :__category_map]} {array set cm ${:__category_map}} foreach category [::xowiki::Category get_category_infos -tree_id $tree_id] { lassign $category category_id category_name deprecated_p level @@ -739,7 +739,7 @@ FormPage instproc map_values {map_type values} { # Map a list of values (for multi-valued form fields) # :log "map_values $map_type, $values" - set mapped_values [list] + set mapped_values {} foreach value $values {lappend mapped_values [:map_value $map_type $value]} return $mapped_values } @@ -802,7 +802,7 @@ # :log "+++ starting with instance_attributes [:instance_attributes]" array set use ${:__instance_attribute_map} array set multiple_index [list category 2 party_id 1 file 1] - set ia [list] + set ia {} foreach {name value} [:instance_attributes] { #:log "marshall check $name $value [info exists use($name)]" if {[info exists use($name)]} { @@ -835,7 +835,7 @@ } ad_try { acs_user::get -user_id $party_id -array info - set result [list] + set result {} foreach a {username email first_names last_name screen_name url} { lappend result $a $info($a) } @@ -987,7 +987,7 @@ # Apply reverse_map_value to a list of values (for multi-valued # form fields) :upvar $category_ids_name category_ids - set mapped_values [list] + set mapped_values {} foreach value $values { lappend mapped_values [:reverse_map_value \ -creation_user $creation_user -create_user_ids $create_user_ids \ @@ -1027,7 +1027,7 @@ # # The function will compute the category_ids, which are were used # to categorize this objects in the source instance. - set category_ids [list] + set category_ids {} #:msg "[:name] check cm=[info exists ::__xowiki_reverse_category_map] && iam=[info exists :__instance_attribute_map]" @@ -1039,7 +1039,7 @@ # # replace all symbolic category values by the mapped IDs # - set ia [list] + set ia {} array set use ${:__instance_attribute_map} array set multiple_index [list category 2 party_id 1 file 1] foreach {name value} [:instance_attributes] { @@ -2451,7 +2451,7 @@ # available variables. # # compute list of possible variables - set __varlist [list] + set __varlist {} set __template_variables__ "