Index: openacs-4/packages/xowf/tcl/xowf-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowf/tcl/xowf-procs.tcl,v diff -u -N -r1.24 -r1.25 --- openacs-4/packages/xowf/tcl/xowf-procs.tcl 21 May 2018 15:48:02 -0000 1.24 +++ openacs-4/packages/xowf/tcl/xowf-procs.tcl 7 Jul 2018 10:58:20 -0000 1.25 @@ -2195,7 +2195,11 @@ uplevel [::xowf::include_get -level 2 $wfName $vars] } - ad_proc include_get {{-level 1} wfName {vars ""}} { + ad_proc -private include_get {{-level 1} wfName {vars ""}} { + + Implement inclusion of worflow definitions. + + } { if {![string match "/packages/*/lib/*" $wfName]} { error "path leading to workflow name must look like /packages/*/lib/*" } Index: openacs-4/packages/xowiki/tcl/xowiki-mode-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/xowiki-mode-procs.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/xowiki/tcl/xowiki-mode-procs.tcl 7 Aug 2017 23:48:30 -0000 1.2 +++ openacs-4/packages/xowiki/tcl/xowiki-mode-procs.tcl 7 Jul 2018 10:58:20 -0000 1.3 @@ -41,7 +41,10 @@ return [ad_get_client_property -cache_only t xowiki $mode_name] } - :public method toggle {} { + :public method toggle {} { + # + # Switch state of the toggle + # set oldState [:get] :set [expr {!$oldState}] } Index: openacs-4/packages/xowiki/tcl/xowiki-uploader-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/xowiki-uploader-procs.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/xowiki/tcl/xowiki-uploader-procs.tcl 7 Aug 2017 23:48:31 -0000 1.2 +++ openacs-4/packages/xowiki/tcl/xowiki-uploader-procs.tcl 7 Jul 2018 10:58:20 -0000 1.3 @@ -19,14 +19,24 @@ :property tmpfile :property parent_object - :public method store_file {} {error "not implemented"} + :public method store_file {} { + # + # Abstract method. + # + + error "not implemented" + } } nx::Class create ::xowiki::UploadFile -superclass ::xowiki::Upload { # # Class for storing files as xowiki::File instances. # :public method store_file {} { + # + # Store the file provided via instance variables by using the + # formfield::file implementation. + # set f [::xowiki::formfield::file new -name upload -object ${:parent_object}] set file_object [$f store_file \ -file_name ${:file_name} \ Index: openacs-4/packages/xowiki/tcl/yui-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/yui-procs.tcl,v diff -u -N -r1.14 -r1.15 --- openacs-4/packages/xowiki/tcl/yui-procs.tcl 20 May 2018 11:01:57 -0000 1.14 +++ openacs-4/packages/xowiki/tcl/yui-procs.tcl 7 Jul 2018 10:58:20 -0000 1.15 @@ -17,7 +17,7 @@ header } - YUIMenuItemList ad_instproc render {} {} { + YUIMenuItemList instproc render {} { if {[info exists :header]} { html::h6 { html::t [:header] @@ -206,7 +206,7 @@ ::xo::tdom::Class create YUIMenuBarItem \ -superclass YUIMenuItem - YUIMenuBarItem ad_instproc init {} {} { + YUIMenuBarItem instproc init {} { #goto YUIMenuItem and set all those nice defaults next append :CSSclass " first-of-type" @@ -216,7 +216,7 @@ } } - YUIMenuBarItem ad_instproc render {} {} { + YUIMenuBarItem instproc render {} { set :extrajs "" set result [next] if {[info exists :__parent]} {