Index: openacs-4/packages/bug-tracker/tcl/bug-tracker-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/tcl/bug-tracker-procs.tcl,v
diff -u -N -r1.50 -r1.51
--- openacs-4/packages/bug-tracker/tcl/bug-tracker-procs.tcl 20 Apr 2016 07:53:22 -0000 1.50
+++ openacs-4/packages/bug-tracker/tcl/bug-tracker-procs.tcl 8 May 2016 13:06:06 -0000 1.51
@@ -1227,12 +1227,12 @@
open {
set status_where_clause "and bt_patches.status = :show_patch_status"
}
- all {
+ default {
set status_where_clause ""
}
}
- db_foreach get_patches_for_bug "" {
+ db_foreach get_patches_for_bug {} {
set status_indicator [ad_decode $show_patch_status "all" "($status)" ""]
lappend patch_list "[ns_quotehtml $summary] $status_indicator"
Index: openacs-4/packages/bug-tracker/www/bug.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/www/bug.tcl,v
diff -u -N -r1.50 -r1.51
--- openacs-4/packages/bug-tracker/www/bug.tcl 20 Oct 2015 07:18:13 -0000 1.50
+++ openacs-4/packages/bug-tracker/www/bug.tcl 8 May 2016 13:06:06 -0000 1.51
@@ -6,7 +6,7 @@
@cvs-id $Id$
} [bug_tracker::get_page_variables {
bug_number:integer,notnull
- {user_agent_p:boolean 0}
+ {user_agent_p:boolean,notnull false}
{show_patch_status:word open}
}]
@@ -310,7 +310,8 @@
# Display value for patches
set href_add [export_vars -base patch-add { { bug_number $bug(bug_number) } { component_id $bug(component_id) } }]
- set bug(patches_display) [subst {[bug_tracker::get_patch_links -bug_id $bug(bug_id) -show_patch_status $show_patch_status]
+ set bug(patches_display) [subst {
+ [bug_tracker::get_patch_links -bug_id $bug(bug_id) -show_patch_status $show_patch_status]
\[ [_ bug-tracker.Upload_Patch] \]}]
# Display value for related files
Index: openacs-4/packages/bug-tracker/www/index.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/www/index.tcl,v
diff -u -N -r1.20 -r1.21
--- openacs-4/packages/bug-tracker/www/index.tcl 17 Jun 2010 18:51:45 -0000 1.20
+++ openacs-4/packages/bug-tracker/www/index.tcl 8 May 2016 13:06:06 -0000 1.21
@@ -34,10 +34,14 @@
# TODO: Get /com/* URLs working again
# TODO: Other important suggestions from threads, etc.
# TODO: Bulk actions (set fix for version, reassign, etc.)
+# TODO: the input validity checking should be improved.
+if {[catch {
+ bug_tracker::bug::get_list -user_id $user_id
+} errorMsg]} {
+ ns_return 422 text/plain "invalid input: $errorMsg"
+} else {
+ bug_tracker::bug::get_multirow -user_id $user_id
+}
-bug_tracker::bug::get_list -user_id $user_id
-bug_tracker::bug::get_multirow -user_id $user_id
-
-