Index: openacs-4/packages/acs-admin/tcl/apm-admin-procs-oracle.xql =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/tcl/Attic/apm-admin-procs-oracle.xql,v diff -u -N --- openacs-4/packages/acs-admin/tcl/apm-admin-procs-oracle.xql 10 May 2001 13:50:10 -0000 1.3 +++ /dev/null 1 Jan 1970 00:00:00 -0000 @@ -1,19 +0,0 @@ - - - - oracle8.1.6 - - - - - select apm_package_version.version_name_greater(:version_name, highest.version_name) - from (select version_name - from apm_package_versions - where version_id = apm_package.highest_version(:package_key) - ) highest - - - - - - Index: openacs-4/packages/acs-admin/tcl/apm-admin-procs-postgresql.xql =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/tcl/Attic/apm-admin-procs-postgresql.xql,v diff -u -N --- openacs-4/packages/acs-admin/tcl/apm-admin-procs-postgresql.xql 11 Dec 2003 21:39:45 -0000 1.4 +++ /dev/null 1 Jan 1970 00:00:00 -0000 @@ -1,20 +0,0 @@ - - - - postgresql7.1 - - - - - - select apm_package_version__version_name_greater(:version_name, highest.version_name) - from (select version_name - from apm_package_versions - where version_id IN (select apm_package__highest_version(:package_key)) - ) highest - - - - - - Index: openacs-4/packages/acs-admin/tcl/apm-admin-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/tcl/apm-admin-procs.tcl,v diff -u -N -r1.21 -r1.22 --- openacs-4/packages/acs-admin/tcl/apm-admin-procs.tcl 7 Aug 2017 23:47:45 -0000 1.21 +++ openacs-4/packages/acs-admin/tcl/apm-admin-procs.tcl 25 Sep 2017 15:43:13 -0000 1.22 @@ -207,15 +207,11 @@
  • 1 if the version you gave is higher than the highest version installed, or no version of this package is installed. } { - - # DRB: I turned this into a simple select by rearranging the code and - # stuck the result into queryfiles. - - # LARS: Default to 1 (the package_key/version_name you supplied was higher than what's on the system) - # for the case where nothing it returned, because this implies that there was no highest version installed, - # i.e., no version at all of the package was installed. - - return [db_string apm_higher_version_installed_p {} -default 1] + set package_version_name [apm_highest_version_name $package_key] + if {$package_version_name eq ""} { + return 1 + } + return [apm_version_names_compare $version_name $package_version_name] }