Index: openacs-4/packages/ecommerce/tcl/ecds-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/ecommerce/tcl/ecds-procs.tcl,v diff -u -N -r1.2 -r1.3 --- openacs-4/packages/ecommerce/tcl/ecds-procs.tcl 12 Aug 2008 11:58:37 -0000 1.2 +++ openacs-4/packages/ecommerce/tcl/ecds-procs.tcl 15 Sep 2008 22:10:05 -0000 1.3 @@ -73,7 +73,7 @@ regsub -all -- { } $brandname_new {-} brandname_new set brandname_new [string trim [string tolower $brandname_new]] - set sku "${brandname_new}${product_sku}" + set sku "${brandname_new}-${product_sku}" } return $sku } @@ -137,16 +137,23 @@ } else { # get file from url - if { [catch {set get_id [ns_http queue GET $url]} err ]} { + if { [catch {set get_id [ns_http queue $url]} err ]} { set page $err + ns_log Error "ecds_get_url: url=$url error: $err" } else { ns_log Notice "ecds_get_url: ns_httping $url" set flags "" - set status [ns_http wait $get_id page] + if { [catch { ns_http wait -result page -status status -timeout "15:0" $get_id } err2 ]} { + ns_log Error "ecds_get_url: ns_http wait $err" + } - if { $page eq "timeout" } { + if { ![info exists status] || $status ne "200" } { # no page info returned, just return error - set page "Error: url timed out" + if { ![info exists status] } { + set status "not exists" + } + set page "Error: url timed out with status $status" + ns_log Notice $page } else { #ns_log Notice "ecds_get_url: adding page to file cache" #put page into file cache @@ -278,6 +285,7 @@ if { [catch {set get_id [ns_http queue GET $url]} err ]} { set page $err + ns_log Error "ecds_get_image_from_url: $error" } else { ns_log Notice "ecds_get_image_from_url: ns_httping $url" set flags ""