Index: openacs-4/packages/download/www/admin/approve-or-reject-2.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/download/www/admin/approve-or-reject-2.tcl,v diff -u -N -r1.7 -r1.8 --- openacs-4/packages/download/www/admin/approve-or-reject-2.tcl 18 Sep 2013 15:23:40 -0000 1.7 +++ openacs-4/packages/download/www/admin/approve-or-reject-2.tcl 30 Sep 2013 11:05:49 -0000 1.8 @@ -11,7 +11,7 @@ {return_url "[ad_conn package_url]"} } -validate { valid_action_value { - if { $action != "approve" && $action != "reject" } { + if { $action ne "approve" && $action ne "reject" } { ad_complain "The value for 'action' must be 'approve' or 'reject'" } } @@ -24,7 +24,7 @@ permission::require_permission -object_id $repository_id -privilege "admin" -if { $action == "approve" } { +if { $action eq "approve" } { set approved_p "t" set approval_action "approving" set approval_status "APPROVED" @@ -35,7 +35,7 @@ } # Here's where we update the database to set the version as approved -if [catch { +if {[catch { db_dml version_approve " update download_archive_revisions set approved_p = :approved_p, @@ -44,7 +44,7 @@ approved_date = sysdate where revision_id = :revision_id " -} errmsg] { +} errmsg]} { ad_return_error "Problem $approval_action version" "There was a problem $approval_action the version in the database. Here's the error message: $errmsg" return