Index: openacs-4/packages/contacts/lib/contacts.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/contacts/lib/contacts.tcl,v diff -u -r1.75 -r1.76 --- openacs-4/packages/contacts/lib/contacts.tcl 26 Apr 2018 08:56:38 -0000 1.75 +++ openacs-4/packages/contacts/lib/contacts.tcl 9 May 2018 15:33:30 -0000 1.76 @@ -1,7 +1,7 @@ -set required_param_list {} +set required_param_list [list] set optional_param_list [list base_url extend_p extend_values attr_val_name] set default_param_list [list orderby format query page page_size package_id search_id group_id] -set optional_unset_list {} +set optional_unset_list [list] # default values for default params set _orderby "first_names,asc" @@ -110,7 +110,7 @@ # We clear the list when no value is submited, otherwise # we acumulate the extend values. if { [empty_string_p $extend_option] } { - set extend_values {} + set extend_values [list] } else { lappend extend_values [list $extend_option] } @@ -149,7 +149,7 @@ } callback contacts::bulk_actions -multirow "bulk_acts" -set bulk_actions {} +set bulk_actions [list] template::multirow foreach bulk_acts { lappend bulk_actions $pretty $link $detailed } @@ -288,7 +288,7 @@ } -set elements {} +set elements [list] lappend elements contact [list \ label {$name_label} \ display_template { @@ -360,7 +360,7 @@ set date_format [lc_get formbuilder_date_format] -set actions {} +set actions [list] if { $admin_p && [exists_and_not_null search_id] } { set actions [list "[_ contacts.Set_default_extend]" "admin/ext-search-options?search_id=$search_id" "[_ contacts.Set_default_extend]" ] } @@ -379,17 +379,17 @@ -object_type $actual_object_type -set add_columns {} -set remove_columns {} -set db_extend_columns {} +set add_columns [list] +set remove_columns [list] +set db_extend_columns [list] if { $search_id ne "" } { # now we get the extensions for this specific search set db_extend_columns [contact::search::get_extensions -search_id $search_id] } set combined_extended_columns [lsort -unique [concat $db_extend_columns $extended_columns]] # we run through the multirow here to determine wether or not the columns are allowed -set report_elements {} +set report_elements [list] template::multirow foreach ext { set selected_p 0 set immutable_p 0 @@ -546,7 +546,7 @@ } - set party_ids {} + set party_ids [list] db_multirow contacts report_contacts_select {} { lappend party_ids $party_id } @@ -597,9 +597,9 @@ eval $command - set keys {} + set keys [list] template::multirow foreach contacts { - set key {} + set key [list] foreach {element details} $report_elements { if { $element ne "party_id" } { lappend key [set $element]