Index: openacs-4/packages/assessment/www/asm-admin/action-params.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/www/asm-admin/action-params.tcl,v
diff -u -r1.10 -r1.11
--- openacs-4/packages/assessment/www/asm-admin/action-params.tcl	7 Aug 2017 23:48:04 -0000	1.10
+++ openacs-4/packages/assessment/www/asm-admin/action-params.tcl	20 Jan 2018 22:38:28 -0000	1.11
@@ -36,7 +36,7 @@
 
 set new_assessment_revision $assessment_data(assessment_rev_id)
 
-if {([info exists by_item_p] && $by_item_p ne "")} {
+if {[info exists by_item_p] && $by_item_p ne ""} {
     set return_url "checks-admin?assessment_id=$assessment_id&section_id=$section_id"
     
     if {$by_item_p == 1} {
@@ -50,7 +50,8 @@
 set has_params_p [db_string has_params {} -default 0]
 
 if {$has_params_p == 0} {
-        ad_returnredirect "one-a?assessment_id=$assessment_id"
+    ad_returnredirect "one-a?assessment_id=$assessment_id"
+    ad_script_abort
 }
 
 set action_perform [db_string get_perform {} -default " "]
@@ -98,19 +99,27 @@
     
     set action_id $action_id
     db_foreach get_params {} {
-	set param_$parameter_id [as::assessment::check::get_parameter_value -parameter_id $parameter_id -type $type -check_id $inter_item_check_id]
+	set param_$parameter_id [as::assessment::check::get_parameter_value \
+                                     -parameter_id $parameter_id \
+                                     -type $type \
+                                     -check_id $inter_item_check_id]
 	if { [set param_$parameter_id] eq ""} {
 	    set param_$parameter_id [lindex $choices 0 1]
 	}
 	
     }
 } -edit_data {
     db_foreach get_params {} {
-	as::assessment::check::set_parameter_value -parameter_id $parameter_id -type $type -check_id $inter_item_check_id -value [set param_$parameter_id]
+	as::assessment::check::set_parameter_value \
+            -parameter_id $parameter_id \
+            -type $type \
+            -check_id $inter_item_check_id \
+            -value [set param_$parameter_id]
     }
     
 } -on_submit {
-    ad_returnredirect $return_url 
+    ad_returnredirect $return_url
+    ad_script_abort
 }