Index: openacs-4/packages/assessment/tcl/as-item-display-fu-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/tcl/as-item-display-fu-procs.tcl,v
diff -u -r1.4 -r1.5
--- openacs-4/packages/assessment/tcl/as-item-display-fu-procs.tcl	2 Sep 2008 17:21:29 -0000	1.4
+++ openacs-4/packages/assessment/tcl/as-item-display-fu-procs.tcl	27 Oct 2014 16:40:57 -0000	1.5
@@ -90,10 +90,10 @@
     Render an Item Display File Upload Type
 } {
     array set type [util_memoize [list as::item_display_f::data -type_id $type_id]]
-    if {[empty_string_p $required_p]} {
+    if {$required_p eq ""} {
 	set required_p f
     }
-    if {[empty_string_p $datatype]} {
+    if {$datatype eq ""} {
 	set datatype file
     }
 
@@ -102,7 +102,7 @@
 	set optional ",optional"
     }
     set param_list [list [list label \$title] [list help_text \$subtext] [list value \$default_value] [list html \$type(html_display_options)]]
-    if {![empty_string_p $type(abs_size)]} {
+    if {$type(abs_size) ne ""} {
 	lappend param_list [list maxlength $type(abs_size)]
     }
     set element_params [concat [list "$element\:file$optional"] $param_list]
@@ -159,7 +159,7 @@
 	db_dml update_section_in_assessment {}
 	set old_item_id $as_item_id
 
-	if {![db_0or1row item_display {}] || $object_type != "as_item_display_f"} {
+	if {![db_0or1row item_display {}] || $object_type ne "as_item_display_f"} {
 	    set as_item_display_id [as::item_display_f::new \
 					-html_display_options $html_options \
 					-abs_size $abs_size \