Index: openacs-4/packages/acs-tcl/tcl/test/file-test-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/test/file-test-procs.tcl,v diff -u -r1.8 -r1.9 --- openacs-4/packages/acs-tcl/tcl/test/file-test-procs.tcl 12 Feb 2009 15:51:23 -0000 1.8 +++ openacs-4/packages/acs-tcl/tcl/test/file-test-procs.tcl 17 Oct 2010 21:06:09 -0000 1.9 @@ -41,7 +41,7 @@ aa_log "$good good of $nfiles checked" } -aa_register_case -cats {smoke production_safe} -error_level notice files__tcl_file_common_errors { +aa_register_case -cats {smoke production_safe} -error_level error files__tcl_file_common_errors { Check for some common error patterns. @author Jeff Davis davis@xarg.net @@ -59,16 +59,18 @@ #inspect every tcl file in the directory tree starting with $startdir foreach file [ad_find_all_files -check_file_func ::tcl_p $startdir] { + if {[string match */acs-tcl/tcl/test/file-test-procs.tcl $file]} continue + set fp [open $file "r"] set data [read $fp] close $fp - if {![regexp {/packages/acs-tcl/tcl/test/acs-tcl-test-procs\.tcl$} $file match]} { - if {[string first @returns $data] < 0} { - aa_log_result fail "$file should not contain '@returns'. @returns is probably a typo of @return" - } - } + if {[string first @returns $data] > -1} { + aa_log_result fail "$file should not contain '@returns'. @returns is probably a typo of @return" + } + } + aa_log "Checked $count tcl files" }