Index: openacs-4/packages/acs-ldap-authentication/tcl/ldap-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-ldap-authentication/tcl/ldap-procs.tcl,v diff -u -r1.4 -r1.5 --- openacs-4/packages/acs-ldap-authentication/tcl/ldap-procs.tcl 23 Apr 2018 15:19:31 -0000 1.4 +++ openacs-4/packages/acs-ldap-authentication/tcl/ldap-procs.tcl 22 May 2018 16:44:55 -0000 1.5 @@ -367,13 +367,13 @@ ad_proc -private ldap_valid_value_p { value } { Checks that the value is not an LDAP error string } { - return [expr [string first "__LDAP_ERROR" $value] != 0] + return [expr {[string first "__LDAP_ERROR" $value] != 0}] } ad_proc -private ldap_valid_and_not_empty_p { value } { Checks that the value is not empty or an LDAP error string } { - return [expr ![empty_string_p $value] && [ldap_valid_value_p $value]] + return [expr {$value ne "" && [ldap_valid_value_p $value]}] } ad_proc -private ldap_make_dn { object_id } {