OpenACS / openacs-4 / packages / acs-tcl

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 71
Last Commit: 21 Jul
Commits this week: 0
Total Lines of Code (LoC): 5,752
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 15 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 05 May
6:37 pm

gustafn

backport from HEAD

Options
    • -2
    • +23
    ./security-procs.tcl
Thursday 03 Apr
7:16 pm

gustafn

Fixed snyk vulnerability check (backport from HEAD)

Snyk page has changed, we have to switch the pattern we are looking for.

Bumped version number to flage the change to "upgrade from repository"

Options
    • -2
    • +2
    ./utilities-procs.tcl
  2. … 1 more file in changeset.
Sunday 19 Jan
9:54 am

gustafn

fixed bug security::validated_host_header

Many thanks to Claudio Pasolini for reporting and identifying the problem!

Options
    • -2
    • +2
    ./security-procs.tcl
Friday 27 Dec 2024
7:25 pm

gustafn

Fixed bug in install-from-repository (issue #3472)

Install from repository (e.g., of /dotlrn) was horribly broken, see,

e.g., issue #3472. Furthermore, this bug was hard to debug, since it

showed up just during a complex installation attempts involving

install.xml, and it requires fetching from the repository. Therefore,

the debug rounds were quite time-consuming.

There were several problems involved:

1) dotlrn/install.xml was trying to set the theme to the

dotlrn-bootstrap3-theme, which was not loaded from the repository

2) The loading order was not correct, since the theme requires an

existing dotlrn instance to register the theme templates there.

3) The tests in install::xml::action::mount checking, if the package

was already mounted were incorrect, probably since many years. It

looks to me as some refactorings of the "get_node_id" semantics

(many years ago) were not reflected in this code. This bug let

the code assume, that the package was already mounted. Therefore,

the package was never mounted, causing a long tail of subsequent

issues.

4) the site_node::instantiate_and_mount call in

install::xml::action::mount was called with incorrect parameters,

causing overwriting of the site root node, leaving the site

completely unusable.

Bumped version number of acs-tcl to 5.10.2d1

Options
    • -8
    • +14
    ./install-procs.tcl
  2. … 1 more file in changeset.
6:31 pm

gustafn

fixed overquoting in "ad_progress_base_end"

Options
    • -2
    • +8
    ./defs-procs.tcl
1:32 pm

gustafn

fixed cut&paste problem

Options
    • -1210
    • +0
    ./install-procs.tcl
1:09 pm

gustafn

reset to released version to keep differences little

Options
    • -1
    • +1201
    ./install-procs.tcl
    • -13
    • +9
    ./site-nodes-procs.tcl
  3. … 1 more file in changeset.
10:50 am

gustafn

keep theme-stetting for dotlrn themes in dotlrn, since it requires a dotlrn instance

but when the dotlrn is installed, it requires the dotlrn-theme package to be installed

Options
    • -0
    • +2
    ./site-nodes-procs.tcl
  2. … 3 more files in changeset.
10:22 am

gustafn

Continue working on the install.xml issue.

Options
    • -8
    • +9
    ./site-nodes-procs.tcl
10:01 am

gustafn

added more debugging info

Options
    • -2
    • +7
    ./install-procs.tcl
    • -2
    • +2
    ./site-nodes-procs.tcl
9:29 am

gustafn

undo one more recent change

Options
    • -3
    • +3
    ./install-procs.tcl
9:15 am

gustafn

undo recent change. This was not the problem

Options
    • -5
    • +1
    ./install-procs.tcl
9:00 am

gustafn

added debug statement

Options
    • -0
    • +1
    ./site-nodes-procs.tcl
Thursday 26 Dec 2024
7:25 pm

gustafn

try to get a non-empty context id

Options
    • -3
    • +7
    ./install-procs.tcl
6:56 pm

gustafn

added debugging line

Options
    • -1
    • +8
    ./install-procs.tcl
6:32 pm

gustafn

Fixed incorrect result handling from ::acs::site_node get_node_id

When

::acs::site_node get_node_id -url /$mount_point

is executed with a non-existing mount point, the node info of the

parent_id is returned. The code assumed that for such cases, the

resulting "object_id" member is empty. Since this affects only the

two action procs

install::xml::action::mount

install::xml::action::mount-existing

i have adjusted the behavior there.

Furthermore, some tests are now less mind-twisted.

Options
    • -13
    • +11
    ./install-procs.tcl
Tuesday 24 Dec 2024
5:27 pm

gustafn

improved log messages

Options
    • -2
    • +3
    ./apm-install-procs.tcl
Tuesday 03 Sep 2024
2:59 pm

gustafn

small fix, when cookie times out and dotlrn is active

Options
    • -1
    • +4
    ./security-procs.tcl
Saturday 31 Aug 2024
11:46 am

gustafn

improved test case

- load first mime package before loading it

- provide version of the mime package in the test log

- don't provide ns_set id as "error"

Options
    • -9
    • +18
    ./test/html-email-procs.tcl
11:37 am

gustafn

documented command result

Options
    • -1
    • +3
    ./html-email-procs.tcl
Thursday 29 Aug 2024
10:37 am

gustafn

Use "ns_mkdtemp" when available to create temporary directories

Options
    • -0
    • +1
    ./00-icanuse-procs.tcl
    • -13
    • +27
    ./utilities-procs.tcl
Wednesday 28 Aug 2024
4:27 pm

gustafn

cleanup tmp directories created by the acs-tcl regression test

Options
    • -0
    • +2
    ./test/apm-file-procs.tcl
    • -0
    • +3
    ./test/utilities-procs.tcl
8:44 am

gustafn

whitespace changes

Options
    • -1
    • +0
    ./00-acs-tcl-init.tcl
    • -1
    • +1
    ./acs-cache-init.tcl
    • -1
    • +1
    ./acs-container-procs.tcl
    • -2
    • +96
    ./deprecated-procs.tcl
    • -2
    • +2
    ./ds-stub-procs.tcl
    • -5
    • +5
    ./html-email-procs.tcl
    • -2
    • +1
    ./http-auth-procs.tcl
    • -3
    • +3
    ./json-procs.tcl
    • -2
    • +2
    ./memoize-procs.tcl
    • -3
    • +3
    ./pdf-procs.tcl
    • -1
    • +1
    ./site-nodes-procs.tcl
    • -105
    • +0
    ./sql-statement-procs.tcl
    • -1
    • +0
    ./test/acs-db-00-procs.tcl
    • -1
    • +1
    ./test/acs-tcl-apm-procs.tcl
    • -4
    • +4
    ./test/acs-tcl-test-procs.tcl
  16. … 7 more files in changeset.
8:32 am

gustafn

improve source code documentation

Options
    • -3
    • +6
    ./request-processor-procs.tcl
8:32 am

gustafn

added icanuse handler for "ns_info meminfo"

Options
    • -0
    • +1
    ./00-icanuse-procs.tcl
8:31 am

gustafn

new function: ad_unless_script_abort and bump version to 5.10.1b12

This convenience function eases handling of ad_script_abort exceptions

in cases, where the OpenACS request processor is not involved.

From the documentation:

Execute the provided body in the callers' environment. When the

body does not raise an "ad_script_abort" exception, the

"non_abort_action" is also executed. This pattern is useful when

handling client requests and where the "non_abort_action" is used

to return results to the client. When "ad_script_abort" is

executed, the connection is usually closed, and any attempt to

talk to the client over the closed connection will fail.

The handling of script_abort exceptions is done usually in the

request processor. The function is useful when registering own

request procs (e.g., via "ns_register_proc") where the OpenACS

request processor is not involved.

bumped version to 5.10.1b12

Options
    • -1
    • +35
    ./exception-procs.tcl
  2. … 1 more file in changeset.
Tuesday 27 Aug 2024
7:24 pm

gustafn

take out "nsstats" from the tests for page_contracts

Options
    • -5
    • +6
    ./test/file-test-procs.tcl
    • -49
    • +0
    ./test/log-test-procs.tcl
4:06 pm

gustafn

silence regression test

Options
    • -1
    • +3
    ./test/doc-check-procs.tcl
    • -1
    • +4
    ./test/security-procs.tcl
3:55 pm

gustafn

reduce verbosity during regression test

Options
    • -1
    • +5
    ./test/acs-tcl-test-procs.tcl
    • -6
    • +4
    ./test/ad-proc-test-procs.tcl
3:37 pm

gustafn

do not complain about expected behavior

Options
    • -7
    • +7
    ./apm-install-procs.tcl