40-db-query-dispatcher-procs.tcl

  • last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
improve spelling

  1. … 2 more files in changeset.
improve spelling

  1. … 8 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
Rework variable assigning loops (set -> lassign) + Whitespace changes

  1. … 13 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 71 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

    • -16
    • +16
    ./40-db-query-dispatcher-procs.tcl
  1. … 7834 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

    • -25
    • +41
    ./40-db-query-dispatcher-procs.tcl
  1. … 2547 more files in changeset.
- cleanup and minor performance improvements

    • -16
    • +13
    ./40-db-query-dispatcher-procs.tcl
  1. … 1 more file in changeset.
- abstract in check for existance of a command whether this is scripted or not

- use a more modern tcl command set

  1. … 12 more files in changeset.
Normalizing string comparison operations into tcl 8.4 operations, enabling byte-code compilation for expressions and many conditionals

    • -23
    • +23
    ./40-db-query-dispatcher-procs.tcl
  1. … 367 more files in changeset.
Fixed bug 2961 by applying Christian Brechbühler's patch

  1. … 1 more file in changeset.
change ad_verify_and_get_user_id to ad_conn user_id, change ad_maybe_redirect_for_registration to auth::require_login, make some db_ and dt_ function -public

    • -35
    • +48
    ./40-db-query-dispatcher-procs.tcl
  1. … 689 more files in changeset.
comment out db_qd_log calls as almost noone will use these anymore and some added appreciable overhead. warn when a proc does not yield a statement name with advice about why, fix the bootstrap version of acs_kernel_id to cache

    • -46
    • +46
    ./40-db-query-dispatcher-procs.tcl
  1. … 1 more file in changeset.
when parsing a xql file fails, it seems appropriate to log this in the error log

-Replaced nsxml with tDOM (http://tdom.org), a much faster & richer XML parser, and XSLT and XPath processor.

  1. … 3 more files in changeset.
merge of 4.6.3b1 to HEAD

  1. … 101 more files in changeset.
making the query *NOT* compatible error message more informative by logging the db version of the query as well as the system db version

logging stack trace when a query file cannot be parsed

when an xql query is not loaded because of too high version number in the xql file - issue an error message in the log file

Merge of all changes from oacs-4-6 to HEAD. All changes up to tag jcd-merge-2

on oacs-4-6 are included.

  1. … 33 more files in changeset.
merge from oacs-4-6

  1. … 110 more files in changeset.
When query dispatcher lookup fails and the default SQL is empty, bomb.

fix calls with literals instead of variables

  1. … 3 more files in changeset.
added ad_proc docs to procs and an ad_proc stub for if ad_proc absent

    • -80
    • +171
    ./40-db-query-dispatcher-procs.tcl
reduced debug output by setting db_qd_log level to QDDebug in most log stmts

    • -45
    • +56
    ./40-db-query-dispatcher-procs.tcl

1. Changed a lot of package info files to fix problems ...

2. Added Vinod's bboard patch

3. Rationalized party e-mail checking by putting a "before insert or update"

trigger on the table that lower-cases email (this was already done by the

party.new() func but at least one update missed this). Got rid of all

"lower(email) = " and "upper(email) = " checks and just made all use the

db email column directly and lower-cased Tcl vars. In this way the index

on the email column is always and consistently used without needing to

define functional indexes on the column (an EE feature for Oracle).

4. Rationalized naming of a couple of workflows and fixed a glossary PG bug

where apparently its workflow got overwritten by one from the CMS at some

point in time.

5. Made the .cmp/.dat/.frm filters in the template code usable though not

very beautiful nor exactly correct. But with practice you can use them

to debug pages in the packages/* hierarchy. I also turned these off by

default as there's no need to run these filters on a production site!

6. Performed minor surgery on templating, including adding a new

"ad_return_exception_template" that allows you to return a templated

error page and aborts the script.

7. ??? probably but I think this covers most stuff.

  1. … 74 more files in changeset.
fixed version checking error

1. changed db_qd_log to use the passed-in level rather than gluing things

to "Debug" for convenience. I then changed all the "Notice" calls to

"Debug". Then my one "Error" call I added worked! :) If a query file

has a syntax error in it now, an error is logged to the server log but

bootstrapping continues.

2. Lots and lots or etp oracle fixes and some PG version clean-ups

3. Some file-storage files were unconventionally named.

    • -42
    • +44
    ./40-db-query-dispatcher-procs.tcl
  1. … 17 more files in changeset.
slight change to db_qd_get_fullname that compensates for procs that are called with the global namespace qualifier - ::foo versus foo.

Fixed a few spelling mistakes

Ported a bunch more of acs-subsite

Fixed a few small, acs-subsite related bugs

  1. … 41 more files in changeset.