• last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

Changeset {id} does not exist.

Extended "ad_conn behind_secure_proxy_p"

This test will be now true, when either the recieved request

contains one of those request header fields.

- "X-SSL-Request: 1"

- "X-Forwarded-Proto: https"

Before, only the first variant was accepted.

The AWS load balancer uses the second variant.

whitespace changes

Fixed potential infinie loop when source code looks like an regexp call

The api-code prettifier contains several heuristics for prettifying

source code without being a proper parser. It contains a

"Hack for nasty regexp stuff" which could run potentially into an infinite

parsing loop. This change fixes an acutal bug on openacs.org for file [1]

which is site-local.

[1] https://openacs.org/api-doc/procs-file-view?path=packages/xowf/tcl/openacs-procs.tcl&version_id=5526548&source_p=1

fix typo

Permit "lang::message::cache" in acs::clusterwide operations

improvement for ACS clusters

Incorporated changes as suggested by Jonathan Kelley

For details, see https://openacs.org/forums/message-post?parent_id=5814308

Base "ad_conn behind_proxy_p" on "ns_conn details" when available

Inject a reference to the current connection package into the tinymce conf (when used outside of xowiki)

Fix file metadata

Provide a reference to the current object when configuring tinymce

Allow to completely override the imageSelectorDialog URL downstream

Fix typo

Don't trigger the "too long without artifacts" timeout in case we are just doing dummy uploads

Fallback to the editor from parameter in the generic api, rather than the widget, so fallback will work also outside of ad_form

Introduce for richtext editors the concept of "preset"

A preset is an abstract set configurations designed to address a specific use case.

An example could be a preset for a "minimal" richtext editor, used in those forms where we want to limit the features a user should have access to. Other presets could address specific usages or applications.

Downstream developers can provide a set of ::richtext::$editor::preset::$preset procs, returning an options dict. This set of options will be merged other local configurations.

The same approach works in ad_forms and xowiki forms.

This also enables the use-case of switching to a different editor maintaining the existing application-specific configurations consistent.

Drop the old approacs based on ::acs_blank_master__htmlareas and use explicit id configuration

TinyMCE XoWiki formfield integration

We introduce a new richtext mixin richtext::tinymce, requiring the richtext-tinymce package, currently integrating TinyMCE editor 7.0.1.

This implementation has been tested with regular, repeat, compound and repeatedcompound fields.

Downstream implementations based on this formfield can customize the editor configuration further, e.g. provide custom plugins via the api parameters.

    • -3
    • +3
    /openacs-4/packages/xowiki/xowiki.info
Move hardcoded configuration out of the default (can be overridden by parameter in case), add image and code plugins in the default, set branding to false by default

Add a richtext to the test formfields specifications

Move back richtext formfield implementations in form-field-procs

Moving to a different file may affect dependencies defined on form-field-procs that also expect the richtext editor to be loaded. As breaking changes are not desirable now, we revert this reform.

Add minimal styling to inline editors

file style.css was initially added on branch oacs-5-10.

Allow to serialize also object options, allow to only include the header stuff

Cleanup leftover code from successful reform in December 2016

Since then, we have been long using dynamic repeat fields on production

    • -15
    • +5
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
Move the specific richtext-editor implementations into an own file

file richtext-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/xowiki/tcl/richtext-procs.tcl
Rework the add_editor api so that it won't rely on global templating variables and fix both configuration from defaults and local

Harden the page contract and ensure that:

- for chat rooms in the chat package, only the chat class enforcing permissions is used

- for other chat ids, either the id is an object the user can read, or the user can at least read on the current connection package

Cleanup old parameter on upgraded installations

file apm-callback-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/richtext-tinymce/tcl/apm-callback-procs.tcl