• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Whitespace changes

Whitespace changes

ad_form: allow multiple files in 'template::widget::file' by using the 'multiple' attribute of the input tag, new on HTML5.

- Pass the 'multiple' flag to 'template::element::create', so it can be used by widgets to modify their behavior.

- Update 'template::element::create' doc.

- This opens the door to reducing the number of widgets by combining single and multivalued ones into one (for instance, 'multiselect' and 'select' widgets), in the same way the 'file' widget does now.

improve comments and linebreaks

modernize code: use resolver variables rather than method calls

modernize code: use resolver variables rather than method calls

    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/weblog-procs.tcl
    • -40
    • +40
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
    • -5
    • +5
    /openacs-4/packages/xowf/lib/clicker-answer.wf
    • -17
    • +17
    /openacs-4/packages/xowf/lib/online-exam-answer.wf
    • -18
    • +18
    /openacs-4/packages/xowf/lib/online-exam.wf
    • -19
    • +15
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
fix typo

add "blob" to the checked attributes

remove xotcl-core specific per-request caching, since acs-tcl performs nowadays as well per-request caching on permissions

fix typos

enforce the system locale for the resolver test

replace anonymous array by Tcl dicts

reduce XOTcl 1.* idioms

modernize code: use resolver variables rather than method calls

    • -59
    • +56
    /openacs-4/packages/xowiki/tcl/link-procs.tcl
extend test cases

add safety belt and hint for pretty_link invocations with unknown target pages

    • -1
    • +12
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
remove xotcl-1 idioms

    • -9
    • +10
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
fix potential confusion for test cases: make sure, the provided name and nls_language are aligned

    • -3
    • +7
    /openacs-4/packages/xowiki/www/admin/test.tcl
add checking for javascript and data protocols (fixes issue #3413)

fix broken test cases

make debugging line more meaningful

Adapt proc doc to implementation, as we are dealing with files in general, instead of only images.

Comment log statement: found_id might not be an object by the time this code is executed

    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
whitespace changes

add test for ambiguous page link with language prefix

add page p0 to regression test, provide more logging

    • -3
    • +6
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
reduce verbosity

    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
As stated in xowiki::Package.item_ref, a trailing slash indicates a folder in case of ambiguity

Use a safer varname for xowf tests as well

As apparently test init cases can pollute each other's namespace, use a different variable name