• last updated 20 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove obsolete code:

- unreferenced oracle query

- Markup about installed Services that would not be displayed in the adp

Rework publicly exposed query:

- inner join immediately with site_nodes_selection so query can terminate quickly when user site map is empty

- clarify query meaning

Whitespace cleanup

Remove obsolete xql files

Reduce divergency between oracle and postgres codebase

Fix typo

Remove obsolete xql files

Add proc ad_html_text_convertable_p as deprecated to improve backwards compatibility

The old name ad_html_text_convertable_p contained a spelling

error and was replaced by ad_html_text_convertible_p.

admin_p and user_p are actually never displayed, so it doesn't make sense to have them in the select clause. What makes sense is that we filter for those chats we can actually access

    • -5
    • +3
    /openacs-4/packages/chat/www/index.tcl
base_url is in fact just the package_url from the connection

    • -3
    • +2
    /openacs-4/packages/chat/www/index.tcl
base_url can be computed just once

    • -4
    • +5
    /openacs-4/packages/chat/www/index.tcl
Reduce divergency between oracle and postgres codebase and make the query less awkward

    • -20
    • +0
    /openacs-4/packages/chat/www/index-oracle.xql
    • -2
    • +20
    /openacs-4/packages/chat/www/index.tcl
Don't overquote URL

    • -2
    • +1
    /openacs-4/packages/chat/www/index.tcl
Replace legacy syntax (these are one-time operations)

Reduce divergency between oracle and postgres codebase

Reduce divergency between oracle and postgres codebase

Further document why people should not expect many results from this page

Pass the creation user to the transcript object, as this proc is often called via scheduled procedure and won't find one otherwise

Reduce divergency between oracle and postgres codebase

Reduce divergency between oracle and postgres codebase

Reduce divergency between oracle and postgres codebase, streamline idiom

Remove leftover files

Reduce divergency between oracle and postgres codebase

Fix typo

Reduce divergency between oracle and postgres codebase

Reduce divergency between oracle and postgres codebase

Reduce divergency between oracle and postgres codebase

Reduce divergency between oracle and postgres codebase

Reduce divergency between oracle and postgres codebase

Reduce divergency between oracle and postgres codebase