OpenACS

openacs-4

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 5
Total Committers: 143
Last Commit: 23 Apr
Commits this week: 5
Total Lines of Code (LoC): 5,629,491
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 11 Feb 2019
12:57 pm

gustafn

parameter::get_from_package_key: check as well in "global" package parameter

and make clear, that lookup from non-singleton packages does not make

sense.

Options
    • -13
    • +36
    ./packages/acs-tcl/tcl/parameter-procs.tcl
12:53 pm

gustafn

fix typos

Options
    • -2
    • +2
    ./packages/acs-tcl/tcl/form-processing-procs.tcl
12:52 pm

gustafn

improve comments, make function private to avoid confusions

Options
    • -2
    • +9
    ./packages/acs-tcl/tcl/security-procs.tcl
12:47 pm

gustafn

improve comment

Options
    • -1
    • +1
    ./packages/acs-tcl/tcl/acs-cache-procs.tcl
12:46 pm

gernst

Make sure variable is an array

Options
    • -2
    • +2
    ./packages/new-portal/tcl/portal-procs.tcl
12:45 pm

gustafn

no need to call private function

Options
    • -1
    • +1
    ./packages/search/tcl/search-init.tcl
12:45 pm

gustafn

follow usual naming conventions

Options
    • -3
    • +3
    ./packages/acs-subsite/tcl/subsite-procs.tcl
    • -13
    • +13
    ./packages/acs-tcl/tcl/apm-procs.tcl
    • -3
    • +3
    ./packages/acs-tcl/tcl/request-processor-procs.tcl
12:42 pm

gustafn

no need to call private function of other package

Options
    • -2
    • +2
    ./packages/acs-bootstrap-installer/bootstrap.tcl
11:11 am

gustafn

Ease usage of util_memoize during startup. let util_memoize succeed,

even when the cache is not yet created

Options
    • -22
    • +31
    ./packages/acs-tcl/tcl/memoize-procs-aolserver.tcl
    • -4
    • +13
    ./packages/acs-tcl/tcl/memoize-procs-naviserver.tcl
11:06 am

gustafn

use separate urlspace for site-node cache to reduce lock contention

Options
    • -6
    • +8
    ./packages/acs-tcl/tcl/site-nodes-procs.tcl
10:56 am

gustafn

prefer inline SQL over generic xql to make apm code usable during initialization

Options
    • -2
    • +8
    ./packages/acs-tcl/tcl/defs-procs.tcl
    • -23
    • +0
    ./packages/acs-tcl/tcl/defs-procs.xql
Saturday 09 Feb 2019
2:58 pm

antoniop

ad_form reform:

- use actual flags instead of parsing arguments all the time

- retrieve proc flags from ad_proc definition (TODO: have some api for this?)

- follow the thread of peculiar ad_form logic to fix new csrf signing feature

- improve documentation using @param instead of manual formatting

- leave some note to travellers in the code

Options
    • -243
    • +229
    ./packages/acs-tcl/tcl/form-processing-procs.tcl
1:18 am

gustafn

new parameter "fallback_languages":

Specify space delimited two character codes for checking default languages. When this parameter is non-empty, try to get the page in the specified languages as fallback rather than offering a link for creation of a page in the requested locale. Per default this paramter is empty.

Options
    • -3
    • +3
    ./packages/xowiki/xowiki.info
    • -6
    • +10
    ./packages/xowiki/tcl/package-procs.tcl
Friday 08 Feb 2019
6:11 pm

antoniop

Reinstate reworked versions of some oracle database utilities left behind during solution of bug #3302

Rework is based on coding style observed in code provided by Brian Fenton, but could still not be tested. See https://openacs.org/bugtracker/openacs/bug?bug_number=3302

Options
    • -2
    • +2
    ./packages/acs-kernel/acs-kernel.info
    • -1
    • +187
    ./packages/acs-kernel/sql/oracle/utilities-create.sql
    • -0
    • +353
    ./packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.0d11-5.10.0d12.sql
4:04 pm

antoniop

Fix typo (thanks to Thomas Renner)

Options
    • -2
    • +2
    ./packages/acs-tcl/tcl/00-database-procs.tcl
2:00 pm

gustafn

reduce redirects

Options
    • -1
    • +1
    ./packages/acs-authentication/www/doc/configure-batch-sync.adp
    • -1
    • +1
    ./packages/acs-authentication/www/doc/ext-auth-design.adp
    • -1
    • +1
    ./packages/acs-authentication/www/doc/ext-auth-install.adp
    • -2
    • +2
    ./packages/acs-authentication/www/doc/ext-auth-ldap-install.adp
    • -1
    • +1
    ./packages/acs-authentication/www/doc/ext-auth-pam-install.adp
    • -1
    • +1
    ./packages/acs-authentication/www/doc/ims-sync-driver-design.adp
    • -1
    • +1
    ./packages/acs-authentication/www/doc/index.adp
    • -3
    • +3
    ./packages/news/www/doc/design.adp
    • -1
    • +1
    ./packages/news/www/doc/index.adp
    • -1
    • +1
    ./packages/news/www/doc/requirements.adp
1:40 pm

antoniop

Fix comment

Options
    • -2
    • +2
    ./packages/acs-subsite/tcl/group-procs.tcl
1:37 pm

antoniop

Add flushing of user permissions as well when adding to a new group, extend comments

Options
    • -1
    • +9
    ./packages/acs-subsite/tcl/group-procs.tcl
3:46 am

gustafn

whitespace and comment changes

Options
    • -6
    • +11
    ./packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
3:15 am

gustafn

- make sure to get rid over overdue elements from statistics

- improve comments

Options
    • -28
    • +37
    ./packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
2:19 am

gustafn

reflow overlong lines in comments

Options
    • -52
    • +75
    ./packages/acs-tcl/tcl/form-processing-procs.tcl
2:07 am

gustafn

ad_form: Add optional parameter -csrf_protection_p (defaults to false)

Options
    • -5
    • +35
    ./packages/acs-tcl/tcl/form-processing-procs.tcl
1:43 am

gustafn

white space changes

Options
    • -12
    • +19
    ./packages/acs-tcl/tcl/form-processing-procs.tcl
1:41 am

gustafn

simplify code

Options
    • -13
    • +3
    ./packages/acs-tcl/tcl/form-processing-procs.tcl
Thursday 07 Feb 2019
11:31 pm

antoniop

Cleanup not more relevant comments, remove idiom meant to work in the context of a db_with_handle we are not using anymore

Options
    • -5
    • +2
    ./packages/acs-tcl/tcl/00-database-procs.tcl
7:24 pm

antoniop

Reuse already existing db_list_of_ns_sets inside db_foreach and db_list_of_lists, as it uses the most native return type: the ns_set

Options
    • -41
    • +20
    ./packages/acs-tcl/tcl/00-database-procs.tcl
7:03 pm

gustafn

reduce verbosity

Options
    • -2
    • +2
    ./packages/acs-tcl/tcl/request-processor-procs.tcl
5:03 pm

antoniop

Operate on the original list to not incur in possible memory foortprint inflation via lrange

Options
    • -7
    • +10
    ./packages/acs-tcl/tcl/00-database-procs.tcl
3:08 pm

antoniop

Exploit new -with_headers flag in db_list_of_lists to reimplement db_foreach in a way that only one db handle is used

Advantages:

- api is now transaction safe (with respect to database operations executed in the code block)

- nested db_foreach statements won't risk to occupy all available handles anymore

Possible drawbacks:

- query result needs to be completely stored inside a list before looping

- calling stack is now one level deeper...

This passes automated tests

Options
    • -52
    • +53
    ./packages/acs-tcl/tcl/00-database-procs.tcl
2:07 pm

antoniop

Reduce code duplication

Options
    • -20
    • +13
    ./packages/acs-tcl/tcl/00-database-procs.tcl