• last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
added a test for checking the results of the preview of test-items

Since the preview workflow requires a multiple redirects, xowiki::test::edit_form_page

requires a new flag refetch to actually turn off automatic refetching of the result

page, since this does not give us access to the redirect location returned by

the edit command.

    • -26
    • +75
    ./xowf/tcl/test/test-item-procs.tcl
    • -13
    • +17
    ./xowiki/tcl/test/test-procs.tcl
include item_id in result dict of ::xowiki::test::create_form_page

this makes it possible to perform further checks without refetch by name

fixed test case

returned violation on plain instance

    • -5
    • +10
    ./xowiki/tcl/test/xowiki-test-procs.tcl
added test case for composite test item

    • -0
    • +174
    ./xowf/tcl/test/test-item-procs.tcl
New automated test for a page, including another page, which includes a picture, checking that everything works as expected

    • -0
    • +150
    ./xowiki/tcl/test/xowiki-test-procs.tcl
output warning message, in case form constraints could not be parsed

Differentiate the case of a field being a repeat field or a "normal" coumpound field: in the first case, the whole 'internal' should be converted regardless of the number of components, in the latter, keep the previous behavior

Fixes xowiki create_form_with_numeric after regression in https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Aantoniop%3A20220117174044

fix broken regression test

VS: ----------------------------------------------------------------------

    • -4
    • +7
    ./acs-api-browser/tcl/acs-api-documentation-procs.tcl
Do not apply the new convert_to_external to repeat fields, stick with the previous behavior

Fixes xowiki create_form_with_form_instance automated test

    • -2
    • +2
    ./acs-api-browser/tcl/acs-api-documentation-procs.tcl
Added question_ids to "details" in grading info and to the "__results" property

All of test-items is name-based to support input/export from different

OpenACS instances. In some situations, it is still necessary to pinpoint

the origin of questions, e.g. when importing pool-questions to an external

gradebook, where e.g. one wants to associate a replacement questions with

the original pool question.

Now we keep an additional question id, which will point to the pool question

or the simple question together with the question names. The instance

attribute "__results" is set once the exam-protocol was rendered

completely.

__results {

UID1 {

QN1 {achieved 4 achievable 6 question_id 187610}

QN2 {achieved 0.0 achievable 1 question_id 163716}

QN3 (achieved 0.0 achievable 2 question_id 163714}

}

UID2 ...

}

added comments and portlets locations for default ports

xotcl/chache: added button to flush all caches

security::locations: return configured servers from the driver/servers section

additionally, improve caching

    • -60
    • +110
    ./acs-tcl/tcl/security-procs.tcl
improve spelling

validate format of richtext field always

    • -2
    • +2
    ./acs-templating/tcl/richtext-procs.tcl
tighten page_contract to mitigate certain attacks

improve readability of generated HTML

added "@see" to deprecated proc

improve warning message

get rid of legacy message key "menu-Clipboard-Copy"; "menu-Clipboard-Use-Copy" is used since several years instead

    • -1
    • +0
    ./xowiki/catalog/xowiki.ru_RU.utf-8.xml
Remove unopened tag

Quote URL in the redirect

Whitespace cleanup

    • -11
    • +11
    ./acs-subsite/www/user/password-update.tcl
Test ::xowf::Package proc create_new_workflow_page

    • -0
    • +71
    ./xowf/tcl/test/xowf-test-procs.tcl
Mark api as tested

    • -1
    • +2
    ./acs-content-repository/tcl/test/content-item-test-procs.tcl
Test content::item::content_is_null public api, which has immediately found a typo

    • -2
    • +2
    ./acs-content-repository/tcl/content-item-procs.tcl
    • -1
    • +52
    ./acs-content-repository/tcl/test/content-item-test-procs.tcl
improved prepared-statement handling

- avoid separate SQL statement for testing, whether prepared statement

exists already in the SQL session.

- use true SQL session-id (obtained via "ns_pg pid") when available

- improve source code documentation

    • -25
    • +50
    ./xotcl-core/tcl/05-db-procs.tcl
added @see tags for deprecated commands

ease tracking of warnings of check_deprecated test

This change actually needs the newest api-doc, but we can't add the cyclic dependency

    • -2
    • +2
    ./acs-tcl/tcl/test/doc-check-procs.tcl