• last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Updates for upload_interaction:

- allow lecturer to specify number of file, which can be uploaded

- handle singular/plural labels for attachment/attachments

- handle singular/plural labels for Students submitting files

- styling improvements

- bump version number to get as well message catalog updates from xowiki

    • -0
    • +3
    ./xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -0
    • +2
    ./xowf/catalog/xowf.en_US.ISO-8859-1.xml
    • -0
    • +5
    ./xowf/www/resources/form-generator.css
bump version number to force update of message catalog

Improved styling of delete buttons

Added code to configure file-upload button (for now deactivated)

improve spelling and comments

    • -11
    • +11
    ./xowiki/tcl/xowiki-www-procs.tcl
improve spelling

    • -12
    • +12
    ./xowiki/tcl/test/xowiki-admin-tests-procs.tcl
form-field repeat: make "add another" label configurable per form-field type

fix typo

make clear from the user-interface that admin is managing the notifications of someone else

Let admin manage notifications of a user

Otherwise, we have currently no user-interface to e.g. unsubscribe the notifications of a user

to avoid sending mails to a domain (which might be in user by some other organization).

Improve handling of cases, where the exam was closed, but some exam-takers have not submitted their results.

Essentially this change avoids an error message and repeated messages, which might

come form autosaving or other ajax calls.

    • -42
    • +63
    ./xowf/lib/inclass-exam-answer.wf
provide compatibility for Tcl versions before tcl 8.6.2

    • -1
    • +0
    ./acs-tcl/tcl/test/00-icanuse-procs.tcl
Revert to previous strategy of determining available subcommands.

Running the provided subcommand is dangerous, since the command might

have side effects, might require connections, etc.

The feature test for "ns_http run" was incorrect, since it was not

introduced with 4.99.15 (as the comment suggested), but already with

4.99.4 (2017)... but at this time, the command did not return a dict,

which is assumed in the http-client procs. One can use "ns_http stats"

as an indicator for this feature, which was introduced at the time

when "ns_http run" was starting to return dicts as results.

Provide a more precise name for the feature test of ns_http returning

dicts (naming the feature simply "ns_http" is not a good idea, since

the command could of course be used already before the feature change).

    • -14
    • +19
    ./acs-tcl/tcl/00-icanuse-procs.tcl
    • -1
    • +1
    ./acs-tcl/tcl/test/00-icanuse-procs.tcl
use 'self' for "security::csp::require object-src" instead of 'none' since the latter is non-incremental

don't create a cache, which is not needed

Fix proc name

    • -2
    • +2
    ./acs-automated-testing/tcl/aa-test-procs.tcl
Do not improperly rely on apm_version_names_compare to check for NaviServer version number, use a more reliable capability check instead

Change the regexp so that we catch multiple kinds of error pattern indicating the subcommand does not exist: NaviServer and Tcl return sligthly different error messages

Extend test to expose that we need a better idiom to detect also NaviServer commands

    • -0
    • +14
    ./acs-tcl/tcl/test/00-icanuse-procs.tcl
Use a different idiom to detect if a command supports a subcommand, fixing acs-tcl.acs__command_has_subcommand automated test

Fix wording

    • -2
    • +2
    ./acs-tcl/tcl/test/00-icanuse-procs.tcl
New test for acs::cmd_has_subcommand exposing how flags at the beginning and end of the error message are not properly recognized

    • -0
    • +49
    ./acs-tcl/tcl/test/00-icanuse-procs.tcl
file 00-icanuse-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./acs-tcl/tcl/test/00-icanuse-procs.tcl
ensure, that the minimal set of controls is provided, also, when there are hidden form fields

improve spelling

since the form-field "file" supports the file multiple attribute, the internal representation is as well a list.

this change takes now as file-name for the local renderer as well the first file name list element.

add the original filename to the generated url, so that it is also delivered to the user

Keep supporting the previous proc signature, throwing a warning

util::http should provide enough fallback via curl already without targeting specific Naviserver versions, use other fallbacks only when no implementation is available

Fix webserver version check using 'apm_version_names_compare' for rc versions.

Between 4.99.6 and 4.99.20rc1, for example, 'apm_version_names_compare' will consider the latter to be the lowest.

As this is not the expected behavior for webserver version check, this patch just removes the rc part of the version before comparing in the few cases where this is done, and should be removed if the behavior changes in the future.

Fix version check