• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

Changeset MAIN:gustafn:20190512195544:1 does not match your current filter (clear filter).

file xowiki-bootstrap3-specific.css was initially added on branch oacs-5-10.

    • -0
    • +0
    ./xowiki/www/resources/xowiki-bootstrap3-specific.css
file xowiki-yui-specific.css was initially added on branch oacs-5-10.

    • -0
    • +0
    ./xowiki/www/resources/xowiki-yui-specific.css
improve wording for clipboard entries in menubar pulldown

break long lines

improve comments and indentation

    • -6
    • +21
    ./xowiki/tcl/xowiki-utility-procs.tcl
make handling of form parameters more uniform

template::add_event_listener: use more compact form in most simple cases

    • -5
    • +10
    ./acs-templating/tcl/head-procs.tcl
replaced YUI dnd by HTML5 dnd and therefor removed need of YUI in candidate_box_select.

candidate_box_select uses now clear distinction between internal representations and labels (as in options).

form-field of "form_page" uses now item-refs as internal representation since this relatively friendly to

clipboard movements and supports elements from different folders (which was previously broken).

    • -60
    • +99
    ./xowiki/tcl/form-field-procs.tcl
    • -0
    • +62
    ./xowiki/www/resources/selection-area.js
file selection-area.js was initially added on branch oacs-5-10.

    • -0
    • +0
    ./xowiki/www/resources/selection-area.js
Further performance improvement: as we only want one column from xowiki_form_page, just get it through a subquery

xowiki_form_instance_item_view performance improvement: do not join with dummy cr_text table, use lateral on Postgres to better guide the query planner

Fix properly import/export in a way that, as we did before, context_id of imported objects will use cr_items default, the parent_id

xowiki_form_instance_item_view reform: retrieve the context_id from the cr_item, rather than from the cr_revision

Rationale: revision's context_id is always set to its item_id. This will make every fetched ORM object appear as its context_id = item_id, while item's acs_object will display the correct context_id (in most cases, its parent)

Keep previous behavior of ignoring the context_id when exporting/importing xowiki objects now that this metadata would be persisted

Fix documentation (complete list of array fields)

Fix documentation (without a trailing slash, a redirect will happen, which transforms the POST into a GET request, which then will not be processed)

prefer absolut object references over ids

    • -18
    • +20
    ./xowiki/tcl/includelet-procs.tcl
    • -22
    • +23
    ./xowiki/tcl/xowiki-www-procs.tcl
    • -25
    • +25
    ./xowiki/tcl/upgrade/upgrade.tcl
prefer package object over plain id

prefer package object over plain id

removed commented out code

Pass object_id to the include UI, make the include contract clear

- modernize code (remove "my")

- prefer fully qualified commands based on IDs

    • -3
    • +3
    ./xowiki/resources/templates/view-book.tcl
    • -17
    • +18
    ./xowiki/tcl/form-field-procs.tcl
    • -61
    • +62
    ./xowiki/tcl/includelet-procs.tcl
    • -2
    • +2
    ./xowiki/tcl/xowiki-uploader-procs.tcl
  1. … 19 more files in changeset.
- modernize code (remove "my")

    • -3
    • +3
    ./xotcl-core/tcl/20-Ordered-Composite-procs.tcl
    • -10
    • +10
    ./xotcl-core/tcl/bgdelivery-procs.tcl
    • -10
    • +10
    ./xotcl-core/tcl/http-client-procs.tcl
    • -2
    • +2
    ./xotcl-core/tcl/40-thread-mod-procs.tcl
- modernize code (remove "my")

    • -15
    • +15
    ./xotcl-core/tcl/06-package-procs.tcl
    • -9
    • +9
    ./xotcl-core/tcl/10-recreation-procs.tcl
    • -6
    • +6
    ./xotcl-core/tcl/20-Ordered-Composite-procs.tcl
    • -6
    • +6
    ./xotcl-core/tcl/40-thread-mod-procs.tcl
    • -19
    • +19
    ./xotcl-core/tcl/context-procs.tcl
    • -2
    • +2
    ./xotcl-core/tcl/http-client-procs.tcl
    • -12
    • +12
    ./xotcl-core/tcl/policy-procs.tcl
fix for issue #3395

Wrap upleveled command in a list statement to make number of arguments clear

    • -2
    • +2
    ./xotcl-core/tcl/10-recreation-procs.tcl
Fix documentation

    • -2
    • +2
    ./acs-authentication/tcl/authority-procs.tcl
Do not require uuid package anymore

Use ns_uuid Naviserver command instead of uuid::uuid generate from tcllib: apparently, this can interact badly with clock localized formatting, leading to the "GREGORIAN_CHANGE_DATE" issue

add missing ad_script_abort

add ad_script abourt after termination command