• last updated 22 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
add missing file

    • -0
    • +134
    ./acs-authentication/www/doc/acs-authentication.adp
Fix incorrect default value

Whitespace changes + editor hints

    • -180
    • +186
    ./adserver/tcl/adserver-procs.tcl
    • -22
    • +21
    ./download/tcl/download-procs.tcl
    • -1
    • +7
    ./download/www/archive-version-add-2.tcl
    • -7
    • +13
    ./download/www/admin/approve-or-reject-2.tcl
    • -84
    • +89
    ./dynamic-types/tcl/dynamic-type-procs.tcl
    • -270
    • +275
    ./dynamic-types/tcl/form-procs.tcl
    • -2
    • +8
    ./image-magick/tcl/image-magick-procs.tcl
    • -91
    • +68
    ./jabber/www/edit-external-contact-2.tcl
    • -131
    • +126
    ./jabber/www/edit-user-2.tcl
  1. … 11 more files in changeset.
Replace/remove deprecated proc 'db_null'

    • -6
    • +6
    ./download/www/archive-version-add-2.tcl
    • -2
    • +2
    ./download/www/admin/approve-or-reject-2.tcl
    • -17
    • +1
    ./dynamic-types/tcl/dynamic-type-procs.tcl
    • -8
    • +0
    ./image-magick/tcl/image-magick-procs.tcl
    • -1
    • +1
    ./jabber/www/edit-external-contact-2.tcl
  1. … 11 more files in changeset.
Remove deprecated proc 'db_nullify_empty_string' from doc

Whitespace changes + editor hints

    • -58
    • +58
    ./acs-admin/www/apm/package-add-2.tcl
    • -16
    • +16
    ./acs-admin/www/apm/parameter-add-2.tcl
    • -9
    • +8
    ./acs-admin/www/apm/parameter-edit-2.tcl
    • -422
    • +422
    ./assessment/tcl/as-qti-procs.tcl
    • -335
    • +338
    ./content-portlet/tcl/content-portlet-compare-procs.tcl
    • -131
    • +137
    ./ecommerce/www/admin/products/delete-2.tcl
    • -62
    • +62
    ./forums/tcl/forums-callback-procs.tcl
  1. … 5 more files in changeset.
Replace/remove deprecated proc 'db_null' and update doc accordingly

    • -2
    • +2
    ./acs-admin/www/apm/parameter-add-2.tcl
    • -2
    • +2
    ./acs-admin/www/apm/parameter-edit-2.tcl
    • -13
    • +1
    ./acs-authentication/tcl/authentication-procs.tcl
    • -17
    • +1
    ./acs-core-docs/www/db-api-detailed.adp
    • -28
    • +1
    ./acs-core-docs/www/db-api-detailed.html
    • -29
    • +1
    ./acs-core-docs/www/xml/kernel/db-api.xml
    • -20
    • +1
    ./acs-tcl/tcl/apm-install-procs.tcl
  1. … 19 more files in changeset.
Deprecate 'db_nullify_empty_string', essentially just returning the same string it receives

Deprecate 'db_null'

    • -6
    • +10
    ./acs-tcl/tcl/00-database-procs.tcl
Trailing whitespace cleanup

    • -25
    • +23
    ./dotlrn/tcl/community-procs.tcl
dotlrn cache reform: added missing cache flush; added caching of "community_key"

bump version number to 5.10.0d2 and update dependencies

bump version number to 5.10.0d23

parameter::get_from_package_key: check as well in "global" package parameter

and make clear, that lookup from non-singleton packages does not make

sense.

    • -13
    • +36
    ./acs-tcl/tcl/parameter-procs.tcl
fix typos

    • -2
    • +2
    ./acs-tcl/tcl/form-processing-procs.tcl
improve comments, make function private to avoid confusions

improve comment

Make sure variable is an array

no need to call private function

follow usual naming conventions

    • -3
    • +3
    ./acs-tcl/tcl/request-processor-procs.tcl
no need to call private function of other package

    • -2
    • +2
    ./acs-bootstrap-installer/bootstrap.tcl
Ease usage of util_memoize during startup. let util_memoize succeed,

even when the cache is not yet created

    • -22
    • +31
    ./acs-tcl/tcl/memoize-procs-aolserver.tcl
    • -4
    • +13
    ./acs-tcl/tcl/memoize-procs-naviserver.tcl
use separate urlspace for site-node cache to reduce lock contention

prefer inline SQL over generic xql to make apm code usable during initialization

ad_form reform:

- use actual flags instead of parsing arguments all the time

- retrieve proc flags from ad_proc definition (TODO: have some api for this?)

- follow the thread of peculiar ad_form logic to fix new csrf signing feature

- improve documentation using @param instead of manual formatting

- leave some note to travellers in the code

    • -243
    • +229
    ./acs-tcl/tcl/form-processing-procs.tcl
new parameter "fallback_languages":

Specify space delimited two character codes for checking default languages. When this parameter is non-empty, try to get the page in the specified languages as fallback rather than offering a link for creation of a page in the requested locale. Per default this paramter is empty.

Reinstate reworked versions of some oracle database utilities left behind during solution of bug #3302

Rework is based on coding style observed in code provided by Brian Fenton, but could still not be tested. See https://openacs.org/bugtracker/openacs/bug?bug_number=3302

    • -1
    • +187
    ./acs-kernel/sql/oracle/utilities-create.sql
    • -0
    • +353
    ./acs-kernel/sql/oracle/upgrade/upgrade-5.10.0d11-5.10.0d12.sql
Fix typo (thanks to Thomas Renner)

reduce redirects

    • -1
    • +1
    ./acs-authentication/www/doc/configure-batch-sync.adp
    • -2
    • +2
    ./acs-authentication/www/doc/ext-auth-ldap-install.adp
    • -1
    • +1
    ./acs-authentication/www/doc/ext-auth-pam-install.adp
    • -1
    • +1
    ./acs-authentication/www/doc/ims-sync-driver-design.adp
    • -1
    • +1
    ./acs-authentication/www/doc/index.adp
Fix comment