• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Reduce oracle/postgres divergence

    • -22
    • +0
    ./rss-support/tcl/rss-generation-service-procs-oracle.xql
    • -23
    • +0
    ./rss-support/tcl/rss-generation-service-procs-postgresql.xql
    • -2
    • +21
    ./rss-support/tcl/rss-generation-service-procs.xql
Uniform sql codebase

    • -19
    • +0
    ./notifications/tcl/sweep-procs-oracle.xql
    • -13
    • +0
    ./notifications/tcl/sweep-procs-postgresql.xql
    • -0
    • +14
    ./notifications/tcl/sweep-procs.xql
Use cached api instead of query to retrieve node id from community and community_type

Remove unused query from xql (no usage was found upstream and on Learn@WU)

Get rid of dual idiom

Oracle doesn't support limit :-|

Streamline and optimize idiom

Declare explicitly the only column we need in a way that DBMS can create a better query plan

Tolerate the same request variable specified multiple times

We use export_vars as arbiter to decide how this will be treated.

Also remove some postgres/oracle divergence

    • -21
    • +16
    ./calendar/www/view-list-display.tcl
Replace db date conversion with tcl one, remove unneded statements (sort_by is already defined in page contract, ad_return_template is implicit)

    • -7
    • +3
    ./calendar-portlet/www/calendar-list-portlet.tcl
Fix typo

Port downstream only usage of reading info api

Also fix such api so that root message is retrieved for every given source message

    • -5
    • +16
    ./forums/sql/oracle/forums-reading-info-package-create.sql
    • -0
    • +163
    ./forums/sql/oracle/upgrade/upgrade-1.3.1d3-1.3.1d4.sql
Converge downstream reading_info feature with upstream

Port downstream only idiom to update reading_info table

Make more use of api when retrieving forum and message information

Optimize message existance query

Fix sql update to populate new forum_id column in existing data

Maintenance of forum reading count feature

- removal of forums_reading_info_user (1Mio rows on Learn@WU).

This materialized view had to be constantly synced with

forums_reading_info table. Reimplemented as view.

- simplify logics in stored procedure due to new datamodel

- fix inconsistencies between oracle and postgres function definition

- re-enabled parameter to decide whether use these stats or not in

administration

TODO: consider further reform of this feature as stats grow very

large on busy sites for probably little value added

    • -3
    • +3
    ./forums/sql/oracle/forums-reading-info-drop.sql
    • -143
    • +5
    ./forums/sql/oracle/forums-reading-info-package-create.sql
    • -0
    • +186
    ./forums/sql/oracle/upgrade/upgrade-1.3.1d2-1.3.1d3.sql
Remove deprecated idioms and unneded queries

    • -8
    • +0
    ./forums/lib/message/post-postgresql.xql
Persist sanitized timestamp into data object before saving (Many thanks to Markus Moser)

Implement post anonymously through explicit forum attribute in table

Now moderators can explicitly decide whether a forum will enable posting anonymously or not.

Forum must be in a policy different from closed and the anonymous flag must be set accordingly for this to happen.

Also:

- normalize api in a way it can accomodate all current attributes. In particular,

now edit api will now leave every unspecified attribute unchanged, instead of

setting it to some default.

- fix some usability issues when managing forum parameters (e.g. values not

retrieved in form when editing existing forum)

- introduce missing Oracle upgrade script for the whole forum reform

- fix oracle creation script

    • -0
    • +27
    ./forums/sql/oracle/upgrade/upgrade-1.3.1d1-1.3.1d2.sql
    • -9
    • +14
    ./forums/tcl/forums-security-procs.tcl
Update docs: remove broken links and remove/update obsolete section

    • -3
    • +22
    ./acs-core-docs/www/acs-package-dev.html
    • -2
    • +2
    ./acs-core-docs/www/analog-install.adp
    • -4
    • +9
    ./acs-core-docs/www/analog-install.html
    • -9
    • +30
    ./acs-core-docs/www/analog-setup.html
    • -30
    • +27
    ./acs-core-docs/www/aolserver.adp
    • -48
    • +156
    ./acs-core-docs/www/aolserver.html
    • -46
    • +37
    ./acs-core-docs/www/aolserver4.adp
    • -37
    • +141
    ./acs-core-docs/www/aolserver4.html
    • -87
    • +428
    ./acs-core-docs/www/apm-design.html
    • -4
    • +2
    ./acs-core-docs/www/apm-requirements.adp
  1. … 285 more files in changeset.
further cleanup for XOTcl2

    • -99
    • +101
    ./xowiki/tcl/xowiki-www-procs.tcl
Simplify idiom

Since PostgreSQL 10 does not support the tsearch2 backword compatibility package anymore, make sure that OpenACS does not use the old names requiring this package.

    • -43
    • +0
    ./tsearch2-driver/tcl/tsearch2-driver-procs-postgresql.xql
Revert db_exec_plsql or Oracle will break, remove leftover xql files

    • -2
    • +2
    ./file-storage/tcl/file-storage-procs.tcl
    • -17
    • +0
    ./file-storage/www/folder-delete-oracle.xql
    • -15
    • +0
    ./file-storage/www/folder-delete-postgresql.xql
restrict detail statistics to swa

    • -1
    • +9
    ./xotcl-request-monitor/www/stat-details.tcl
Optimize query by using multi-object permission checking and trying to filter the most tuples before joining cr_items with cr_revisions

    • -5
    • +33
    ./assessment/www/index-postgresql.xql
Reduce divergence between oracle and postgres

    • -40
    • +1
    ./file-storage/www/move-postgresql.xql
Fix oracle systax to call function via select

    • -4
    • +1
    ./file-storage/tcl/file-storage-procs-oracle.xql
Uniform API when deleting folder, drill through some calling levels in stored procedure, use a simpler db_string instead of db_exec_plsql

    • -4
    • +1
    ./file-storage/tcl/file-storage-procs-postgresql.xql
    • -2
    • +2
    ./file-storage/tcl/file-storage-procs.tcl
Fix broken links

    • -0
    • +70
    ./acs-authentication/www/doc/configure-batch-sync.adp
    • -0
    • +25
    ./acs-authentication/www/doc/ext-auth-design.adp
    • -0
    • +32
    ./acs-authentication/www/doc/ext-auth-install.adp
    • -0
    • +153
    ./acs-authentication/www/doc/ext-auth-ldap-install.adp
    • -0
    • +140
    ./acs-authentication/www/doc/ext-auth-pam-install.adp
    • -0
    • +207
    ./acs-authentication/www/doc/ims-sync-driver-design.adp
    • -1
    • +1
    ./acs-authentication/www/doc/ims-sync-driver-design.html
    • -0
    • +32
    ./acs-authentication/www/doc/index.adp
    • -5
    • +4
    ./acs-lang/www/doc/i18n-requirements.adp
    • -6
    • +5
    ./acs-lang/www/doc/i18n-requirements.html
Remove broken links