• last updated 2 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Replace tmpnam api

Quote unallowed HTML according to acs-tcl.documentation__check_proc_doc

fix documentation

improve spelling

Add proc names to the list of covered procs in xml-rpc tests

Fallback to 'util_current_location' when 'ad_url' returns an empty string, such in cases when the SystemUrl is not set, on the xml_rpc_validate testcase

Whitespace changes + editor hints

Fix typo

Rename xmlrpc_decode_test_prep and add it to a namespace in order to pass the 'naming__proc_naming' testcase

Whitespace cleanup

Replace deprecated proc

Specify an explicit format that clock scan can recognize, otherwise results will be unexpected (port from downstream)

fix typos and provide adp doc page

  1. … 1 more file in changeset.
Add editor hints + Whitespace cleanup

Mention explicitly the tested procs in the test cases.

Sanitize date stings for parsability with clock scan and allow HTTPS requests using 'util::http::post' (many thanks to Markus Moser).

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 473 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 202 more files in changeset.
Rework variable assignment (set -> lassign) + Whitespace changes

  1. … 3 more files in changeset.
fix typos

  1. … 13 more files in changeset.
Use ns_getcontent to access content of the POST requests, when using NaviServer

Handle empty XML strings explicitly

free doc only, when it exists

- modernize tcl

- prefer ns_quotehtml over ad_quotehtml

  1. … 4 more files in changeset.
- replace deprecated command "ns_unlink" with native tcl command "file delete"

  1. … 7 more files in changeset.
- normalize string comparisons

- allow for byte compiled expressions

  1. … 1 more file in changeset.
fix by christoph haberberger: empty parameters in xml-rpc lead to crash

change the manyTypesTest to use 0010704T11:50:30Z (note Z) since w/o it you would get a result that depended on the server local timezone

Make xmlrpc::httppost error out instead of returning a useless -1 in case of error. Vinod-approved change.

all TCL's clock clicks always with the -milliseconds option. The TCL manual

explicitly states that without this switch the return result is platform

dependant. The OpenACS code works at the millisecond granulartiy and silently

assumes that 1 millisecond equals 1000 clicks which is not necessarily true.

I used this shell script to automatize the replacing:


for file in `grep -lsr "\[clock clicks\]" /web/openacs-head/packages/ `; do

echo "repairing $file"

sed "s/\[clock clicks\]/\[clock clicks -milliseconds\]/g" $file > fout

mv fout $file


And then grepped for

grep -r "expr.*clock clicks" /web/openacs-head/packages/

to manually remove the divisions by 1000.

  1. … 10 more files in changeset.