OpenACS / openacs-4 / packages

news-aggregator

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 21
Last Commit: 05 Apr
Commits this week: 0
Total Lines of Code (LoC): 4,604
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 02 Apr 2019
11:32 am

antoniop

New test checking behavior of the news aggregator

This currently fails for what concerns updating an existing news item

Options
    • -0
    • +90
    ./tcl/test/news-aggregator-test-procs.tcl
10:42 am

antoniop

Use existing api

Options
    • -1
    • +1
    ./www/index.tcl
Monday 01 Apr 2019
7:21 pm

antoniop

Prepend source URL to the one of the news item in case this is not an absolute URL

Options
    • -0
    • +3
    ./www/index.tcl
Tuesday 24 Jul 2018
11:41 am

antoniop

Add test for the news aggregator and feed-parser

news-aggregator will reuse basic test from the feed parser

Options
    • -0
    • +46
    ./tcl/test/news-aggregator-test-procs.tcl
  2. … 1 more file in changeset.
11:34 am

antoniop

Fix subscription form error (left behind from previous commit)

Options
    • -3
    • +3
    ./www/subscriptions.adp
Thursday 19 Jul 2018
7:11 pm

antoniop

Trim whitespace

Options
    • -3
    • +3
    ./www/subscriptions.tcl
7:10 pm

antoniop

Repair form validation of URL

Options
    • -5
    • +5
    ./www/subscriptions.tcl
5:36 pm

antoniop

New test to check whether configured news feeds look ok

Options
    • -2
    • +2
    ./tcl/source-procs.tcl
3:36 pm

antoniop

Trim whitespace

Options
    • -2
    • +2
    ./tcl/install-procs.tcl
Wednesday 18 Jul 2018
7:09 pm

antoniop

Replace deprecated header_stuff with head

Options
    • -1
    • +1
    ./www/index.adp
7:08 pm

antoniop

Give some feedback in case of error

Options
    • -5
    • +8
    ./www/opml.tcl
7:04 pm

antoniop

Repair broken opml export, exploit new api to streamline query, fix typo

Options
    • -17
    • +0
    ./tcl/aggregator-procs-postgresql.xql
    • -6
    • +22
    ./tcl/aggregator-procs.tcl
6:41 pm

antoniop

Return 0 also when a default is there but is the empty string

Options
    • -1
    • +1
    ./tcl/aggregator-procs.tcl
6:36 pm

antoniop

Bring other sql inline, simplify idioms

Options
    • -49
    • +0
    ./tcl/aggregator-procs-postgresql.xql
    • -18
    • +35
    ./tcl/aggregator-procs.tcl
6:23 pm

antoniop

Bring sql for this proc inline, remove unused statements

Options
    • -41
    • +0
    ./tcl/aggregator-procs-postgresql.xql
    • -6
    • +19
    ./tcl/aggregator-procs.tcl
6:13 pm

antoniop

Document public procs (fixes automated tests), rework code, remove leftover statements

Options
    • -3
    • +8
    ./tcl/aggregator-procs.tcl
    • -21
    • +4
    ./tcl/aggregator-procs.xql
    • -0
    • +5
    ./tcl/subscription-procs.tcl
5:43 pm

antoniop

Modernize tcl

Options
    • -9
    • +8
    ./www/index.vuh
4:11 pm

antoniop

Trim whitespace

Options
    • -4
    • +1
    ./tcl/news-aggregator-procs.tcl
4:09 pm

antoniop

Remove obsolete xql files

Options
    • -34
    • +0
    ./tcl/subscription-procs-postgresql.xql
    • -32
    • +0
    ./tcl/subscription-procs.xql
4:08 pm

antoniop

Make all sql portable and bring it in line, remove code duplication

Options
    • -5
    • +30
    ./tcl/subscription-procs.tcl
3:51 pm

antoniop

Further UI fixing after tests to make so that actions are displayed only when the proper conditions are met

Options
    • -2
    • +4
    ./www/index.adp
    • -8
    • +13
    ./www/index.tcl
3:36 pm

antoniop

Revision of the index page:

- pass template properties according to conventions

- streamline boolean expressions

- fix UI, show purge button and its explanation when the actual form is generated

- make sql portable and bring it inline

- better exploit api

Options
    • -36
    • +0
    ./www/index-postgresql.xql
    • -8
    • +16
    ./www/index.adp
    • -50
    • +43
    ./www/index.tcl
    • -14
    • +0
    ./www/index.xql
12:31 pm

antoniop

Use db_0or1row flag to return an array natively, repair news_aggregator::aggregator::as_xml as for some reason creating the xml processing instruction via tDOM is broken on tDOM 0.8.3

Options
    • -10
    • +0
    ./tcl/aggregator-procs-postgresql.xql
    • -16
    • +22
    ./tcl/aggregator-procs.tcl
11:18 am

antoniop

Whitespace cleanup

Options
    • -27
    • +27
    ./tcl/aggregator-procs.tcl
11:15 am

antoniop

Fix boolean adp expression, pass properties according to adp guidelines

Options
    • -3
    • +4
    ./www/subscriptions.adp
11:08 am

antoniop

Package rework and maintenance

- deprecate undocumented news_aggregator::source::get_identifier as no mention was found in upstream code (fixes automated tests)

- put all portable sql inline

- rework all sql idioms that could be made portable

- remove leftover sql statements

- simplify idioms

Options
    • -34
    • +1
    ./tcl/source-procs-postgresql.xql
    • -19
    • +24
    ./tcl/source-procs.tcl
    • -12
    • +0
    ./tcl/source-procs.xql
Tuesday 17 Jul 2018
5:48 pm

antoniop

Rework of news_aggregator::source::update

- replace deprecated calls

- replace array idioms with dict idioms

- bring portable sql inline

This was tested against RSS feeds used downstream on a vanilla instance

Options
    • -26
    • +1
    ./tcl/source-procs-postgresql.xql
    • -82
    • +82
    ./tcl/source-procs.tcl
    • -12
    • +0
    ./tcl/source-procs.xql
5:42 pm

antoniop

Change adp expression so news can be displayed

Options
    • -1
    • +1
    ./www/index.adp
3:40 pm

hectorr

Removed 'setResultEncoding' tdom option, which has no effect in Tcl > 8.0, and is removed in tdom > 0.9.0.

See upstream commit: http://tdom.org/index.html/info/d729de4c396d71ff

From the old docs: http://tdom.org/index.html/artifact/2a79d8cf33feacf9

dom setResultEncoding ?encodingName?

This option is for backward compatibility with Tcl 8.0. If tDOM is build

with any newer Tcl version this option does not has any effect.

If encodingName is not given the current global result encoding is

returned. Otherwise the global result encoding is set to encodingName.

All character data, attribute values etc. will then be converted from

UTF-8, which is delivered from the Expat XML parser, to the given 8 bit

encoding at XML/DOM parse time. Valid values for encodingName are:

utf-8, ascii, cp1250, cp1251, cp1252, cp1253, cp1254, cp1255, cp1256,

cp437, cp850, en, iso8859-1, iso8859-2, iso8859-3, iso8859-4, iso8859-5,

iso8859-6, iso8859-7, iso8859-8, iso8859-9, koi8-r.

Options
    • -2
    • +0
    ./tcl/aggregator-procs.tcl
3:28 pm

antoniop

Almost complete rewrite of news_aggregator::source::new

- replace deprecated calls

- remove code duplication

- don't loop through response items, as nothing is done with that information

- replace array idioms with dict idioms

- let stored procedure figure out the object_id

Works on WU RSS URLs on a vanilla instance

Options
    • -7
    • +6
    ./tcl/source-procs-postgresql.xql
    • -60
    • +44
    ./tcl/source-procs.tcl
    • -8
    • +0
    ./tcl/source-procs.xql