• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Whitespace changes + Editor hints

Rework news source update to simplify the logics and handle updating of existing news items (passes tests)

Move normalization of the pub date closer to its source

New test checking behavior of the news aggregator

This currently fails for what concerns updating an existing news item

    • -0
    • +90
    ./test/news-aggregator-test-procs.tcl
Add test for the news aggregator and feed-parser

news-aggregator will reuse basic test from the feed parser

    • -0
    • +46
    ./test/news-aggregator-test-procs.tcl
  1. … 1 more file in changeset.
New test to check whether configured news feeds look ok

Trim whitespace

Repair broken opml export, exploit new api to streamline query, fix typo

Return 0 also when a default is there but is the empty string

Bring other sql inline, simplify idioms

Bring sql for this proc inline, remove unused statements

Document public procs (fixes automated tests), rework code, remove leftover statements

Trim whitespace

Remove obsolete xql files

    • -34
    • +0
    ./subscription-procs-postgresql.xql
Make all sql portable and bring it in line, remove code duplication

Use db_0or1row flag to return an array natively, repair news_aggregator::aggregator::as_xml as for some reason creating the xml processing instruction via tDOM is broken on tDOM 0.8.3

Whitespace cleanup

Package rework and maintenance

- deprecate undocumented news_aggregator::source::get_identifier as no mention was found in upstream code (fixes automated tests)

- put all portable sql inline

- rework all sql idioms that could be made portable

- remove leftover sql statements

- simplify idioms

Rework of news_aggregator::source::update

- replace deprecated calls

- replace array idioms with dict idioms

- bring portable sql inline

This was tested against RSS feeds used downstream on a vanilla instance

Removed 'setResultEncoding' tdom option, which has no effect in Tcl > 8.0, and is removed in tdom > 0.9.0.

See upstream commit: http://tdom.org/index.html/info/d729de4c396d71ff

From the old docs: http://tdom.org/index.html/artifact/2a79d8cf33feacf9

dom setResultEncoding ?encodingName?

This option is for backward compatibility with Tcl 8.0. If tDOM is build

with any newer Tcl version this option does not has any effect.

If encodingName is not given the current global result encoding is

returned. Otherwise the global result encoding is set to encodingName.

All character data, attribute values etc. will then be converted from

UTF-8, which is delivered from the Expat XML parser, to the given 8 bit

encoding at XML/DOM parse time. Valid values for encodingName are:

utf-8, ascii, cp1250, cp1251, cp1252, cp1253, cp1254, cp1255, cp1256,

cp437, cp850, en, iso8859-1, iso8859-2, iso8859-3, iso8859-4, iso8859-5,

iso8859-6, iso8859-7, iso8859-8, iso8859-9, koi8-r.

Almost complete rewrite of news_aggregator::source::new

- replace deprecated calls

- remove code duplication

- don't loop through response items, as nothing is done with that information

- replace array idioms with dict idioms

- let stored procedure figure out the object_id

Works on WU RSS URLs on a vanilla instance

improve spelling

  1. … 11 more files in changeset.
Fix proc and contract doc elements, so they are properly parsed by apidoc::api_*_documentation.

- @cvs_id -> @cvs-id

- @version -> @cvs-id

- @creation_date -> @creation-date

- @date -> @creation-date

- Different variations of $Id$

- Remove wrong @param entry

- Fix typos

  1. … 368 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
Rework variable assignment (set -> lassign) + Whitespace changes

  1. … 17 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 204 more files in changeset.
Rework variable assignment (set -> lassign)

  1. … 12 more files in changeset.
Fix typos

  1. … 1 more file in changeset.
Fiy typo

Rework conditional expressions

  1. … 2 more files in changeset.