• last updated 22 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Make all sql portable and bring it in line, remove code duplication

Use db_0or1row flag to return an array natively, repair news_aggregator::aggregator::as_xml as for some reason creating the xml processing instruction via tDOM is broken on tDOM 0.8.3

Whitespace cleanup

Package rework and maintenance

- deprecate undocumented news_aggregator::source::get_identifier as no mention was found in upstream code (fixes automated tests)

- put all portable sql inline

- rework all sql idioms that could be made portable

- remove leftover sql statements

- simplify idioms

Rework of news_aggregator::source::update

- replace deprecated calls

- replace array idioms with dict idioms

- bring portable sql inline

This was tested against RSS feeds used downstream on a vanilla instance

Removed 'setResultEncoding' tdom option, which has no effect in Tcl > 8.0, and is removed in tdom > 0.9.0.

See upstream commit: http://tdom.org/index.html/info/d729de4c396d71ff

From the old docs: http://tdom.org/index.html/artifact/2a79d8cf33feacf9

dom setResultEncoding ?encodingName?

This option is for backward compatibility with Tcl 8.0. If tDOM is build

with any newer Tcl version this option does not has any effect.

If encodingName is not given the current global result encoding is

returned. Otherwise the global result encoding is set to encodingName.

All character data, attribute values etc. will then be converted from

UTF-8, which is delivered from the Expat XML parser, to the given 8 bit

encoding at XML/DOM parse time. Valid values for encodingName are:

utf-8, ascii, cp1250, cp1251, cp1252, cp1253, cp1254, cp1255, cp1256,

cp437, cp850, en, iso8859-1, iso8859-2, iso8859-3, iso8859-4, iso8859-5,

iso8859-6, iso8859-7, iso8859-8, iso8859-9, koi8-r.

Almost complete rewrite of news_aggregator::source::new

- replace deprecated calls

- remove code duplication

- don't loop through response items, as nothing is done with that information

- replace array idioms with dict idioms

- let stored procedure figure out the object_id

Works on WU RSS URLs on a vanilla instance

improve spelling

  1. … 11 more files in changeset.
Fix proc and contract doc elements, so they are properly parsed by apidoc::api_*_documentation.

- @cvs_id -> @cvs-id

- @version -> @cvs-id

- @creation_date -> @creation-date

- @date -> @creation-date

- Different variations of $Id$

- Remove wrong @param entry

- Fix typos

  1. … 368 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
Rework variable assignment (set -> lassign) + Whitespace changes

  1. … 17 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 204 more files in changeset.
Rework variable assignment (set -> lassign)

  1. … 12 more files in changeset.
Fix typos

  1. … 1 more file in changeset.
Fiy typo

Rework conditional expressions

  1. … 2 more files in changeset.
remove conditions, which are always true

remove parens

  1. … 6 more files in changeset.
modernize tcl

  1. … 9 more files in changeset.
reduce usage of deprecated procs

modernize tcl

  1. … 2 more files in changeset.
- fix sloppy pseudo-comments to silence automated testing

  1. … 8 more files in changeset.
Reverted all changes from Mannheim

  1. … 222 more files in changeset.
Mannheim update, fix and merge bugbash

  1. … 14 more files in changeset.
Minor fixes to the linking and dealing with funny servers that return file not found with error code 200

  1. … 2 more files in changeset.
fix bug uncovered by this poster: http://openacs.org/forums/message-view?message_id=404567; bump version and tag

  1. … 1 more file in changeset.
convert to localtime and sort in DB (much, much faster index page); releasing v1.0.1

  1. … 3 more files in changeset.
tidy up error handling, return codes and proc comments

straightened out grouping issue in display (ran into the old issue detailed here - http://openacs.org/bugtracker/openacs/bug?bug%5fnumber=428); backing out maltes upgrade script change as it doesn't break anything and will create inconsistent data model - portlet should really be updated to fix the issue; tagging for rel v0.9.9

  1. … 9 more files in changeset.
fixed display issue with group tag by separating the two cases (one source/multiple sources to display) into to includible chunks

  1. … 6 more files in changeset.
remove debugging for multiple group by; drop title column for na_sources (not used by UI plus part of acs_objects with 5.2) and made user_id optional for source::new; still need to deal with the group by issue on index page - now, the first grouping (pub date) is not applied when there is only one source (source_id being the second grouping

  1. … 2 more files in changeset.
some basic tests for aggregator and source apis