• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Almost complete rewrite of news_aggregator::source::new

- replace deprecated calls

- remove code duplication

- don't loop through response items, as nothing is done with that information

- replace array idioms with dict idioms

- let stored procedure figure out the object_id

Works on WU RSS URLs on a vanilla instance

improve spelling

  1. … 11 more files in changeset.
Fix proc and contract doc elements, so they are properly parsed by apidoc::api_*_documentation.

- @cvs_id -> @cvs-id

- @version -> @cvs-id

- @creation_date -> @creation-date

- @date -> @creation-date

- Different variations of $Id$

- Remove wrong @param entry

- Fix typos

  1. … 368 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
Rework variable assignment (set -> lassign) + Whitespace changes

  1. … 17 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 204 more files in changeset.
Rework variable assignment (set -> lassign)

  1. … 12 more files in changeset.
Fix typos

  1. … 1 more file in changeset.
Fiy typo

Rework conditional expressions

  1. … 2 more files in changeset.
remove conditions, which are always true

remove parens

  1. … 6 more files in changeset.
modernize tcl

  1. … 9 more files in changeset.
reduce usage of deprecated procs

modernize tcl

  1. … 2 more files in changeset.
- fix sloppy pseudo-comments to silence automated testing

  1. … 8 more files in changeset.
Reverted all changes from Mannheim

  1. … 222 more files in changeset.
Mannheim update, fix and merge bugbash

  1. … 14 more files in changeset.
Minor fixes to the linking and dealing with funny servers that return file not found with error code 200

  1. … 2 more files in changeset.
fix bug uncovered by this poster: http://openacs.org/forums/message-view?message_id=404567; bump version and tag

  1. … 1 more file in changeset.
convert to localtime and sort in DB (much, much faster index page); releasing v1.0.1

  1. … 3 more files in changeset.
tidy up error handling, return codes and proc comments

straightened out grouping issue in display (ran into the old issue detailed here - http://openacs.org/bugtracker/openacs/bug?bug%5fnumber=428); backing out maltes upgrade script change as it doesn't break anything and will create inconsistent data model - portlet should really be updated to fix the issue; tagging for rel v0.9.9

  1. … 9 more files in changeset.
fixed display issue with group tag by separating the two cases (one source/multiple sources to display) into to includible chunks

  1. … 6 more files in changeset.
remove debugging for multiple group by; drop title column for na_sources (not used by UI plus part of acs_objects with 5.2) and made user_id optional for source::new; still need to deal with the group by issue on index page - now, the first grouping (pub date) is not applied when there is only one source (source_id being the second grouping

  1. … 2 more files in changeset.
some basic tests for aggregator and source apis

file news-aggregator-procs.tcl was initially added on branch oacs-5-2.

    • -0
    • +0
    ./test/news-aggregator-procs.tcl
lots of little tweaks for data cleanup on uninstantiate, some more UI work, bug fixes, etc.; added daveb's sweeper proc; not tagging v0.9.8 just yet though

    • -2
    • +9
    ./news-aggregator-procs-postgresql.xql
  1. … 16 more files in changeset.
fixing something minor i broke in proc args and changing now() to current_timestamp

minor fix to proc that calculates 'updated since' time

remove source if no longer referenced

remove a source if it is no longer being used by any aggregators