OpenACS / openacs-4 / packages / forums / www

message-view.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 19
Last Commit: 12:40
Commits this week: 0
Total Lines of Code (LoC): 106
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 30 Aug 2022
2:22 pm

gustafn

re-add notnull value constraint on message_id

This constraint was removed about 14 days ago. Without this constraint,

errors like the following will show up....

[30/Aug/2022:14:07:29.820625][3102633.7f152c28d700][-conn:openacs.org:default:0:196214-] Error: rp_handler no-script-abort: errorMsg can't read "message(forum_id)": no such variable while serving GE

T /forums/message-view?message_id HTTP/1.1

: ad_url </forums/message-view> maps to file </var/www/openacs.org/packages/forums/www/message-view.adp>

: TCL LOOKUP VARNAME message

: can't read "message(forum_id)": no such variable

: while executing

: "forum::get -forum_id $message(forum_id) -array forum"

Probably, in many more cases, the incorrect removal of the notnull constrain performed by [1]

requires the same fix.

[1] https://github.com/openacs/forums/commit/c403e3134ce4e73ba94a80540a8b0f3cb1651ed0#diff-d35c736495ede0174fb39791ab660c5cd1a4ca467db2c4741cfc935167d7e5a8

Options
    • -2
    • +2
    ./message-view.tcl
Friday 15 Jul 2022
6:19 pm

antoniop

Harden page and include contracts using new acs-tcl feature

Options
    • -10
    • +4
    ./message-view.tcl
  2. … 35 more files in changeset.
Sunday 14 Feb 2021
10:08 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./message-view.tcl
  2. … 4 more files in changeset.
Saturday 26 Sep 2020
2:10 pm

gustafn

show notification controls only, when the request is not from a bot

Options
    • -3
    • +6
    ./message-view.tcl
  2. … 4 more files in changeset.
Wednesday 13 May 2020
4:31 pm

antoniop

Implement a new type of "Moderator" notification type for forums

This notification will be triggered also by unapproved messages. The UI will show the subscription link only to forum moderators, using a different color (customizable via css, vanilla color is red). Message content will always be hidden for such notifications, so user will need to have access to new message.

Options
    • -1
    • +8
    ./message-view.tcl
  2. … 7 more files in changeset.
Sunday 09 Feb 2020
9:11 am

gustafn

remove print.css and include its content in forums.css

Options
    • -2
    • +1
    ./message-view.tcl
  2. … 3 more files in changeset.
Thursday 16 Nov 2017
1:40 pm

antoniop

Make forum::use_ReadingInfo_p more robust when UseReadingInfo parameter in forums is not set

Options
    • -2
    • +2
    ./message-view.tcl
  2. … 3 more files in changeset.
12:03 pm

gustafn

make boolean test strict

Options
    • -2
    • +2
    ./message-view.tcl
  2. … 2 more files in changeset.
11:58 am

gustafn

Hot fix for latest changes concerning reading info

Options
    • -2
    • +2
    ./message-view.tcl
  2. … 2 more files in changeset.
Wednesday 27 Sep 2017
1:07 pm

antoniop

Forum reform

- remove hardcoded dependency with registered_users group. Target is to improve suitability in convoluted multi groups/multi subsites context

- in place of previous permission-based machinery, use plain table columns to detect whether user can or cannot post replies/new threads

- remove permission check at the message level in favor of that on forum level

Options
    • -20
    • +2
    ./message-view.tcl
  2. … 21 more files in changeset.
Tuesday 08 Aug 2017
1:47 am

gustafn

merged changes from the oacs-5-9 branch and resolved conflicts

Options
    • -16
    • +17
    ./message-view.tcl
  2. … 7834 more files in changeset.
Thursday 27 Oct 2016
10:16 am

gustafn

- move validation of message_id into a validation block

Options
    • -7
    • +9
    ./message-view.tcl
Saturday 10 Oct 2015
2:06 pm

gustafn

- prefer doc(title) over page_title

Options
    • -2
    • +2
    ./message-view.tcl
  2. … 1 more file in changeset.
Saturday 19 Sep 2015
6:55 pm

gustafn

- use notification-widget for message notification as well

Options
    • -9
    • +2
    ./message-view.tcl
  2. … 1 more file in changeset.
Saturday 12 Sep 2015
1:06 pm

gustafn

- add editor hints to keep spaces/tabs in the future more consistent

Options
    • -1
    • +7
    ./message-view.tcl
  2. … 350 more files in changeset.
Sunday 12 Jul 2015
6:27 am

gustafn

- do localization in script since apparently the arrays for the embedded variables (%forum.name%, %message.subject%) are not passed to the environment where the master is evaluated

Options
    • -2
    • +2
    ./message-view.tcl
Friday 03 Jul 2015
11:56 am

gustafn

- strengthen page contracts

Options
    • -2
    • +2
    ./message-view.tcl
Monday 27 Oct 2014
5:38 pm

victorg

Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

Options
    • -5
    • +5
    ./message-view.tcl
  2. … 2547 more files in changeset.
Wednesday 10 Sep 2014
9:48 pm

gustafn

- remove unneeded braces

Options
    • -3
    • +3
    ./message-view.tcl
Tuesday 29 Jul 2014
1:23 pm

gustafn

- use consistently "naturalnum" instead of "integer" when accepting just positive values

Options
    • -2
    • +2
    ./message-view.tcl
  2. … 125 more files in changeset.
Thursday 10 Oct 2013
10:48 pm

gustafn

- use numeric comparison for truth value comparison

Options
    • -2
    • +2
    ./message-view.tcl
  2. … 2 more files in changeset.
Monday 27 Apr 2009
10:25 pm

emmar

More fixes for bug 3153 to consider the "anonymous" user case

Options
    • -2
    • +2
    ./message-view.tcl
  2. … 2 more files in changeset.
9:36 pm

emmar

Fix for bug 3153

Options
    • -2
    • +2
    ./message-view.tcl
  2. … 4 more files in changeset.
Monday 10 Nov 2008
12:29 am

donb

1. Merge 2.4.1 to HEAD other than assessment, imsld, lorsm, and views.

2. Bump version numbers to 2.5.0d1.

Options
    • -30
    • +10
    ./message-view.tcl
  2. … 379 more files in changeset.
Saturday 20 Sep 2008
2:10 pm

gustafn

- normalize string expressions

Options
    • -5
    • +5
    ./message-view.tcl
  2. … 23 more files in changeset.
Tuesday 16 Sep 2008
7:26 pm

gustafn

- present reply/post button only, when permissions allow it

- present email-message button only, if user is logged in

- present mark_all_read button only, if user is logged in

- add parameter "-user_id" to forums:permissions for orthogonality with the rest of the API

Options
    • -5
    • +15
    ./message-view.tcl
  2. … 4 more files in changeset.
Monday 02 Jun 2008
8:05 pm

emmar

Set meaningful alt text for the expand/collapse image of a message. Added title attribute to the link. Made both accurate with the status of the message.

Options
    • -2
    • +9
    ./message-view.tcl
  2. … 5 more files in changeset.
Friday 21 Mar 2008
7:24 pm

donb

The print.css link shouldn't be "alternative" but just plain style, since

it's enabled only for the "print" media type and we don't want theme zen's

or any other js to accidently select it ...

Options
    • -2
    • +2
    ./message-view.tcl
Wednesday 19 Mar 2008
11:21 pm

donb

Cleaned up forums.js. As discussed in e-mail, changed generic function names

such as "toggle()" to "forums_toggle()" to reduce the odds of future name

clashes causing as much confusion and embarrassment as the recent ones in zen

and forums did. Made formatting consistent. Got rid of template::head calls

to load unused javascript which just made the code more confusing.

Behavior matches .LRN 2.2 behavior, the arrow on a message collapses or

expands that message only, not its subtree. Subtree would probably be better

(and I swear it did, once upon a time) but that will have to wait for the

future if people want it.

Options
    • -14
    • +1
    ./message-view.tcl
  2. … 3 more files in changeset.
3:11 am

donb

I think I removed a bit too much, such as stuff related to optional ajax

usage or something like that, so I put it back.

Options
    • -1
    • +14
    ./message-view.tcl