OpenACS / openacs-4 / packages

file-storage

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 66
Last Commit: 05 Apr
Commits this week: 0
Total Lines of Code (LoC): 26,014
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 21 Jun 2017
11:09 pm

antoniop

Use site_node:: api to retrieve package_url instead of explicit query. Remove unused sql and simplify idiom for fs_get_folder_name.

Options
    • -6
    • +4
    ./tcl/file-storage-procs.tcl
    • -8
    • +0
    ./tcl/file-storage-procs.xql
Thursday 08 Jun 2017
6:42 pm

antoniop

- Introduce new proc ad_sanitize_filename implementing current best practices for ensuring a valid filename on most filesystems.

- Use it in every place where filename sanitization is performed in the code and deprecate fs::remove_special_file_system_characters.

TODO deprecate also util_text_to_html? Use case of sanitizing urls and filenames might have different requirements.

Options
    • -1
    • +0
    ./lib/folder-links.tcl
    • -8
    • +24
    ./tcl/file-storage-procs.tcl
    • -3
    • +1
    ./www/folder-chunk.tcl
    • -2
    • +5
    ./www/folder-create.tcl
  5. … 2 more files in changeset.
Tuesday 30 May 2017
2:00 pm

antoniop

Fix typo

Options
    • -1
    • +1
    ./www/folder-delete.adp
1:58 pm

antoniop

Check if we have already a folder with same name before inserting, or we get error in the logs.

Remove small duplication

Options
    • -8
    • +15
    ./www/folder-create.tcl
Wednesday 24 May 2017
8:49 pm

antoniop

Remove sql duplication, converge oracle and postgres codebase

Options
    • -14
    • +0
    ./tcl/file-storage-procs-oracle.xql
    • -17
    • +0
    ./tcl/file-storage-procs-postgresql.xql
    • -1
    • +2
    ./tcl/file-storage-procs.tcl
    • -0
    • +8
    ./tcl/file-storage-procs.xql
6:09 pm

antoniop

Prevent user from selecting source folder as destination folder when moving files. Localize feedback messages (thanks to Markus Moser for the germen translation)

Options
    • -0
    • +2
    ./catalog/file-storage.de_DE.ISO-8859-1.xml
    • -2
    • +4
    ./catalog/file-storage.en_US.ISO-8859-1.xml
    • -0
    • +2
    ./catalog/file-storage.it_IT.ISO-8859-1.xml
    • -33
    • +34
    ./www/move.tcl
Tuesday 09 May 2017
2:03 pm

antoniop

Remove debugging comment

Options
    • -4
    • +3
    ./www/copy.tcl
2:01 pm

antoniop

Use name and title for the copy, rather than name as title and file_upload_name as name. This will make so copied files will have also the same title as the original when this was renamed.

Try conserving file extension in the name when adding the suffix

Options
    • -6
    • +6
    ./www/copy-oracle.xql
    • -6
    • +6
    ./www/copy-postgresql.xql
    • -9
    • +15
    ./www/copy.tcl
12:07 pm

antoniop

Localize untranslated messages in the copy file-storage script (thanks to Markus Moser for the german translation)

Options
    • -0
    • +2
    ./catalog/file-storage.de_DE.ISO-8859-1.xml
    • -0
    • +2
    ./catalog/file-storage.en_US.ISO-8859-1.xml
    • -0
    • +2
    ./catalog/file-storage.it_IT.ISO-8859-1.xml
    • -2
    • +2
    ./www/copy.tcl
Wednesday 03 May 2017
8:18 pm

antoniop

Use a lazy but feasible check to decide if we have buttons for copy in the file storage

Options
    • -3
    • +6
    ./www/file.tcl
    • -3
    • +7
    ./www/folder-chunk.tcl
Tuesday 25 Apr 2017
8:08 pm

antoniop

Fix hiding of delete and move buttons. For move I resolved using the

delete permission as a criteria, because otherwise one should ensure

also the availability of a suitable destination, which must be writable

and in none of the object's subtrees. Complicated and costly to execute everytime.

Options
    • -6
    • +5
    ./www/file.tcl
    • -4
    • +12
    ./www/folder-chunk.tcl
Friday 21 Apr 2017
10:00 pm

gustafn

Fix spelling errors

Options
    • -3
    • +3
    ./tcl/file-storage-procs.tcl
    • -2
    • +2
    ./tcl/test/file-storage-procs.tcl
    • -1
    • +1
    ./www/download-zip.tcl
    • -1
    • +1
    ./www/admin/rss-subscr-ae.adp
    • -1
    • +1
    ./www/doc/design.adp
    • -1
    • +1
    ./www/doc/design.html
  7. … 7 more files in changeset.
7:14 pm

antoniop

Allow copy of files/folders into the same folder of the original content. This is done by appending a numerical suffix to the name.

It required modifying copy stored procedures so they could accept a different name and title for the copy.

I have also removed redundant package definition in oracle code that was immediately overridden afterwards.

Options
    • -3
    • +3
    ./file-storage.info
    • -153
    • +9
    ./sql/oracle/file-storage-package-create.sql
    • -0
    • +478
    ./sql/oracle/upgrade/upgrade-5.9.1b3-5.9.1b4.sql
    • -8
    • +11
    ./sql/postgresql/file-storage-package-create.sql
    • -0
    • +135
    ./sql/postgresql/upgrade/upgrade-5.9.1b3-5.9.1b4.sql
    • -5
    • +9
    ./www/copy-oracle.xql
    • -4
    • +8
    ./www/copy-postgresql.xql
    • -2
    • +18
    ./www/copy.tcl
  9. … 5 more files in changeset.
7:14 pm

antoniop

file upgrade-5.9.1b3-5.9.1b4.sql was initially added on branch oacs-5-9.

Options
    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.9.1b3-5.9.1b4.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.9.1b3-5.9.1b4.sql
Wednesday 19 Apr 2017
8:15 pm

antoniop

Add move and copy buttons only when available folders for these actions exist

Options
    • -8
    • +16
    ./www/file.tcl
    • -4
    • +12
    ./www/folder-chunk.tcl
Tuesday 11 Apr 2017
7:52 am

antoniop

Hide file-storage actions that are not allowed for the user. (receives analogous modifications on Learn@WU)

Options
    • -13
    • +33
    ./www/file.tcl
    • -33
    • +42
    ./www/folder-chunk.tcl
7:20 am

antoniop

Use standard file-storage delete api, as extlink one seems to require extra sql stored procedures (which don't seem necessary to me)

Options
    • -3
    • +5
    ./www/simple-delete.tcl
Thursday 06 Apr 2017
4:16 pm

hectorr

Fixed german message key

Options
    • -1
    • +1
    ./catalog/file-storage.de_DE.ISO-8859-1.xml
2:31 pm

hectorr

Updated de_DE translation (Dateisystem -> Dateiablage)

Options
    • -3
    • +3
    ./catalog/file-storage.de_DE.ISO-8859-1.xml
Monday 27 Mar 2017
12:44 pm

gustafn

Improve robustness of "file delete" operations

Options
    • -2
    • +2
    ./tcl/file-storage-dav-procs.tcl
    • -2
    • +2
    ./tcl/file-storage-install-procs.tcl
    • -5
    • +5
    ./www/download-zip.tcl
    • -3
    • +3
    ./www/file-add.tcl
    • -4
    • +4
    ./www/folder-zip-add.tcl
    • -1
    • +1
    ./www/admin/rss-subscr-del.tcl
  7. … 14 more files in changeset.
Monday 27 Feb 2017
8:42 am

gustafn

- bump version number of OpenACS to 5.9.1b3 and DotLRN to 2.9.1b3

Options
    • -3
    • +3
    ./file-storage.info
  2. … 79 more files in changeset.
Thursday 16 Feb 2017
5:33 pm

antoniop

Updating of German translation for many packages (many thanks to Markus Moser)

Options
    • -22
    • +40
    ./catalog/file-storage.de_DE.ISO-8859-1.xml
  2. … 25 more files in changeset.
Wednesday 15 Feb 2017
8:35 pm

hectorr

Updated es_ES translation

Options
    • -12
    • +14
    ./catalog/file-storage.es_ES.ISO-8859-1.xml
  2. … 20 more files in changeset.
12:28 pm

gustafn

Bump version numbers for OpenACS 5.9.1b1

Options
    • -7
    • +7
    ./file-storage.info
  2. … 81 more files in changeset.
Tuesday 14 Feb 2017
7:29 pm

antoniop

Italian localization of message keys for many packages

Options
    • -13
    • +45
    ./catalog/file-storage.it_IT.ISO-8859-1.xml
  2. … 25 more files in changeset.
Saturday 04 Feb 2017
3:13 pm

gustafn

- replace "<include ... />" by "<include ... >", since adp parser in

AOLserver and NaviServer passes "/" as argument to the adp-include.

Options
    • -1
    • +1
    ./www/permissions.adp
  2. … 14 more files in changeset.
Thursday 02 Feb 2017
4:15 pm

gustafn

- tighten page contracts

Options
    • -2
    • +2
    ./www/copy.tcl
    • -2
    • +2
    ./www/folder-chunk.tcl
    • -2
    • +2
    ./www/move.tcl
  4. … 2 more files in changeset.
Wednesday 18 Jan 2017
9:05 am

gustafn

- make boolean tests in .adp files more uniform

Options
    • -2
    • +2
    ./lib/folder-links.adp
  2. … 56 more files in changeset.
8:50 am

gustafn

- make boolean tests in .adp files more uniform

Options
    • -2
    • +2
    ./lib/folder-links.adp
    • -2
    • +2
    ./www/file.adp
    • -1
    • +1
    ./www/folder-chunk.adp
    • -1
    • +1
    ./www/folder-delete.adp
    • -2
    • +2
    ./www/simple.adp
Friday 09 Dec 2016
8:19 pm

gustafn

- standardize entries in de_DE: rule of thumb: when en_US entry does not end with colon, then the german entry should not do so either.

This way, we avoid .adp pages with double colons.

Options
    • -1
    • +1
    ./catalog/file-storage.de_DE.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/file-storage.en_US.ISO-8859-1.xml
  3. … 9 more files in changeset.