• last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove unnecessary parentheses and idioms, state query variables explicitly

don't pass deprecated argumentent "-user_id" to fs::get_folder_contents_count

  1. … 1 more file in changeset.
Move callback hooks definitions together with their siblings, add documentation to public procs (fixes automated tests)

    • -94
    • +135
    ./tcl/file-storage-callback-procs.tcl
    • -39
    • +1
    ./tcl/file-storage-install-procs.tcl
Add documentation for public procs (fixes automated tests)

Add documentation to public callback hook (fixes automated tests)

Set package_id explicitly as the main subsite package, as ad_conn package_id could not be properly initialized when a system was freshly restarted

Prefer 'person::name' to 'acs_user::get_element ... -name'

Fiy typo

Deprecated leftover parameter from year 2002

Exploit api instead of using local sql

Localize possible I18n message in folder name

While working on reducing divergencies between oracle and postgres codebase and testing changes I have found the following issues:

- fs::add_created_version.new_text_revision query was defined in postgres only

- version-delete and folder-delete were broken in case notification was enabled,

because this was issued after object was deleted and therefore all references

needed to build notification message were missing (and query failed looking up the object)

    • -25
    • +0
    ./tcl/file-storage-procs-oracle.xql
    • -43
    • +0
    ./tcl/file-storage-procs-postgresql.xql
Whitespace changes

Reduce divergency between oracle and postgres codebase and remove redundant statements

Dont even offer to delete the root folder as this is prevented anyway

whitespace cleanup

    • -453
    • +453
    ./tcl/file-storage-procs.tcl
mark required parameters as required. Fixes issue #3347

always use @see when procs are deprecated to show, what to use instead

improve spelling

  1. … 8 more files in changeset.
file file-storage-init.tcl was added on branch oacs-5-10 on 2023-02-15 17:00:52 +0000

Remove legacy file

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 473 more files in changeset.
improve query name

regenerated documentation

Prefer '{}' to '[list]' when creating empty lists

  1. … 225 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 203 more files in changeset.
Fix typos

  1. … 7 more files in changeset.
remove conditions, which are always true

remove parens

Fix more typos

  1. … 83 more files in changeset.
remove not referenced .xql queries