• last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Use full <if @foo_p@ true> instead of undocumented shortcut idiom <if @foo_p@>

  1. … 1 more file in changeset.
normalize expression in adp

use fast recursive query instead of slow query bbased on tree_sortkeys

    • -11
    • +8
    ./tcl/file-storage-procs-postgresql.xql
merged changes from the oacs-5-9 branch and resolved conflicts

    • -23
    • +45
    ./catalog/file-storage.de_DE.ISO-8859-1.xml
    • -1
    • +5
    ./catalog/file-storage.en_US.ISO-8859-1.xml
    • -12
    • +18
    ./catalog/file-storage.es_ES.ISO-8859-1.xml
    • -13
    • +49
    ./catalog/file-storage.it_IT.ISO-8859-1.xml
    • -153
    • +9
    ./sql/oracle/file-storage-package-create.sql
    • -0
    • +478
    ./sql/oracle/upgrade/upgrade-5.9.1b3-5.9.1b4.sql
    • -7
    • +22
    ./sql/postgresql/upgrade/upgrade-5.8.1-5.8.2.sql
  1. … 7820 more files in changeset.
regenerated ducumentation

  1. … 251 more files in changeset.
- do not depend on beta or development versions

- make sure that released versions are not beta or development

- align version numbers (e.g. use also 5.9.1 for xotcl-core)

- bump version numbers to 5.9.1

  1. … 83 more files in changeset.
Modernize script:

- use export_vars

- reduce redundancy

- remove misleading SQL statements

- brace SQL statements, when no substitutions are needed

pass required return url to included adp

Updated spanish translation

    • -0
    • +4
    ./catalog/file-storage.es_ES.ISO-8859-1.xml
  1. … 13 more files in changeset.
bump version numbers to 5.9.1b9 respectively to 2.9.1b9 to prepare for release

  1. … 91 more files in changeset.
add check before file moving to avoid violation of 'cr_items_unique_name' constraint

Fixed a seemingly 11 years old bug

Standardize spellings of names

  1. … 8 more files in changeset.
Use site_node:: api to retrieve package_url instead of explicit query. Remove unused sql and simplify idiom for fs_get_folder_name.

- Introduce new proc ad_sanitize_filename implementing current best practices for ensuring a valid filename on most filesystems.

- Use it in every place where filename sanitization is performed in the code and deprecate fs::remove_special_file_system_characters.

TODO deprecate also util_text_to_html? Use case of sanitizing urls and filenames might have different requirements.

  1. … 2 more files in changeset.
Fix typo

Check if we have already a folder with same name before inserting, or we get error in the logs.

Remove small duplication

Remove sql duplication, converge oracle and postgres codebase

    • -14
    • +0
    ./tcl/file-storage-procs-oracle.xql
    • -17
    • +0
    ./tcl/file-storage-procs-postgresql.xql
Prevent user from selecting source folder as destination folder when moving files. Localize feedback messages (thanks to Markus Moser for the germen translation)

    • -0
    • +2
    ./catalog/file-storage.de_DE.ISO-8859-1.xml
    • -2
    • +4
    ./catalog/file-storage.en_US.ISO-8859-1.xml
    • -0
    • +2
    ./catalog/file-storage.it_IT.ISO-8859-1.xml
Remove debugging comment

Use name and title for the copy, rather than name as title and file_upload_name as name. This will make so copied files will have also the same title as the original when this was renamed.

Try conserving file extension in the name when adding the suffix

Localize untranslated messages in the copy file-storage script (thanks to Markus Moser for the german translation)

    • -0
    • +2
    ./catalog/file-storage.de_DE.ISO-8859-1.xml
    • -0
    • +2
    ./catalog/file-storage.en_US.ISO-8859-1.xml
    • -0
    • +2
    ./catalog/file-storage.it_IT.ISO-8859-1.xml
Use a lazy but feasible check to decide if we have buttons for copy in the file storage

Fix hiding of delete and move buttons. For move I resolved using the

delete permission as a criteria, because otherwise one should ensure

also the availability of a suitable destination, which must be writable

and in none of the object's subtrees. Complicated and costly to execute everytime.

Fix spelling errors

  1. … 7 more files in changeset.
Allow copy of files/folders into the same folder of the original content. This is done by appending a numerical suffix to the name.

It required modifying copy stored procedures so they could accept a different name and title for the copy.

I have also removed redundant package definition in oracle code that was immediately overridden afterwards.

    • -153
    • +9
    ./sql/oracle/file-storage-package-create.sql
    • -0
    • +478
    ./sql/oracle/upgrade/upgrade-5.9.1b3-5.9.1b4.sql
  1. … 5 more files in changeset.
file upgrade-5.9.1b3-5.9.1b4.sql was initially added on branch oacs-5-9.

    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.9.1b3-5.9.1b4.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.9.1b3-5.9.1b4.sql
Add move and copy buttons only when available folders for these actions exist

Hide file-storage actions that are not allowed for the user. (receives analogous modifications on Learn@WU)

Use standard file-storage delete api, as extlink one seems to require extra sql stored procedures (which don't seem necessary to me)