• last updated 22 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fiy typo

Deprecated leftover parameter from year 2002

While working on reducing divergencies between oracle and postgres codebase and testing changes I have found the following issues:

- fs::add_created_version.new_text_revision query was defined in postgres only

- version-delete and folder-delete were broken in case notification was enabled,

because this was issued after object was deleted and therefore all references

needed to build notification message were missing (and query failed looking up the object)

    • -43
    • +0
    ./file-storage-procs-postgresql.xql
  1. … 2 more files in changeset.
Whitespace changes

whitespace cleanup

mark required parameters as required. Fixes issue #3347

always use @see when procs are deprecated to show, what to use instead

improve spelling

  1. … 8 more files in changeset.
file file-storage-init.tcl was added on branch oacs-5-10 on 2023-02-15 17:00:52 +0000

Remove legacy file

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 474 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 203 more files in changeset.
Fix typos

  1. … 7 more files in changeset.
Bugfix: content variable was not define before access (thanks to Giulia Nencini)

I am also not reading file content anymore, as this is potentially unsafe when file is very big and also could need special encoding translation etc.

Better retrieve the path and let the user decide what to do afterwards.

Reduce divergency between oracle and postgres codebase

Revert db_exec_plsql or Oracle will break, remove leftover xql files

  1. … 2 more files in changeset.
Fix oracle systax to call function via select

Uniform API when deleting folder, drill through some calling levels in stored procedure, use a simpler db_string instead of db_exec_plsql

  1. … 1 more file in changeset.
Bug fix: avoid confusion between command argument and option, when argument starts with "-"

  1. … 81 more files in changeset.
use fast recursive query instead of slow query bbased on tree_sortkeys

    • -11
    • +8
    ./file-storage-procs-postgresql.xql
merged changes from the oacs-5-9 branch and resolved conflicts

    • -23
    • +1
    ./file-storage-callback-procs-oracle.xql
    • -30
    • +8
    ./file-storage-callback-procs-postgresql.xql
    • -18
    • +12
    ./file-storage-callback-procs.tcl
    • -86
    • +5
    ./file-storage-procs-postgresql.xql
  1. … 7820 more files in changeset.
Standardize spellings of names

  1. … 8 more files in changeset.
Use site_node:: api to retrieve package_url instead of explicit query. Remove unused sql and simplify idiom for fs_get_folder_name.

- Introduce new proc ad_sanitize_filename implementing current best practices for ensuring a valid filename on most filesystems.

- Use it in every place where filename sanitization is performed in the code and deprecate fs::remove_special_file_system_characters.

TODO deprecate also util_text_to_html? Use case of sanitizing urls and filenames might have different requirements.

  1. … 5 more files in changeset.
Remove sql duplication, converge oracle and postgres codebase

    • -17
    • +0
    ./file-storage-procs-postgresql.xql
Fix spelling errors

  1. … 11 more files in changeset.
Improve robustness of "file delete" operations

  1. … 18 more files in changeset.
- fix SQL query in datasource callback (variable is called object_id and not revision_id)

    • -1
    • +1
    ./file-storage-callback-procs-oracle.xql
    • -8
    • +8
    ./file-storage-callback-procs-postgresql.xql
- fix query name

Created new proc cr_check_mime_type, centralizing the retrieval of the mime_type from uploaded file's information.

Applied the new proc to the different situations in the system when we require mime_type retrieval: content-repository, file-storage and xotcl CrItem

TODO: get the real mime_type from the file content, but this would require some modification in the data model.

  1. … 7 more files in changeset.