OpenACS / openacs-4 / packages / file-storage / tcl

file-storage-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 33
Last Commit: 12:40
Commits this week: 0
Total Lines of Code (LoC): 1,693
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 26 Feb
4:05 pm

antoniop

download-archive reform

File-Storage used to generate downloaded archives in tgz format, to then switch to zip, more user-friendly, in particular outside the Linux world (See https://openacs.org/forums/message-view?message_id=557561). To ease the transition, a couple of parameters and relative API were introduced that would allow to choose the preferred command one should use. During this reform however, default parameter values in the tcl code became inconsistent with those in the info file. Furthermore, the chosen defaults were set as absolute paths to the executable, which is not friendly to non-linux environments, or other scenarios where the "typical" Linux filesystem structure cannot be assumed (e.g. containers, MacOS...).

The only usage of this parameters/api was in fact in the download-archive vuh. In upstream codebase, no package references this file, not even the file-storage itself. Upon review, one could see that the file would also allow to specify a custom download filename via the path, which could be considered questionable. It would also execute the command in a way that once again assumes some form of Linux environment (e.g. invoking bash).

Save for the ability to customize the archive format and the anti-feature of being able to manipulate the archive filename via the path, the script largely relplicates www/download-zip, in a better shape after a few reforms hinted by e.g. penetration tools.

Given the aformentioned considerations, I have decided to make download-archive a simple redirect to download-zip. Specifying the object_id via the path will keep working, while URLs out there expecting the name to change will not fail, but the name will not be modified. The archive format will from now on be assumed to be zip.

Options
    • -2
    • +2
    ./file-storage-procs.tcl
  2. … 4 more files in changeset.
Friday 17 Mar 2023
4:15 pm

antoniop

Fix english

Options
    • -6
    • +6
    ./file-storage-procs.tcl
4:12 pm

antoniop

Deprecate fs::get_folder_contents

Options
    • -2
    • +10
    ./file-storage-procs.tcl
4:07 pm

antoniop

Avoid using get_folder_contents, doing a lot more stuff, and get the info from the db directly

Options
    • -4
    • +12
    ./file-storage-procs.tcl
4:02 pm

antoniop

Retrieve only the necessary information

Options
    • -5
    • +5
    ./file-storage-procs.tcl
4:00 pm

antoniop

Replace ad_tmpnam

Options
    • -2
    • +2
    ./file-storage-procs.tcl
2:36 pm

antoniop

Make fs::get_folder_contents private: this api is only used internally to the file-storage over the codebase and its documentation suggests that it should be used with caution

Options
    • -2
    • +2
    ./file-storage-procs.tcl
2:29 pm

antoniop

Deprecate trivial fs::get_archive_extension and inline its only upstream occurrence

Options
    • -2
    • +6
    ./file-storage-procs.tcl
  2. … 1 more file in changeset.
2:25 pm

antoniop

Prevent usage of fs::get_archive_command outside a file-storage connection context, as in this case the parameter value will be uspecified

Options
    • -1
    • +5
    ./file-storage-procs.tcl
  2. … 1 more file in changeset.
Thursday 16 Mar 2023
3:58 pm

antoniop

Deprecate fs::item_editable_info and fs::item_editable_p, probably unfinished work towards some kind of inline editing feature

Options
    • -3
    • +17
    ./file-storage-procs.tcl
Friday 24 Feb 2023
4:04 pm

antoniop

Deprecate fs::add_created_version

This api was nowhere used in upstream code, however, allowed to create a new file object revision by text content, different from fs::add_version, which would only allow to create a revision from a file.

As the two apis were otherwise identical, I have ported the behavior of fs::add_created_version info fs::add_version.

The new fs::add_version will also take many defaults for unspecified parameters from the existing content item.

Options
    • -37
    • +110
    ./file-storage-procs.tcl
2:50 pm

antoniop

Make service contract implementation private

Options
    • -4
    • +6
    ./file-storage-procs.tcl
Wednesday 15 Feb 2023
6:00 pm

antoniop

Commit remaining files

Options
    • -4
    • +8
    ./file-storage-procs.tcl
  2. … 3 more files in changeset.
Sunday 27 Nov 2022
11:52 am

gustafn

Make use of new API "ad_mktmpdir" and "ad_opentmpfile" instead of "ad_tmpnam"

Options
    • -5
    • +3
    ./file-storage-procs.tcl
  2. … 6 more files in changeset.
Thursday 17 Feb 2022
9:19 pm

gustafn

Fixes for Oracle 19c: more fixes of handling of Boolean values

Options
    • -5
    • +5
    ./file-storage-procs.tcl
Friday 04 Feb 2022
3:53 pm

antoniop

ad_conn provides since a long time a fallback when the package_id is queried outside of a connection context, hence no need for these concerning catches

Options
    • -19
    • +20
    ./file-storage-procs.tcl
2:40 pm

antoniop

Make fs::get_file_package_id more robust to cases where the package_id is not set on the object itself: climb up the hierarchy

Options
    • -2
    • +18
    ./file-storage-procs.tcl
  2. … 1 more file in changeset.
Tuesday 14 Sep 2021
8:04 pm

gustafn

fix typo

Options
    • -2
    • +2
    ./file-storage-procs.tcl
Saturday 01 May 2021
2:21 pm

gustafn

allow to specify max upload size in configuration file in KB or MB

Options
    • -6
    • +18
    ./file-storage-procs.tcl
Tuesday 20 Apr 2021
1:08 pm

antoniop

Fix typo

Options
    • -2
    • +2
    ./file-storage-procs.tcl
Monday 19 Apr 2021
3:01 pm

antoniop

Make oacs-dav only a weak dependency for file-storage, if the package is not there, just treat it as if the parameter was disabled

Options
    • -2
    • +13
    ./file-storage-procs.tcl
  2. … 2 more files in changeset.
Monday 12 Apr 2021
10:36 am

antoniop

Refactor query to go over the fs hierachy, rather than the permission one, add remarks

Options
    • -15
    • +17
    ./file-storage-procs.tcl
Friday 09 Apr 2021
7:48 pm

antoniop

Recover logic went missing after refactoring (with some remarks)

Options
    • -2
    • +33
    ./file-storage-procs.tcl
Wednesday 07 Apr 2021
10:07 pm

gustafn

break overlong lines

Options
    • -18
    • +53
    ./file-storage-procs.tcl
9:54 pm

gustafn

stick to content-repository API instead of duplicating code here.

Options
    • -55
    • +24
    ./file-storage-procs.tcl
  2. … 3 more files in changeset.
Tuesday 06 Apr 2021
9:16 pm

gustafn

new function: ::content::revision::export_to_filesystem

This change moves functionality from file-storage to acs-content-repository.

all application packages should be free of internals, such as the storage

type. Storage_type should be handeled in the content-repository package.

We are not yet done, there is still more to do in this respect in

the file-storage package.

Options
    • -43
    • +8
    ./file-storage-procs.tcl
  2. … 7 more files in changeset.
8:25 pm

gustafn

break overlong lines

Options
    • -5
    • +18
    ./file-storage-procs.tcl
Wednesday 31 Mar 2021
1:32 pm

gustafn

improve spelling

Options
    • -9
    • +9
    ./file-storage-procs.tcl
  2. … 5 more files in changeset.
1:31 pm

gustafn

whitespace changes

Options
    • -2
    • +2
    ./file-storage-procs.tcl
  2. … 2 more files in changeset.
12:06 pm

hectorr

Mark 'fs::max_upload_size' as public, as it is used in 'attachments'

Options
    • -2
    • +2
    ./file-storage-procs.tcl