• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Chat reform:

- reduce code duplication by determining the proper chat class dynamically and storing it in an nsv

- move static content in the resources path. Serving them is now independent from the mounted xowiki path

- get rid of the ajax url path

  1. … 12 more files in changeset.
Give xowiki chat also some kind of nice skin and centralize css retrieval

TODO: something smarter can be done in order to retrieve the proper css, based e.g. on theme, chat skin (to be implemented) etc. To be discussed is some way to resolve resources based on the theme.

  1. … 3 more files in changeset.
New chat_room includelet, behaving as the existing chat one, but plugged with extra chat package's feature (transcript management...)

To avoid package_id to be overridden, we force it always to the one of the current chat

  1. … 2 more files in changeset.
When transcripting a message, use the provided user_id when available

This fixes auto logout messages being written down as from unregistered visitor in the transcript

Specialize the way chat::Chat class retrieves the package_id: use the context_id of the chat room (if this is a valid chat room)

This will allow to embed a chat::Chat instance in a xowiki page pinting to an existing chat room and let it use the chat package specific features to e.g. keep transcripts of a conversation

  1. … 2 more files in changeset.
Fade out obsolete code

Whitespace cleanup + Add editor hints

  1. … 5 more files in changeset.
Chat reform:

- rework xotcl-core chat machinery to return its responses through JSON and include information about active users

- depend on xowiki instead of xotcl-core only

- exploit xowiki "Comet" server push implementation when the browser supports it

- reduce code duplication

- drop plain HTML chat

- reduce hardcoded styling

- minor cleanups

  1. … 23 more files in changeset.
Converge render method for chat and xotcl-core package

  1. … 1 more file in changeset.
Add editor hints + Whitespace changes

Normalize indentation

Give templating a chance

move all hardcoded styling to the adp template, which might be styled by the theme. Also, biring some order in the login proc, e.g. don't open and read a file to include a javascript all the time.

  1. … 1 more file in changeset.
Modernize XoTcl idioms

Use finer grained api for user name

Retract package parameter configuration, as chat is not a singleton package... not clear if we will want a global paremeter for this in the future

Replace leftover Naviserver-only cache idioms with retro compatible ones

Create chat room cache in a way to provide compatibility with AOLserver

make timeout and cache size configurable.

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
Rework variable assignment (set -> lassign) + Whitespace changes

  1. … 17 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 204 more files in changeset.
fix typos

  1. … 2 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7830 more files in changeset.
Port some improvements from Learn@WU codebase:

- check whether chat room exists exploits cache

- chat room retrieval enriches with some acs_objects metadata

Fix potential errors when we try entering a chat room that has been deleted and check for its activity status

Don't lookup creator name for messages coming from the system, as they won't be found

Fix spelling errors

  1. … 15 more files in changeset.
Don't abort script when people sends a message over a non-existing

chat, as this is required by the chat sweeper to happen.

- brace "if" condition

Replace inline js event when sending the message to comply with CSP

Uniform cache for chat room infos to the established nomenclature.

Increase size so that 1000 maximum entries would fit in the cache.

Fix typo