• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Whitespace changes + add editor hints

    • -42
    • +40
    ./www/asm-admin/add-edit-check.tcl
    • -191
    • +193
    ./www/asm-admin/item-stats.tcl
    • -15
    • +16
    ./www/asm-admin/section-select.tcl
  1. … 20 more files in changeset.
Remove superflous parentheses

  1. … 23 more files in changeset.
simplyfy expressions, remove useless file

  1. … 2 more files in changeset.
Align case of acs_object_type with that of the actual table (fixes automated tests), remove reference to non-existing stored procedure acs_action__name (fixes automated tests), comment out leftover sql script referenced nowhere

    • -122
    • +125
    ./sql/postgresql/assessment-actions-create-p.sql
    • -0
    • +11
    ./sql/postgresql/upgrade/upgrade-2.10.0d1-2.10.0d2.sql
Make proc private as their sibling counterparts (fixes automated tests), uniform documentation style

Add documentation for public procs (fixes automated tests), use an api that will assume a single mountpoint for the package (as was intended)

Uniform documentation style, add documentation to public proc (fixes automated tests)

Uniform documentation style, make as::item_display_sb::set_item_display_type as its sibling as::item_display_f::set_item_display_type (fixes automated tests)

Add documentation for public procs, simplify idiom, uniform documentation style

    • -16
    • +14
    ./tcl/as-item-display-fu-procs.tcl
Add documentation for public procs (fixes automated tests), uniform indentation, uniform documentation style

    • -1158
    • +1156
    ./tcl/as-install-procs.tcl
Skip test when tclwebtest is not available

Fix acs_attribute datatype to match table type (fixes automated tests)

    • -0
    • +34
    ./sql/postgresql/upgrade/upgrade-2.10.0d0-2.10.0d1.sql
Unwrap indentation

    • -233
    • +1320
    ./tcl/as-install-procs.tcl
Fix duplicate 'the'

    • -1
    • +1
    ./catalog/assessment.en_US.ISO-8859-1.xml
  1. … 17 more files in changeset.
Fix proc and contract doc elements, so they are properly parsed by apidoc::api_*_documentation.

- Add mising @param

- Add missing @author

- @creation_date -> @creation-date

- @creation-user -> @author

- Fix typos

  1. … 7 more files in changeset.
Fix proc and contract doc elements, so they are properly parsed by apidoc::api_*_documentation.

- @cvs_id -> @cvs-id

- @version -> @cvs-id

- @creation_date -> @creation-date

- @date -> @creation-date

- Different variations of $Id$

- Remove wrong @param entry

- Fix typos

    • -2
    • +2
    ./www/admin/asm-action-param-admin.tcl
    • -2
    • +2
    ./www/admin/asm-action-param-delete.tcl
  1. … 354 more files in changeset.
Prefer 'person::name' to 'acs_user::get_element ... -name' + Fix arguments: user_id -> person_id

  1. … 8 more files in changeset.
Prefer 'person::name' to 'acs_user::get_element ... -name'

    • -1
    • +1
    ./www/asm-admin/request-notification.tcl
  1. … 7 more files in changeset.
Reduce divergency between oracle and postgres codebase

    • -26
    • +0
    ./lib/comments-chunk-postgresql.xql
Whitespace changes

    • -196
    • +195
    ./tcl/as-assessment-procs.tcl
    • -60
    • +61
    ./tcl/as-item-display-tb-procs.tcl
  1. … 2 more files in changeset.
Avoid unnecesary existence checks.

  1. … 2 more files in changeset.
Fix query in generic xql that was committed by mistake, replace it with the one for postgres, as it is portable, remove oracle query

    • -39
    • +0
    ./www/asm-admin/send-mail-oracle.xql
    • -39
    • +0
    ./www/asm-admin/send-mail-postgresql.xql
Whitespace changes

Fix duplicated words

  1. … 2 more files in changeset.
Make clearer what is going on here (a lot, apparently)

    • -14
    • +66
    ./www/asm-admin/admin-request.tcl
Remove unused query and put last remaining inline to avoid xql file. Reduce joining

    • -1
    • +12
    ./www/asm-admin/request-notification.tcl
    • -26
    • +0
    ./www/asm-admin/request-notification.xql
Don't pass fine tcl variables through the database for random reasons, improve code legibility, reduce divergency between oracle and postgres codebase, exploit multi-user permission checking on postgres

    • -40
    • +3
    ./www/asm-admin/send-mail-oracle.xql
    • -48
    • +6
    ./www/asm-admin/send-mail-postgresql.xql
Beautify code, remove unneded variables and queries

modernize tcl

Add missing brace