• last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Whitespace changes

    • -141
    • +135
    ./test/as-assessment-procs.tcl
Add proc names to the list of covered procs in assessment tests

use bind variables instead of tcl variable substition in xql fullqueries

  1. … 16 more files in changeset.
remove calls to deprecated proc acs_lookup_magic_object (use acs_magic_object instead)

  1. … 3 more files in changeset.
Replace limit idiom with portable idiom

    • -10
    • +0
    ./as-apm-action-procs-postgresql.xql
Deprecate content::folder::get_folder_from_package as it assumes there will be one folder per package, not true in general

Replace its only occurrence in the codebase with a local reimplementation (expecting the assessment package to comply with this restriction and not have more than 1 folder per package instance)

  1. … 1 more file in changeset.
improve spelling

  1. … 15 more files in changeset.
Whitespace changes

Comment out seemingly useless computation which has been detected running > 18s in some case on the live system

Whitespace cleanup

improve SQL quoting

  1. … 5 more files in changeset.
Check for existence before deleting attribute

Whitespace changes

Delete attribute 'survey_p', as it was replaced by 'type' in 2006 and is not created in new instances.

It is unclear if the 'survey_p' column of the 'as_assessments' table can also be dropped.

Original attribute replacement commit:

https://github.com/openacs/assessment/commit/433463faf6d50140fe26f848ab2f28662e0acc85#diff-cff15be6842f249cef812f983e064e78

https://fisheye.openacs.org/changelog/OpenACS?cs=MAIN%3Adaveb%3A20060926002244

  1. … 1 more file in changeset.
Replace deprecated idiom

apply patch from mischa to current development pranch

Use current namespace ::tdom instead of legacy ::tDOM

Replace ad_decode idioms

  1. … 1 more file in changeset.
Bring files on oacs-5-10 in sync with HEAD

    • -228
    • +228
    ./as-item-type-mc-procs.tcl
  1. … 159 more files in changeset.
Whitespace changes + editor hints

  1. … 19 more files in changeset.
Replace/remove deprecated proc 'db_null' and update doc accordingly

  1. … 33 more files in changeset.
Whitespace changes

  1. … 6 more files in changeset.
Whitespace changes

    • -227
    • +227
    ./as-item-type-mc-procs.tcl
  1. … 3 more files in changeset.
Fix proc doc errors detected by 'documentation__check_parameters'

  1. … 5 more files in changeset.
improve testcases by removing useless expr commands

  1. … 16 more files in changeset.
Make proc private as their sibling counterparts (fixes automated tests), uniform documentation style

Add documentation for public procs (fixes automated tests), use an api that will assume a single mountpoint for the package (as was intended)

Uniform documentation style, add documentation to public proc (fixes automated tests)

Uniform documentation style, make as::item_display_sb::set_item_display_type as its sibling as::item_display_f::set_item_display_type (fixes automated tests)

Add documentation for public procs, simplify idiom, uniform documentation style