• last updated 22 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Comment noop result of a 18 years old typo, add remarks

Arrays might or not have been a better choice for the date object, however, such decision happened very long ago and it has worked good enough... cleanup concerning remarks

Whitespace change

Review concerning remark: the algotirhm is indeed correct, assuming the year is expressed in the Gregorian calendar

Replace deprecated idiom

Uniform documentation formatting and indentation, add missing documentation

Fix typo

Reduce usage of ns_mktemp in OpenACS

ns_mktemp uses the deprecated old POSIX call mktemp(), which should

not be used anymore for security reasons (race between the name

creation and opening the file). This change removes several usages of

"ns_mktemp" from OpenACS and replaces it with calls to the

safe Tcl call "file tempfile ..." (introduced by Tcl 8.6).

  1. … 7 more files in changeset.
Extend 'validate_url' test case

Unify URL checking, now that 'util_url_valid_p' accepts relative URLs. Extend 'validate_url' test case and bump package version for dependencies.

Add 'get_url_directory' test case, covering 'template::util::get_url_directory'

Add 'nvl' test case, covering 'template::util::nvl'

Add 'number_list' test case, covering 'template::util::number_list'

file util-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/test/util-procs.tcl
Add 'validate_currency' test case, covering 'template::data::validate' and 'template::data::validate::currency'

Break overlong lines

Whitespace changes

Add 'validate_oneof' test case, covering 'template::data::validate' and 'template::data::validate::oneof'

Fix clock check. The clock command will not fail on incorrect dates (e.g. 2021-13-00) unless the format is specified.

Add 'validate_textdate' test case, covering 'template::data::validate' and 'template::data::validate::textdate'

Add 'validate_enumeration' test case, covering 'template::data::validate' and 'template::data::validate::checkbox_enumeration'

Extend 'validate_text' test case and reduce code duplication

Extend 'validate_search' test case with 'template::data::validate::party_search'

Add 'validate_checkbox_text' test case, covering 'template::data::validate' and 'template::data::validate::checkbox_text'

Add 'validate_file' test case, covering 'template::data::validate' and 'template::data::validate::file'

Add 'validate_search' test case, covering 'template::data::validate' and 'template::data::validate::search'

Extend 'validate_date' with 'template::data::validate::time_of_day'

Add 'util_negative' test case, covering 'template::util::negative'

Add 'validate_date' test case, covering 'template::data::validate', 'template::data::validate::date' and 'template::data::validate::timestamp'

Add 'validate_url_element' test case, covering 'template::data::validate' and 'template::data::validate::url_element'