• last updated 4 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Provide tests for public procs: util::trim_leading_zeros

Whitespace changes

Mention explicitly the tested procs in the test cases.

note, that change_state_member tests checks implicitly as well membership_rel::change_state

set error-level to warning for documentation__check_proc_testcase (similar to datamodel__named_constraints)

Add 'documentation__check_proc_testcase' test, for checking public procs without test cases. Many thanks to Monika Andergassen.

fix for redirect-to-secure, when SuppressHttpPort is set

This changes as well:

- improve symmetry security::get_insecure_location and security::get_secure_location

- add regression test to cover basic cases

- bumb version number of acs-tcl to 5.10.0d19

    • -0
    • +52
  1. … 2 more files in changeset.
improve source code documentation of ad_html_qualify_links and add test cases

  1. … 1 more file in changeset.
prefer acs:test functions over twt

prefer acs::test::user::create over twt variant

improve spelling

  1. … 6 more files in changeset.
Check also for empty lines at the end of the file in the 'files__trailing_whitespace' test case

Allow square brackets in proc doc. In particular, this fixed a false positive with [doc_string] in 'ad_proc'

Improve 'args' check in 'documentation__check_parameters' test case by using the built-in 'varargs_p' variable.

Add 'args' parameter to the real parameter list of the 'documentation__check_parameters', as it is not included into 'switches' or 'positionals'.

Use 'apm_get_package_files -file_types' instead of filtering the 'www' and 'lib' directories manually.

Take care of '_p' boolean parameters when checking for discrepancies between real and documented proc parameters.

Overhaul of test cases:

- make tested API calls explict

- reduce dependency on twt

    • -113
    • +141
  1. … 4 more files in changeset.
don't leak user_ids from regression test case

make tested API calls explicit

Add new test case 'documentation__check_parameters', which checks if parameters defined in the proc doc (@param) are really proc parameters.

Sometimes proc parameter changes are not reflected in the proc doc, this should take care of some of these cases.

Improve the list of common typos for the 'documentation__check_typos' test case, including some from Wikipedia: https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines

    • -1
    • +3354
Remove apparent leftover + trailing whitespace

Add new test case 'files__page_contracts', which checks for the existance of both 'ad_page_contract' and 'ad_include_contract' in the .tcl files inside 'www' and 'lib' package directories.

There are cases, where includelets are not stored in 'lib' but 'www', or have 'ad_page_contract' instead of 'ad_include_contract'. Checking if the location of includelets is correct is not so clear, so we avoid doing this in this particular test.

rework test case documentation__check_typos

- make test case more robust (don't abort tests when there is a proc_doc without a "main" section

- improve performance and sanity:

* move invariantes out of the loop

* use built-in hashes

* don't check the same term multiple times

... times went from >15 sec to <1sec

remove useless semicolon

Add new test case 'files__trailing_whitespace', which looks for trailing whitespace (spaces or tabs at the end of lines).

Currently, only .tcl files are checked.

no reason for casting values to integer

incr would return a decimal number, but test wants an integer to be returned. Restore expr and make clear that we want an integer out of it

Add more information about typos loaded and checks passed