• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
correct the name of the tested proc

Create a full subsite instead of just a node, or the context bar will ignore it, then consider localization in the test

Consider localization when testing the context bar

improving ad_html_to_text:

- handle src specs with "data:" (skip data)

- handle anchors with empty hrefs and internal links by not adding these to the text rendering

- add test cases to regression test

  1. … 1 more file in changeset.
extend regression test

Provide tests for public procs: min and max

Provide tests for public procs: util_escape_quotes_for_csv

Provide tests for public procs: util_commify_number

Refactor test case for util_absolute_path_p

Provide tests for public procs: util_complete_url_p

Provide tests for public procs: util_absolute_path_p

Provide tests for public procs: util::trim_leading_zeros

Whitespace changes

Mention explicitly the tested procs in the test cases.

note, that change_state_member tests checks implicitly as well membership_rel::change_state

set error-level to warning for documentation__check_proc_testcase (similar to datamodel__named_constraints)

Add 'documentation__check_proc_testcase' test, for checking public procs without test cases. Many thanks to Monika Andergassen.

fix for redirect-to-secure, when SuppressHttpPort is set

This changes as well:

- improve symmetry security::get_insecure_location and security::get_secure_location

- add regression test to cover basic cases

- bumb version number of acs-tcl to 5.10.0d19

    • -0
    • +52
    ./location-procs.tcl
  1. … 2 more files in changeset.
improve source code documentation of ad_html_qualify_links and add test cases

  1. … 1 more file in changeset.
prefer acs:test functions over twt

prefer acs::test::user::create over twt variant

improve spelling

  1. … 6 more files in changeset.
Check also for empty lines at the end of the file in the 'files__trailing_whitespace' test case

Allow square brackets in proc doc. In particular, this fixed a false positive with [doc_string] in 'ad_proc'

Improve 'args' check in 'documentation__check_parameters' test case by using the built-in 'varargs_p' variable.

Add 'args' parameter to the real parameter list of the 'documentation__check_parameters', as it is not included into 'switches' or 'positionals'.

Use 'apm_get_package_files -file_types' instead of filtering the 'www' and 'lib' directories manually.

Take care of '_p' boolean parameters when checking for discrepancies between real and documented proc parameters.

Overhaul of test cases:

- make tested API calls explict

- reduce dependency on twt

    • -113
    • +141
    ./application-data-link-procs.tcl
  1. … 4 more files in changeset.
don't leak user_ids from regression test case