• last updated 28 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Overhaul of test cases:

- make tested API calls explict

- reduce dependency on twt

    • -113
    • +141
    ./application-data-link-procs.tcl
  1. … 4 more files in changeset.
don't leak user_ids from regression test case

make tested API calls explicit

Add new test case 'documentation__check_parameters', which checks if parameters defined in the proc doc (@param) are really proc parameters.

Sometimes proc parameter changes are not reflected in the proc doc, this should take care of some of these cases.

Improve the list of common typos for the 'documentation__check_typos' test case, including some from Wikipedia: https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines

    • -1
    • +3354
    ./doc-check-procs-common-typos.txt
Remove apparent leftover + trailing whitespace

Add new test case 'files__page_contracts', which checks for the existance of both 'ad_page_contract' and 'ad_include_contract' in the .tcl files inside 'www' and 'lib' package directories.

There are cases, where includelets are not stored in 'lib' but 'www', or have 'ad_page_contract' instead of 'ad_include_contract'. Checking if the location of includelets is correct is not so clear, so we avoid doing this in this particular test.

rework test case documentation__check_typos

- make test case more robust (don't abort tests when there is a proc_doc without a "main" section

- improve performance and sanity:

* move invariantes out of the loop

* use built-in hashes

* don't check the same term multiple times

... times went from >15 sec to <1sec

remove useless semicolon

Add new test case 'files__trailing_whitespace', which looks for trailing whitespace (spaces or tabs at the end of lines).

Currently, only .tcl files are checked.

no reason for casting values to integer

incr would return a decimal number, but test wants an integer to be returned. Restore expr and make clear that we want an integer out of it

Add more information about typos loaded and checks passed

Fix typo + Whitespace changes

Test refactoring

Improve test documentation.

Add more common spelling errors to the 'documentation__check_typos' test case, collected from previous typo fixes in openacs.

Reduce test verbosity

Add new test case 'documentation__check_typos', which checks for spelling errors in the proc documentation.

The test uses a file containing common spelling errors (doc-check-procs-common-typos.txt), based in the one

provided by Debian's lintian, which can be found here: https://github.com/Debian/lintian/tree/master/data/spelling

The test can take some time, depending on the amount of packages and how powerful the machine is.

    • -0
    • +4234
    ./doc-check-procs-common-typos.txt
prefer "aa_equals" over "aa_true"+"string equal"

  1. … 2 more files in changeset.
replace "expr" by "incr"

Fix typo

improve testcases by removing useless expr commands

    • -14
    • +14
    ./application-data-link-procs.tcl
Declass constraint names breaking the very strict OpenACS naming convention from errors to warnings

Rationale: it is sometimes impossible to have constraint names that are both < 30 chars and consistent with the naming scheme 'table_name'_'column_name'_'constraint_type' for all those defined on a particular table (see e.g. acs_named_objects).

Breaking this convention might be suboptimal, but is not harmful in itself.

simplify code

improve test cases: align comment with operations, remove useless "expr" commands

Trim whitespace

Whitespace cleanup

Add 'Markdown' tests for 'ad_html_text_convert'

- use information from acs_testing in api-browser: provide link for

test cases.

- new function: api_add_to_proc_doc for updating apidoc information

from other packages

- bump version of acs-automated testing to 5.10.0d4 and

acs-api-browser to 5.10.0d2

- toc includelet:

* new flag: "-renderer" (default "")

specify an explicit renderer. This is an alternative to the

classic "rendering by style", where there style determines the renderer.

* new flag: "-include_in_foldertree" (default true)

it is now possible to avoid inclusion of all folder-tree element

in the standard folder tree. Default set for backwards

compatibility.

  1. … 5 more files in changeset.